Re: [PATCH] staging: atomisp: add a driver for ov5648 camera sensor

2017-09-18 Thread Andy Shevchenko
On Mon, 2017-09-11 at 20:03 +0200, Devid Antonio Filoni wrote: > On Mon, Sep 11, 2017 at 05:55:29PM +0300, Sakari Ailus wrote: > > Hi Devid, > > > > Please see my comments below. > > > > Andy: please look for "INT5648". > > Hi Sakari, > I'm replying below to your comments. I'll work on a v2 patc

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues

2017-09-18 Thread Vitaly Kuznetsov
Stephen Hemminger writes: > On Sep 15, 2017 11:01 AM, "KY Srinivasan" wrote: > > > Vitaly Kuznetsov writes: > > > > > > > > I'm seeing the same issue, reverting the offending > > > > > > commit 6f3d791f300618caf82a2be0c27456edd76d5164 > > > Author: K. Y. Srinivasan > > > Date: Fri Aug

Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code

2017-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 12, 2017 at 09:41:20AM -0700, Guenter Roeck wrote: > On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote: > > On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote: > > > Commented out code can be added as needed. Drop it. > > > Also drop TODO and an obsolete XXX com

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unused variable ret

2017-09-18 Thread Greg KH
On Thu, Sep 14, 2017 at 10:21:29PM +0530, Harsha Sharma wrote: > Hi, > Yes, you are right but the function returns 0 in the end and the changes > compiles well . Then the function is incorrect, it should be reporting back that error. thanks, greg k-h _

Re: [PATCH v2] staging: iio: tsl2x7x: clean up limit checks

2017-09-18 Thread Dan Carpenter
On Sat, Sep 16, 2017 at 02:18:52PM +0200, Paolo Cretaro wrote: > On 16/09/2017 13:37, Dan Carpenter wrote: > > On Sat, Sep 16, 2017 at 01:11:29PM +0200, Paolo Cretaro wrote: > >> Hi Dan, > >> just minor nitpicking on the commit message: > >> > >> On 08/09/2017 12:53, Dan Carpenter wrote: > >>> The

Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps

2017-09-18 Thread Greg Kroah-Hartman
On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote: > The source and sink caps should follow the following rules. > This patch validates whether the src_caps/snk_caps adheres > to it. > > 6.4.1 Capabilities Message > A Capabilities message (Source Capabilities message or Sink >

Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro

2017-09-18 Thread Himanshi Jain
On Thu, Sep 14, 2017 at 2:20 AM, Jonathan Cameron wrote: > > > On 13 September 2017 12:23:31 GMT-07:00, Lars-Peter Clausen > wrote: >>On 09/13/2017 08:58 PM, Greg KH wrote: >>> On Wed, Sep 13, 2017 at 06:03:10PM +0100, Jonathan Cameron wrote: On Wed, 13 Sep 2017 14:14:07 +0530 Himanshi

Re: [PATCH] Staging: media: atomisp: Merge assignment with return

2017-09-18 Thread Sakari Ailus
On Tue, Sep 12, 2017 at 07:55:07PM +0530, Srishti Sharma wrote: > Merge the assignment and the return statements to return the value > directly. Done using the following semantic patch by coccinelle. > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return re

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues

2017-09-18 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > > Reverting 6f3d791f300618caf82a2be0c27456edd76d5164 still helps. In addition to the above I got the following crash while playing with 4.14-rc1 (unmodified): [ 55.810080] kernel tried to execute NX-protected page - exploit attempt? (uid: 0) [ 55.814293] BUG: una

Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister()

2017-09-18 Thread Greg KH
On Sun, Sep 17, 2017 at 08:54:16PM -0700, k...@exchange.microsoft.com wrote: > From: Dexuan Cui > > Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"), > we need this patch to resolve the below deadlock: So does this patch need a "Fixes:" tag, and a "stable@" tag as well, so

Re: [PATCH V2 2/4] Drivers: hv: fcopy: restore correct transfer length

2017-09-18 Thread Greg KH
On Sun, Sep 17, 2017 at 08:54:17PM -0700, k...@exchange.microsoft.com wrote: > From: Olaf Hering > > Till recently the expected length of bytes read by the > daemon did depend on the context. It was either hv_start_fcopy or > hv_do_fcopy. The daemon had a buffer size of two pages, which was much

Re: [PATCH V2 4/4] Drivers: hv: vmbus: Expose per-channel event counters events counters

2017-09-18 Thread Greg KH
On Sun, Sep 17, 2017 at 08:54:19PM -0700, k...@exchange.microsoft.com wrote: > From: Stephen Hemminger > > When investigating performance, it is useful to be able to look at > the number of host and guest events per-channel. This is equivalent > to per-device interrupt statistics. > > Signed-off

Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info

2017-09-18 Thread Greg KH
On Sun, Sep 17, 2017 at 08:54:18PM -0700, k...@exchange.microsoft.com wrote: > From: Stephen Hemminger > > This extends existing vmbus related sysfs structure to provide per-channel > state information. This is useful when diagnosing issues with multiple > queues in networking and storage. > > T

Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister()

2017-09-18 Thread Greg KH
On Sun, Sep 17, 2017 at 08:54:16PM -0700, k...@exchange.microsoft.com wrote: > From: Dexuan Cui > > Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"), > we need this patch to resolve the below deadlock: > > after we get the mutex in vmbus_hvsock_device_unregister() and call

Re: [PATCH] binder: fix "cast to pointer from integer of different size" warning

2017-09-18 Thread Greg KH
On Mon, Sep 04, 2017 at 01:17:40PM +0800, Jisheng Zhang wrote: > The binder driver now could cause warnings as below on 32bit platforms > if ANDROID_BINDER_IPC_32BIT is unselected: > > drivers/android/binder.c:1550:15: warning: cast to pointer from integer > of different size [-Wint-to-pointer-cas

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 05, 2017 at 10:56:13AM +0200, Arnd Bergmann wrote: > Allowing binder to expose the 64-bit API on 32-bit kernels caused a > build warning: > > drivers/android/binder.c: In function 'binder_transaction_buffer_release': > drivers/android/binder.c:2220:15: error: cast to pointer from integ

RE: [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister()

2017-09-18 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, September 18, 2017 7:00 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; lean

[PATCH] staging: ion: create one device entry per heap

2017-09-18 Thread Benjamin Gaignard
Instead a getting one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id match wit

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Arnd Bergmann
On Mon, Sep 18, 2017 at 4:02 PM, Greg Kroah-Hartman wrote: >> However, there is another problem with the Kconfig option: turning >> it on or off creates two incompatible ABI versions, a kernel that >> has this enabled cannot run user space that was built without it >> or vice versa. A better solut

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Christoph Hellwig
On Mon, Sep 18, 2017 at 05:35:03PM +0200, Arnd Bergmann wrote: > Probably not on a native Android device or even a Chromebook that > ships a binder user space together with a kernel, but what about > people using "anbox" or similar projects that allow you to run > Android apps in a container? > >

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Greg Kroah-Hartman
On Mon, Sep 18, 2017 at 05:35:03PM +0200, Arnd Bergmann wrote: > On Mon, Sep 18, 2017 at 4:02 PM, Greg Kroah-Hartman > wrote: > >> However, there is another problem with the Kconfig option: turning > >> it on or off creates two incompatible ABI versions, a kernel that > >> has this enabled cannot

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Christoph Hellwig
On Mon, Sep 18, 2017 at 05:53:47PM +0200, Greg Kroah-Hartman wrote: > > It seems like a legitimate use case of the binder modules, but > > now there is a kernel Kconfig option that has to match a user > > space binary. > > So, should we revert that? > > I don't really know what to suggest here, s

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Greg Kroah-Hartman
On Mon, Sep 18, 2017 at 09:23:03AM -0700, Christoph Hellwig wrote: > On Mon, Sep 18, 2017 at 05:53:47PM +0200, Greg Kroah-Hartman wrote: > > > It seems like a legitimate use case of the binder modules, but > > > now there is a kernel Kconfig option that has to match a user > > > space binary. > >

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Arnd Bergmann
On Mon, Sep 18, 2017 at 6:23 PM, Christoph Hellwig wrote: > On Mon, Sep 18, 2017 at 05:53:47PM +0200, Greg Kroah-Hartman wrote: >> > It seems like a legitimate use case of the binder modules, but >> > now there is a kernel Kconfig option that has to match a user >> > space binary. >> >> So, should

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues

2017-09-18 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, September 18, 2017 5:55 AM > To: KY Srinivasan > Cc: Stephen Hemminger ; > leann.ogasaw...@canonical.com; Stephen Hemminger > ; a...@canonical.com; o...@aepfle.de; > marcelo.ce...@canonical.com; gr