Re: [PATCH v3] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Tobin C. Harding
On Sat, Sep 30, 2017 at 07:41:11PM +0530, Shreeya Patel wrote: > Remove unnecessary comments which are there > to explain why call to memset is in comments. Both of the > comments are not needed as they are not very useful. > > > Signed-off-by: Shreeya Patel > --- > Changes in v2: > -Remove so

Re: [PATCH] staging: iio: trigger: Move header file content to source file

2017-09-30 Thread Jonathan Cameron
On Tue, 26 Sep 2017 23:56:15 +0530 Harsha Sharma wrote: > The contents of the header file are used only by this single source file. > Moved content into iio-trig-bfin-timer.c and removed iio-trig-bfin-timer.h > > Signed-off-by: Harsha Sharma Hmm. This one again. Sometimes you need to not just

Re: [PATCH] staging: iio: ade7759: fix signed extension bug on shift of a u8

2017-09-30 Thread Jonathan Cameron
On Wed, 13 Sep 2017 18:02:02 +0100 Colin King wrote: > From: Colin Ian King > > The current shift of st->rx[2] left shifts a u8 24 bits left, > promotes the integer to a an int and then to a unsigned u64. If > the top bit of st->rx[2] is set then we end up with all the upper > bits being set to

[PATCH] staging: rtl8192u: make r8192_wx_handlers_def structure const

2017-09-30 Thread Bhumika Goyal
Make this const as it is only stored in a const field of a pci_dev structure. Make the declaration in the header const too. Structure found using Coccinelle and changes done by hand. Signed-off-by: Bhumika Goyal --- drivers/staging/rtl8192u/r8192U_wx.c | 2 +- drivers/staging/rtl8192u/r8192U_wx

[PATCH v3] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Shreeya Patel
Remove unnecessary comments which are there to explain why call to memset is in comments. Both of the comments are not needed as they are not very useful. Signed-off-by: Shreeya Patel --- Changes in v2: -Remove some more unnecessary comments and make the commit message more appropriate. Ch

[PATCH] vme: Fix integer overflow checking in vme_check_window()

2017-09-30 Thread Dan Carpenter
The controversial part of this patch is that I've changed it so we now prevent integer overflows for VME_USER types and before we didn't. I view it as kernel-hardening. I looked at a couple places that used VME_USER types and they seemed pretty suspicious so I'm pretty sure preventing overflows h

Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Shreeya Patel
On Sat, 2017-09-30 at 21:06 +1000, Tobin C. Harding wrote: > Hi Shreeya, > > We don't usually add a period to the subject line for kernel patches. > (reason: we only have about > 52 characters for the commit brief description so best not to waste > any). > > On Sat, Sep 30, 2017 at 01:30:34PM +05

Re: [PATCH 0/6] Replace container_of with list_entry

2017-09-30 Thread Tobin C. Harding
On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote: > Replaces instances of container_of with list_entry to > access current list element. > > Srishti Sharma (6): > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead

Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Tobin C. Harding
Hi Shreeya, We don't usually add a period to the subject line for kernel patches. (reason: we only have about 52 characters for the commit brief description so best not to waste any). On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote: > This patch removes unnecessary comments which a

Re: [PATCH RFC] media: staging/imx: fix complete handler

2017-09-30 Thread Mauro Carvalho Chehab
Em Fri, 29 Sep 2017 22:38:39 +0100 Russell King escreveu: > The complete handler walks all entities, expecting to find an imx > subdevice for each and every entity. > > However, camera drivers such as smiapp can themselves contain multiple > entities, for which there will not be an imx subdevice

Re: [Outreachy kernel] [PATCH 6/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Julia Lawall
On Sat, 30 Sep 2017, Srishti Sharma wrote: > For variables of type struct list_head* use list_entry to access > current list element instead of using container_of. Done by the > following semantic patch by coccinelle. > > @r@ > struct list_head* l; > @@ > > -container_of > +list_entry > (l,...

[PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Shreeya Patel
This patch removes unnecessary comments which are there to explain why call to memset is in comments. Both of the comments are not needed as they are not very useful. Signed-off-by: Shreeya Patel --- Changes in v2: -Remove some more unnecessary comments and make the commit message more app

[PATCH 6/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of type struct list_head* use list_entry to access current list element instead of using container_of. Done by the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/c

[PATCH 5/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188

[PATCH 4/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl

[PATCH 3/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8

[PATCH 2/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8

[PATCH 1/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188e

[PATCH 0/6] Replace container_of with list_entry

2017-09-30 Thread Srishti Sharma
Replaces instances of container_of with list_entry to access current list element. Srishti Sharma (6): Staging: rtl8188eu: core: Use list_entry instead of container_of Staging: rtl8188eu: core: Use list_entry instead of container_of Staging: rtl8188eu: core: Use list_entry instead of contai