Re: Destaging most drivers

2017-10-20 Thread Greg KH
On Fri, Oct 20, 2017 at 12:15:56PM +0530, PrasannaKumar Muralidharan wrote: > Hi Christian, > > It has been a couple of years since most was added to the staging > tree. Except for review the TODO list does not mention things that are > required to destage it. Wondering why most is still in stagin

Re: Destaging most drivers

2017-10-20 Thread Christian Gromm
On 20.10.2017 09:10, Greg KH wrote: On Fri, Oct 20, 2017 at 12:15:56PM +0530, PrasannaKumar Muralidharan wrote: Hi Christian, It has been a couple of years since most was added to the staging tree. Except for review the TODO list does not mention things that are required to destage it. Wonderin

Re: [RFC 02/12] mtd: nand: force drivers to explicitly send READ/PROG commands

2017-10-20 Thread Stefan Agner
Hi Miquel, Thanks for the work on this, happy to see the new interface is moving forward. Some comments below. On 2017-10-18 16:36, Miquel Raynal wrote: > From: Boris Brezillon > > The core currently send the READ0 and SEQIN+PAGEPROG commands in > nand_do_read/write_ops(). This is inconsistent

Re: [RFC 02/12] mtd: nand: force drivers to explicitly send READ/PROG commands

2017-10-20 Thread Boris Brezillon
On Fri, 20 Oct 2017 11:29:18 +0200 Stefan Agner wrote: > Hi Miquel, > > Thanks for the work on this, happy to see the new interface is moving > forward. Some comments below. > > On 2017-10-18 16:36, Miquel Raynal wrote: > > From: Boris Brezillon > > > > The core currently send the READ0 and S

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2017-10-20 Thread gre...@linuxfoundation.org
On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote: > On Fri, 6 Oct 2017 13:50:44 + > "Stahl, Manuel" wrote: > > > MSI(X) interrupts are not shared between devices. So when available > > those should be preferred over legacy interrupts. > > > > Signed-off-by: Manuel Stahl > >

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2017-10-20 Thread Stahl, Manuel
Hi Greg, it just uses MSI-X or MSI when available and falls back to legacy IRQ otherwise. Regards, Manuel On Fr, 2017-10-20 at 14:50 +0200, gre...@linuxfoundation.org wrote: > On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote: > > On Fri, 6 Oct 2017 13:50:44 + > > "Stahl, Man

Re: [GIT PULL] VME Subsystem patches for 4.14-rc4

2017-10-20 Thread Greg Kroah-Hartman
On Fri, Oct 13, 2017 at 10:09:19PM +0100, Martyn Welch wrote: > The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: > > Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) > > are available in the git repository at: > > https://gitlab.collabora.com/martyn/linux.git tags/vme-n

Re: [PATCH 1/3] Drivers: hv: vmbus: Expose per-channel interrupts and events counters

2017-10-20 Thread Greg KH
On Thu, Oct 05, 2017 at 05:35:04PM -0700, k...@exchange.microsoft.com wrote: > From: Stephen Hemminger > > When investigating performance, it is useful to be able to look at > the number of host and guest events per-channel. This is equivalent > to per-device interrupt statistics. > > Signed-off

Re: [PATCH 0/3] Drivers: hv: vmbus: Miscellaneous enhancements and fixes

2017-10-20 Thread Greg KH
On Thu, Oct 05, 2017 at 05:33:59PM -0700, k...@exchange.microsoft.com wrote: > From: "K. Y. Srinivasan" > > Miscellaneous enhancements and fixes. > > K. Y. Srinivasan (1): > Drivers: hv: vmbus: Make pannic reporting to be more useful > > Stephen Hemminger (2): > Drivers: hv: vmbus: Expose p

Re: [PATCH 2/2] android: binder: Don't get mm from task

2017-10-20 Thread Greg Kroah-Hartman
On Sat, Sep 16, 2017 at 01:11:57AM -0400, Sherry Yang wrote: > Use binder_alloc struct's mm_struct rather than getting > a reference to the mm struct through get_task_mm to > avoid a potential deadlock between lru lock, task lock and > dentry lock, since a thread can be holding the task lock > and

Re: [PATCH 2/2] android: binder: Fix null ptr dereference in debug msg

2017-10-20 Thread Greg Kroah-Hartman
On Fri, Oct 06, 2017 at 04:12:06PM -0400, Sherry Yang wrote: > Don't access next->data in kernel debug message when the > next buffer is null. > > Acked-by: Arve Hjønnevåg > Signed-off-by: Sherry Yang > --- > drivers/android/binder_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

2017-10-20 Thread Christian Gromm
On 18.10.2017 16:29, Greg KH wrote: On Wed, Oct 18, 2017 at 04:02:33PM +0200, Christian Gromm wrote: On 18.10.2017 14:12, Greg KH wrote: On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: The following patch adapts the driver to use the device model by: - adopting the MO

Re: Destaging most drivers

2017-10-20 Thread PrasannaKumar Muralidharan
Hi Greg, On 20 October 2017 at 12:40, Greg KH wrote: > On Fri, Oct 20, 2017 at 12:15:56PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Christian, >> >> It has been a couple of years since most was added to the staging >> tree. Except for review the TODO list does not mention things that are >>

Re: Destaging most drivers

2017-10-20 Thread PrasannaKumar Muralidharan
Hi Christian, On 20 October 2017 at 14:35, Christian Gromm wrote: > Hi Prasanna, > > the reason why the TODO file doesn't list anything, is because by > the time we initially committed the driver upstream, we didn't know > what work is really necessary to move the sources out of staging. > (We wo

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

2017-10-20 Thread Greg KH
On Fri, Oct 20, 2017 at 04:20:33PM +0200, Christian Gromm wrote: > On 18.10.2017 16:29, Greg KH wrote: > > On Wed, Oct 18, 2017 at 04:02:33PM +0200, Christian Gromm wrote: > > > On 18.10.2017 14:12, Greg KH wrote: > > > > On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: > > > > > Th

Re: Destaging most drivers

2017-10-20 Thread Greg KH
On Fri, Oct 20, 2017 at 08:15:23PM +0530, PrasannaKumar Muralidharan wrote: > Hi Greg, > > On 20 October 2017 at 12:40, Greg KH wrote: > > On Fri, Oct 20, 2017 at 12:15:56PM +0530, PrasannaKumar Muralidharan wrote: > >> Hi Christian, > >> > >> It has been a couple of years since most was added to

Re: Destaging most drivers

2017-10-20 Thread Christian Gromm
On 20.10.2017 16:50, PrasannaKumar Muralidharan wrote: Hi Christian, On 20 October 2017 at 14:35, Christian Gromm wrote: Hi Prasanna, the reason why the TODO file doesn't list anything, is because by the time we initially committed the driver upstream, we didn't know what work is really neces

Re: Destaging most drivers

2017-10-20 Thread PrasannaKumar Muralidharan
Greg, On 20 October 2017 at 20:31, Greg KH wrote: > On Fri, Oct 20, 2017 at 08:15:23PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Greg, >> >> On 20 October 2017 at 12:40, Greg KH wrote: >> > On Fri, Oct 20, 2017 at 12:15:56PM +0530, PrasannaKumar Muralidharan wrote: >> >> Hi Christian, >> >>

[PATCH] staging: rtl8188eu: avoid a null dereference on pmlmepriv

2017-10-20 Thread Colin King
From: Colin Ian King There is a check on pmlmepriv before dereferencing it when vfree'ing pmlmepriv->free_bss_buf however the previous call to rtw_free_mlme_priv_ie_data deferences pmlmepriv causing a null pointer deference if it is null. Avoid this by also calling rtw_free_mlme_priv_ie_data if

RE: [PATCH 0/3] Drivers: hv: vmbus: Miscellaneous enhancements and fixes

2017-10-20 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, October 20, 2017 3:28 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; leann.

Re: [patch 0/3] x86/PCI/MSI: Make sure that irq reservation mode works everywhere

2017-10-20 Thread Bjorn Helgaas
On Tue, Oct 17, 2017 at 09:54:56AM +0200, Thomas Gleixner wrote: > Dexuan reported that the recent rework of the vector allocation mode in x86 > broke HyperV PCI passtrough because the rework missed to add the > MSI_FLAG_MUST_REACTIVATE flag to the HyperV/PCI interrupt domain info. > > The simple

[PATCH v2 3/4] android: binder: Remove unused vma argument

2017-10-20 Thread Sherry Yang
The vma argument in update_page_range is no longer used after 74310e06 ("android: binder: Move buffer out of area shared with user space"), since mmap_handler no longer calls update_page_range with a vma. Acked-by: Arve Hjønnevåg Signed-off-by: Sherry Yang --- drivers/android/binder_alloc.c | 1

[PATCH v2 4/4] android: binder: Change binder_shrinker to static

2017-10-20 Thread Sherry Yang
binder_shrinker struct is not used anywhere outside of binder_alloc.c and should be static. Acked-by: Arve Hjønnevåg Signed-off-by: Sherry Yang --- drivers/android/binder_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android

[PATCH v2 1/4] android: binder: Don't get mm from task

2017-10-20 Thread Sherry Yang
Use binder_alloc struct's mm_struct rather than getting a reference to the mm struct through get_task_mm to avoid a potential deadlock between lru lock, task lock and dentry lock, since a thread can be holding the task lock and the dentry lock while trying to acquire the lru lock. Acked-by: Arve H

[PATCH v2 2/4] android: binder: Fix null ptr dereference in debug msg

2017-10-20 Thread Sherry Yang
Don't access next->data in kernel debug message when the next buffer is null. Acked-by: Arve Hjønnevåg Signed-off-by: Sherry Yang --- drivers/android/binder_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.

Re: [PATCH net] hv_sock: add locking in the open/close/release code paths

2017-10-20 Thread David Miller
From: Dexuan Cui Date: Thu, 19 Oct 2017 03:33:14 + > > Without the patch, when hvs_open_connection() hasn't completely established > a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't > inserted the sock into the connected queue), vsock_stream_connect() may see > the