Re: [greybus-dev] [PATCH 2/2] staging: greybus/loopback: use ktime_get() for time intervals

On 02-11-17, 15:32, Arnd Bergmann wrote: > This driver is the only one using the deprecated timeval_to_ns() > helper. Changing it from do_gettimeofday() to ktime_get() makes > the code more efficient, more robust against concurrent > settimeofday(), more accurate and lets us get rid of that helper

Re: [PATCH] staging: rtlwifi: remove an unused variable

On Thu, Nov 2, 2017 at 7:31 AM, Arnd Bergmann wrote: > The timer conversion patch left a variable behind, and this > escaped the build testing: > > drivers/staging/rtlwifi/base.c: In function 'rtl_watch_dog_timer_callback': > drivers/staging/rtlwifi/base.c:2167:23: error: unused

OFERTA POZYCZKI

Dobry dzien, Czy potrzebujesz prostej, prostej i szybkiej pozyczki z banku lub prywatnego kredytodawcy. Oferujemy pozyczke w wysokosci 3% na anum. Prosze nam odpowiedziec, jesli potrzebujesz pozyczki. Skontaktuj sie z nami za posrednictwem tego adresu e-mail martinezjosemartinez...@gmail.com

[PATCH] staging: fbtft: fb_ssd1331: Use common error handling code in write_reg8_bus8()

From: Markus Elfring Date: Thu, 2 Nov 2017 22:27:13 +0100 * Add a jump target so that a specific error message is stored only once at the end of this function implementation. * Replace two calls of the function "dev_err" by goto statements. This issue was

[PATCH] staging: fbtft: fb_ra8875: Use common error handling code in write_reg8_bus8()

From: Markus Elfring Date: Thu, 2 Nov 2017 22:12:58 +0100 * Add a jump target so that a specific error message is stored only once at the end of this function implementation. * Replace two calls of the function "dev_err" by goto statements. This issue was

[PATCH] staging: comedi: usbduxsigma: Improve unlocking of a mutex in three functions

From: Markus Elfring Date: Thu, 2 Nov 2017 21:16:50 +0100 * Add a jump target so that a call of the function "mutex_unlock" is stored only twice in these function implementations. * Replace seven calls by goto statements. This issue was detected by using the

[PATCH] staging: comedi: usbduxfast: Improve unlocking of a mutex in usbduxfast_ai_insn_read()

From: Markus Elfring Date: Thu, 2 Nov 2017 20:30:31 +0100 * Add a jump target so that a call of the function "mutex_unlock" is stored only twice in this function implementation. * Replace five calls by goto statements. This issue was detected by using the

Re: [PATCH v2] staging: rtlwifi: Fix line too long warning

On Wed, 2017-11-01 at 17:47 +0100, Greg KH wrote: > On Tue, Oct 31, 2017 at 12:48:04AM -0400, Kien Ha wrote: > > > From aa0f4ae8c325545b1fd794d6bbf8c4d2f64e2ec2 Mon Sep 17 00:00:00 > > > 2001 > > > > From: Kien Ha > > Date: Fri, 27 Oct 2017 14:07:55 -0400 > > Subject:

[PATCH 2/2] staging: greybus/loopback: use ktime_get() for time intervals

This driver is the only one using the deprecated timeval_to_ns() helper. Changing it from do_gettimeofday() to ktime_get() makes the code more efficient, more robust against concurrent settimeofday(), more accurate and lets us get rid of that helper in the future. Signed-off-by: Arnd Bergmann

[PATCH 1/2] staging: greybus: remove unused kfifo_ts

As of commit 8e1d6c336d74 ("greybus: loopback: drop bus aggregate calculation"), nothing ever reads from kfifo_ts, so there is no reason to write to it or even allocate it any more. Signed-off-by: Arnd Bergmann --- drivers/staging/greybus/loopback.c | 27

[PATCH] staging: rtlwifi: remove an unused variable

The timer conversion patch left a variable behind, and this escaped the build testing: drivers/staging/rtlwifi/base.c: In function 'rtl_watch_dog_timer_callback': drivers/staging/rtlwifi/base.c:2167:23: error: unused variable 'hw' [-Werror=unused-variable] This removes the stale variable as

[PATCH] staging: rtl8723bs: remove unused variables

A cleanup patch removed the only user of two local variables: drivers/staging/rtl8723bs/hal/hal_btcoex.c: In function 'hal_btcoex_Initialize': drivers/staging/rtl8723bs/hal/hal_btcoex.c:1415:5: error: unused variable 'ret2' [-Werror=unused-variable]

[PATCH] staging: rtlwifi: remove unused pointer hw

From: Colin Ian King Pointer hw is not being used and hence can be removed. Cleans up warning: drivers/staging/rtlwifi/base.c:2167:23: warning: unused variable ‘hw’ [-Wunused-variable] Signed-off-by: Colin Ian King ---

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: > On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > > There was a discussion a while ago in the context of I2C/SPI MFDs > > which concluded that if you need a bus and it's going to be effectively > > noop then you should just

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote: > > > I'm not a fan of the platform bus but I have mixed feelings about > > creating a dedicated bus type. I guess if we really need a bus > > type we can do it later? > >

[PATCH net-next v2 2/2] hv_netvsc: hide warnings about uninitialized/missing rndis device

Hyper-V hosts are known to send RNDIS messages even after we halt the device in rndis_filter_halt_device(). Remove user visible messages as they are not really useful. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/rndis_filter.c | 4 ++-- 1 file changed, 2

[PATCH net-next v2 1/2] hv_netvsc: netvsc_teardown_gpadl() split

It was found that in some cases host refuses to teardown GPADL for send/ receive buffers (probably when some work with these buffere is scheduled or ongoing). Change the teardown logic to be: 1) Send NVSP_MSG1_TYPE_REVOKE_* messages 2) Close the channel 3) Teardown GPADLs. This seems to work

[PATCH net-next v2 0/2] hv_netvsc: fix a hang on channel/mtu changes

It was found that netvsc driver doesn't survive e.g. # while true; do ethtool -L eth0 combined 4; ethtool -L eth0 combined 8; done" test. I was able to identify a hang in guest/host communication, it is fixed by PATCH1 of this series. PATCH2 is a cosmetic change masking unneeded messages.

Re: [PATCH net-next 2/4] hv_netvsc: protect nvdev->extension with RCU

Vitaly Kuznetsov writes: > > Ok, I may have missed something. I'll try reproducing the crash and > finding a better fine-grained solution. > It's been two days and I'm failing to reproduce the crash in rndis_filter_receive() in my environment so I'll probably just re-send

[PATCH 1/3] staging: rtl8188eu: Revert part of "staging: rtl8188eu: fix comments with lines over 80 characters"

Commit 74e1e498e84e ("staging: rtl8188eu: fix comments with lines over 80 characters") not only changed comments but also changed an if check: -if (pmlmepriv->cur_network.join_res != true) { +if (!(pmlmepriv->cur_network.join_res)) { This is not equivalent as join_res is an int and can have

[PATCH 3/3] staging: r8188eu: Revert 4 commits breaking ARP

Commit 2ba8444c97b1 ("staging:r8188eu: move IV/ICV trimming into decrypt() and also place it after rtl88eu_mon_recv_hook()") breaks ARP. After this commit ssh-ing to a laptop with r8188eu wifi no longer works if the machine connecting has never communicated with the laptop before. This is 100%

[PATCH 2/3] staging: rtl8188eu: Fix bug introduced by convert timers to use timer_setup()

Commit b7749656e946 ("staging: rtl8188eu: Convert timers to use timer_setup()") introduces a copy and paste error which causes the rtl8188eu driver to no longer function. This commit fixes this. Fixes: b7749656e946 ("staging: rtl8188eu: Convert timers to use timer_setup()") Cc: Kees Cook

[PATCH v2 3/3] staging: ccree: remove dead code

The inflight_counter field is updated in a single location and never used. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 4 drivers/staging/ccree/ssi_driver.h | 1 - 2 files changed, 5 deletions(-) diff --git

[PATCH v2 1/3] staging: ccree: copy IV to DMAable memory

We are being passed an IV buffer from unknown origin, which may be stack allocated and thus not safe for DMA. Allocate a DMA safe buffer for the IV and use that instead. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 20 ++--

[PATCH v2 0/3] staging: ccree: Fixes and cleanups

Fixes and cleanups for 4.15 Changes from v1: - Move DMA mask code to before turning on clocks, based on feedback from Dan Carpenter. - Add missing kmalloc success check, as spotted by Dan Carpenter. Gilad Ben-Yossef (3): staging: ccree: copy IV to DMAable memory staging: ccree: handle

[PATCH v2 2/3] staging: ccree: handle limiting of DMA masks

Properly handle limiting of DMA masks based on device and bus capabilities. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 2/3] staging: ccree: handle limiting of DMA masks

Hi, Thank you for the review. On Wed, Nov 1, 2017 at 1:09 PM, Dan Carpenter wrote: > On Tue, Oct 31, 2017 at 11:56:16AM +, Gilad Ben-Yossef wrote: >> >> - if (!dev->coherent_dma_mask) >> - dev->coherent_dma_mask = DMA_BIT_MASK(DMA_BIT_MASK_LEN); >>