Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote: > Fixed some signedness warnings from sparse on lustre. > > Stefano Manni (4): > staging: lustre: fixed signedness of some socklnd params > staging: lustre: fixed signedness of llite > staging: lustre: fixed signedness of lov >

[PATCH] staging: rtl8188eu: Fix private WEXT IOCTL calls

From: Ishraq Ibne Ashraf Commit 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback") breaks private WEXT IOCTL calls of this driver as these are not invoked through ndo_do_ioctl interface anymore. As a result hostapd stops working with this driver. In this

[PATCH V2 22/29] [media] atomisp: deprecate pci_get_bus_and_slot()

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function. Since ISP always uses domain 0, hard-code it in the code when

[PATCH V2 23/29] staging: rts5208: deprecate pci_get_bus_and_slot()

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Remove unused

[PATCH AUTOSEL for 4.9 04/24] staging: greybus: loopback: Fix iteration count on async path

From: Bryan O'Donoghue [ Upstream commit 44b02da39210e6dd67e39ff1f48d30c56d384240 ] Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support") does what it says on the tin - namely, adds support for asynchronous bi-directional loopback

[PATCH AUTOSEL for 4.14 07/51] staging: greybus: loopback: Fix iteration count on async path

From: Bryan O'Donoghue [ Upstream commit 44b02da39210e6dd67e39ff1f48d30c56d384240 ] Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support") does what it says on the tin - namely, adds support for asynchronous bi-directional loopback

Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

On Wed, 2017-11-22 at 18:33 +0100, Patryk Kocielnik wrote: > Joe, > > Thank you for your comments! > > I did compile it beforehand and it was clean. Did I miss anything? You also have to compile it afterhand... i.e.: with your patch applied $ make allyesconfig [] $ make

[PATCH] staging/irda/net: Drop extraneous parentheses around test

Noticed during Clang builds. This drops the redundant parentheses. Cc: Samuel Ortiz Cc: Greg Kroah-Hartman Cc: de...@driverdev.osuosl.org Signed-off-by: Kees Cook --- drivers/staging/irda/net/irlmp.c | 4 ++-- 1 file

[PATCH 4/4] staging: lustre: fixed signedness of obdclass

sparse warning on obd_mount.c: warning: incorrect type in argument 5 (different signedness) expected unsigned int [usertype] *vallen got int * Signed-off-by: Stefano Manni --- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

Fixed some signedness warnings from sparse on lustre. Stefano Manni (4): staging: lustre: fixed signedness of some socklnd params staging: lustre: fixed signedness of llite staging: lustre: fixed signedness of lov staging: lustre: fixed signedness of obdclass

[PATCH 1/4] staging: lustre: fixed signedness of some socklnd params

sparse warnings: warning: incorrect type in assignment (different signedness) expected int *[addressable] [toplevel] [assigned] ksnd_nscheds got unsigned int static [toplevel] * warning: incorrect type in assignment (different signedness) expected int *[addressable] [toplevel] [assigned]

[PATCH 2/4] staging: lustre: fixed signedness of llite

sparse warnings on dir.c: warning: incorrect type in argument 5 (different signedness) expected unsigned int [usertype] *vallen got int * sparse warnings on llite_lib.c: warning: incorrect type in argument 5 (different signedness) expected unsigned int [usertype] *vallen got int * sparse

[PATCH 3/4] staging: lustre: fixed signedness of lov

sparse warning on lov_obd.c: warning: incorrect type in argument 3 (different signedness) expected int *res got unsigned int [usertype] *i sparse warning on lov_offset.c: warning: incorrect type in argument 4 (different signedness) expected long long [usertype] * got unsigned long long *

Re: [PATCH 23/30] [media] atomisp: deprecate pci_get_bus_and_slot()

On Wed, 22 Nov 2017 12:20:47 + Alan Cox wrote: > On Wed, 2017-11-22 at 00:31 -0500, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 > > as > > where a PCI device is present. This restricts the device drivers to > > be > > reused

Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

Joe, Thank you for your comments! > checkpatch is not always correct. I did compile it beforehand and it was clean. Did I miss anything? Regards, Patryk On 22 November 2017 at 18:33, Patryk Kocielnik wrote: > Joe, > > Thank you for your comments! > > I did compile

Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

On Wed, 2017-11-22 at 16:42 +0100, Patryk Kocielnik wrote: > Cleaned checkpatch warnings by fixing coding style issues. checkpatch is not always correct. > Signed-off-by: Patryk Kocielnik > --- > drivers/staging/sm750fb/sm750.c | 4 ++-- > 1 file changed, 2

[PATCH] Staging: sm750fb: sm750: fixed coding style issues

Cleaned checkpatch warnings by fixing coding style issues. Signed-off-by: Patryk Kocielnik --- drivers/staging/sm750fb/sm750.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c

Re: [PATCH 23/30] [media] atomisp: deprecate pci_get_bus_and_slot()

On 11/22/2017 9:05 AM, Sinan Kaya wrote: > Hi Alex, I tried to mean Alan. Sorry about that. Apparently, I didn't have enough coffee this morning. I shouldn't touch the code for a few hours. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.

Re: [PATCH 23/30] [media] atomisp: deprecate pci_get_bus_and_slot()

Hi Alex, On 11/22/2017 7:20 AM, Alan Cox wrote: > On Wed, 2017-11-22 at 00:31 -0500, Sinan Kaya wrote: >> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 >> as >> where a PCI device is present. This restricts the device drivers to >> be >> reused for other domain numbers. > >

Re: [PATCH 42/50] staging: most: core: fix data type

Hi Christian, On 21 November 2017 at 19:35, Christian Gromm wrote: > This patch fixes the type used to manage the channels of an > registered MOST interface. > > Signed-off-by: Christian Gromm > --- > drivers/staging/most/core.h | 2

Re: [PATCH 41/50] staging: most: usb: clear functional stall on OUT endpoint

Hi Christian, On 21 November 2017 at 19:35, Christian Gromm wrote: > For the MOST packet channel there are two dedicated USB endpoints. But > internally the hardware has actually one channel for data forwarding from > and to MOST. To have the hardware clean up its

Re: [PATCH 20/50] staging: most: core: remove struct device

Hi Christian, On 21 November 2017 at 19:34, Christian Gromm wrote: > This patch takes out the struct device of struct most_aim, because it is > not needed. Patch 9 adds struct device to struct most_aim and this patch removes it. I think not adding struct device to

Re: [PATCH 47/50] staging: most: core: remove class generation

Hi Christian, On 21 November 2017 at 19:35, Christian Gromm wrote: > This patch stops the core from generating a module owned class and > registering it with the kernel. It is needed, because there is no need for Should be "It is not needed". Not is missing. > a

Re: [PATCH 26/50] staging: most: rename struct most_aim

Hi Christian, On 21 November 2017 at 19:35, Christian Gromm wrote: > The designator of a module that proivdes means to interface userspace is > called an AIM. Since this name seems to be unappropiate, this kind of > moduels are going to be referred to as

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

Hi Christian, On 21 November 2017 at 19:34, Christian Gromm wrote: > This patch set fixes bugs and integrates the driver to the kernel's device > model by revising its architecture. Part of this change is rearranging the > directory layout, renaming of files and

Re: [PATCH 23/30] [media] atomisp: deprecate pci_get_bus_and_slot()

On Wed, 2017-11-22 at 00:31 -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 > as > where a PCI device is present. This restricts the device drivers to > be > reused for other domain numbers. The ISP v2 will always been in domain 0. Alan

Re: [PATCH] Staging: comedi: adl_pci9118: fixed some parentheses coding style issue

Thank you. I'll keep that in mind next time! On Wed, Nov 22, 2017 at 11:28:51AM +1100, Tobin C. Harding wrote: > You may like to limit the git log brief description to 50 characters > (this is going to be hard with such a long pre-fix though :) > > Brief description should be in imperative mood

Re: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

On 11/22/2017 09:48 AM, Bharat Bhushan wrote: > As per APIs each mc-portal is of 64K size while currently > 16bits (type u16) is used to store size of mc-portal. > In these cases upper bit of portal size gets truncated. > > Signed-off-by: Bharat Bhushan > --- Ok, so

Re: [PATCH 10/50] staging: most: core: remove function get_channel_by_iface

On Tue, Nov 21, 2017 at 3:04 PM, Christian Gromm wrote: > This patch removes the function get_channel_by_iface that walks a list of > all registered interfaces and returns a pointer to a channel when matched. > Instead the private field of the interface structure is

Re: [PATCH 24/30] staging: rts5208: deprecate pci_get_bus_and_slot()

On Wed, Nov 22, 2017 at 12:31:09AM -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Use pci_get_domain_bus_and_slot() with a domain

[PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

As per APIs each mc-portal is of 64K size while currently 16bits (type u16) is used to store size of mc-portal. In these cases upper bit of portal size gets truncated. Signed-off-by: Bharat Bhushan --- v2->v3: - v2 patch: https://patchwork.kernel.org/patch/10067661/ -