On Mon, Dec 04, 2017 at 09:39:05PM -0500, Genki Sky wrote:
> Signed-off-by: Genki Sky
> ---
> .../vc04_services/bcm2835-camera/bcm2835-camera.c| 16
> ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
I can't take patches without any changelog text at all, sorry.
greg
Hi,
This is v2 of a patch series to fix some checkpatch.pl warnings in
drivers/staging/vc04_services/bcm2835-camera/*
Changes from v1 [1]:
- Split single patch into multiple patches
- Remove reference to eudyptula in commit message
[1]:
https://lkml.kernel.org/r/<30cc7b48def470f1bec8d8d255044f4
Signed-off-by: Genki Sky
---
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
index 5ddea4f54bf7.
Signed-off-by: Genki Sky
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 7 +++
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 3 +--
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera
Signed-off-by: Genki Sky
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c| 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.
On Dec 4, 2017, at 11:42, Aliaksei Karaliou wrote:
>
> On 12/04/2017 11:40 AM, Dan Carpenter wrote:
>> On Sun, Dec 03, 2017 at 07:59:07PM +0300, ak wrote:
>>> Thank you for your extensive comments.
>>>
>>> I've also thought about adding more protection into unregister_shrinker(),
>>> but not sur
To increase the readability of the register accesses, the abstraction
of the helpers was increased from simple read and write to set bit,
clear bit and read modify write bit.
Annotation: This patch contains a lot of long lines and camel case
var names. These long lines and camel case vars weren't
This patch fix several brace on next line, braces not necessary, space
around =/<, and space before/after open/close parenthesis coding style
errors find by checkpatch in pi433_if.c.
In addition, the interrupt routine DIO0_irq_handler logic is updated:
- use 'switch' statement instead of 'if/else
To increase the readability of the register accesses, the abstraction
of the helpers was increased from simple read and write to set bit,
clear bit and read modify write bit.
Annotation: This patch contains a lot of long lines and camel case
var names. These long lines and camel case vars weren't
Am 04.12.2017 um 21:56 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 09:31:06PM +0200, Marcus Wolf wrote:
Then it might be, that DATAMODUL_MODE_PACKET might need an other value.
That's future code so we can delete that sentence for now.
With the rule above, you are absolutely right. But w
On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote:
>
> Hi Simon, hi Dan,
>
> if you both are of the same opinion, for me, it's fine, if we go with two
> functions.
>
> But I don't get the advantage, if we split approx. 10 functions, to get rid
> of enum optionOnOff.
>
> Keep in mind,
On Mon, Dec 04, 2017 at 10:45:02PM +0300, Roman Storozhenko wrote:
> On Thu, Nov 30, 2017 at 09:08:46AM +0300, Dan Carpenter wrote:
> > On Wed, Nov 29, 2017 at 07:46:21PM +0300, Roman Storozhenko wrote:
> > > There are two reasons for that:
> >
> > In my email client the subject line and body are
Am 04.12.2017 um 21:42 schrieb Simon Sandström:
On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote:
Am 04.12.2017 um 21:15 schrieb Dan Carpenter:
That's a bad name, because it doesn't just enable it also disables.
Please split them.
regards,
dan carpenter
Same applies to all
On Wed, Nov 29, 2017 at 07:46:21PM +0300, Roman Storozhenko wrote:
> There are two reasons for that:
What I'm asking is there are two reasons for what? Where is the first
part of that paragraph?
regards,
dan carpenter
___
devel mailing list
de...@linu
On Mon, Dec 04, 2017 at 09:31:06PM +0200, Marcus Wolf wrote:
> > > Then it might be, that DATAMODUL_MODE_PACKET might need an other value.
> >
> > That's future code so we can delete that sentence for now.
>
> With the rule above, you are absolutely right. But we now spend time, to
> remove an cu
On 12/04/2017 10:32 AM, Dan Carpenter wrote:
> On Sat, Dec 02, 2017 at 10:05:20PM +0100, Tomas Marek wrote:
>> @@ -578,13 +546,9 @@ static irqreturn_t DIO1_irq_handler(int irq, void
>> *dev_id)
>> SET_CHECKED(rf69_set_mode(spi, standby)); /* this clears the
>> fifo */
>>
On Thu, Nov 30, 2017 at 09:08:46AM +0300, Dan Carpenter wrote:
> On Wed, Nov 29, 2017 at 07:46:21PM +0300, Roman Storozhenko wrote:
> > There are two reasons for that:
>
> In my email client the subject line and body are not next to each other.
> It looks like this:
>
> https://marc.info/?l=linux
On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote:
>
>
> Am 04.12.2017 um 21:15 schrieb Dan Carpenter:
> >
> > That's a bad name, because it doesn't just enable it also disables.
> > Please split them.
> >
> > regards,
> > dan carpenter
> >
> >
>
> Same applies to all other stuff,
Am 04.12.2017 um 21:18 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote:
Am 04.12.2017 um 12:33 schrieb Dan Carpenter:
On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote:
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi4
Second there might be the idea of supporting different chips in the future
(I already thought about).
Linux style is never to write code for the future.
Ok. I didn't know.
To be honest, I already started writing code, also supporting the rf12
some time ago, thus programming a rfxx.c, but neve
The subject is way too long.
On Mon, Dec 04, 2017 at 08:18:51PM +0200, Marcus Wolf wrote:
> To increase the readability of the register accesses, the abstraction
> of the helpers was increased from simple read and write to set bit,
> reset bit and read modify write bit. In addition - according to
lu_global_init() does not clean internals on failure, and its
cleanup procedure lu_global_fini() is also not called on any failure.
Patch addresses this problem by adding appropriate error handling.
Signed-off-by: Aliaksei Karaliou
---
drivers/staging/lustre/lustre/obdclass/lu_object.c | 22
On Mon, Dec 04, 2017 at 09:12:52PM +0200, Marcus Wolf wrote:
>
>
> Am 04.12.2017 um 12:24 schrieb Dan Carpenter:
> > On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote:
> > > Renames enum dataMode and its values packet, continuous, continuousNoSync
> > > to enum data_mode and PACKET,
Lustre code lacks checking the result of register_shrinker()
in several places. register_shrinker() was tagged __must_check
recently so that sparse has started reporting it.
Signed-off-by: Aliaksei Karaliou
---
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 12 +---
drivers/staging
Am 04.12.2017 um 21:15 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 08:37:51PM +0200, Marcus Wolf wrote:
Am 04.12.2017 um 12:37 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote:
Perhaps choose different function names if you want? You could do it
as s
Hello,
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index d04ec3b..e09f035 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -30,7 +30,6 @@
> #include
> #include
On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote:
>
> Am 04.12.2017 um 12:33 schrieb Dan Carpenter:
> > On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote:
> > > diff --git a/drivers/staging/pi433/pi433_if.h
> > > b/drivers/staging/pi433/pi433_if.h
> > > index 34ff0d4807bd
On Mon, Dec 04, 2017 at 09:42:12PM +0300, Aliaksei Karaliou wrote:
> On 12/04/2017 11:40 AM, Dan Carpenter wrote:
> > On Sun, Dec 03, 2017 at 07:59:07PM +0300, ak wrote:
> > > Thank you for your extensive comments.
> > >
> > > I've also thought about adding more protection into unregister_shrinker
On Mon, Dec 04, 2017 at 08:37:51PM +0200, Marcus Wolf wrote:
>
>
> Am 04.12.2017 um 12:37 schrieb Dan Carpenter:
> > On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote:
> > > Perhaps choose different function names if you want? You could do it
> > > as several patches:
> > >
> > > pa
Am 04.12.2017 um 12:24 schrieb Dan Carpenter:
On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote:
Renames enum dataMode and its values packet, continuous, continuousNoSync
to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes
checkpatch.pl warnings: "Avoid CamelCase:
Am 04.12.2017 um 12:33 schrieb Dan Carpenter:
On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote:
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index 34ff0d4807bd..bcfe29840889 100644
--- a/drivers/staging/pi433/pi433_if.h
+++ b/drivers/staging/pi
On 12/04/2017 11:40 AM, Dan Carpenter wrote:
On Sun, Dec 03, 2017 at 07:59:07PM +0300, ak wrote:
Thank you for your extensive comments.
I've also thought about adding more protection into unregister_shrinker(),
but not sure how to properly organize the patch set, because there will be
three pat
Am 04.12.2017 um 12:37 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote:
Perhaps choose different function names if you want? You could do it
as several patches:
patch 1: change types to bool
patch 2: sed -e '/ == optionOn//'
patch 3: split the functions i
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Unit Testing:
>
> - build successful
> - LTP testsuite passes.
> - checkpatch.pl pas
To increase the readability of the register accesses, the abstraction
of the helpers was increased from simple read and write to set bit,
reset bit and read modify write bit. In addition - according to the
proposal from Walter Harms from 20.07.2017 - instead of marcros inline
functions were used.
Hi Ishraq,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.15-rc2 next-20171204]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
Hi Aditya,
On 01.12.2017 22:27, Aditya Shankar wrote:
> This commit fixes below style problems in multiple lines
> Fix checkpatch WARNING: line over 80 characters
> Fix CHECK: Lines should not end with a '('
You should fix only one issue per patch. Would be better to have
a patch with "line over 8
Hi Dmitry,
As you already mention in the TODO, this should become a v4l2 codec driver.
Good existing examples are the coda, qcom/venus and mtk-vcodec drivers.
One thing that is not clear from this code is if the tegra hardware is a
stateful or stateless codec, i.e. does it keep track of the deco
Hi Steve,
On 10/28/2017 10:36 PM, Steve Longerbeam wrote:
> This is a set of patches that improve support for more complex OF
> graphs. Currently the imx-media driver only supports a single device
> with a single port connected directly to either the CSI muxes or the
> MIPI CSI-2 receiver input po
On Mon, Dec 04, 2017 at 12:19:02PM +0100, Nguyen Phan Quang Minh wrote:
> On Mon, Dec 04, 2017 at 11:51:32AM +0300, Dan Carpenter wrote:
> > On Sun, Dec 03, 2017 at 01:09:49AM +0100, Nguyen Phan Quang Minh wrote:
> > > @@ -335,6 +406,7 @@ pi433_receive(void *data)
> > > struct spi_device *spi = d
On Mon, Dec 04, 2017 at 01:17:36AM -0500, Genki Sky wrote:
> In bcm2835-camera, handle the following checkpatch.pl types:
> - EMBEDDED_FUNCTION_NAME
> - MULTILINE_DEREFERENCE
> - SPLIT_STRING
>
> [ note: this is for Task 10 of http://eudyptula-challenge.org/ ]
Leave this part out or put it
Change 0 to NULL in lov_object_fiemap() in order to fix warning produced
by sparse
Signed-off-by: Andrii Vladyka
Signed-off-by: Andreas Dilger
---
diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c
b/drivers/staging/lustre/lustre/lov/lov_object.c
index 105b707..897cf2c 100644
--- a/
On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote:
> Perhaps choose different function names if you want? You could do it
> as several patches:
>
> patch 1: change types to bool
> patch 2: sed -e '/ == optionOn//'
> patch 3: split the functions into two functions
> patch 4: delete opt
On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote:
> diff --git a/drivers/staging/pi433/pi433_if.h
> b/drivers/staging/pi433/pi433_if.h
> index 34ff0d4807bd..bcfe29840889 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -63,7 +63,7 @@ stru
On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote:
> Renames enum dataMode and its values packet, continuous, continuousNoSync
> to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes
> checkpatch.pl warnings: "Avoid CamelCase: , ".
These names are too generic. Delete t
On Sun, Dec 03, 2017 at 04:17:24PM +0100, Simon Sandström wrote:
> Renames the enum optionOnOff and its values optionOn, optionOff to enum
> option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings:
> "Avoid CamelCase: , , ".
>
> Signed-off-by: Simon Sandström
> ---
> drivers/stagin
On Sun, Dec 03, 2017 at 06:49:40PM +0200, Marcus Wolf wrote:
>
> Hi Simon,
Hi,
>
> thanks for your effort.
>
> I have two questions:
> * According to my practical experiance, enums were always written in lower
> case. Does kernel style guide ask for upper case for enums?
Yes. From Documentation
Looks good. Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, Dec 03, 2017 at 01:58:12PM +, Gilad Ben-Yossef wrote:
> The ccree drivers was marking a lot of big functions in C file as
> static inline for no good reason. Remove the inline qualifier from
> any but the few truly single line functions.
>
The compiler is free to ignore inline hints..
On Sat, Dec 02, 2017 at 10:05:20PM +0100, Tomas Marek wrote:
> @@ -578,13 +546,9 @@ static irqreturn_t DIO1_irq_handler(int irq, void
> *dev_id)
> SET_CHECKED(rf69_set_mode(spi, standby)); /* this clears the
> fifo */
> SET_CHECKED(rf69_set_fifo_threshold(spi, FIFO_THR
Paolo Bonzini writes:
> On 01/12/2017 18:29, Stephen Hemminger wrote:
>>> +static inline u64 hv_read_tsc_page_tsc(const struct ms_hyperv_tsc_page
>>> *tsc_pg,
>>> + u64 *cur_tsc)
>>> +{
>>> + *cur_tsc = rdtsc();
>>> +
>>> + return cur_tsc;
>> Why do return an
On Sun, Dec 03, 2017 at 07:59:07PM +0300, ak wrote:
> Thank you for your extensive comments.
>
> I've also thought about adding more protection into unregister_shrinker(),
> but not sure how to properly organize the patch set, because there will be
> three patches:
> * change in mm/vmscan that
On Sun, Dec 03, 2017 at 12:47:03AM +, Dilger, Andreas wrote:
> The preferred way to handle this would be:
>
> rc = ldlm_pools_thread_start();
> if (rc)
> goto out;
>
> rc = register_shrinker(&ldlm_pools_cli_shrinker);
> if (rc)
> goto out_po
On Sat, Dec 02, 2017 at 09:40:46PM +0300, Aliaksei Karaliou wrote:
> Lustre code lacks checking the result of register_shrinker()
> in several places. register_shrinker() was tagged __must_check
> recently so that sparse has started reporting it.
>
> Signed-off-by: Aliaksei Karaliou
> ---
> driv
> On Nov 30, 2017, at 11:30, Andrii Vladyka wrote:
>
> Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by
> sparse
>
> Signed-off-by: Andrii Vladyka
Patches should be inline rather than in an attachment.
That said, the patch looks correct, so you can add:
Signed-of
55 matches
Mail list logo
