[PATCH 1/1] codestyle issue fixed drivers/staging/vc04_services

From: Mike Signed-off-by: Mike --- .../interface/vchiq_arm/vchiq_kern_lib.c | 64 -- 1 file changed, 35 insertions(+), 29 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c

[PATCH v3 3/4] drivers: lustre: ldlm: check result of register_shrinker()

ldlm_pools_init() does not check result of register_shrinker() which was tagged __must_check recently, reported by sparse. Signed-off-by: Aliaksei Karaliou --- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[PATCH v3 2/4] drivers: lustre: ptlrpc: check result of register_shrinker()

sptlrpc_enc_pool_init() does not check result of register_shrinker() which was tagged __must_check recently, reported by sparse. Signed-off-by: Aliaksei Karaliou --- drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v3 4/4] drivers: lustre: obdclass: check result of register_shrinker()

lu_global_init() does not check result of register_shrinker() which was tagged __must_check recently, reported by sparse. Patch also fixes missed cleanup of resources allocated prior to register_shrinker() invocation and not freed after any failure. Signed-off-by: Aliaksei Karaliou

[PATCH v3 1/4] drivers: lustre: osc: check result of register_shrinker()

osc_init() does not check result of register_shrinker() which was tagged __must_check recently, reported by sparse. Signed-off-by: Aliaksei Karaliou --- drivers/staging/lustre/lustre/osc/osc_request.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v3 4/4] drivers: lustre: obdclass: check result of register_shrinker()

On 12/07/2017 12:55 AM, Aliaksei Karaliou wrote: lu_global_init() does not check result of register_shrinker() which was tagged __must_check recently, reported by sparse. Patch also fixes missed cleanup of resources allocated prior to register_shrinker() invocation and not freed after any

Re: [PATCH 01/10] staging: ccree: remove inline qualifiers

On Mon, Dec 4, 2017 at 11:36 AM, Dan Carpenter wrote: > On Sun, Dec 03, 2017 at 01:58:12PM +, Gilad Ben-Yossef wrote: >> The ccree drivers was marking a lot of big functions in C file as >> static inline for no good reason. Remove the inline qualifier from >> any but

Re: [PATCH] staging: ccree: Uninitialized return in ssi_ahash_import()

On Tue, Dec 5, 2017 at 4:37 PM, Dan Carpenter wrote: > The return value isn't initialized on some success paths. > > Fixes: c5f39d07860c ("staging: ccree: fix leak of import() after init()") > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH] staging: ccree: ssi_aead: fixed all coding style warnings.

Hi Sunil, On Thu, Dec 7, 2017 at 12:08 AM, SUNIL KALLUR RAMEGOWDA wrote: > My first kernel patch, fixed warnings. > Congratulations and may there be many more! :-) Please note that in addition to what Greg's patch-bot already mentioned I'm pretty sure you are looking at

Re: [PATCH] staging: ccree: ssi_aead: fixed all coding style warnings.

On Wed, Dec 06, 2017 at 11:08:09PM +0100, SUNIL KALLUR RAMEGOWDA wrote: > My first kernel patch, fixed warnings. > > Signed-off-by: SUNIL KALLUR RAMEGOWDA > --- > drivers/staging/ccree/ssi_aead.c | 179 > +++ > 1 file changed, 123

Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h

On Thu, Dec 07, 2017 at 12:24:34AM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 22:42 schrieb Simon Sandström: > > The enum is now only used for ioctl, so move it pi433_if.h. > > > > Signed-off-by: Simon Sandström > > --- > > drivers/staging/pi433/pi433_if.h | 5 +

RE: [PATCH 2/2] staging: fsl-mc: do not print error in case of defer probe error

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, December 06, 2017 16:46 > To: Nipun Gupta > Cc: Laurentiu Tudor ; stuyo...@gmail.com; Bharat > Bhushan ; cakt...@gmail.com; >

Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h

Am 06.12.2017 um 22:42 schrieb Simon Sandström: The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 21:57 schrieb Simon Sandström: On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: Am 06.12.2017 um 12:23 schrieb Dan Carpenter: Wow... This was the one patch I thought was going to sink this

[PATCH] staging: ccree: ssi_aead: fixed all coding style warnings.

My first kernel patch, fixed warnings. Signed-off-by: SUNIL KALLUR RAMEGOWDA --- drivers/staging/ccree/ssi_aead.c | 179 +++ 1 file changed, 123 insertions(+), 56 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c

[PATCH v3 4/4] drivers: lustre: obdclass: check result of register_shrinker()

lu_global_init() does not check result of register_shrinker() which was tagged __must_check recently, reported by sparse. Patch also fixes missed cleanup of resources allocated prior to register_shrinker() invocation and not freed after any failure. Signed-off-by: Aliaksei Karaliou

[PATCH v3 3/4] drivers: lustre: ldlm: check result of register_shrinker()

ldlm_pools_init() does not check result of register_shrinker() which was tagged __must_check recently, reported by sparse. Signed-off-by: Aliaksei Karaliou --- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[PATCH v3 1/4] drivers: lustre: osc: check result of register_shrinker()

osc_init() does not check result of register_shrinker() which was tagged __must_check recently, reported by sparse. Signed-off-by: Aliaksei Karaliou --- drivers/staging/lustre/lustre/osc/osc_request.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCHv3] staging: pi433: pi433_if.c remove SET_CHECKED macro

The macro calls its argument -a function- twice, makes the calling function return prematurely -skipping resource cleanup code- and hurts understandability. Signed-off-by: Nguyen Phan Quang Minh --- v3: change pi433_receive abort code to always call

[PATCH 6/6] staging: pi433: Remove SET_CHECKED usage from pi433_probe

SET_CHECKED returns from the function on failure and in pi433_probe it is necessary to free the GPIOs and the device on failure. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 28 +--- 1 file changed, 21 insertions(+), 7

[PATCH 0/6] staging: pi433: Minor cleanup and style fixes

These are the six remaining patches from "[PATCH v2 00/11] Fix indentation and CamelCase issues in staging/pi433" that couldn't be applied, rebased on top of staging-next. - Simon --- Simon Sandström (6): staging: pi433: Split rf69_set_crc_enabled into two functions staging: pi433: Split

[PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h

The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 2/6] staging: pi433: Split rf69_set_sync_enabled into two functions

Splits rf69_set_sync_enabled(dev, enabled) into rf69_enable_sync(dev) and rf69_disable_sync(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 21 +++-- drivers/staging/pi433/rf69.c | 18 ++

[PATCH 3/6] staging: pi433: Remove enum data_mode

Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 6

[PATCH 4/6] staging: pi433: Combine all rf69_set_amplifier_x()

Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c | 46

[PATCH 1/6] staging: pi433: Split rf69_set_crc_enabled into two functions

Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

On Wed, Dec 06, 2017 at 04:16:04PM +0100, Greg KH wrote: > > I had to stop here in applying this series, as the merge conflicts just > got too much for me to resolve by hand. > > Can you rebase this series on my staging-testing branch of staging.git > and send the remaining patches please? > >

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: > On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > > > > > > > > Wow... This was the one patch I thought was going to sink this > > > patchset... > > > > I

[PATCH 3/3] staging: lustre: llite: Remove redundant else keyword

There is no need to use 'else' if in main branch 'return' is present. Signed-off-by: Luis de Bethencourt --- drivers/staging/lustre/lustre/llite/vvp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/vvp_io.c

[PATCH 1/3] staging: lustre: llite: Remove else after goto

If an "if" branch is terminated by a "goto", there's no need to have an "else" statement and an indented block of code. Remove the "else" statement to simplify the code flow. Signed-off-by: Luis de Bethencourt --- Hi, The following patches remove unneeded 'else' after a

[PATCH 2/3] staging: lustre: llite: Remove redundant else keyword

There is no need to use 'else' if in main branch 'goto' is present. Signed-off-by: Luis de Bethencourt --- drivers/staging/lustre/lustre/llite/llite_lib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c

Re: [PATCH] android: binder: Check for errors in binder_alloc_shrinker_init().

Hi Tetsuo, It looks like this patch was not submitted to LKML. Perhaps you want to send it to the mailing list and add the correct set of recipients using scripts/get_maintainer.pl as suggested here https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html. -Sherry On Wed, Nov 29,

Re: [PATCH v2 1/2] staging: lustre: check result of register_shrinker

On Wed, Dec 06, 2017 at 08:40:43PM +0300, Aliaksei Karaliou wrote: > On 12/06/2017 11:51 AM, Greg KH wrote: > > > On Mon, Dec 04, 2017 at 10:21:56PM +0300, Aliaksei Karaliou wrote: > > > Lustre code lacks checking the result of register_shrinker() > > > in several places. register_shrinker() was

Re: [PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro

On Mon, Dec 04, 2017 at 02:41:51PM +0300, Dan Carpenter wrote: > drivers/staging/pi433/pi433_if.c >468 /* rx done, wait was interrupted or error occurred */ >469 abort: >470 dev->interrupt_rx_allowed = true; >471 SET_CHECKED(rf69_set_mode(dev->spi,

Re: [PATCH v2 1/2] staging: lustre: check result of register_shrinker

On 12/06/2017 11:51 AM, Greg KH wrote: On Mon, Dec 04, 2017 at 10:21:56PM +0300, Aliaksei Karaliou wrote: Lustre code lacks checking the result of register_shrinker() in several places. register_shrinker() was tagged __must_check recently so that sparse has started reporting it.

[PATCH 19/45] drivers: staging: remove duplicate includes

These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge --- drivers/staging/ccree/ssi_buffer_mgr.c| 1 - drivers/staging/ccree/ssi_driver.c

[PATCH 3/4] staging: unisys: combine visorchannel.h and visorbus.h

Combine the include files visorchannel.h and visorbus.h so that only one include file is needed for the .c files. Reported-by: Christoph Hellwig Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 2/4] staging: unisys: remove !UML flag

Remove the dependency that the drivers are not built during UML. Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1

[PATCH 1/4] staging: unisys: fix dependencies with UNISYSSPAR Kconfig flag

The Kconfig file for UNISYSSPAR uses select ACPI and select PCI instead of depends on ACPI. This patch fixes the problem. Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 0/4] staging: unisys: fix dependency and include issues

This patch series combines the global include files into a single include and cleans up dependencies that were in the wrong location. We had code dependencies on the UNISYSSPAR Kconfig flag instead of the VISORBUS config flag. UNISYSSPAR is just there for organizational purposes. David Kershner

[PATCH 4/4] staging: unisys: move dependencies from UNISYSSPAR to VISORBUS

The Kconfig flag UNISYSSPAR depended on ACPI and X86, these dependencies really belong to visorbus, so move them there. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig | 2 --

[PATCH] Staging: rtl8192u: Fix no spaces around '+'

Added spaces around '+'. Warning found using checkpatch.pl Signed-off-by: Akash Kumar --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.c

Re: [PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro

On Sun, Dec 03, 2017 at 01:09:49AM +0100, Nguyen Phan Quang Minh wrote: > The macro calls its argument -a function- twice, makes the calling > function return prematurely -skipping resource cleanup code- and hurts > understandability. > > Signed-off-by: Nguyen Phan Quang Minh

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

On Tue, Dec 05, 2017 at 11:08:44PM +0100, Simon Sandström wrote: > Splits rf69_set_crc_enabled(dev, enabled) into > rf69_enable_crc(dev) and rf69_disable_crc(dev). > > Signed-off-by: Simon Sandström > --- > drivers/staging/pi433/pi433_if.c | 22 -- >

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

On Wed, Dec 06, 2017 at 12:07:20PM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 11:37 schrieb Dan Carpenter: > > On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote: > > > > > > > > > Am 06.12.2017 um 00:08 schrieb Simon Sandström: > > > > Splits rf69_set_crc_enabled(dev, enabled)

Re: [PATCH v2] Staging: pi433: fix brace coding style issues in pi433_if.c

On Mon, Dec 04, 2017 at 09:40:10PM +0100, Tomas Marek wrote: > This patch fix several brace on next line, braces not necessary, space > around =/<, and space before/after open/close parenthesis coding style > errors find by checkpatch in pi433_if.c. > > In addition, the interrupt routine

Re: [PATCH] staging: pi433: pi433_if.c codestyle space prohibited

On Tue, Nov 28, 2017 at 06:13:16PM +0100, Oliver Graute wrote: > This patch fixes the following checkpatch.pl error: > > ERROR: space prohibited after that open parenthesis '(' > #973: FILE: pi433_if.c:973: > + if ( IS_ERR(device->gpiod[i]) ) > > > ERROR: space prohibited after

Re: [PATCH] staging: pi433: rf69.c: Introduced define DEBUG_FUNC_ENTRY

On Sat, Dec 02, 2017 at 07:00:17PM +0200, Marcus Wolf wrote: > Am 02.12.2017 um 17:00 schrieb Greg KH: > > On Sat, Dec 02, 2017 at 01:45:50PM +0200, Marcus Wolf wrote: > > > Since dev_dbg already depends on define DEBUG, there was no sense, to > > > enclose > > > dev_dbg lines with #ifdef DEBUG.

Re: [PATCH V3] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with smarter functions

On Mon, Dec 04, 2017 at 11:45:16PM +0200, Marcus Wolf wrote: > To increase the readability of the register accesses, the abstraction > of the helpers was increased from simple read and write to set bit, > clear bit and read modify write bit. > > Annotation: This patch contains a lot of long lines

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

Hi Bharat, On 12/06/2017 04:03 PM, Bharat Bhushan wrote: > Hi Laurentiu, > >> -Original Message- >> From: Laurentiu Tudor >> Sent: Wednesday, December 06, 2017 7:00 PM >> To: Nipun Gupta ; stuyo...@gmail.com; Bharat >> Bhushan ;

Re: [PATCH] staging: pi433: Fixes issue with bit shift in rf69_get_modulation

On Wed, Dec 06, 2017 at 12:02:13PM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 11:02 schrieb Greg KH: > > On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote: > > > Fixes issue with bit shift in rf69_get_modulation > > > > What "issue"? > > > > > > > > Signed-off-by: Marcus Wolf

RE: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

Hi Laurentiu, > -Original Message- > From: Laurentiu Tudor > Sent: Wednesday, December 06, 2017 7:00 PM > To: Nipun Gupta ; stuyo...@gmail.com; Bharat > Bhushan ; gre...@linuxfoundation.org; > cakt...@gmail.com; bretth...@gmail.com;

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

Hi Nipun, Can you polish a bit this commit message? It doesn't seem to explain why this is needed. On 12/06/2017 06:18 PM, Nipun Gupta wrote: > When DPRC probing is deferred (such as where IOMMU is not probed > before the fsl-mc bus), all the devices in the DPRC containers gets > initialized

Re: [PATCH v2 08/11] staging: pi433: Remove enum data_mode

On Wed, Dec 06, 2017 at 11:11:27AM +0200, Marcus Wolf wrote: > > Since the rule for kernel development seems to be, not to care about future, > most probably you patch is fine, anyway. > Yeah. Deleting code if there is no user is required to move this code out of staging... I've worked in

Re: [PATCH 2/2] staging: fsl-mc: do not print error in case of defer probe error

On Wed, Dec 06, 2017 at 09:48:07PM +0530, Nipun Gupta wrote: > Signed-off-by: Nipun Gupta > --- I can't take patches without any changelog text :( Please fix and resend the series. greg k-h ___ devel mailing list

Re: [PATCH] staging: rtl8712: Cleanup codestyle

On Wed, Dec 06, 2017 at 05:31:38PM +0700, Neil Singh wrote: > Fix following checkpatch.pl messages: > > WARNING: line over 80 characters > 1000: FILE: rtl871x_security.c:1000: > > ERROR: code indent should use tabs where possible > 1408: FILE: rtl871x_security.c:1408: > > WARNING: please, no

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Sorry, for sending HTML as well - I am writing from my phone... Yes, you will break something, when renaming. Since order isn't changed, most probably old programs will still compile with old enum.h. If we want to move from optionOnOff to bool, we will also break old progs. Since driver is

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: > > > > diff --git a/drivers/staging/pi433/rf69_enum.h > > > > b/drivers/staging/pi433/rf69_enum.h > > > > index

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

>> >> rf69 -set/get - action >> -> rf69_set_crc_enable > > No... Simon's name is better. His is shorter and makes more sense. I disagree. If I am going to implement a new functionality and need to think about the naming of the function name, every time I need to change a register setting

[PATCH] staging: rtl8712: Cleanup codestyle

Fix following checkpatch.pl messages: WARNING: line over 80 characters 1000: FILE: rtl871x_security.c:1000: ERROR: code indent should use tabs where possible 1408: FILE: rtl871x_security.c:1408: WARNING: please, no spaces at the start of a line 1408: FILE: rtl871x_security.c:1408:

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 12:23 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h index babe597e2ec6..5247e9269de9 100644 --- a/drivers/staging/pi433/rf69_enum.h +++

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: > > diff --git a/drivers/staging/pi433/rf69_enum.h > > b/drivers/staging/pi433/rf69_enum.h > > index babe597e2ec6..5247e9269de9 100644 > > --- a/drivers/staging/pi433/rf69_enum.h > > +++ b/drivers/staging/pi433/rf69_enum.h > > @@ -18,9

[PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

When DPRC probing is deferred (such as where IOMMU is not probed before the fsl-mc bus), all the devices in the DPRC containers gets initialized one after another. As IRQ's were allocated only once the DPRC scanning is completed, the devices like DPIO which uses these IRQ's at initalization fails.

[PATCH 2/2] staging: fsl-mc: do not print error in case of defer probe error

Signed-off-by: Nipun Gupta --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c index 409f2b9..10cee00 100644 ---

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Am 06.12.2017 um 11:37 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote: Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström

Re: [PATCH] staging: pi433: Fixes issue with bit shift in rf69_get_modulation

Am 06.12.2017 um 11:02 schrieb Greg KH: On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote: Fixes issue with bit shift in rf69_get_modulation What "issue"? Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström ---

Re: [PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 00:08 schrieb Simon Sandström: > > Splits rf69_set_crc_enabled(dev, enabled) into > > rf69_enable_crc(dev) and rf69_disable_crc(dev). > > > > Signed-off-by: Simon Sandström > > --- > >

[PATCH] staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()

Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by sparse Signed-off-by: Andrii Vladyka Signed-off-by: Andreas Dilger diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c

Re: [PATCH v2 08/11] staging: pi433: Remove enum data_mode

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c

Re: [PATCH] staging: android: ion: Check for register_shrinker() failure.

On Wed, Nov 29, 2017 at 10:33:39PM +0900, Tetsuo Handa wrote: > register_shrinker() might return -ENOMEM error since Linux 3.12. > But since callers of ion_device_add_heap() are not ready to receive an > error and it is not simple enough to fix within this patch, this patch > just prints a warning

Re: [PATCH] staging: android: ashmem: Check for register_shrinker() failure.

On Wed, Nov 29, 2017 at 10:32:00PM +0900, Tetsuo Handa wrote: > register_shrinker() might return -ENOMEM error since Linux 3.12. > > Signed-off-by: Tetsuo Handa > Cc: Robert Love > Cc: Marco Nelissen > Cc: John Stultz

Re: [PATCH] staging: pi433: Fixes issue with bit shift in rf69_get_modulation

On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote: > Fixes issue with bit shift in rf69_get_modulation What "issue"? > > Signed-off-by: Marcus Wolf > --- > drivers/staging/pi433/rf69.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()

On Mon, Dec 04, 2017 at 12:44:32PM +0200, Andrii Vladyka wrote: > Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by > sparse > > Signed-off-by: Andrii Vladyka > Signed-off-by: Andreas Dilger > --- > > diff --git

Re: [PATCH v2 1/2] staging: lustre: check result of register_shrinker

On Mon, Dec 04, 2017 at 10:21:56PM +0300, Aliaksei Karaliou wrote: > Lustre code lacks checking the result of register_shrinker() > in several places. register_shrinker() was tagged __must_check > recently so that sparse has started reporting it. > > Signed-off-by: Aliaksei Karaliou