Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-10 Thread Dmitry Osipenko
On 10.12.2017 22:29, Nicolas Dufresne wrote: > Le dimanche 10 décembre 2017 à 21:56 +0300, Dmitry Osipenko a écrit : >>> I've CC-ed Maxime and Giulio as well: they are looking into adding support >>> for >>> the stateless allwinner codec based on this code as well. There may well be >>> opportunit

[PATCH][staging-next] staging: most: core: make functions print_links and most_match static

2017-12-10 Thread Colin King
From: Colin Ian King The functions print_links and most_match static are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'print_links' was not declared. Should it be static? symbol 'most_match' was not declared. Should it be stati

[PATCH] Staging: rtl8723bs: Merge assignment with return

2017-12-10 Thread Shreeya Patel
Merge the assignment and return statements to return the value directly. Done using the following semantic patch by coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Also, remove the variable declaration and some braces that became useless after the merg

[PATCH 1/1] staging: rtl8723bs: make memcmp() calls consistent

2017-12-10 Thread Nicolas Iooss
rtw_pm_set() uses memcmp() with 5-chars strings and a length of 4 when parsing extra, and then parses extra+4 as an int: if (!memcmp(extra, "lps =", 4)) { sscanf(extra+4, "%u", &mode); /* ... */ } else if (!memcmp(extra, "ips =", 4)) { sscanf(extra+4, "%u", &mode); The

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-10 Thread Nicolas Dufresne
Le dimanche 10 décembre 2017 à 21:56 +0300, Dmitry Osipenko a écrit : > > I've CC-ed Maxime and Giulio as well: they are looking into adding support > > for > > the stateless allwinner codec based on this code as well. There may well be > > opportunities for you to work together, esp. on the users

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-10 Thread Dmitry Osipenko
On 05.12.2017 16:03, Hans Verkuil wrote: > On 12/05/17 13:17, Dmitry Osipenko wrote: >> Hi Hans, >> >> On 04.12.2017 17:04, Hans Verkuil wrote: >>> Hi Dmitry, >>> >>> As you already mention in the TODO, this should become a v4l2 codec driver. >>> >>> Good existing examples are the coda, qcom/venus

[PATCH 08/16] staging: pi433: remove spaces before tabs

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for hidden spaces before tabs. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 4 ++-- drivers/staging/pi433/rf69.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi

[PATCH 12/16] staging: pi433: rewrite comparison with NULL

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for comparing value with NULL. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 6e6996c68f0f..f32aeb215727

[PATCH 11/16] staging: pi433: remove multiple blank lines

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for multiple blank lines in source. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 11 --- drivers/staging/pi433/pi433_if.h | 8 drivers/staging/pi433/rf69.c | 2 -- drivers/staging/pi433/rf69.h |

[PATCH 02/16] staging: pi433: add space after comma

2017-12-10 Thread Valentin Vidic
Fixes checkpatch error for missing spaces. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 9c1787ef14e3..155d486f6cb3 100644 --- a/

[PATCH 01/16] staging: pi433: add space before open parenthesis

2017-12-10 Thread Valentin Vidic
Fixes checkpatch error for missing spaces. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 32db3b320cbd..9c1787ef14e3 100644 --- a/

[PATCH 06/16] staging: pi433: use tabs for code indent

2017-12-10 Thread Valentin Vidic
Fixes checkpatch error for whitespace idents. Signed-off-by: Valentin Vidic --- .../Documentation/devicetree/pi433-overlay.dts | 32 +++--- drivers/staging/pi433/pi433_if.c | 8 +++--- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers

[PATCH 16/16] staging: pi433: remove comparison with true

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for error prone comparison. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 1211216bdc2f..b4e6094ad553 100644

[PATCH 07/16] staging: pi433: move trailing statements to next line

2017-12-10 Thread Valentin Vidic
Fixes checkpatch error for trailing if statements. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 45 +++- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c

[PATCH 15/16] staging: pi433: remove comparison with false

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for error prone comparison. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 68498c457c49..1211216bdc2f 100644

[PATCH 10/16] staging: pi433: remove return from a void function

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for void function return statements. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 1e50d8f431f0..00cd8193cfd4 100644 --- a/dr

[PATCH 13/16] staging: pi433: fix spelling errors in documentation

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for 'transfered' and 'devided'. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/Documentation/pi433.txt b/drivers/staging/pi433/Documentation/pi

[PATCH 04/16] staging: pi433: remove space inside parenthesis

2017-12-10 Thread Valentin Vidic
Fixes checkpatch error for prohibited spaces. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 34 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 4 ++-- 3 files changed, 21 insertions(+), 21 deletions(-) di

[PATCH 14/16] staging: pi433: add blank line after function

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for blank line after function/struct/union/enum declarations. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index f32aeb215727..68

[PATCH 03/16] staging: pi433: add space around operators

2017-12-10 Thread Valentin Vidic
Fixes checkpatch error for missing spaces. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 155d486f6cb3..ab848c1d55a6 100644 -

[PATCH 09/16] staging: pi433: remove spaces before newline

2017-12-10 Thread Valentin Vidic
Fixes checkpatch warning for whitespace before a quoted newline. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 8dae788972cc..75a0f62d5636 100

[PATCH 05/16] staging: pi433: use consistent brace style

2017-12-10 Thread Valentin Vidic
Fixes checkpatch error for open/close braces. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 129 +-- 1 file changed, 41 insertions(+), 88 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c inde