Re: [PATCH] staging: ccree: shorten lengthy lines with breaks

2018-01-06 Thread Joe Perches
On Sat, 2018-01-06 at 15:47 +, George Edward Bulmer wrote: > This fixes five instances of checkpatch warning: > WARNING: line over 80 characters [] > diff --git a/drivers/staging/ccree/ssi_sysfs.c > b/drivers/staging/ccree/ssi_sysfs.c [] > @@ -32,15 +32,26 @@ static ssize_t

[PATCH] staging: ccree: shorten lengthy lines with breaks

2018-01-06 Thread George Edward Bulmer
This fixes five instances of checkpatch warning: WARNING: line over 80 characters Signed-off-by: George Edward Bulmer --- drivers/staging/ccree/ssi_sysfs.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v2] Staging: iio: cdc: Prefer using BIT macro

2018-01-06 Thread Jonathan Cameron
On Sat, 6 Jan 2018 20:35:24 +0530 Sumit Pundir wrote: > This patch fixes the following checkpatch.pl issue at multiple lines: > > CHECK: Prefer using the BIT macro > > Signed-off-by: Sumit Pundir > --- > v2: > Added the specific driver being

[PATCH v2] Staging: iio: cdc: Prefer using BIT macro

2018-01-06 Thread Sumit Pundir
This patch fixes the following checkpatch.pl issue at multiple lines: CHECK: Prefer using the BIT macro Signed-off-by: Sumit Pundir --- v2: Added the specific driver being changed to the patch title and the appropriate fixes as suggested.

Re: [PATCH] Staging: iio: Prefer using BIT macro

2018-01-06 Thread Sumit Pundir
On Sat, Jan 6, 2018 at 6:12 PM, Jonathan Cameron wrote: > On Thu, 4 Jan 2018 22:06:31 +0530 > Sumit Pundir wrote: > > Patch title needs to mention the specific driver being changed. > >> This patch fixes the following checkpatch.pl error at multiple

Re: [PATCH] Staging: iio: Prefer using BIT macro

2018-01-06 Thread Jonathan Cameron
On Thu, 4 Jan 2018 22:06:31 +0530 Sumit Pundir wrote: Patch title needs to mention the specific driver being changed. > This patch fixes the following checkpatch.pl error at multiple lines: > > CHECK: Prefer using the BIT macro > > Signed-off-by: Sumit Pundir

Re: [PATCH] staging: iio: trigger: replace device_attr with device_attr_rw

2018-01-06 Thread Jonathan Cameron
On Thu, 4 Jan 2018 16:28:51 +0530 Aishwarya Pant wrote: > This is a clean-up patch which replaces DEVICE_ATTR() macro with the > file permission specific DEVICE_ATTR_RW() macro for compaction and > readability. Done using coccinelle. > > Signed-off-by: Aishwarya Pant