[PATCH] Staging: ks7010: Fix Unnecessary parentheses in ks_hostif.c

This patch fixes up unnecessary parenthesis issue found by checkpatch.pl Signed-off-by: Yash Omer --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c

[PATCH 4/4] Staging: ks7010: hostif: Fix multiple use of arguments in ps_confirm_wait_inc() macro.

Use GCC extensions to prevent macro arguments from accidentally being evaluated multiple times when the macro is called. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH 2/4] Staging: ks7010: hostif: Fix multiple use of arguments in SME queue macros.

Use GCC extensions to prevent macro arguments from accidentally being evaluated multiple times when the macro is called. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff

[PATCH 3/4] Staging: ks7010: hostif: Fix multiple use of arguments in rate and event masking macros.

Use GCC extensions to prevent macro arguments from accidentally being evaluated multiple times when the macro is called. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 74 +- 1 file changed, 50 insertions(+), 24

[PATCH 1/4] Staging: ks7010: sdio: Fix multiple use of arguments in RX/TX queue macros.

Use GCC extensions to prevent macro arguments from accidentally being evaluated multiple times when the macro is called. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010_sdio.c | 40 1 file changed, 27 insertions(+), 13

Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation

On 02/16/2018 04:17 AM, Alexey Skidanov wrote: On 02/16/2018 01:48 AM, Laura Abbott wrote: On 02/12/2018 02:33 PM, Alexey Skidanov wrote: Current ion kernel mapping implementation uses vmap() to map previously allocated buffers into kernel virtual address space. On 32-bit platforms, vmap()

[PATCH v2 char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer signaling

Fix bugs in signaling the Hyper-V host when freeing space in the host->guest ring buffer: 1. The interrupt_mask must not be used to determine whether to signal on the host->guest ring buffer 2. The ring buffer write_index must be read (via hv_get_bytes_to_write) *after* pending_send_sz is

[PATCH] Staging: gdm724x: tty: Fix macro argument reuse that could cause side-effects.

Fix a coding style warning from checkpatch.pl. Use GNU extensions to create references to the results of problem macro arguments when they are evaluated so that they can be used safely multiple times. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_tty.c |

[PATCH 2/2] Staging: gdm724x: LTE: Fix argument list not aligned with parenthesis.

Fix coding style warning from checkpatch.pl. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index

[PATCH] Staging: gdm724x: LTE: Fix trailing open parenthesis code style issue.

Fix a coding style problem causing warnings from checkpatch.pl. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 50 ++- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git

Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation

On Fri, Feb 16, 2018 at 11:13:03PM +0200, Alexey Skidanov wrote: > > > On 02/16/2018 10:49 PM, Greg KH wrote: > > On Fri, Feb 16, 2018 at 10:43:03PM +0200, Alexey Skidanov wrote: > >> > >> > >> On 02/16/2018 04:46 PM, Greg KH wrote: > >>> On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov

Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation

On 02/16/2018 10:49 PM, Greg KH wrote: > On Fri, Feb 16, 2018 at 10:43:03PM +0200, Alexey Skidanov wrote: >> >> >> On 02/16/2018 04:46 PM, Greg KH wrote: >>> On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov wrote: Current ion kernel mapping implementation uses vmap() to map

Re: [RFC patch] checkpatch: test identifier lengths

On Fri, 2018-02-16 at 12:31 -0800, Andrew Morton wrote: > On Fri, 16 Feb 2018 09:13:27 -0800 Joe Perches wrote: > > > On Fri, 2018-02-16 at 15:55 +0300, Dan Carpenter wrote: > > > On Fri, Feb 16, 2018 at 05:06:34PM +0530, Yash Omer wrote: > > > > This patch fix line should not

Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation

On Fri, Feb 16, 2018 at 10:43:03PM +0200, Alexey Skidanov wrote: > > > On 02/16/2018 04:46 PM, Greg KH wrote: > > On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov wrote: > >> Current ion kernel mapping implementation uses vmap() to map previously > >> allocated buffers into kernel

Re: [RFC patch] checkpatch: test identifier lengths

On Fri, Feb 16, 2018 at 12:31:39PM -0800, Andrew Morton wrote: > On Fri, 16 Feb 2018 09:13:27 -0800 Joe Perches wrote: > > > On Fri, 2018-02-16 at 15:55 +0300, Dan Carpenter wrote: > > > On Fri, Feb 16, 2018 at 05:06:34PM +0530, Yash Omer wrote: > > > > This patch fix line

Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation

On 02/16/2018 04:46 PM, Greg KH wrote: > On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov wrote: >> Current ion kernel mapping implementation uses vmap() to map previously >> allocated buffers into kernel virtual address space. >> >> On 32-bit platforms, vmap() might fail on large

Re: [RFC patch] checkpatch: test identifier lengths

On Fri, 16 Feb 2018 09:13:27 -0800 Joe Perches wrote: > On Fri, 2018-02-16 at 15:55 +0300, Dan Carpenter wrote: > > On Fri, Feb 16, 2018 at 05:06:34PM +0530, Yash Omer wrote: > > > This patch fix line should not end with open parenthesis found by > > > checkpatch.plscript. > >

[PATCH v2] staging: android: ion: Initialize dma_address of new sg list

Fix the dup_sg_table function to initialize the dma_address of the new sg list entries instead of the source dma_address entries. Since ION duplicates the sg_list this issue does not appear to result in an actual bug. Signed-off-by: Liam Mark Acked-by: Laura Abbott

Re: [PATCH] staging: android: ion: Initialize dma_address of new sg list

On Fri, Feb 16, 2018 at 09:57:12AM -0800, Liam Mark wrote: > On Fri, 16 Feb 2018, Greg KH wrote: > > > On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: > > > Fix the dup_sg_table function to initialize the dma_address of the new > > > sg list entries instead of the source dma_address

[PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c

This patch fixes up line should not end with open parenthesis found by checkpatch.pl script. Signed-off-by: Yash Omer --- drivers/staging/xgifb/vb_setmode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c

Re: [PATCH 5/6] staging: wilc1000: fix line over 80 characters in wilc_spi_read_int()

On 14.02.2018 13:10, Ajay Singh wrote: > Refactor wilc_spi_read_int() to fix the line over 80 char issues reported > by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_spi.c | 57 > +++-- > 1

Re: [PATCH 6/6] staging: wilc1000: fix line over 80 chars in wilc_spi_clear_int_ext()

On 14.02.2018 13:10, Ajay Singh wrote: > Refactor wilc_spi_clear_int_ext() to fix the "line over 80 char" issue > reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_spi.c | 113 >

Re: [PATCH 3/6] staging: wilc1000: fix line over 80 characters in spi_cmd_complete()

On 14.02.2018 13:10, Ajay Singh wrote: > Refactor spi_cmd_complete() to fix the line over 80 char issues reported > by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_spi.c | 250 > ++-- > 1

Re: [PATCH 1/6] staging: wilc1000: modified code comments as per linux coding style

Hi Ajay, Even I cannot locate something in Documentation/CodingStyle related to single line comment, I prefer to use: /* comment */ instead of: /* * comment */ Do as you wish! Thank you, Claudiu On 14.02.2018 13:10, Ajay Singh wrote: > diff --git a/drivers/staging/wilc1000/wilc_spi.c >

Re: [PATCH] staging: android: ion: Initialize dma_address of new sg list

On Fri, 16 Feb 2018, Greg KH wrote: > On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: > > Fix the dup_sg_table function to initialize the dma_address of the new > > sg list entries instead of the source dma_address entries. > > > > Fixes: 17fd283f3870 ("staging: android: ion:

Re: [PATCH] staging: android: ion: Initialize dma_address of new sg list

On Thu, 15 Feb 2018, Laura Abbott wrote: > On 02/12/2018 01:25 PM, Liam Mark wrote: > > > > On Mon, 12 Feb 2018, Dan Carpenter wrote: > > > > > On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: > > > > Fix the dup_sg_table function to initialize the dma_address of the new > > > > sg

[RFC patch] checkpatch: test identifier lengths

On Fri, 2018-02-16 at 15:55 +0300, Dan Carpenter wrote: > On Fri, Feb 16, 2018 at 05:06:34PM +0530, Yash Omer wrote: > > This patch fix line should not end with open parenthesis found by > > checkpatch.plscript. > > > > Signed-off-by: Yash Omer > > --- > >

Re: [PATCH] Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c

On Fri, 2018-02-16 at 15:36 +0100, Greg KH wrote: > On Fri, Feb 16, 2018 at 12:18:36AM +0530, Yash Omer wrote: > > This is patch fixes up a matching paranthesis alignment issue found by > > checkpatch.pl script. [] > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c > >

Re: [PATCH 00/12] fix to remove line over 80 chars and few other

On Fri, Feb 16, 2018 at 08:41:37PM +0530, Ajay Singh wrote: > This patch series contains changes to fix line over 80 characters, > too many leading tabs and few other issues reported by checkpatch.pl > script. Please put the proper prefix on your 00/XX patches, that are with your other patches.

Re: [PATCH v2 4/9] staging: android: ion: Avoid NULL point in error path

On Mon, Feb 12, 2018 at 06:43:09PM +0800, Yisheng Xie wrote: > If we failed to create debugfs for ion at ion_device_create, the > debug_root of ion_device will be NULL, and then when try to create debug > file for shrinker of heap it will be create on the top of debugfs. If we > also failed to

Re: [PATCH] staging: android: ion: Initialize dma_address of new sg list

On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: > Fix the dup_sg_table function to initialize the dma_address of the new > sg list entries instead of the source dma_address entries. > > Fixes: 17fd283f3870 ("staging: android: ion: Duplicate sg_table") So this should be sent to the

[PATCH 01/12] staging: wilc1000: remove unnecessary comments to avoid line over 80 char issue

Fix "line over 80 characters" issue reported by checkpatch.pl script by removing unnecessary comments. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 06/12] staging: wilc1000: remove blank line before close brace in wilc_wlan_cfg_get_wid_value()

Cleanup patch to remove "Blank lines aren't necessary before a close brace '}'" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 11/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack()

Fix "line over 80 characters" issue reported by checkpatch.pl. Use temporary variable to avoid checkpatch.pl issue. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH 10/12] staging: wilc1000: fix line over 80 characters in tcp_process()

Fix "line over 80 characters" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH 12/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_handle_txq()

Fix "line over 80 characters" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 38 +++- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git

[PATCH 04/12] staging: wilc1000: fix open parenthesis alignment mismatch in wilc_parse_network_info()

Fix "Alignment should match open parenthesis" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 07/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_cfg_indicate_rxi()

Cleanup patch to fix "line over 80 characters" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 09/12] staging: wilc1000: fix line over 80 chars in add_tcp_pending_ack()

Fix "line over 80 characters" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH 08/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_cfg_get_wid_value()

Fix "line over 80 character" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.c

[PATCH 05/12] staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set_str()

Fix "line over 80 characters" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.c

[PATCH 02/12] staging: wilc1000: fix too many leading tabs warning in sdio_clear_int_ext()

Refactor sdio_clear_int_ext() function to remove "Too many leading tabs" warning reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 134 +-- 1 file changed, 65 insertions(+), 69

[PATCH 00/12] fix to remove line over 80 chars and few other

This patch series contains changes to fix line over 80 characters, too many leading tabs and few other issues reported by checkpatch.pl script. Ajay Singh (12): staging: wilc1000: remove unnecessary comments to avoid line over 80 char issue staging: wilc1000: fix too many leading tabs

[PATCH 03/12] staging: wilc1000: fix line over 80 characters in sdio_clear_int_ext()

Fix "line over 80 characters" issue found by checkpatch.pl script by modifying the comment description. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/2] staging: rtl8712: make unsigned length for rtl8717_get{_wpa_,_wpa2_,_}ie

On Thu, Feb 01, 2018 at 08:14:52PM +0100, Stefano Manni wrote: > Fixed r8712_get_ie, r8712_get_wpa_ie, r8712_get_wpa2_ie > to have a length as unsigned int pointer instead of signed. Can you rebase both of these patches on the staging-testing branch of the staging.git tree so that I can apply

Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation

On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov wrote: > Current ion kernel mapping implementation uses vmap() to map previously > allocated buffers into kernel virtual address space. > > On 32-bit platforms, vmap() might fail on large enough buffers due to the > limited available

Re: [PATCH] Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c

On Fri, Feb 16, 2018 at 12:18:36AM +0530, Yash Omer wrote: > This is patch fixes up a matching paranthesis alignment issue found by > checkpatch.pl script. > > Signed-off-by: Yash Omer > --- > drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 2/2] Staging: netlogic: platform_net.c: introduced a helper function

On Wed, Jan 17, 2018 at 02:10:47PM +0530, Naveen Panwar wrote: > In staging/netlogic/platform.c Refactoring the identical code used > in several places for calculating the physical address of > memory-mapped objects on the device.Put that into an inline helper > function and use it. > > Adjust

Re: [PATCH 4/6] staging: wilc1000: fix line over 80 characters in wilc_spi_init()

On Wed, Feb 14, 2018 at 04:40:13PM +0530, Ajay Singh wrote: > Modified wilc_spi_init() to fix the line over 80 char issues reported > by checkpatch.pl script. > To overcome the checkpatch.pl reported issue modified debug logs and > comments used in wilc_spi_init(). > > Signed-off-by: Ajay Singh

Re: [PATCH] staging: iio/meter: add name to function definition arguments

Hi Rodrigo, I think this is a nice finding. One comment inline: On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > This patch fixes the checkpatch.pl warning: > > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition > argument 'struct device *' should also have an

Re: [PATCH] staging: iio/meter: add name to function definition arguments

Hi Daniel > Hi Rodrigo, > > I think this is a nice finding. One comment inline: > > On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > > This patch fixes the checkpatch.pl warning: > > > > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition > > argument 'struct device

Re: [PATCH] Staging: nvec: fix line should not end with a open parenthesis.

On Fri, Feb 16, 2018 at 05:06:34PM +0530, Yash Omer wrote: > This patch fix line should not end with open parenthesis found by > checkpatch.plscript. > > Signed-off-by: Yash Omer > --- > drivers/staging/nvec/nvec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH] staging: iio/meter: add name to function definition arguments

This patch fixes the checkpatch.pl warning: drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition argument 'struct device *' should also have an identifier name... Signed-off-by: Rodrigo Siqueira --- drivers/staging/iio/meter/ade7854.h | 28

Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation

On 02/16/2018 01:48 AM, Laura Abbott wrote: > On 02/12/2018 02:33 PM, Alexey Skidanov wrote: >> Current ion kernel mapping implementation uses vmap() to map previously >> allocated buffers into kernel virtual address space. >> >> On 32-bit platforms, vmap() might fail on large enough buffers due

RE: [PATCH] Staging: nvec: fix line should not end with a open parenthesis.

From: Yash Omer > Sent: 16 February 2018 11:37 > This patch fix line should not end with open parenthesis found by > checkpatch.plscript. > > Signed-off-by: Yash Omer > --- > drivers/staging/nvec/nvec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[PATCH] Staging: nvec: fix line should not end with a open parenthesis.

This patch fix line should not end with open parenthesis found by checkpatch.plscript. Signed-off-by: Yash Omer --- drivers/staging/nvec/nvec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c

Re: [PATCH] comedi: fix comedi_nsamples_left.

On 15/02/18 20:13, Frank Mori Hess wrote: A rounding error was causing comedi_nsamples_left to return the wrong value when nsamples was not a multiple of the scan length. Cc: # v4.4+ Signed-off-by: Frank Mori Hess ---

Re: [PATCH] ANDROID: binder: synchronize_rcu() when using POLLFREE.

Greg, This is for 4.14 LTS and 4.16. Thanks, Martijn On Fri, Feb 16, 2018 at 9:47 AM, Martijn Coenen wrote: > To prevent races with ep_remove_waitqueue() removing the > waitqueue at the same time. > > Reported-by: syzbot+a2a3c4909716e2714...@syzkaller.appspotmail.com >

[PATCH] ANDROID: binder: synchronize_rcu() when using POLLFREE.

To prevent races with ep_remove_waitqueue() removing the waitqueue at the same time. Reported-by: syzbot+a2a3c4909716e2714...@syzkaller.appspotmail.com Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 9 + 1 file changed, 9 insertions(+) diff --git