[PATCH] staging: media: davinci_vpfe: add error handling on kmalloc failure

There is no failure checking on the param value which will be allocated memory by kmalloc. Add a null pointer checking statement. Then goto error: and return -ENOMEM error code when kmalloc is failed. Signed-off-by: Ji-Hun Kim ---

Re: [PATCH] storvsc: Set up correct queue depth values for IDE devices

On Thu, 15 Mar 2018 16:52:23 -0700 Long Li wrote: > From: Long Li > > Unlike SCSI and FC, we don't use multiple channels for IDE. So set queue depth > correctly for IDE. > > Also set the correct cmd_per_lun for all devices. > >

Re: [PATCH 7/7] staging:iio:ade7854: Add proper error handling condition

On 03/15, Dan Carpenter wrote: > On Wed, Mar 14, 2018 at 03:12:18PM -0300, Rodrigo Siqueira wrote: > > There is some improper error handling for IRQ and device register. This > > patch adds a proper verification. The IRQ correction was extracted from > > John Syne patches. > > > > Signed-off-by:

Re: [PATCH 1/7] staging:iio:ade7854: Rework I2C write function

Hi, I will fixes all of these things here and in the other patches and send a v2. Thanks for the review. On 03/15, Dan Carpenter wrote: > On Wed, Mar 14, 2018 at 03:10:18PM -0300, Rodrigo Siqueira wrote: > > The write operation using I2C has many code duplications and four > > different

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

On Thu, Mar 15, 2018 at 01:56:42PM +0300, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: > > On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > > > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > > > with DPAA2

[PATCH] storvsc: Set up correct queue depth values for IDE devices

From: Long Li Unlike SCSI and FC, we don't use multiple channels for IDE. So set queue depth correctly for IDE. Also set the correct cmd_per_lun for all devices. Signed-off-by: Long Li --- drivers/scsi/storvsc_drv.c | 8 ++-- 1 file changed, 6

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15 2018, John Crispin wrote: > On 15/03/18 21:12, NeilBrown wrote: >> On Thu, Mar 15 2018, John Crispin wrote: >> >>> On 15/03/18 11:48, Dan Carpenter wrote: This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it

[PATCH] staging: lustre: o2iblnd: Enable Multiple OPA Endpoints between Nodes

OPA driver optimizations are based on the MPI model where it is expected to have multiple endpoints between two given nodes. To enable this optimization for Lustre, we need to make it possible, via an LND-specific tuneable, to create multiple endpoints and to balance the traffic over them. Both

Re: [PATCH v2] Staging: iio: adis16209: Move adis16209 driver out of staging

On 16 March 2018 00:31:53 GMT+05:30, Shreeya Patel wrote: >On Sat, 2018-03-10 at 15:57 +, Jonathan Cameron wrote: > >Hi Jonathan, > >> On Sat, 10 Mar 2018 15:50:23 +0530 >> Shreeya Patel wrote: >> >> > >> > Move the adis16209

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On 15/03/18 21:12, NeilBrown wrote: On Thu, Mar 15 2018, John Crispin wrote: On 15/03/18 11:48, Dan Carpenter wrote: This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doesn't break the build. But some of the patches don't

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15 2018, John Crispin wrote: > On 15/03/18 11:48, Dan Carpenter wrote: >> This all seems fine. Generally the requirements for staging are that it >> has a TODO, someone to work on it, and it doesn't break the build. But >> some of the patches don't have commit message and those are

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15 2018, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote: >> On Thu, Mar 15 2018, Dan Carpenter wrote: >> >> > This all seems fine. Generally the requirements for staging are that it >> > has a TODO, someone to work on it, and it doesn't break the

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Resending the email because it was sent only to Greg. Context: In my previous patch, I had removed an extra newline at the end of the code. My Reply: It was unintentional, but does it violate any coding or other standard? ___ devel mailing list

[PATCH v2] drivers:staging:android:ashmem: Changing return type from int to loff_t

Changing return type from int to loff_t. Actual return type of the function (vfs_llseek) is loff_t (long long). Here due to implicit converion from long long to int, result will be implementation defined. Signed-off-by: Rohit Kumar --- drivers/staging/android/ashmem.c |

[no subject]

de...@driverdev.osuosl.org Bcc: Subject: [PATCH v2] drivers:staging:android:ashmem: Changing return type from int to loff_t Reply-To: Changing return type from int to loff_t. Actual return type of the function (vfs_llseek) is loff_t (long long). Here due to implicit converion from long long to

[PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry

- enables gstreamer v4l2src lost frame detection, e.g: 0:00:08.685185668 348 0x54f520 WARN v4l2src gstv4l2src.c:970:gst_v4l2src_create: lost frames detected: count = 141 - ts: 0:00:08.330177332 - fixes v4l2-compliance test failure: Streaming ioctls: test read/write: OK (Not

[PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry

- fixes gstreamer v4l2src warning: 0:00:00.716640334 349 0x164f720 WARN v4l2bufferpool gstv4l2bufferpool.c:1195:gst_v4l2_buffer_pool_dqbuf: Driver should never set v4l2_buffer.field to ANY - fixes v4l2-compliance test failure: Streaming ioctls: test read/write: OK (Not

[PATCH v2 4/4] staging: ks7010: remove unnecessary brackets in single statement block

This patch fix the following checkpatch warning: braces {} are not necessary for single statement blocks Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v2 0/4] staging: ks7010: some cleanups and replaces

The following patch series includes some cleanups of useless traces as well as some replaces in order to use preferred macros for debugging and others. v2: * Review deleted DPRINTK traces * Minor checkpatch warning cleanup Sergio Paracuellos (4): staging: ks7010: remove useless DPRINTK traces

[PATCH v2 1/4] staging: ks7010: remove useless DPRINTK traces

This commit removes some useless traces in some source files Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 58 -- drivers/staging/ks7010/ks_hostif.c | 147 +++

[PATCH v2 2/4] staging: ks7010: replace DPRINTK traces in favour of netdev_*

This commit removes custom defined DPRINTK macro and replaces all the associated debug and other traces for preferred ones netdev_*. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 84 ++---

[PATCH v2 3/4] staging: ks7010: replace KS_WLAN_DEBUG with DEBUG preprocessor directive

This commit replaces custom KS_WLAN_DEBUG which is not being used anymore in favour of DEBUG which is the one included when debugging is enabled. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 9 - 1 file changed, 4

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain --- drivers/staging/comedi/drivers/ni_atmio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c index

RE: [PATCH v4 1/2] PCI: hv: Serialize the present and eject work items

> From: Dexuan Cui > > From: Lorenzo Pieralisi > > I need to know either what commit you are fixing (ie Fixes: tag - which > > is preferrable) or you tell me which kernel versions we are targeting > > for the stable backport. > > Lorenzo > > Sorry. Here I was hesitant

Re: [PATCH v3]PCI: hv: fix PCI-BUS domainID corruption

Apologies for not aligning my reply, I just realized after looking into the mail archive in LKML. I have aligned the replay now. On 3/15/18, 10:56 AM, "Sridhar Pitchai" wrote: Hi Lorenzo, Answering the question inline. Kindly let me know if it clarifies. I will

[PATCH] staging: android: ion: Update wording in drivers/staging/android/ion/Kconfig

Changes the usage of the word 'Chose' to 'Choose' in the ION Memory Manager Kconfig. Signed-off-by: Phillip Potter --- --- a/drivers/staging/android/ion/Kconfig +++ b/drivers/staging/android/ion/Kconfig @@ -4,7 +4,7 @@ menuconfig ION select GENERIC_ALLOCATOR

RE: [PATCH v3]PCI: hv: fix PCI-BUS domainID corruption

Hi Lorenzo, Answering the question inline. Kindly let me know if it clarifies. I will send out another patch after we agree on the clarification. Thanks Sridhar Pitchai -Original Message- From: Lorenzo Pieralisi Sent: Thursday, March 15, 2018 5:05 AM To:

RE: [PATCH v4 1/2] PCI: hv: Serialize the present and eject work items

> From: Lorenzo Pieralisi > Sent: Thursday, March 15, 2018 10:02 > On Thu, Mar 15, 2018 at 02:20:53PM +, Dexuan Cui wrote: > > When we hot-remove the device, we first receive a PCI_EJECT message and > > then receive a PCI_BUS_RELATIONS message with

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

On Thu, 15 Mar 2018 17:24:13 +0100 Mohammed Gamal wrote: > On Wed, 2018-03-14 at 10:22 +0100, Mohammed Gamal wrote: > > On Tue, 2018-03-13 at 12:35 -0700, Stephen Hemminger wrote: > > > On Tue, 13 Mar 2018 20:06:50 +0100 > > > Mohammed Gamal wrote: > > >

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

On Thu, Mar 15, 2018 at 11:00:40PM +0530, Pratik Jain wrote: > Fixed coding style issue. > > Signed-off-by: Pratik Jain > --- > drivers/staging/comedi/drivers/ni_atmio.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain --- drivers/staging/comedi/drivers/ni_atmio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c index

[PATCH] staging:mt29f_spinand: MT29F2G failing as only 16 bits used for addressing.

From: Palle Christensen For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits are necessary to address the correct page. Signed-off-by: Palle Christensen --- drivers/staging/mt29f_spinand/mt29f_spinand.c |

Re: [PATCH v4 1/2] PCI: hv: Serialize the present and eject work items

On Thu, Mar 15, 2018 at 02:20:53PM +, Dexuan Cui wrote: > When we hot-remove the device, we first receive a PCI_EJECT message and > then receive a PCI_BUS_RELATIONS message with bus_rel->device_count == 0. > > The first message is offloaded to hv_eject_device_work(), and the second > is

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

On Wed, 2018-03-14 at 10:22 +0100, Mohammed Gamal wrote: > On Tue, 2018-03-13 at 12:35 -0700, Stephen Hemminger wrote: > > On Tue, 13 Mar 2018 20:06:50 +0100 > > Mohammed Gamal wrote: > > > > > Dring high network traffic changes to network interface > > > parameters > > > such

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: > On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > > switch

[PATCH v4 4/4] PCI: hv: Only queue a new work in hv_pci_devices_present() if necessary

If there is a pending work, we just need to add the new dr into the dr_list. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley Acked-by: Haiyang Zhang Cc: Vitaly Kuznetsov Cc: Jack Morgenstein

[PATCH v4 3/4] PCI: hv: Remove hbus->enum_sem

Since we serialize the present/eject work items now, we don't need the semaphore any more. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley Acked-by: Haiyang Zhang Cc: Vitaly Kuznetsov Cc: Jack

[PATCH v4 2/4] PCI: hv: Remove the bogus test in hv_eject_device_work()

When we're in the function, hpdev->state must be hv_pcichild_ejecting: see hv_pci_eject_device(). Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley Acked-by: Haiyang Zhang Cc: Vitaly Kuznetsov Cc:

[PATCH v4 1/4] PCI: hv: Fix a comment typo in _hv_pcifront_read_config()

No functional change. Fixes: bdd74440d9e8 ("PCI: hv: Add explicit barriers to config space access") Signed-off-by: Dexuan Cui Acked-by: Haiyang Zhang Cc: Vitaly Kuznetsov Cc: Stephen Hemminger Cc: K. Y.

[PATCH v4 0/4] PCI: hv: Add 4 cosmetic patches

The 4 patches should go in v4.16. There is no code change since v3: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1628496.html I just split the original 6 patches to 2 series, and this is series 2. I fixed the order of Signed-off-by/Tested-by/Cc, etc., and fixed the other format

[PATCH v4 2/2] PCI: hv: Fix 2 hang issues in hv_compose_msi_msg()

1. With the patch "x86/vector/msi: Switch to global reservation mode", the recent v4.15 and newer kernels always hang for 1-vCPU Hyper-V VM with SR-IOV. This is because when we reach hv_compose_msi_msg() by request_irq() -> request_threaded_irq() ->__setup_irq()->irq_startup() -> __irq_startup()

[PATCH v4 1/2] PCI: hv: Serialize the present and eject work items

When we hot-remove the device, we first receive a PCI_EJECT message and then receive a PCI_BUS_RELATIONS message with bus_rel->device_count == 0. The first message is offloaded to hv_eject_device_work(), and the second is offloaded to pci_devices_present_work(). Both the paths can be running

[PATCH v4 0/2] PCI: hv: Fix some real issues

The 2 patches should go in v4.16. They should go in old stable kernels too, especially this one should go in v4.15: PCI: hv: Fix 2 hang issues in hv_compose_msi_msg() Otherwise, a UP v4.15 VM can 100% hang when we pass through a VF to the VM that runs on Hyper-V. There is no code change since

Re: [PATCH 7/7] staging:iio:ade7854: Add proper error handling condition

On Wed, Mar 14, 2018 at 03:12:18PM -0300, Rodrigo Siqueira wrote: > There is some improper error handling for IRQ and device register. This > patch adds a proper verification. The IRQ correction was extracted from > John Syne patches. > > Signed-off-by: Rodrigo Siqueira

Re: [PATCH 1/7] staging:iio:ade7854: Rework I2C write function

On Wed, Mar 14, 2018 at 03:10:18PM -0300, Rodrigo Siqueira wrote: > The write operation using I2C has many code duplications and four > different interfaces per data size. This patch introduces a single > function that centralizes the main tasks. > > The central function inserted by this patch

Re: [PATCH v3]PCI: hv: fix PCI-BUS domainID corruption

On Thu, Mar 15, 2018 at 12:03:07AM +, Sridhar Pitchai wrote: > Whenever PCI bus is added, HyperV guarantees the BUS id is unique. Even "Whenever a PCI bus is added" > with that when a first device is added to the bus, it overrides bus domain > ID with the device serial number. Sometime this

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On 15/03/18 11:48, Dan Carpenter wrote: This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doesn't break the build. But some of the patches don't have commit message and those are required and some of the commit messages are just

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15, 2018 at 12:07:26PM +0100, John Crispin wrote: > None of the stuff posted is anywhere near ready to be > upstreamed. Yeah. This is staging so we accept any quality... The rest of the information is very useful. Thanks! regards, dan carpenter

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote: > On Thu, Mar 15 2018, Dan Carpenter wrote: > > > This all seems fine. Generally the requirements for staging are that it > > has a TODO, someone to work on it, and it doesn't break the build. But > > some of the patches don't have

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15 2018, Dan Carpenter wrote: > This all seems fine. Generally the requirements for staging are that it > has a TODO, someone to work on it, and it doesn't break the build. But > some of the patches don't have commit message and those are required and > some of the commit messages

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doesn't break the build. But some of the patches don't have commit message and those are required and some of the commit messages are just the changes you have made not don't

Re: [PATCH 01/13] staging: mt7621-pci: MIPS/ralink: add MT7621 pcie driver

These patches need better changelogs. Some of them don't have a changelog at all. Like just say this what kind of device this is or something? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

[PATCH] staging: comedi: ni_mio_common: ack ai fifo error interrupts.

From: Frank Mori Hess Ack ai fifo error interrupts in interrupt handler to clear interrupt after fifo overflow. It should prevent lock-ups after the ai fifo overflows. Cc: # v4.2+ Signed-off-by: Frank Mori Hess Signed-off-by: Ian

[PATCH] staging: lustre: o2iblnd: Fix FastReg map/unmap for MLX5

The FastReg support in ko2iblnd was not unmapping pool items causing the items to leak. In addition, the mapping code is not growing the pool like we do with FMR. This patch makes sure we are unmapping FastReg pool elements when we are done with them. It also makes sure the pool will grow when

Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR

Hi Jonathan, I have been looking at the IIO ABI docs and if I understand correctly, the idea is to use consistent naming conventions? So for example, looking at the ADE7854 datasheet, the naming matching the ADE7854 registers would be as follows: