Re: [PATCH] staging: pi433: add descriptions for mutex locks

2018-03-23 Thread Valentin Vidic
On Fri, Mar 23, 2018 at 11:22:39AM +0100, Marcus Wolf wrote: > could you please decribe in short words, why you think, that hte lock > isn't obsolete? > > I wasn't sure, but close to remove the lock. That's why I putted the > comment. Sure, if pi433_tx_thread runs on one CPU it might be possible

Re: [PATCH 09/12] staging: ks7010: replace MichaelBlockFunction macro with inline function

2018-03-23 Thread Sergio Paracuellos
On Fri, Mar 23, 2018 at 11:56 AM, Dan Carpenter wrote: > On Fri, Mar 23, 2018 at 11:14:59AM +0100, Sergio Paracuellos wrote: >> On Fri, Mar 23, 2018 at 10:49 AM, Dan Carpenter >> wrote: >> > On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio

Re: [PATCH 09/12] staging: ks7010: replace MichaelBlockFunction macro with inline function

2018-03-23 Thread Dan Carpenter
On Fri, Mar 23, 2018 at 11:14:59AM +0100, Sergio Paracuellos wrote: > On Fri, Mar 23, 2018 at 10:49 AM, Dan Carpenter > wrote: > > On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio Paracuellos wrote: > >> This commit replaces MichaelBlockFunction macro with similar inline

[PATCH v2] Staging: comedi: fix multiple line dereference coding style issue in cb_pcidas64.c

2018-03-23 Thread Jian Zhang
This is a patch to the cb_pcidas64.c file that fixes up a multiple line dereference warning found by the checkpatch.pl tool. Signed-off-by: Jian Zhang --- drivers/staging/comedi/drivers/cb_pcidas64.c | 19 ++- 1 file changed, 10 insertions(+), 9

Re: [PATCH] staging: pi433: add descriptions for mutex locks

2018-03-23 Thread Marcus Wolf
Hi Valentin, could you please decribe in short words, why you think, that hte lock isn't obsolete? I wasn't sure, but close to remove the lock. That's why I putted the comment. Thanks, Marcus Am 23.03.2018 um 10:47 schrieb Valentin Vidic: > Removes TODO for tx_fifo_lock as tx_fifo is modified

Re: [PATCH 11/12] staging: ks7010: replace uint8_t in favour of u8 in michael_append

2018-03-23 Thread Dan Carpenter
On Thu, Mar 22, 2018 at 08:19:22PM +0100, Sergio Paracuellos wrote: > This commit replaces param which is uint8_t in michael_append > function in favour of preferred one u8. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/ks7010/michael_mic.c | 6

Re: [PATCH 09/12] staging: ks7010: replace MichaelBlockFunction macro with inline function

2018-03-23 Thread Sergio Paracuellos
On Fri, Mar 23, 2018 at 10:49 AM, Dan Carpenter wrote: > On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio Paracuellos wrote: >> This commit replaces MichaelBlockFunction macro with similar inline function >> renaming it to michael_block. >> >> Signed-off-by: Sergio

Re: [PATCH 09/12] staging: ks7010: replace MichaelBlockFunction macro with inline function

2018-03-23 Thread Dan Carpenter
On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio Paracuellos wrote: > This commit replaces MichaelBlockFunction macro with similar inline function > renaming it to michael_block. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/ks7010/michael_mic.c |

[PATCH] staging: pi433: add descriptions for mutex locks

2018-03-23 Thread Valentin Vidic
Removes TODO for tx_fifo_lock as tx_fifo is modified from both pi433_tx_thread and pi433_write. Fixes checkpatch warning: CHECK: struct mutex definition without comment Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-03-23 Thread Quentin Schulz
Hi Uffe, On Fri, Feb 09, 2018 at 03:01:00PM +0100, Ulf Hansson wrote: > [...] > > >> > I'd like to know if any progress has been made on that problem (I may > >> > have missed patches). > >> > Had you had the time to look at the issue? > >> > >> I have looked at the issue, but not manage to cook

Re: [v2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-23 Thread kbuild test robot
: https://github.com/0day-ci/linux/commits/Roy-Pledge/staging-fsl-mc-Move-DPIO-from-staging-to-drivers-soc-fsl/20180323-102325 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp

<    1   2