> -Original Message-
> From: Michael Kelley (EOSG)
> Sent: Saturday, March 24, 2018 12:48 PM
> To: Haiyang Zhang ; da...@davemloft.net;
> net...@vger.kernel.org
> Cc: KY Srinivasan ; Stephen Hemminger
> ; o...@aepfle.de; vkuzn...@redhat.com;
> de...@linuxdriverproject.org; linux-ker...@vg
> On Mar 24, 2018, at 8:02 AM, Jonathan Cameron wrote:
>
> On Mon, 19 Mar 2018 22:57:16 -0700
> John Syne wrote:
>
>> Hi Jonathan,
>>
>> Thank you for all your hard work. Your feedback is really helpful. I’m
>> surprised that no one from Analog Device has offered any suggestions.
>>
>
> S
pi433_write requires locking due to multiple kfifo writers. After
acquiring the lock check if enough free space is available in the kfifo
to write the whole message. This check should prevent partial writes to
kfifo so kfifo_reset is not needed anymore.
pi433_tx_thread is the only kfifo reader so
On 03/23/2018 01:00 PM, Colin King wrote:
From: Colin Ian King
The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain
typos and don't match the #if guard check. Defined them correctly.
Cleans up clang warnings:
warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
by #
The events IIO_EV_INFO_VALUE and IIO_EV_INFO_ENABLE currently have a
falling and rising direction configured. There does not need to be a
separate distinction so this patch changes these to use the
either direction. Directory listing of event sysfs attributes for a
TSL2772 with this patch applied:
The hardware supports 16-bit ALS and proximity readings, however the
datasheet recommends using the I2C auto increment protocol so that the
correct high and low bytes are read even if the integration cycle ends
between reading the lower and upper registers. More information about
this protocol can
The IIO_CHAN_INFO_CALIBSCALE and IIO_CHAN_INFO_CALIBBIAS masks are
currently associated with the IIO_INTENSITY channel but should be
associated with the IIO_LIGHT channel since these values are used to
calculate the lux. Directory listing of the sysfs attributes for a
TSL2772 with this patch applie
Move the tsl2x7x driver out of staging and into mainline.
Signed-off-by: Brian Masney
---
Note: I intentionally ran git format-patch with --no-renames since
Jonathan likes to see the whole files in the email body for staging
graduation patches.
The #include "tsl2x7x.h" was changed to #include
i
Here is a patch series to move the tsl2x7x driver out of staging and
into mainline. Driver was tested using various TSL2X7X devices on a
Raspberry Pi 2.
Datasheet for the TSl2772:
https://ams.com/eng/content/download/291503/1066377/file/TSL2772_DS000181_2-00.pdf
Brian Masney (4):
staging: iio:
On Sat, 24 Mar 2018 15:57:19 +0100
David Julian Veenstra wrote:
> On 24, March 2018 14:12, Jonathan Cameron wrote:
>
> > On Sat, 24 Mar 2018 13:36:44 +0100
> > David Julian Veenstra wrote:
> >
> >> On 23, March 2018 14:27, Jonathan Cameron wrote:
> >>
> >> > On Sun, 18 Mar 2018 14:37:04 +0
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> On Behalf
> Of Long Li
> Sent: Thursday, March 22, 2018 2:47 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen
> Hemminger ; James E . J . Bottomley
> ;
> Martin K . Petersen ;
> de...@linuxdriverproject.org; linux-
> s
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> On Behalf
> Of Haiyang Zhang
> Sent: Thursday, March 22, 2018 12:01 PM
> To: da...@davemloft.net; net...@vger.kernel.org
> Cc: Haiyang Zhang ; KY Srinivasan
> ; Stephen
> Hemminger ; o...@aepfle.de; vkuzn...@redhat.com;
>
On Mon, 19 Mar 2018 23:28:45 -0700
John Syne wrote:
> Hi Jonathan,
>
> I broke out the {Direction}_{Type}_{Index}_{Modifier}_{Info_Mask} into
> separate columns to make sure I understand your instructions. Good way to
> check the results.
>
> Probably easier to copy and paste this table into
On Mon, 19 Mar 2018 22:57:16 -0700
John Syne wrote:
> Hi Jonathan,
>
> Thank you for all your hard work. Your feedback is really helpful. I’m
> surprised that no one from Analog Device has offered any suggestions.
>
Sadly those active in the mainline linux kernel from ADI are focused in
other
On 24, March 2018 14:12, Jonathan Cameron wrote:
> On Sat, 24 Mar 2018 13:36:44 +0100
> David Julian Veenstra wrote:
>
>> On 23, March 2018 14:27, Jonathan Cameron wrote:
>>
>> > On Sun, 18 Mar 2018 14:37:04 +0100
>> > David Veenstra wrote:
>> >
>> >> The angle channel is not defined in sysfs
On Fri, 23 Mar 2018 00:42:45 +0530
Himanshu Jha wrote:
> Move adis16201 driver out of staging and merge into mainline
> IIO subsystem.
>
> Signed-off-by: Himanshu Jha
There are a few really minor points inline. However,
non prevent this moving out of staging (and I'll fix one up anyway).
App
On Fri, 23 Mar 2018 00:42:44 +0530
Himanshu Jha wrote:
> Split the line over 80 characters limit to fix checkpatch
> warning.
>
> Signed-off-by: Himanshu Jha
Applied,
Thanks,
Jonathan
> ---
> drivers/staging/iio/accel/adis16201.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
On Fri, 23 Mar 2018 00:42:43 +0530
Himanshu Jha wrote:
> Use GENMASK to improve readability and remove the local variables used to
> store intermediate data.
>
> Signed-off-by: Himanshu Jha
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/accel/adis16201
On Fri, 23 Mar 2018 00:42:42 +0530
Himanshu Jha wrote:
> Remove few unused headers files since the adis core handles the buffer and
> sysfs support.
>
> Signed-off-by: Himanshu Jha
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/staging/ii
On Sat, 24 Mar 2018 13:36:44 +0100
David Julian Veenstra wrote:
> On 23, March 2018 14:27, Jonathan Cameron wrote:
>
> > On Sun, 18 Mar 2018 14:37:04 +0100
> > David Veenstra wrote:
> >
> >> The angle channel is not defined in sysfs iio ABI. So it is replaced
> >> with an inclination channel,
On Sat, 24 Mar 2018 13:22:22 +0100
David Julian Veenstra wrote:
> On 23, March 2018 14:17, Jonathan Cameron wrote:
>
> > On Sun, 18 Mar 2018 14:35:46 +0100
> > David Veenstra wrote:
> >
> >> Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly
> >> used in ad2s1200_probe
On Wed, 21 Mar 2018 06:29:12 -0400
Brian Masney wrote:
> Add Brian Masney's copyright and to the list of module authors for all
> of the staging cleanups. This patch also update's Jon Brenner's current
> work email address since AMS now owns TAOS.
>
> Signed-off-by: Brian Masney
Applied to the
On Wed, 21 Mar 2018 06:29:11 -0400
Brian Masney wrote:
> This patch ensures that all of the local variable declarations are in
> reverse Christmas tree order where possible to increase code
> readability.
>
> Signed-off-by: Brian Masney
Applied. As ever it's a minor improvement but I suppose wo
On Wed, 21 Mar 2018 06:29:10 -0400
Brian Masney wrote:
> Remove the ch0 and ch1 variables from tsl2x7x_get_lux() and
> write those values directly into the chip->als_cur_info.als_ch0
> and chip->als_cur_info.als_ch01 variables.
>
> Signed-off-by: Brian Masney
Hmm. A marginal improvement in read
On Wed, 21 Mar 2018 06:29:08 -0400
Brian Masney wrote:
> The struct tsl2x7x_settings contained a persistence member that
> contained both the ALS and proximity persistence fields. This patch
> splits this out into two separate fields so that the bitmasks in
> several parts of the code are no long
On Wed, 21 Mar 2018 06:29:09 -0400
Brian Masney wrote:
> tsl2x7x_get_lux() has a ch0lux and ch1lux variables that are not used
> so this patch removes them.
>
> Signed-off-by: Brian Masney
Had to argue with this one ;)
Applied,
Thanks,
Jonathan
> ---
> drivers/staging/iio/light/tsl2x7x.c |
On Wed, 21 Mar 2018 06:29:07 -0400
Brian Masney wrote:
> This patch updates all of the logging commands so that they are
> consistent with the other messages, includes __func__ in the message,
> and all of the messages include newlines. This patch also removes some
> debug log messages.
>
> Sign
On Wed, 21 Mar 2018 06:29:06 -0400
Brian Masney wrote:
> The struct tsl2x7x_settings contained an interrupts_en member that was
> a bitmask for which interrupts are enabled. This required having
> bitmasks in several parts of the code. This patch splits this field
> out into two booleans to remov
On Wed, 21 Mar 2018 06:29:05 -0400
Brian Masney wrote:
> tsl2x7x_prox_cal() would set the interrupt flag, and reset the device to
> start doing the calibration routine. However, this did not actually
> affect the readings since they are polled. This patch drops the interrupt
> code.
>
> This pat
On Wed, 21 Mar 2018 06:29:04 -0400
Brian Masney wrote:
> tsl2x7x_get_lux() does not need to clear the interrupt flag when
> querying the ALS. The interrupt flag is cleared in
> tsl2x7x_event_handler(). This patches removes the unnecessary code.
>
> Signed-off-by: Brian Masney
Applied.
Thanks,
On Wed, 21 Mar 2018 06:29:03 -0400
Brian Masney wrote:
> tsl2x7x_event_handler() was not called as expected when the device was
> asserting a hardware interrupt. This patch changes the interrupt line
> trigger from rising to falling.
I guess the original test board used for driver development mus
On Wed, 21 Mar 2018 06:29:02 -0400
Brian Masney wrote:
> As a follow up to the work in commit a0722d05a195 ("staging: iio:
> tsl2x7x: convert mutex_trylock() to mutex_lock()"), this patch removes
> the unnecessary calls to tsl2x7x_get_prox() and tsl2x7x_get_lux() in
> tsl2x7x_event_handler(). Pre
On Fri, 23 Mar 2018 11:27:27 -0300
Rodrigo Siqueira wrote:
> The original code had a read function per data size; after updates, all
> read functions tasks were centralized in a single function, but the old
> signature was kept to maintain the module working without problems. This
> patch removes
On Fri, 23 Mar 2018 11:27:12 -0300
Rodrigo Siqueira wrote:
> Rework read SPI function to reduce the code duplication and centralizes
> all the task in a single function.
>
> Signed-off-by: Rodrigo Siqueira
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to
On Fri, 23 Mar 2018 11:26:57 -0300
Rodrigo Siqueira wrote:
> The read operation for the I2C function has many duplications that can
> be generalized into a single function. This patch reworks the read
> operation for I2C to centralizes all similar code in a single function.
>
> It is possible to
On Fri, 23 Mar 2018 11:26:41 -0300
Rodrigo Siqueira wrote:
> This patch removes code duplications related to the write_reg_*
> functions and centralizes them in a single function. Also, it eliminates
> the legacy functions and replaces them by a unique signature that is
> used by SPI and I2C.
>
On Fri, 23 Mar 2018 11:26:25 -0300
Rodrigo Siqueira wrote:
> The write operation using SPI has a many code duplications (similar to
> I2C) and four different interfaces per data size. This patch introduces
> a single function that centralizes the main task related to SPI.
>
> Signed-off-by: Rodr
On Fri, 23 Mar 2018 11:26:06 -0300
Rodrigo Siqueira wrote:
> The write operation using I2C has many code duplications and four
> different interfaces per data size. This patch introduces a single
> function that centralizes the main tasks.
>
> The central function inserted by this patch can easi
On Fri, 23 Mar 2018 11:25:48 -0300
John Syne wrote:
> Fixes: correctly handle the data size in the read operation for I2C
>
> The function ade7854_i2c_read_reg_32() have to invoke the
> i2c_master_recv() for read 32 bits values, however, the counter is set
> to 3 which means 24 bits. This patch
On Fri, 23 Mar 2018 11:22:10 -0300
John Syne wrote:
> Fixes: correctly handle errors on the read and write operation for I2C
Please look at the Submitting patches documentation. This is not
what a fixes tag is about! I'll fix it up this time but please
look at it.
>
> The original code does no
On 23, March 2018 14:27, Jonathan Cameron wrote:
> On Sun, 18 Mar 2018 14:37:04 +0100
> David Veenstra wrote:
>
>> The angle channel is not defined in sysfs iio ABI. So it is replaced
>> with an inclination channel, because it is defined in the ABI, and has the
>> semantics of an angle.
>>
>> In
On 23, March 2018 14:20, Jonathan Cameron wrote:
> On Sun, 18 Mar 2018 14:36:15 +0100
> David Veenstra wrote:
>
>> After a successful spi transaction, a udelay(1) is needed.
>> This doesn't happen for the default case of the switch statement
>> in ad2s1200_read_raw. This patch makes sure that it
On 23, March 2018 14:17, Jonathan Cameron wrote:
> On Sun, 18 Mar 2018 14:35:46 +0100
> David Veenstra wrote:
>
>> Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly
>> used in ad2s1200_probe.
>>
>> Signed-off-by: David Veenstra
> I'm a little unconvinced by this one. I
43 matches
Mail list logo