The "_t" suffix is not needed for structure names in this driver,
and is a reflection of an older typedef system that is no longer
in place. Remove the "_t" suffix from every structure defined in this
driver.
Signed-off-by: Quytelda Kahja
---
Remove an extra blank line indicated by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
drivers/staging/ks7010/ks_hostif.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
'reg_net' is never used in this driver.
Signed-off-by: Quytelda Kahja x
---
drivers/staging/ks7010/ks_wlan.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 846bb1041850..1b7036c32d1c 100644
---
The ethernet address of the network device is already stored in the
'dev_addr' field of 'struct net_device'. Since 'struct ks_wlan_private'
keeps a pointer to the driver's 'struct net_device', there is no reason
to duplicate this information in 'struct ks_wlan_private'.
Signed-off-by: Quytelda
'mac_address_valid' is only ever assigned 0 or 1, so it makes more sense
to use a bool type for this variable.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
drivers/staging/ks7010/ks_wlan.h | 2 +-
drivers/staging/ks7010/ks_wlan_net.c
Copying the dummy HW address into the struct net_device doesn't need
to be done byte by byte; use ether_addr_copy() instead.
Additionally, dev->dev_addr is not eight bytes long.
ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6)
in the net core code.
Signed-off-by: Quytelda Kahja
All of the net_device_ops callbacks are named after their counterparts
in the kernel's 'struct net_device_ops', except
ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for
greater consistency.
Signed-off-by: Quytelda Kahja
---
Reorder the members of 'ks_wlan_netdev_ops' to reflect the order
of their counterparts in the kernel's 'struct net_device_ops'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff
The driver casts '_wlan_handler_def' to 'struct iw_handler_def *',
but it is already of that type.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Mar 28, 2018 at 05:55:57PM +0800, Jia-Ju Bai wrote:
> >@@ -646,7 +649,8 @@ static void device_init_td1_ring(struct vnt_private
> >*priv)
> > i++, curr += sizeof(struct vnt_tx_desc)) {
> > desc = >apTD1Rings[i];
> > desc->td_info =
Thanks, I hadn't updated to rc7 yet
-Original Message-
From: Joshua R. Poulson
Sent: Wednesday, March 28, 2018 12:18 PM
To: Stephen Hemminger
Cc: K. Y. Srinivasan ; KY Srinivasan
;
Maybe best through greg's char-misc tree since it has generic hv code and
sometime updates both network and scsi.
Alternatively, put common code through one tree, and hold off the network
device change till next release.
-Original Message-
From: Long Li
Sent: Wednesday, March 28,
> Subject: Re: [Resend Patch 1/3] Vmbus: Add function to report available ring
> buffer to write in total ring size percentage
>
>
> Long,
>
> > Netvsc has a function to calculate how much ring buffer in percentage
> > is available to write. This function is also useful for storvsc and
> >
Remove yield() call. Yield does not guarantee progress, cond_resched()
is a safer alternative
Signed-off-by: Thomas Avery
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Remove yield call(). yield does not guarantee progress, and should not
be used. cond_resched() is a safe alternative.
Signed-off-by: Thomas Avery
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Long,
> Netvsc has a function to calculate how much ring buffer in percentage is
> available to write. This function is also useful for storvsc and other
> vmbus devices.
What is the submission strategy for this series? Do you expect it to go
through net or scsi? If the latter, I'll need an ack
Include the local ethtool.h header file in mtk_eth_soc.h so
implementation files have centralized access to it.
This fixes the following sparse warning:
drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol
'mtk_set_ethtool_ops' was not declared. Should it be static?
Signed-off-by: Chris
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.16-rc7=655296c8bbeffcf020558c4455305d597a73bde1
On Wed, Mar 28, 2018 at 12:01 PM, Stephen Hemminger
wrote:
> On Sun, 4 Mar 2018 22:24:08 -0700
> k...@exchange.microsoft.com wrote:
>
>>
On Sun, 4 Mar 2018 22:24:08 -0700
k...@exchange.microsoft.com wrote:
> From: Michael Kelley
>
> Fix bugs in signaling the Hyper-V host when freeing space in the
> host->guest ring buffer:
>
> 1. The interrupt_mask must not be used to determine whether to signal
>on
With that we can clear any pending events and the port is registered
so driver can be ready to handle typec events once we request irq.
Signed-off-by: Peter Chen
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 15 ---
1 file changed, 8
We need regmap_update_bits to avoid touch any other bits when
enable or disable vconn.
Reviewed-by: Guenter Roeck
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
Move TCPCI(Typec port controller interface) driver out of staging.
Signed-off-by: Li Jun
---
drivers/staging/Kconfig| 2 --
drivers/staging/Makefile | 1 -
drivers/staging/typec/Kconfig | 14 --
drivers/staging/typec/Makefile
This patch adds support of get typec and power delivery config from
firmware description.
Signed-off-by: Li Jun
---
drivers/usb/typec/tcpm.c | 140 ++-
1 file changed, 115 insertions(+), 25 deletions(-)
diff --git
Add fwnode handle to get the fwnode so we can get typec configs
it contains.
Suggested-by: Heikki Krogerus
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 14 +++---
drivers/usb/typec/tcpm.c | 1 +
While set polarity, we should keep the not connecting cc line to be
open.
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
TCPCI implementation may need SW to enable VBUS detection to generate
power status events.
Reviewed-by: Guenter Roeck
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
As DRP port autonomously toggles the Rp/Rd need a start value to
begin with, so add one parameter for it in tcpm_start_drp_toggling.
Reviewed-by: Guenter Roeck
Signed-off-by: Li Jun
---
drivers/usb/typec/tcpm.c | 10 +-
1 file changed, 5
Add nxp ptn5110 typec controller compatible string: usb-tcpci,ptn5110,
which is a standard tcpci chip with power delivery support.
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/typec/tcpci.c
In case of drp toggling, we may need set correct cc value for role control
after attach as it may never been set.
Signed-off-by: Li Jun
---
drivers/usb/typec/tcpm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index
This patch adds 3 APIs to get the typec port power and data type,
and preferred power role by its name string.
Suggested-by: Heikki Krogerus
Signed-off-by: Li Jun
---
drivers/usb/typec/class.c | 52 +++
This patch set attempts to move the tcpci driver out of staging by fix
some tcpci driver issues and define typec and power delivery device
properties, the changes are verified on NXP PTN5110, which is a standard
tcpci typec port controller device with power delivery support, tested
power source
TCPCI stands for typec port controller interface, its implementation
has full typec port control with power delivery support, it's a
standard i2c slave with GPIO input as irq interface, detail see spec
"Universal Serial Bus Type-C Port Controller Interface Specification
Revision 1.0, Version 1.1"
Add bingdings supported by current typec driver, so user can pass
all those properties via dt.
Signed-off-by: Li Jun
---
.../bindings/connector/usb-connector.txt | 39 ++
1 file changed, 39 insertions(+)
diff --git
On Wed, Mar 28, 2018 at 1:49 PM, Greg KH wrote:
> On Fri, Mar 23, 2018 at 02:05:10PM +0100, Sergio Paracuellos wrote:
>> This commit replace camel cases for name and params used in
>> MichaelMICFunction. This improves a bit readability.
>>
>> Signed-off-by: Sergio
This commit replaces PutUInt32 custom macro with put_unaligned_le32
function included in the linux kernel.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git
This commit replaces custom GetUInt32 macro with get_unaligned_le32
which is included in the linux kernel.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git
This commit removes death code which is not being used at all. The
statements which are contained inside the else block of preprocessor
#if 1 directive are no sense. Also remove #if 1 preprocessor stuff
just because it is just true and being executed always.
This change improves a bit readability
This commit avoid camel cases in MichaelInitFunction signature and params
renaming it to michael_init.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
This commit replaces uint8_t parameter for preferred one u8 in
michael_get_mic function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This commit replaces MichaelBlockFunction macro with similar
inline function renaming it to michael_block.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 31 ---
1 file changed, 16 insertions(+), 15
This commit replaces param which is uint8_t in michael_append
function in favour of preferred one u8. It also removes no more
needed casts when calling this function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 6 +++---
1 file
This commit replaces uint8_t for preferred one u8 in parameter
of michael_init function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This are some clean ups for this driver. Changes are as follows:
- Some camel cases fixes
- remove some macros to use inline functions or functions which
exists in linux kernel itself
- Use u8 types instead of uint8_t
There was a previous patch series including some of these patches
which
This commit avoid camel cases in MichaelAppend function and params
renaming it to michael_append.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 45 ++--
1 file changed, 22 insertions(+), 23 deletions(-)
This commit replaces MichaelClear macro with similar inline function
renaming it to michael_clear.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
This commit avoid camel cases in MichaelGetMIC function and params
renaming it to michael_get_mic.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff
This commit replace camel cases for name and params used in
MichaelMICFunction. This improves a bit readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/michael_mic.c | 15
Em Wed, 28 Mar 2018 17:13:29 +0300
Dan Carpenter escreveu:
> On Mon, Mar 26, 2018 at 05:10:45PM -0400, Mauro Carvalho Chehab wrote:
> > Checking if a size_t value is bigger than ULONG_INT only makes
> > sense if building on 64 bits, as warned by:
> >
> >
On Wed, Mar 28, 2018 at 1:49 PM, Greg KH wrote:
> On Fri, Mar 23, 2018 at 02:05:10PM +0100, Sergio Paracuellos wrote:
>> This commit replace camel cases for name and params used in
>> MichaelMICFunction. This improves a bit readability.
>>
>> Signed-off-by: Sergio
On Mon, Mar 26, 2018 at 05:10:45PM -0400, Mauro Carvalho Chehab wrote:
> Checking if a size_t value is bigger than ULONG_INT only makes
> sense if building on 64 bits, as warned by:
>
> drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:697
> gmin_get_config_var()
On Mon, Mar 26, 2018 at 06:52:48PM +0200, Sergio Paracuellos wrote:
> This commit removes death code which is not being used at all because
> it is inside a preprocessor if 0 directive. This change improves a bit
> readability of ks_wlan_set_essid function.
That's not what your patch does:
>
>
On Fri, Mar 23, 2018 at 11:40:42PM -0700, Quytelda Kahja wrote:
> The "_t" suffix is not needed for structure names in this driver,
> and is a reflection of an older typedef system that is no longer
> in place. Remove the "_t" suffix from every structure defined in this
> driver.
>
>
On Fri, Mar 23, 2018 at 02:05:17PM +0100, Sergio Paracuellos wrote:
> This commit replaces MichaelBlockFunction macro with similar
> inline function renaming it to michael_block.
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/ks7010/michael_mic.c |
On Fri, Mar 23, 2018 at 02:05:15PM +0100, Sergio Paracuellos wrote:
> This commit replaces PutUInt32 macro in favour of inline function
> renaming it to put_uint32.
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/ks7010/michael_mic.c | 18
On Mon, Mar 26, 2018 at 06:16:29PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Replace several allocation and memcpys with kmemdup and add in some
> missing memory allocation failure checks. Also fix an incorrect
> -EFAULT return with -ENOMEM.
>
>
On Mon, Mar 26, 2018 at 05:15:55PM +0530, Ajay Singh wrote:
> Cleanup patch to remove the unused global variables defined for p2p.
>
> Signed-off-by: Ajay Singh
> Reviewed-by: Claudiu Beznea
> ---
>
On Wed, Mar 28, 2018 at 1:28 PM, Greg KH wrote:
> What is different from "v2" you sent before this? No change information
> from v1?
Sorry I messed this up - the first resend did not have "v2" in the
subject but did contain v2 change information, the second resend
On Tue, Mar 27, 2018 at 12:52:13PM +0530, Ajay Singh wrote:
>
> Please let me know, in case I have to rework and resubmit this patch
> series to make them into staging branch.
You already sent a v2 series for this, right? Why respond to the v1
set?
confused,
greg k-h
On Wed, Mar 28, 2018 at 11:14:50AM +0200, Martijn Coenen wrote:
> This can't happen with normal nodes (because you can't get a ref
> to a node you own), but it could happen with the context manager;
> to make the behavior consistent with regular nodes, reject
> transactions into the context
On Wed, Mar 28, 2018 at 11:06:54AM +0200, Martijn Coenen wrote:
> On Wed, Mar 28, 2018 at 10:19 AM, Greg KH wrote:
> > Does this need to go to older kernels as well?
>
> Yes, this should apply cleanly to 4.14 as well. It won't apply to
> pre-4.14 kernels because of
The tag control information (TCI) part of the VLAN header contains several
fields, including PCP (priority code point) and PVID (port VLAN id).
Current implementation uses function ethsw_port_set_tci() to set the PVID
value and mistakenly overwrites the rest of the TCI fields with 0,
including
://github.com/0day-ci/linux/commits/Razvan-Stefanescu/staging-fsl-dpaa2-ethsw-Fix-TCI-values-overwrite/20180328-154703
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All
On 2018/3/28 14:31, Ji-Hun Kim wrote:
There are no null pointer checking on rd_info and td_info values which
are allocated by kzalloc. It has potential null pointer dereferencing
issues. Add return when allocation is failed.
Signed-off-by: Ji-Hun Kim
---
Em Tue, 27 Mar 2018 14:02:55 +0300
Andy Shevchenko escreveu:
> On Mon, 2018-03-26 at 17:10 -0400, Mauro Carvalho Chehab wrote:
> > There are lots of be-related warnings there, as it doesn't properly
> > mark what data uses bigendian.
>
> > @@ -107,7 +107,7
This can't happen with normal nodes (because you can't get a ref
to a node you own), but it could happen with the context manager;
to make the behavior consistent with regular nodes, reject
transactions into the context manager by the process owning it.
Reported-by:
This can't happen with normal nodes (because you can't get a ref
to a node you own), but it could happen with the context manager;
to make the behavior consistent with regular nodes, reject
transactions into the context manager by the process owning it.
Reported-by:
On Wed, Mar 28, 2018 at 10:19 AM, Greg KH wrote:
> Does this need to go to older kernels as well?
Yes, this should apply cleanly to 4.14 as well. It won't apply to
pre-4.14 kernels because of the fine-grained locking changes, but the
same issue exists there and I
On Wed, Mar 28, 2018 at 03:31:31PM +0900, Ji-Hun Kim wrote:
> There are no null pointer checking on rd_info and td_info values which
> are allocated by kzalloc. It has potential null pointer dereferencing
> issues. Add return when allocation is failed.
>
> Signed-off-by: Ji-Hun Kim
On Wed, Mar 28, 2018 at 09:29:03AM +0200, Martijn Coenen wrote:
> This can't happen with normal nodes (because you can't get a ref
> to a node you own), but it could happen with the context manager;
> to make the behavior consistent with regular nodes, reject
> transactions into the context
This can't happen with normal nodes (because you can't get a ref
to a node you own), but it could happen with the context manager;
to make the behavior consistent with regular nodes, reject
transactions into the context manager by the process owning it.
Reported-by:
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
> ow...@vger.kernel.org] On Behalf Of Andrew Lunn
> Sent: Tuesday, March 27, 2018 4:38 PM
> To: Razvan Stefanescu
> Cc: gre...@linuxfoundation.org;
The tag control information (TCI) part of the VLAN header contains several
fields, including PCP (priority code point) and PVID (port VLAN id).
Current implementation uses function ethsw_port_set_tci() to set the PVID
value and mistakenly overwrites the rest of the TCI fields with 0,
including
There are no null pointer checking on rd_info and td_info values which
are allocated by kzalloc. It has potential null pointer dereferencing
issues. Add return when allocation is failed.
Signed-off-by: Ji-Hun Kim
---
drivers/staging/vt6655/device_main.c | 12
73 matches
Mail list logo