Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-03-30 Thread Joe Perches
On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > This macro, provided in 'linux/kernel.h', will calculate the size > more succinctly than a division operation. It's nice that you send patches, but please try to send a cover letter with your patch series. Also, 75 patches is quite a lot

[PATCH v2 75/75] staging: ks7010: Replace memcpy() with ether_addr_copy().

2018-03-30 Thread Quytelda Kahja
ether_addr_copy() is the function for copying a hardware address, so replace the manual memcpy() operation with ether_addr_copy(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_ho

[PATCH v2 69/75] staging: ks7010: Remove extra blank line between functions.

2018-03-30 Thread Quytelda Kahja
Remove an extra blank line indicated by checkpatch. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010_sdio.c | 3 ++- drivers/staging/ks7010/ks_hostif.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/k

[PATCH v2 74/75] staging: ks7010: Replace memcmp() with ether_addr_equal().

2018-03-30 Thread Quytelda Kahja
ether_addr_equal() is the function for comparing HW addresses, so remove the manual memcmp operation and replace it with ether_addr_equals(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH v2 53/75] staging: ks7010: Remove trailing _t from 'struct wps_ie_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wps_ie_t' with 'struct wps_ie'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++-- 1 file chang

[PATCH v2 61/75] staging: ks7010: Remove trailing _t from 'struct wpa_key_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wpa_key_t' with 'struct wpa_key'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 2 +- drivers/

[PATCH v2 65/75] staging: ks7010: Remove trailing _t from 'struct pmk_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct pmk_t' with 'struct pmk'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 2 +- drivers/staging/

[PATCH v2 58/75] staging: ks7010: Remove trailing _t from 'struct power_save_status_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct power_save_status_t' with 'struct power_save_status'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h

[PATCH v2 70/75] staging: ks7010: Rename ks_wlan_set_multicast_list()

2018-03-30 Thread Quytelda Kahja
All of the net_device_ops callbacks are named after their counterparts in the kernel's 'struct net_device_ops', except ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for greater consistency. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 6 +++--- 1 f

[PATCH v2 63/75] staging: ks7010: Remove trailing _t from 'struct wpa_status_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wpa_status_t' with 'struct wpa_status'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++-- 1 fi

[PATCH v2 73/75] staging: ks7010: Remove unnecessary casts in 'struct ks_wlan_handler_def'.

2018-03-30 Thread Quytelda Kahja
The casts used when initializing members of this data structure mirror the types the variables already have. Remove the casts. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/

[PATCH v2 55/75] staging: ks7010: Remove trailing _t from 'struct local_aplist_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct local_aplist_t' with 'struct local_aplist'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++--

[PATCH v2 68/75] staging: ks7010: Replace manual array copy with ether_addr_copy().

2018-03-30 Thread Quytelda Kahja
Copying the dummy HW address into the struct net_device doesn't need to be done byte by byte; use ether_addr_copy() instead. Additionally, dev->dev_addr is not eight bytes long. ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6) in the net core code. Signed-off-by: Quytelda Kahja ---

[PATCH v2 67/75] staging: ks7010: Remove trailing _t from 'struct michael_mic_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct michael_mic_t' with 'struct michael_mic'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 4 ++-

[PATCH v2 64/75] staging: ks7010: Remove trailing _t from 'struct pmk_list_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct pmk_list_t' with 'struct pmk_list'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++-- 1 file c

[PATCH v2 71/75] staging: ks7010: Remove dummy address set.

2018-03-30 Thread Quytelda Kahja
Setting a dummy address during the driver probe is not necessary. The dev_addr field is already zeroed out from alloc_etherdev(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c

[PATCH v2 54/75] staging: ks7010: Remove trailing _t from 'struct local_ap_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct local_ap_t' with 'struct local_ap'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 10 +

[PATCH v2 40/75] staging: ks7010: Remove trailing _t from 'struct association_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct association_request_t' with 'struct association_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hos

[PATCH v2 72/75] staging: ks7010: Change 'device_open_status' to a bool.

2018-03-30 Thread Quytelda Kahja
The 'device_open_status' member of 'struct ks_wlan_private' is only ever set to zero or one, so it makes more sense for it to be a bool instead of an int. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 2 +- drivers/staging/ks7010/ks_wlan_net.c | 5 ++--- 2 files change

[PATCH v2 59/75] staging: ks7010: Remove trailing _t from 'struct sleep_status_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct sleep_status_t' with 'struct sleep_status'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++--

[PATCH v2 66/75] staging: ks7010: Remove trailing _t from 'struct wps_status_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wps_status_t' with 'struct wps_status'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++-- 1 fi

[PATCH v2 62/75] staging: ks7010: Remove trailing _t from 'struct mic_failure_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct mic_failure_t' with 'struct mic_failure'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 2 +- dr

[PATCH v2 60/75] staging: ks7010: Remove trailing _t from 'struct scan_ext_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct scan_ext_t' with 'struct scan_ext'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++-- 1 file c

[PATCH v2 46/75] staging: ks7010: Remove unused 'struct hostif_phy_information_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_phy_information_confirm_t' is not used in this driver. Remove 'struct hostif_phy_information_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/driv

[PATCH v2 52/75] staging: ks7010: Remove trailing _t from 'struct rsn_ie_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct rsn_ie_t' with 'struct rsn_ie'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 6 +++--- 1 file cha

[PATCH v2 56/75] staging: ks7010: Remove trailing _t from 'struct local_gain_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct local_gain_t' with 'struct local_gain'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++-- 1 fi

[PATCH v2 41/75] staging: ks7010: Remove trailing _t from 'struct association_response_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct association_response_t' with 'struct association_response'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_h

[PATCH v2 48/75] staging: ks7010: Remove unused 'struct hostif_sleep_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_sleep_confirm_t' is not used in this driver. Remove 'struct hostif_sleep_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.

[PATCH v2 35/75] staging: ks7010: Remove unused 'struct hostif_infrastructure_set_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_infrastructure_set_confirm_t' is not used in this driver. Remove 'struct hostif_infrastructure_set_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers

[PATCH v2 57/75] staging: ks7010: Remove trailing _t from 'struct local_eeprom_sum_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct local_eeprom_sum_t' with 'struct local_eeprom_sum'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h |

[PATCH v2 51/75] staging: ks7010: Remove trailing _t from 'struct hostt_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostt_t' with 'struct hostt'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 4 ++-- 1 file changed

[PATCH v2 50/75] staging: ks7010: Remove unused 'struct hostif_mic_failure_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_mic_failure_confirm_t' is not used in this driver. Remove 'struct hostif_mic_failure_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks701

[PATCH v2 33/75] staging: ks7010: Remove unused 'struct hostif_ps_adhoc_set_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_ps_adhoc_set_confirm_t' is not used in this driver. Remove 'struct hostif_ps_adhoc_set_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7

[PATCH v2 49/75] staging: ks7010: Remove trailing _t from 'struct hostif_mic_failure_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_mic_failure_request_t' with 'struct hostif_mic_failure_request'. Signed-off-by: Quytelda Kahja --- drivers/staging

[PATCH v2 10/75] staging: ks7010: Remove unused 'struct hostif_mib_get_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_mib_get_confirm_t' is not used in this driver. Remove 'struct hostif_mib_get_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_ho

[PATCH v2 23/75] staging: ks7010: Remove unused 'struct rsn_t'.

2018-03-30 Thread Quytelda Kahja
'struct rsn_t' is not used in this driver. Remove 'struct rsn_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index a3c686c1289c..091bc82a99c4

[PATCH v2 28/75] staging: ks7010: Remove unused 'struct hostif_connect_indication_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_connect_indication_t' is not used in this driver. Remove 'struct hostif_connect_indication_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/

[PATCH v2 15/75] staging: ks7010: Remove trailing _t from 'struct hostif_start_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_start_request_t' with 'struct hostif_start_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_h

[PATCH v2 37/75] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set2_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_adhoc_set2_request_t' with 'struct hostif_adhoc_set2_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/k

[PATCH v2 42/75] staging: ks7010: Remove unused 'struct hostif_associate_indication_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_associate_indication_t' is not used in this driver. Remove 'struct hostif_associate_indication_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/

[PATCH v2 14/75] staging: ks7010: Remove unused 'struct hostif_power_mgmt_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_power_mgmt_confirm_t' is not used in this driver. Remove 'struct hostif_power_mgmt_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/

[PATCH v2 32/75] staging: ks7010: Remove trailing _t from 'struct hostif_ps_adhoc_set_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_ps_adhoc_set_request_t' with 'struct hostif_ps_adhoc_set_request'. Signed-off-by: Quytelda Kahja --- drivers/stagi

[PATCH v2 24/75] staging: ks7010: Remove trailing _t from 'struct erp_params_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct erp_params_t' with 'struct erp_params'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1

[PATCH v2 34/75] staging: ks7010: Remove trailing _t from 'struct hostif_infrastructure_set_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_infrastructure_set_request_t' with 'struct hostif_infrastructure_set_request'. Signed-off-by: Quytelda Kahja --- d

[PATCH v2 20/75] staging: ks7010: Remove trailing _t from 'struct ds_parms_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct ds_parms_t' with 'struct ds_parms'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1 file

[PATCH v2 38/75] staging: ks7010: Remove unused 'struct hostif_adhoc_set_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_adhoc_set_confirm_t' is not used in this driver. Remove 'struct hostif_adhoc_set_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks

[PATCH v2 29/75] staging: ks7010: Remove trailing _t from 'struct hostif_stop_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_stop_request_t' with 'struct hostif_stop_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010

[PATCH v2 18/75] staging: ks7010: Remove trailing _t from 'struct rate_set8_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct rate_set8_t' with 'struct rate_set8'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 6 +++--- 1

[PATCH v2 47/75] staging: ks7010: Remove trailing _t from 'struct hostif_sleep_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_sleep_request_t' with 'struct hostif_sleep_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_h

[PATCH v2 44/75] staging: ks7010: Remove unused 'struct hostif_bss_scan_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_bss_scan_confirm_t' is not used in this driver. Remove 'struct hostif_bss_scan_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_

[PATCH v2 45/75] staging: ks7010: Remove trailing _t from 'struct hostif_phy_information_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_phy_information_request_t' with 'struct hostif_phy_information_request'. Signed-off-by: Quytelda Kahja --- drivers

[PATCH v2 43/75] staging: ks7010: Remove trailing _t from 'struct hostif_bss_scan_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_bss_scan_request_t' with 'struct hostif_bss_scan_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks701

[PATCH v2 30/75] staging: ks7010: Remove unused 'struct hostif_stop_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_stop_confirm_t' is not used in this driver. Remove 'struct hostif_stop_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 39/75] staging: ks7010: Remove unused 'struct last_associate_t'.

2018-03-30 Thread Quytelda Kahja
'struct last_associate_t' is not used in this driver. Remove 'struct last_associate_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index ce9f

[PATCH v2 36/75] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_adhoc_set_request_t' with 'struct hostif_adhoc_set_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7

[PATCH v2 21/75] staging: ks7010: Remove trailing _t from 'struct cf_parms_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct cf_parms_t' with 'struct cf_parms'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1 file

[PATCH v2 31/75] staging: ks7010: Remove trailing _t from 'struct hostif_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_request_t' with 'struct hostif_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 2

[PATCH v2 06/75] staging: ks7010: Remove unused 'struct hostif_data_indication_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_data_indication_t' is not used in this driver. Remove 'struct hostif_data_indication_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_h

[PATCH v2 26/75] staging: ks7010: Remove trailing _t from 'struct ap_info_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct ap_info_t' with 'struct ap_info'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 8 driv

[PATCH v2 17/75] staging: ks7010: Remove trailing _t from 'struct ssid_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct ssid_t' with 'struct ssid'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 10 +- 1 file

[PATCH v2 22/75] staging: ks7010: Remove trailing _t from 'struct ibss_parms_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct ibss_parms_t' with 'struct ibss_parms'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1

[PATCH v2 25/75] staging: ks7010: Remove trailing _t from 'struct rate_set16_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct rate_set16_t' with 'struct rate_set16'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1

[PATCH v2 13/75] staging: ks7010: Remove trailing _t from 'struct hostif_power_mgmt_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_power_mgmt_request_t' with 'struct hostif_power_mgmt_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/k

[PATCH v2 19/75] staging: ks7010: Remove trailing _t from 'struct fh_parms_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct fh_parms_t' with 'struct fh_parms'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1 file

[PATCH v2 27/75] staging: ks7010: Remove trailing _t from 'struct link_ap_info_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct link_ap_info_t' with 'struct link_ap_info'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 4 ++--

[PATCH v2 12/75] staging: ks7010: Remove unused 'struct hostif_mib_set_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_mib_set_confirm_t' is not used in this driver. Remove 'struct hostif_mib_set_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_ho

[PATCH v2 07/75] staging: ks7010: Remove trailing _t from 'struct channel_list_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct channel_list_t' with 'struct channel_list'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 8

[PATCH v2 16/75] staging: ks7010: Remove unused 'struct hostif_start_confirm_t'.

2018-03-30 Thread Quytelda Kahja
'struct hostif_start_confirm_t' is not used in this driver. Remove 'struct hostif_start_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.

[PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-03-30 Thread Quytelda Kahja
This macro, provided in 'linux/kernel.h', will calculate the size more succinctly than a division operation. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/d

[PATCH v2 09/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_value_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_mib_value_t' with 'struct hostif_mib_value'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h

[PATCH v2 08/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_get_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_mib_get_request_t' with 'struct hostif_mib_get_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/

[PATCH v2 11/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_set_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_mib_set_request_t' with 'struct hostif_mib_set_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/

[PATCH v2 02/75] staging: ks7010: Remove trailing _t from 'struct wpa_suite_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wpa_suite_t' with 'struct wpa_suite'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 fi

[PATCH v2 04/75] staging: ks7010: Remove trailing _t from 'struct pmk_cache_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct pmk_cache_t' with 'struct pmk_cache'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file

[PATCH v2 03/75] staging: ks7010: Remove trailing _t from 'struct rsn_mode_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct rsn_mode_t' with 'struct rsn_mode'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file

[PATCH v2 05/75] staging: ks7010: Remove trailing _t from 'struct hostif_data_request_t'.

2018-03-30 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_data_request_t' with 'struct hostif_data_request'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hos

RE: [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年3月30日 23:16 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com > Cc: a.ha...@samsung.com; shufan_...@richtek.com; Peter Chen > ; dev

RE: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-30 Thread Jun Li
> -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年3月30日 6:49 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; a.ha...@samsung.com; > shufan_...@richtek.com; Peter Chen ; > dev

Re: [PATCH] staging: lustre: libcfs: use dynamic minors for /dev/{lnet, obd}

2018-03-30 Thread NeilBrown
On Fri, Mar 30 2018, James Simmons wrote: > From: "John L. Hammond" > > Request dynamic minor allocation when registering /dev/lnet and > /dev/obd. > > Signed-off-by: John L. Hammond > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-100086 > Reviewed-on: https://review.whamcloud.com/29741 >

RE: [PATCH v4 04/13] usb: typec: add fwnode to tcpc

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年3月29日 20:58 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; li...@roeck-us.net; > a.ha...@samsung.com; shufan_...@richtek.com; Peter Chen > ; devicet...@vger.kernel.org;

RE: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年3月30日 5:19 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; shufan_...@richtek.com; Peter Chen > ; device

RE: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年3月30日 3:54 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; shufan_...@richtek.com; Peter Chen > ; device

RE: [PATCH v4 07/13] staging: typec: tcpci: register port before request irq

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: 2018年3月29日 18:52 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; > de...@driverdev.osuosl.org; devicet...@vger.kernel.org; Peter

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

2018-03-30 Thread Sridhar Pitchai
>On 3/30/18, 2:23 PM, "Bjorn Helgaas" wrote: > >On Fri, Mar 30, 2018 at 07:35:04PM +, Sridhar Pitchai wrote: > >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI > >domain") need to be reverted. Also, we no longer need it as commit >

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

2018-03-30 Thread Bjorn Helgaas
On Fri, Mar 30, 2018 at 07:35:04PM +, Sridhar Pitchai wrote: > >When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual > >PCI bus to the guest, Hyper-V always provides unique PCI domain. > > > >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain") > >o

[PATCH net-next] hv_netvsc: Clean up extra parameter from rndis_filter_receive_data()

2018-03-30 Thread Haiyang Zhang
From: Haiyang Zhang The variables, msg and data, have the same value. This patch removes the extra one. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/rndis_filter.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c b/d

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

2018-03-30 Thread Sridhar Pitchai
>When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual >PCI bus to the guest, Hyper-V always provides unique PCI domain. > >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain") >overrode unique domain with the serial number of the first device added >t

[PATCH] staging: lustre: libcfs: use dynamic minors for /dev/{lnet, obd}

2018-03-30 Thread James Simmons
From: "John L. Hammond" Request dynamic minor allocation when registering /dev/lnet and /dev/obd. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-100086 Reviewed-on: https://review.whamcloud.com/29741 Reviewed-by: Andreas Dilger Reviewed-by: Jian Yu Reviewed

Re: [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open

2018-03-30 Thread Guenter Roeck
On 03/28/2018 09:06 AM, Li Jun wrote: While set polarity, we should keep the not connecting cc line to be open. The more I look at this code, the more I am confused by it. The original code doesn't touch the CC lines. This function only sets the polarity. Is it really appropriate to touch th

[PATCH 7/8] staging: ks7010: factor out check for firmware running into ks7010_is_firmware_running

2018-03-30 Thread Sergio Paracuellos
This commit extracts process to check if firmware is running into a new inline function called ks7010_is_firmware_running. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drive

[PATCH 8/8] staging: ks7010: factor out firmware copy process into ks7010_copy_firmware

2018-03-30 Thread Sergio Paracuellos
This commit extracts firmware copy process into a new function ks7010_copy_firmware. Because rom_buf is only needed for this process, memory request for it has been also moved to this new function so the error handling label release_host_and_free has been renamed to release_host into ks7010_upload_

[PATCH 6/8] staging: ks7010: factor out initial enqueue process into ks7010_sme_enqueue_events

2018-03-30 Thread Sergio Paracuellos
This commit extract initial enqueue process into a new ks7010_sme_enqueue_events function. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/staging/ks7010/ks7

[PATCH 4/8] staging: ks7010: factor out irq setup process to ks7010_sdio_setup_irqs

2018-03-30 Thread Sergio Paracuellos
This commit extract sdio irq setup process into a new function ks7010_sdio_setup_irqs to improve readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/

[PATCH 5/8] staging: ks7010: factor out ks_wlan_private init process into ks7010_private_init

2018-03-30 Thread Sergio Paracuellos
This commit extract ks_wlan_private initialization process into a new function ks7010_private_init to improve a bit readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 50 1 file changed, 28 insertions(+), 22 deletions(-)

[PATCH 1/8] staging: ks7010: remove unnecessary 'out of memory' message

2018-03-30 Thread Sergio Paracuellos
This commit removes unnecessay out of memory message fixing the following checkpach.pl warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/

[PATCH 0/8] staging: ks7010: factor out some functions

2018-03-30 Thread Sergio Paracuellos
This patch series factors out some functions to improve a bit readability in ks7010_sdio source file. Sergio Paracuellos (8): staging: ks7010: remove unnecessary 'out of memory' message staging: ks7010: factor out irq enable process to ks7010_sdio_init_irqs staging: ks7010: fix label to

[PATCH 3/8] staging: ks7010: fix label to jump to in error case

2018-03-30 Thread Sergio Paracuellos
This commit fixs the label to jump to when in case an error occurs disabling interrupts. At this point of the code sdio_enable_func() function has been successfully called. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele

[PATCH 2/8] staging: ks7010: factor out irq enable process to ks7010_sdio_init_irqs

2018-03-30 Thread Sergio Paracuellos
This commit extracts sdio irq enable process to a new function ks7010_sdio_init_irqs to improve readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 43 ++-- 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/drive

Re: [PATCH v6 6/6] Staging: iio: adis16209: Move adis16209 driver out of staging

2018-03-30 Thread Jonathan Cameron
On Thu, 29 Mar 2018 14:52:51 +0530 Shreeya Patel wrote: > Move the adis16209 driver out of staging directory and merge to the > mainline IIO subsystem. > > Signed-off-by: Shreeya Patel Other than fixing up for the patch 5 indentation change there was some 'fuzz' due to the adis16201 moving befo

Re: [PATCH v6 5/6] Staging: iio: adis16209: Use GENMASK

2018-03-30 Thread Jonathan Cameron
On Thu, 29 Mar 2018 14:51:19 +0530 Shreeya Patel wrote: > Use GENMASK to improve readability and remove the local > variables used to store intermediate data. > > Signed-off-by: Shreeya Patel See below. Fixed up and applied to the togreg branch of iio.git and pushed out as testing for the auto

  1   2   >