Re: [PATCH v2 71/75] staging: ks7010: Remove dummy address set.

On Sat, Mar 31, 2018 at 11:46:40AM +0300, Dan Carpenter wrote: > On Fri, Mar 30, 2018 at 11:08:51PM -0700, Quytelda Kahja wrote: > > Setting a dummy address during the driver probe is not necessary. > > The dev_addr field is already zeroed out from alloc_etherdev(). > > > > Signed-off-by:

Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

On Mon, Apr 02 2018, Christian Lütke-Stetzkamp wrote: > On Mon, Apr 02, 2018 at 01:41:33PM +1000, NeilBrown wrote: >> On Mon, Apr 02 2018, Sean Wang wrote: >> > Hi, Neil >> > >> > Forgive me I cannot find the cover letter in the original series in my >> > mailbox to make a reply, so I rudely made

Re: [PATCH 15/15] ARM: pxa: change SSP DMA channels allocation

://github.com/0day-ci/linux/commits/Robert-Jarzmik/ARM-pxa-switch-to-DMA-slave-maps/20180402-233029 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

[PATCH 17/34] staging: mt7621-mmc: Remove redundant driver owner assignment

Remove the owner assignment form the platform driver as platform_driver_register() already initializes the owner. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/mt7621-mmc/sd.c

[PATCH 27/34] staging: mt7621-mmc: Fix bug on dma_alloc_coherent fail

In case of dma_alloc_coherent failing the current code just called BUG_ON. By adding error handling for that case this can be avoided. This also fixes a memory leek in case of a fail later on in the probe function. Signed-off-by: Christian Lütke-Stetzkamp ---

[PATCH 07/34] staging: mt7621-mmc: Fix indent for board.h

This fixes the indentaions in the file board.h Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/board.h | 68 +++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/staging/mt7621-mmc/board.h

[PATCH 11/34] staging: mt7621-mmc: Fix spacing

Fixes checkpatch errors, warnings, checks: SPACING, LEADING_SPACE, LINE_SPACING Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/board.h | 3 +- drivers/staging/mt7621-mmc/dbg.c | 67 - drivers/staging/mt7621-mmc/dbg.h | 16

[PATCH 23/34] staging: mt7621-mmc: Refactor suspend, resume

Refactor msdc_drv_{suspend, resume} by adding a new function msdc_drv_pm, that cleans up the code and removes double code. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 26 +++--- 1 file changed, 11 insertions(+), 15

[PATCH 28/34] staging: mt7621-mmc: Remove unnecessary setting of dev.platform_data

In the probe function, pdev->dev.platform_data is set to _hw, but the only get access to that is also in the probe function. So that assignment is removed. The msdc0_hw structure is still available to the driver as part of the msdc_host structure. Signed-off-by: Christian Lütke-Stetzkamp

[PATCH 13/34] staging: mt7621-mmc: Remove unnecessary typedefs

Fixes checkpatch warning: NEW_TYPEDEFS Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.c | 2 +- drivers/staging/mt7621-mmc/dbg.h | 11 +- drivers/staging/mt7621-mmc/mt6575_sd.h | 305 +++--

[PATCH 26/34] staging: mt7621-mmc: Fix unmatched release_mem_regin

Current code calls release_mem_regin on driver remove without requesting it explicit first. The region is only requested via devm_ioremap_resource and that releases it automatically. Removing the release_mem_region calls fixes this. Signed-off-by: Christian Lütke-Stetzkamp

[PATCH 24/34] staging: mt7621-mmc: Fix memory leek in case of error in probe

If the base address is not successfully obtained in the probe function, then the mmc_host struct is not freed. Adding an exit for that case fixes the bug. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 7 +-- 1 file changed, 5

[PATCH 32/34] staging: mt7621-mmc: Fix dma_alloc_coherent should get device as first param

The dma_alloc_coherent (and also dma_free_coherent) should get the device, the dma memory is allocated for as the first parameter. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 18 -- 1 file changed, 12 insertions(+), 6

[PATCH 01/34] staging: mt7621-mmc: Remove whitespace errors in board.h

The whitespace errors in the file board.h are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/board.h | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH 06/34] staging: mt7621-mmc: Fix indent for dbg.c

This fixes the indentaions in the file dbg.c Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.c | 258 +++ 1 file changed, 129 insertions(+), 129 deletions(-) diff --git a/drivers/staging/mt7621-mmc/dbg.c

[PATCH 22/34] staging: mt7621-mmc: Cleanup function mt_msdc_init

Cleanup the mt_msdc_init function, remove excceding printk. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index

[PATCH 14/34] staging: mt7621-mmc: Fix trailing statements

Fix checkpatch error: TRAILING_STATEMENTS Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.c | 25 ++--- drivers/staging/mt7621-mmc/dbg.h | 3 ++- drivers/staging/mt7621-mmc/sd.c | 39 ++- 3

[PATCH 16/34] staging: mt7621-mmc: Fix style of braces

Fix checkpatch errors, warnings, checks about braces: BRACES, ELSE_AFTER_BRACE, OPEN_BRACE Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.c | 31 +++ drivers/staging/mt7621-mmc/mt6575_sd.h | 3 +- drivers/staging/mt7621-mmc/sd.c

[PATCH 08/34] staging: mt7621-mmc: Fix indent for dbg.h

This fixes the indentaions in the file dbg.h Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.h | 60 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/mt7621-mmc/dbg.h

[PATCH 34/34] staging: mt7621-mmc: Remove duplicate defines

Remove defines that are both in board.h and sd.c from sd.c, this file already includes board.h Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c

[PATCH 20/34] staging: mt7621-mmc: Remove code for different soc types

Remove code that is intended for soc other then the mt7621 because this driver is only for that soc. This also removes some conditions. However the remaining code is also at the wrong place, it just selects the mode of the pins, this is a job for pinctl not for the sdxc driver. Signed-off-by:

[PATCH 18/34] staging: mt7621-mmc: Replace seq_printf with seq_puts where possible

Replace seq_printf with seq_puts when the string is const. Fix checkpatch warning: PREFER_SEQ_PUTS Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH 12/34] staging: mt7621-mmc: Fix Pointer Location

Fix checkpatch error: POINTER_LOCATION Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/board.h | 2 +- drivers/staging/mt7621-mmc/dbg.c | 8 +++--- drivers/staging/mt7621-mmc/sd.c| 56 +++--- 3 files changed, 33

[PATCH 33/34] staging: mt7621-mmc: Fix requesting of irq

The request of the irq line is not correctly handled by the current code, platform_get_irq may fail and if the irq is requested via devm_request_irq, its release is automatically done. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 29

[PATCH 19/34] staging: mt7621-mmc: Remove code guarded by nonexistent config option

Remove a piece of code that is guarded by a config option, that is nonexistent, the function it calls is also nonexistent. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[PATCH 25/34] staging: mt7621-mmc: Remove code checking for old kernel versions

Remove code, that is checking for old kernel versions, leaving only the case for current versions. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 03/34] staging: mt7621-mmc: Remove whitespace errors in dbg.h

The whitespace errors in the file dbg.h are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.h | 38 +++--- 1 file

[PATCH 09/34] staging: mt7621-mmc: Fix indent for mt6575_sd.h

This fixes the indentaions in the file mt7621_sd.h Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/mt6575_sd.h | 820 - 1 file changed, 410 insertions(+), 410 deletions(-) diff --git

[PATCH 04/34] staging: mt7621-mmc: Remove whitespace errors in mt6575_sd.h

The whitespace errors in the file mt6575_sd.h are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/mt6575_sd.h | 49 +- 1

[PATCH 29/34] staging: mt7621-mmc: Remove unnecessary field from struct msdc_hw

Remove the unnecessary field data_pins from msdc_hw, later this information should be taken from the device tree. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/board.h | 1 - drivers/staging/mt7621-mmc/sd.c| 10 -- 2 files changed, 4

[PATCH 30/34] staging: mt7621-mmc: Fix different caps for different devices

Current code saves the need for polling in a global variable, that leeds to problems, when the driver should handle multiple devices with different capabilities. By looking up the capability in the mmc_host capabilities, they now have per device scope. Signed-off-by: Christian Lütke-Stetzkamp

[PATCH 15/34] staging: mt7621-mmc: Remove global initialise to 0

Fix checkpatch error: GLOBAL_INITIALISERS Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c index

[PATCH 05/34] staging: mt7621-mmc: Remove whitespace errors in sd.c

The whitespace errors in the file sd.c are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 1142 +++ 1 file

[PATCH 31/34] staging: mt7621-mmc: Remove dead codepath from probe function

The probe function contains lots of code, that is never used, because the fields it checks for in the msdc_hw structure are never initialized. Removing them should be safe. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 20

[PATCH 00/34] staging: mt7621-mmc: First cleanups

This patch series does the first cleanups in this driver. At some points I already tried to get the code of this driver as near as possible to the mk-sd driver in mainline. Christian Lütke-Stetzkamp (34): staging: mt7621-mmc: Remove whitespace errors in board.h staging: mt7621-mmc: Remove

[PATCH 02/34] staging: mt7621-mmc: Remove whitespace errors in dbg.c

The whitespace errors in the file dbg.c are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/dbg.c | 190 +++ 1 file

[PATCH 21/34] staging: mt7621-mmc: Remove unused datastructures

Remove unused datastructures and comments referring to their former use. Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-mmc/sd.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c

Re: [PATCH 12/15] dmaengine: pxa: make the filter function internal

: https://github.com/0day-ci/linux/commits/Robert-Jarzmik/ARM-pxa-switch-to-DMA-slave-maps/20180402-233029 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/mt

Re: [PATCH 12/15] dmaengine: pxa: make the filter function internal

://github.com/0day-ci/linux/commits/Robert-Jarzmik/ARM-pxa-switch-to-DMA-slave-maps/20180402-233029 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

On Mon, 2018-04-02 at 14:45 +0300, Dan Carpenter wrote: > On Sat, Mar 31, 2018 at 07:12:53AM -0700, Joe Perches wrote: > > On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote: > > > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > > > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda

[PATCH 15/15] ARM: pxa: change SSP DMA channels allocation

Now the dma_slave_map is available for PXA architecture, switch the SSP device to it. This specifically means that : - for platform data based machines, the DMA requestor channels are extracted from platform data and passed further to the SSP user, ie. usually the pxa-pcm-audio driver - for

[PATCH 14/15] ARM: pxa: change SSP devices allocation

In order to prepare for the dma_slave_map change for SSP DMA channels allocation, the SSP platform devices will now include a platform data structure which in turn selects which dma channel has to be used for data transfers, especially the PCM ones. Signed-off-by: Robert Jarzmik

[PATCH 12/15] dmaengine: pxa: make the filter function internal

As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5

[PATCH 13/15] ARM: pxa: remove the DMA IO resources

As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 136

[PATCH 11/15] dmaengine: pxa: document pxad_param

Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 07/15] net: smc91x: remove the dmaengine compat need

From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more

[PATCH 06/15] net: smc911x: remove the dmaengine compat need

From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more

[PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need

As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel().

[PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel().

[PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel().

[PATCH 01/15] dmaengine: pxa: use a dma slave map

In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This won't impact MMP architecture, but is aimed only at all PXA boards. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static,

[PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more

[PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more

[PATCH 03/15] mmc: pxamci: remove the dmaengine compat need

As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel().

[PATCH 00/15] ARM: pxa: switch to DMA slave maps

Hi, This serie is aimed at removing the dmaengine slave compat use, and transfer knowledge of the DMA requestors into architecture code. This was discussed/advised by Arnd a couple of years back, it's almost time. The serie is divided in 3 phasees : - phase 1 : patch 1/15 and patch 2/15 =>

[PATCH 02/15] ARM: pxa: add dma slave map

In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

On Sat, Mar 31, 2018 at 07:12:53AM -0700, Joe Perches wrote: > On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote: > > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > > > > This macro, provided in 'linux/kernel.h',

Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

On Mon, Apr 02, 2018 at 01:41:33PM +1000, NeilBrown wrote: > On Mon, Apr 02 2018, Sean Wang wrote: > > Hi, Neil > > > > Forgive me I cannot find the cover letter in the original series in my > > mailbox to make a reply, so I rudely made here just letting you know > > something good to the growth