[PATCH] staging: ks7010: replace kmalloc() + memcpy() with kmemdup()

2018-04-05 Thread Ji-Hun Kim
Use kmemdup rather than duplicating its implementation. Signed-off-by: Ji-Hun Kim --- drivers/staging/ks7010/ks7010_sdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index b8f55a1..c8eb55b 100

Re: [PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts

2018-04-05 Thread David Miller
From: Mohammed Gamal Date: Thu, 5 Apr 2018 21:09:17 +0200 > Guests running on WS2012 hosts would not shutdown when changing network > interface setting (e.g. Number of channels, MTU ... etc). > > This patch series addresses these shutdown issues we enecountered with WS2012 > hosts. It's essent

Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation

2018-04-05 Thread David Miller
From: Haiyang Zhang Date: Thu, 5 Apr 2018 11:42:22 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 message structures, and includes this > version into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang Zhang The net-next tree is closed, please resubmit this

Re: [PATCH v2 17/19] media: omap4iss: make it build with COMPILE_TEST

2018-04-05 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Thursday, 5 April 2018 23:29:44 EEST Mauro Carvalho Chehab wrote: > This driver compile as-is with COMPILE_TEST. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Laurent Pinchart I don't have patches pending for the omap4iss driver, could you merge thi

[PATCH v2 17/19] media: omap4iss: make it build with COMPILE_TEST

2018-04-05 Thread Mauro Carvalho Chehab
This driver compile as-is with COMPILE_TEST. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/omap4iss/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig index 46183464ee79..

[PATCH v2 19/19] media: staging: davinci_vpfe: allow building with COMPILE_TEST

2018-04-05 Thread Mauro Carvalho Chehab
This is a little bit hashish, but this driver is at staging, so it won't become worse. With this small change at Makefile, we can now build it with COMPILE_TEST. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/davinci_vpfe/Kconfig | 3 ++- drivers/staging/media/davinci_vpfe/Make

[PATCH 4/4] hv_netvsc: Pass net_device parameter to revoke and teardown functions

2018-04-05 Thread Mohammed Gamal
The callers to netvsc_revoke_*_buf() and netvsc_teardown_*_gpadl() already have their net_device instances. Pass them as a paramaeter to the function instead of obtaining them from netvsc_device struct everytime Signed-off-by: Mohammed Gamal --- drivers/net/hyperv/netvsc.c | 37 +

[PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts

2018-04-05 Thread Mohammed Gamal
Guests running on WS2012 hosts would not shutdown when changing network interface setting (e.g. Number of channels, MTU ... etc). This patch series addresses these shutdown issues we enecountered with WS2012 hosts. It's essentialy a rework of the series sent in https://lkml.org/lkml/2018/1/23/11

[PATCH 3/4] hv_netvsc: Ensure correct teardown message sequence order

2018-04-05 Thread Mohammed Gamal
Prior to commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split") the call sequence in netvsc_device_remove() was as follows (as implemented in netvsc_destroy_buf()): 1- Send NVSP_MSG1_TYPE_REVOKE_RECV_BUF message 2- Teardown receive buffer GPADL 3- Send NVSP_MSG1_TYPE_REVOKE_SEND_BUF messa

[PATCH 2/4] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()

2018-04-05 Thread Mohammed Gamal
Split each of the functions into two for each of send/recv buffers. This will be needed in order to implement a fine-grained messaging sequence to the host so tht we accommodate the requirements of different Windows versions Fixes: 0ef58b0a05c12 ("hv_netvsc: change GPAD teardown order on older ver

[PATCH 1/4] hv_netvsc: Use Windows version instead of NVSP version on GPAD teardown

2018-04-05 Thread Mohammed Gamal
When changing network interface settings, Windows guests older than WS2016 can no longer shutdown. This was addressed by commit 0ef58b0a05c12 ("hv_netvsc: change GPAD teardown order on older versions"), however the issue also occurs on WS2012 guests that share NVSP protocol versions with WS2016 gue

[PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation

2018-04-05 Thread Haiyang Zhang
From: Haiyang Zhang This patch adds the NetVSP v6 message structures, and includes this version into NetVSC/NetVSP version negotiation process. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 33 + drivers/net/hyperv/netvsc.c | 3 ++- 2 f

Re: [bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

2018-04-05 Thread Christian Lütke-Stetzkamp
On Thu, Apr 05, 2018 at 02:56:54PM +0300, Dan Carpenter wrote: > Hello John Crispin, > > The patch 8b634a9c7620: "staging: mt7621-mmc: MIPS: ralink: add sdhci > for mt7620a SoC" from Mar 15, 2018, leads to the following static > checker warning: > > drivers/staging/mt7621-mmc/sd.c:2790 msdc

Re: [bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

2018-04-05 Thread Christian Lütke-Stetzkamp
On Thu, Apr 05, 2018 at 03:13:10PM +0300, Dan Carpenter wrote: > [ I just decided to forward you guys all the Smatch warnings. -dan ] > > Hello John Crispin, > > The patch 8b634a9c7620: "staging: mt7621-mmc: MIPS: ralink: add sdhci > for mt7620a SoC" from Mar 15, 2018, leads to the following sta

Re: [GIT PULL] Staging/IIO driver changes for 4.17-rc1

2018-04-05 Thread Greg KH
On Wed, Apr 04, 2018 at 07:00:14PM -0700, Linus Torvalds wrote: > On Wed, Apr 4, 2018 at 3:32 AM, Greg KH wrote: > > > > It is a lot, over 500 changes, but not huge by previous kernel release > > standards. We deleted more lines than we added again (27k added vs. 91k > > remvoed), thanks to final

Re: [bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

2018-04-05 Thread John Crispin
Hi Dan, I explained why I think this should not be merged, i do not plan to fix any issues, please send all maintenance requests towards NeilBrown. And .. it was merged it with an out dated defunct mail addr of mine.     John On 05/04/18 14:13, Dan Carpenter wrote: [ I just decided to forw

Re: [bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

2018-04-05 Thread John Crispin
Hi Dan, I explained why I think this should not be merged, i do not plan to fix any issues, please send all maintenance requests towards NeilBrown. And .. it was merged it with an out dated defunct mail addr of mine.     John On 05/04/18 13:56, Dan Carpenter wrote: Hello John Crispin, Th

[bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

2018-04-05 Thread Dan Carpenter
[ I just decided to forward you guys all the Smatch warnings. -dan ] Hello John Crispin, The patch 8b634a9c7620: "staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC" from Mar 15, 2018, leads to the following static checker warning: drivers/staging/mt7621-mmc/sd.c:951 msdc_comm

[bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

2018-04-05 Thread Dan Carpenter
Hello John Crispin, The patch 8b634a9c7620: "staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC" from Mar 15, 2018, leads to the following static checker warning: drivers/staging/mt7621-mmc/sd.c:2790 msdc_drv_probe() warn: curly braces intended? drivers/staging/mt7621-m

Re: [PATCH v5 1/2] staging: vt6655: check for memory allocation failures

2018-04-05 Thread Dan Carpenter
Thanks. These look good. And to me, it's really easy to review now. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v5 2/2] staging: vt6655: add handling memory leak on vnt_start()

2018-04-05 Thread Ji-Hun Kim
There was no code for handling memory leaks of device_init_rings() and request_irq(). It needs to free allocated memory in the device_init_rings() , when request_irq() would be failed. Add freeing sequences of irq and device init rings. Signed-off-by: Ji-Hun Kim --- It's additional memory leak ha

[PATCH v5 1/2] staging: vt6655: check for memory allocation failures

2018-04-05 Thread Ji-Hun Kim
There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Implement error handling code on device_init_rd*, device_init_td* and vnt_start for the allocation failures. Signed-off-by: Ji-Hun Kim --- Changes v