Re: [PATCH v3 05/11] staging: mt7621-gpio: avoid use of globals and use platform_data instead

2018-05-19 Thread NeilBrown
On Sat, May 19 2018, Sergio Paracuellos wrote: > On Sat, May 19, 2018 at 08:51:43PM +1000, NeilBrown wrote: >> On Wed, May 16 2018, Sergio Paracuellos wrote: >> >> > Gpio driver have a some globals which can be avoided just >> > using platform_data in a proper form. This commit adds a new >> > st

[PATCH] Staging: rtl8192e: rtllib_tx: fix spelling issue.

2018-05-19 Thread Davide spataro
Fix a spelling warning from checkpatch.pl. Signed-off-by: Davide Spataro --- drivers/staging/rtl8192e/rtllib_tx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index fc88d47dea43..d3

Re: [PATCH v3 05/11] staging: mt7621-gpio: avoid use of globals and use platform_data instead

2018-05-19 Thread Sergio Paracuellos
On Sat, May 19, 2018 at 08:51:43PM +1000, NeilBrown wrote: > On Wed, May 16 2018, Sergio Paracuellos wrote: > > > Gpio driver have a some globals which can be avoided just > > using platform_data in a proper form. This commit adds a new > > struct mtk_data which includes all of those globals setti

[PATCH v4 02/11] staging: mt7621-gpio: update TODO file

2018-05-19 Thread Sergio Paracuellos
This commit updates TODO file with missing things to get this driver ready to be mainlined. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/TODO | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio

[PATCH v4 04/11] staging: mt7621-gpio: replace 'mtk' to use correct one 'mediatek'

2018-05-19 Thread Sergio Paracuellos
Gpio driver is using mtk and there is already 'mediatek' binding defined for this maker. Update driver to use it instead the custom one 'mtk'. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v4 09/11] staging: mt7621-gpio: use ternary operator in return in mediatek_gpio_get_direction

2018-05-19 Thread Sergio Paracuellos
This commits replaces if statement and two returns in favour of a only one return using a ternary operator. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-gpio/gpio-mt7

[PATCH v4 01/11] staging: mt7621-gpio: dt-bindings: add documentation for mt7621-gpio

2018-05-19 Thread Sergio Paracuellos
This commit add missing dt bindings documentation for mt7621-gpio driver. There is some missing stuff here about interrupts with is not also being used in the mt7621.dtsi file. So just include in staging a incomplete version before moving this to kernel's dt-bindings place. Signed-off-by: Sergio P

[PATCH v4 08/11] staging: mt7621-gpio: avoid devm_kzalloc() hidden inside declarations and refactor function a bit

2018-05-19 Thread Sergio Paracuellos
Driver probe function includes an allocation using devm_kzalloc which is "hidden" a bit inside the declarations. Extract this to a better place to increase readability. Also because we are allocating zeroed memory 'memset' statement is not needed at all. Condition for checking for a valid gpio id i

[PATCH v4 00/11] staging: mt7621-gpio: use mediatek as binding instead of custom mtk

2018-05-19 Thread Sergio Paracuellos
The following series updated mt7621-gpio driver to use 'mediatek' which is already defined in kernel bindings documentation instead of add a new custom one 'mtk' for this company. mt7621-gpio device-tree documentation has been added also to the staging driver directory. v4: - Only PATCH 5 ("stagi

[PATCH v4 06/11] staging: mt7621-dts: add interrupt device tree nodes for the gpio controller

2018-05-19 Thread Sergio Paracuellos
The GPIO controller of mt7621 can receive interrupts on any of the GPIOs, either edge or level. It then interrupts the CPU using GIC INT12. Update device tree accordly. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --g

[PATCH v4 10/11] staging: mt7621-gpio: use MTK_BANK_WIDTH instead of magic number

2018-05-19 Thread Sergio Paracuellos
There are some places where magic number '32' is being used to get the gpio bank. There already exist a definition MTK_BANK_WIDTH with this value, so just use it instead. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 6 +++--- 1 file changed, 3 insertions(+),

[PATCH v4 03/11] staging: mt7621-dts: update gpios related entries to use 'mediatek'

2018-05-19 Thread Sergio Paracuellos
Gpio driver for mt7621 is using 'mtk' as binding but in the kernel is already defined one for this maker which is 'mediatek'. Update device tree to use the correct one. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 8 1 file changed, 4 insertions(+), 4 d

[PATCH v4 05/11] staging: mt7621-gpio: avoid use of globals and use platform_data instead

2018-05-19 Thread Sergio Paracuellos
Gpio driver have a some globals which can be avoided just using platform_data in a proper form. This commit adds a new struct mtk_data which includes all of those globals setting them using platform_set_drvdata and devm_gpiochip_add_data functions. With this properly set we are able to retrieve dri

[PATCH v4 11/11] staging: mt7621-gpio: update TODO list

2018-05-19 Thread Sergio Paracuellos
Some of the remaining stuff included in TODO list have been complete. So update this file accordly. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/TODO | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio/TODO ind

[PATCH v4 07/11] staging: mt7621-gpio: dt-bindings: add interrupt nodes to bindings doc

2018-05-19 Thread Sergio Paracuellos
Interrupt related stuff for gpio controller in mt7621 was missing in device tree documentation. Add it to complete documentation for this driver. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/mediatek,mt7621-gpio.txt | 9 - 1 file changed, 8 insertions(+), 1 deletion(

[PATCH v4 00/11] staging: mt7621-gpio: use mediatek as binding instead of custom mtk

2018-05-19 Thread Sergio Paracuellos
The following series updated mt7621-gpio driver to use 'mediatek' which is already defined in kernel bindings documentation instead of add a new custom one 'mtk' for this company. mt7621-gpio device-tree documentation has been added also to the staging driver directory. v4: - Only PATCH 5 ("stagi

Re: [PATCH v3 05/11] staging: mt7621-gpio: avoid use of globals and use platform_data instead

2018-05-19 Thread NeilBrown
On Wed, May 16 2018, Sergio Paracuellos wrote: > Gpio driver have a some globals which can be avoided just > using platform_data in a proper form. This commit adds a new > struct mtk_data which includes all of those globals setting them > using platform_set_drvdata and devm_gpiochip_add_data funct

Re: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-19 Thread Greg KH
On Fri, May 18, 2018 at 09:00:51PM +, Sunil Muthuswamy wrote: > Thanks, Greg. > > My first patch to the Linux kernel. Still making mistakes, but, learning > through the documented process. > > > -Original Message- > > From: Greg KH > > Sent: Wednesday, May 9, 2018 11:51 PM > > To: S

Re: [PATCH v2] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-19 Thread Greg KH
On Fri, May 18, 2018 at 07:09:10PM +, Sunil Muthuswamy wrote: > In the VM mode on Hyper-V, currently, when the kernel panics, an error > code and few register values are populated in an MSR and the Hypervisor > notified. This information is collected on the host. The amount of > information cur