[PATCH 6/6] staging: mt7621-gpio: reorder includes alphabetically

This commit reviews driver includes reordering them in alphabetic order. This improves readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 4/6] staging: mt7621-gpio: use GPIOF_DIR_OUT and GPIOF_DIR_IN macros instead of custom values

There are macros in gpio kernel's headers to define direction of a gpio. Use them instead of return custom '0' and '1' values. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 1/6] staging: mt7621-dts: fix property #interrupt-cells for the gpio node

Most gpio chips have two cells for interrupts and this should be also. Set this property accordly fixing this up. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 5/6] staging: mt7621-gpio: change gc_map to don't use pointers

There is no special gain in using pointers for 'gc_map' inside 'mtk_data' structure. We know the number of banks which is fixed to MTK_BANK_CNT and we can just statically allocate them without using kernel allocators. Signed-off-by: Sergio Paracuellos ---

[PATCH 0/6] staging: mt7621-gpio: last cleanups

The following series performs last cleanups pointed out in this mail by NeilBrown: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-May/121282.html If this is ok and after testing this driver should be ready to go out of staging. Please, note that this has to eb applied

[PATCH 3/6] staging: mt7621-gpio: change 'to_mediatek_gpio' to make just a one line return

Function to_mediatek_gpio can directly return without declaring anything else in its body improving readability. Also change pointer '*' declaration to be with return type in the upper line. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 10 +++--- 1 file

[PATCH 2/6] staging: mt7621-gpio: dt-bindings: update documentation for #interrupt-cells property

This commit update documentation for #interrupt-cells property in the gpio node which has been changed from '1' to '2'. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/mediatek,mt7621-gpio.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

RE: [PATCH] PCI: hv: Do not wait forever on a device that has disappeared

> > Before the guest finishes the device initialization, the device can be > removed anytime by the host, and after that the host won't respond to > the guest's request, so the guest should be prepared to handle this > case. > > Signed-off-by: Dexuan Cui > Cc: Stephen Hemminger > Cc: K. Y.

Re: [PATCH v2] staging: speakup: remove simple_strtoul()

/linux/commits/Gabriel-Fedel/staging-speakup-remove-simple_strtoul/20180528-231304 coccinelle warnings: (new ones prefixed by >>) >> drivers/staging/speakup/kobjects.c:163:2-5: alloc with no test, possible >> model on line 146 drivers/staging/speakup/kobjects.c:163:2-5:

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

Jason Gunthorpe wrote: On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote: On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a >

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

On Fri, May 25, 2018 at 11:29:59PM +0200, Arnd Bergmann wrote: > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a > link error when another driver using it is built-in. The > INFINIBAND_ADDR_TRANS

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote: > On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: > > > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a > > link

[PATCH net-next v3 3/7] rocker: rocker_main: Ignore bridge VLAN events

Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c

[PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

A driver might need to react to changes in settings of brentry VLANs. Therefore send switchdev port notifications for these as well. Reuse SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use netif_is_bridge_master() on orig_dev to determine whether the notification is about a bridge

[PATCH net-next v3 5/7] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c

[PATCH net-next v3 4/7] dsa: port: Ignore bridge VLAN events

Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata Reviewed-by: Vivien Didelot --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/port.c index

[PATCH net-next v3 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

Since there's no special support for the bridge events, the driver returns -EOPNOTSUPP, and thus the commit never happens. Therefore schedule respin during the prepare stage: there's no real difference one way or another. This fixes the problem that mirror-to-gretap offload wouldn't adapt to

[PATCH net-next v3 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH net-next v3 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves initializing a struct switchdev_obj_port_vlan, a piece of code that repeats on each call site almost verbatim. While in the current codebase there is just one duplicated add call, the follow-up patches add more of both add and

[PATCH net-next v3 0/7] net: bridge: Notify about bridge VLANs

In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap mirror"), mlxsw got support for offloading mirror-to-gretap such that the underlay packet path involves a bridge. In that case, the offload is also influenced by PVID setting of said bridge. However, changes to VLAN

Re: [PATCH] staging:r8188eu: Use lib80211 to encrypt (WEP) tx frames

On Mon, May 28, 2018 at 09:18:21AM +0300, Ivan Safonov wrote: > Put data to skb, decrypt with lib80211_crypt_wep, and place back to tx buffer. > > Signed-off-by: Ivan Safonov > --- > drivers/staging/rtl8188eu/core/rtw_security.c | 72 > --- > 1 file

Re: [PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

Petr Machata writes: > diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h > index 11520ed..33bd914 100644 > --- a/net/bridge/br_private.h > +++ b/net/bridge/br_private.h > @@ -1178,6 +1178,9 @@ static inline void br_switchdev_frame_unmark(struct > sk_buff *skb) >

Re: [PATCH v2] staging: speakup: remove simple_strtoul()

The original code is fine. Just ignore checkpatch.pl. You added some kmalloc()s without a freeing the memory afterward. It's all way more complicated than it looks... regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

[PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c

[PATCH net-next v2 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

Since there's no special support for the bridge events, the driver returns -EOPNOTSUPP, and thus the commit never happens. Therefore schedule respin during the prepare stage: there's no real difference one way or another. This fixes the problem that mirror-to-gretap offload wouldn't adapt to

[PATCH net-next v2 6/7] net: bridge: Notify about bridge VLANs

A driver might need to react to changes in settings of brentry VLANs. Therefore send switchdev port notifications for these as well. Reuse SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use netif_is_bridge_master() on orig_dev to determine whether the notification is about a bridge

[PATCH net-next v2 0/7] net: bridge: Notify about bridge VLANs

In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap mirror"), mlxsw got support for offloading mirror-to-gretap such that the underlay packet path involves a bridge. In that case, the offload is also influenced by PVID setting of said bridge. However, changes to VLAN

[PATCH net-next v2 5/7] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c

[PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves initializing a struct switchdev_obj_port_vlan, a piece of code that repeats on each call site almost verbatim. While in the current codebase there is just one duplicated add call, the follow-up patches add more of both add and

[PATCH net-next v2 4/7] dsa: port: Ignore bridge VLAN events

Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata Reviewed-by: Vivien Didelot --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/port.c index

[PATCH net-next v2 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

Vivien Didelot writes: > Hi Petr, > > Petr Machata writes: > >> Vivien Didelot writes: >> + } else { + err = br_switchdev_port_obj_add(dev, v->vid, flags); + if (err

[PATCH] staging:r8188eu: Use lib80211 to encrypt (WEP) tx frames

Put data to skb, decrypt with lib80211_crypt_wep, and place back to tx buffer. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_security.c | 72 --- 1 file changed, 43 insertions(+), 29 deletions(-) diff --git