Re: [greybus-dev] [PATCH] Staging:greybus Fix comparison to NULL

2018-06-04 Thread Viresh Kumar
On 03-06-18, 08:52, Janani Sankara Babu wrote: > This patch replaces comparison of var to NULL with !var > > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/greybus/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/core.c

rf69_set_deviation in rf69.c (pi433 driver)

2018-06-04 Thread Hugo Lefeuvre
Hi Marcus, I have been taking a look at the pi433 driver these last days, and started working on the remaining TODOs. I just stumbled across the following one (drivers/staging/pi433/rf69.c): 245 // TODO: Dependency to bitrate 246 if (deviation < 600 || deviation > 50) { 247

Re: [PATCH 2/2] staging: mt7621-dts: Match pcie format to mt7623.dtsi

2018-06-04 Thread NeilBrown
On Mon, Jun 04 2018, Rosen Penev wrote: > This currently fixes the remaining dtb warnings: > > Node /pcie@1e14/pcie0 has a reg or ranges property, but no unit name > Node /pcie@1e14/pcie1 has a reg or ranges property, but no unit name > Node /pcie@1e14/pcie2 has a reg or ranges

Re: [PATCH 1/2] staging: mt7621-dts: Fix several dts warnings

2018-06-04 Thread NeilBrown
On Mon, Jun 04 2018, Rosen Penev wrote: > Node /cpus/cpu@0 has a unit name, but no reg property > Node /cpus/cpu@1 has a unit name, but no reg property > Node /cpuintc@0 has a unit name, but no reg property > Node /cpuclock@0 has a unit name, but no reg property > Node /sysclock@0 has a unit

[PATCH 2/2] staging: mt7621-dts: Match pcie format to mt7623.dtsi

2018-06-04 Thread Rosen Penev
This currently fixes the remaining dtb warnings: Node /pcie@1e14/pcie0 has a reg or ranges property, but no unit name Node /pcie@1e14/pcie1 has a reg or ranges property, but no unit name Node /pcie@1e14/pcie2 has a reg or ranges property, but no unit name Node /pcie@1e14/pcie0

[PATCH 1/2] staging: mt7621-dts: Fix several dts warnings

2018-06-04 Thread Rosen Penev
Node /cpus/cpu@0 has a unit name, but no reg property Node /cpus/cpu@1 has a unit name, but no reg property Node /cpuintc@0 has a unit name, but no reg property Node /cpuclock@0 has a unit name, but no reg property Node /sysclock@0 has a unit name, but no reg property I tried to match what is in

Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-06-04 Thread Thibaut Robert
Le mercredi 30 mai 2018 à 14:17:25 (+0300), Dan Carpenter a écrit : > On Tue, May 29, 2018 at 09:11:43PM +0200, Thibaut Robert wrote: > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > index e248702ee519..745bf5ca2622

Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-06-04 Thread Thibaut Robert
Le lundi 04 juin 2018 à 10:55:49 (+0530), Ajay Singh a écrit : > > Thank you for submitting the patches. > > The modification in this patch looks okay to me. > Please resend this by including changes as suggested by Dan. > I can do the modification and resubmit this patch by including review >

Re: [PATCH] staging: fwserial: fix checkpatch alignment check

2018-06-04 Thread Dan Carpenter
On Sun, Jan 01, 2017 at 01:00:59AM +, Abdul Rauf wrote: > Fix the following checks: > Alignment should match open parenthesis. > > Signed-off-by: Abdul Rauf > --- > drivers/staging/fwserial/fwserial.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-04 Thread Samuel Thibault
Hello, Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit: > The synths[] array is a collection of synths acting like a list. > There is no need for synths to be an array, so refactor synths[] to use > standard kernel list_head API, instead, and modify the usages to suit. > As a

[PATCH] staging: speakup: refactor synths array to use a list

2018-06-04 Thread Justin Skists
The synths[] array is a collection of synths acting like a list. There is no need for synths to be an array, so refactor synths[] to use standard kernel list_head API, instead, and modify the usages to suit. As a side-effect, the maximum number of synths has also become redundant. Signed-off-by:

Re: [PATCH 0/4] staging: wilc1000: modification to use list_head data structure

2018-06-04 Thread Claudiu Beznea
Reviewed-by: Claudiu Beznea On 04.06.2018 08:29, Ajay Singh wrote: > Instead of having own linked list implementation to maintain buffer queue > change > to use list_head. Also removed the few elements from 'wilc' struct as it's not > required to be part of 'wilc' struct. > > Ajay Singh (4): >

[RFC Patch 1/3] X86/Hyper-V: Add flush HvFlushGuestPhysicalAddressSpace hypercall support

2018-06-04 Thread Tianyu Lan
Hyper-V provides a pv hypercall HvFlushGuestPhysicalAddressSpace to flush nested VM address space mapping in l1 hypervisor and it's to reduce overhead of flushing ept tlb among vcpus. This patch is to implement it. Signed-off-by: Lan Tianyu --- arch/x86/hyperv/Makefile | 2 +-

[RFC Patch 0/3] KVM/x86/hyper-V: Introduce PV guest address space mapping flush support

2018-06-04 Thread Tianyu Lan
Hyper-V provides a para-virtualization hypercall HvFlushGuestPhysicalAddressSpace to flush nested VM address space mapping in l1 hypervisor and it's to reduce overhead of flushing ept tlb among vcpus. The tradition way is to send IPIs to all affected vcpus and executes INVEPT on each vcpus. It

Re: [PATCH] staging:r8188eu: Use lib80211 to encrypt (WEP) tx frames

2018-06-04 Thread Dan Carpenter
On Sun, Jun 03, 2018 at 07:16:19PM +0300, Ivan Safonov wrote: > On 05/28/2018 04:53 PM, Dan Carpenter wrote: > > On Mon, May 28, 2018 at 09:18:21AM +0300, Ivan Safonov wrote: > > > Put data to skb, decrypt with lib80211_crypt_wep, and place back to tx > > > buffer. > > > > > > Signed-off-by:

Re: [PATCH] staging: mt7621-gpio: move out of staging

2018-06-04 Thread Dan Carpenter
Looks like a nice driver to me now. Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] staging: goldfish: Replace read and write macros with functions

2018-06-04 Thread Greg KH
On Fri, Jun 01, 2018 at 11:31:20AM -0700, r...@google.com wrote: > From: Roman Kiryanov > > Functions are less error-prone and generate cleaner compilation. > > Signed-off-by: Roman Kiryanov > --- > drivers/staging/goldfish/goldfish_audio.c | 46 +++ > 1 file changed, 30

Re: [PATCH] staging: lustre: delete the filesystem from the tree.

2018-06-04 Thread Greg Kroah-Hartman
On Mon, Jun 04, 2018 at 12:09:22AM -0700, Christoph Hellwig wrote: > On Fri, Jun 01, 2018 at 09:08:39PM +0200, Greg Kroah-Hartman wrote: > > Please, compare yourself to orangefs. That is the perfect example of > > how to do everything right. They got their code into staging, cleaned > > it up,

Re: [PATCH] staging: lustre: delete the filesystem from the tree.

2018-06-04 Thread Christoph Hellwig
On Fri, Jun 01, 2018 at 09:08:39PM +0200, Greg Kroah-Hartman wrote: > Please, compare yourself to orangefs. That is the perfect example of > how to do everything right. They got their code into staging, cleaned > it up, talked to us about what was needed to do to get the remaining > bits in