Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-06-05 Thread Dan Carpenter
On Mon, Jun 04, 2018 at 09:32:50PM +0200, Thibaut Robert wrote: > Le mercredi 30 mai 2018 à 14:17:25 (+0300), Dan Carpenter a écrit : > > On Tue, May 29, 2018 at 09:11:43PM +0200, Thibaut Robert wrote: > > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > > b/drivers/staging/wil

Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-06-05 Thread Thibaut Robert
Le mardi 05 juin 2018 à 10:36:31 (+0300), Dan Carpenter a écrit : > On Mon, Jun 04, 2018 at 09:32:50PM +0200, Thibaut Robert wrote: > > Le mercredi 30 mai 2018 à 14:17:25 (+0300), Dan Carpenter a écrit : > > > On Tue, May 29, 2018 at 09:11:43PM +0200, Thibaut Robert wrote: > > > > diff --git a/driv

Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-06-05 Thread Dan Carpenter
On Mon, Jun 04, 2018 at 09:27:02PM +0200, Thibaut Robert wrote: > Le lundi 04 juin 2018 à 10:55:49 (+0530), Ajay Singh a écrit : > > > > Thank you for submitting the patches. > > > > The modification in this patch looks okay to me. > > Please resend this by including changes as suggested by Dan.

Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-06-05 Thread Dan Carpenter
On Tue, Jun 05, 2018 at 10:33:25AM +0200, Thibaut Robert wrote: > Le mardi 05 juin 2018 à 10:36:31 (+0300), Dan Carpenter a écrit : > > On Mon, Jun 04, 2018 at 09:32:50PM +0200, Thibaut Robert wrote: > > > Le mercredi 30 mai 2018 à 14:17:25 (+0300), Dan Carpenter a écrit : > > > > On Tue, May 29, 2

Re: [greybus-dev] [PATCH] Staging:greybus Fix comparison to NULL

2018-06-05 Thread Dan Carpenter
On Tue, Jun 05, 2018 at 11:02:36AM +0530, Viresh Kumar wrote: > On 03-06-18, 08:52, Janani Sankara Babu wrote: > > This patch replaces comparison of var to NULL with !var > > > > Signed-off-by: Janani Sankara Babu > > --- > > drivers/staging/greybus/core.c | 2 +- > > 1 file changed, 1 insertion

[PATCH] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write()

2018-06-05 Thread Dan Carpenter
There is a '>' vs '<' typo so this loop is a no-op. Fixes: d35dcc89fc93 ("staging: comedi: quatech_daqp_cs: fix daqp_ao_insn_write()") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c index ea194aa01a6

Re: [PATCH] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write()

2018-06-05 Thread Ian Abbott
On 05/06/18 10:36, Dan Carpenter wrote: There is a '>' vs '<' typo so this loop is a no-op. Fixes: d35dcc89fc93 ("staging: comedi: quatech_daqp_cs: fix daqp_ao_insn_write()") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/d

Re: [PATCH] staging: mt7621-gpio: move out of staging

2018-06-05 Thread Sergio Paracuellos
On Mon, Jun 04, 2018 at 12:09:38PM +0300, Dan Carpenter wrote: > Looks like a nice driver to me now. Thanks! Thanks, Dan. Let's wait for feedback from gpio and device tree guys. > > regards, > dan carpenter > Best regards, Sergio Paracuellos ___ d

Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-06-05 Thread Ajay Singh
On Tue, 5 Jun 2018 10:33:25 +0200 Thibaut Robert wrote: > Le mardi 05 juin 2018 à 10:36:31 (+0300), Dan Carpenter a écrit : > > On Mon, Jun 04, 2018 at 09:32:50PM +0200, Thibaut Robert wrote: > > > Le mercredi 30 mai 2018 à 14:17:25 (+0300), Dan Carpenter a > > > écrit : > > > > On Tue, May 2

Re: [greybus-dev] [PATCH] Staging:greybus Fix comparison to NULL

2018-06-05 Thread Alex Elder
On 06/05/2018 04:00 AM, Dan Carpenter wrote: > On Tue, Jun 05, 2018 at 11:02:36AM +0530, Viresh Kumar wrote: >> On 03-06-18, 08:52, Janani Sankara Babu wrote: >>> This patch replaces comparison of var to NULL with !var >>> >>> Signed-off-by: Janani Sankara Babu Wow, such deep discussion for such

RE: [RFC Patch 1/3] X86/Hyper-V: Add flush HvFlushGuestPhysicalAddressSpace hypercall support

2018-06-05 Thread Michael Kelley (EOSG)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > On Behalf > Of Tianyu Lan > Sent: Monday, June 4, 2018 2:08 AM > Cc: Tianyu Lan ; KY Srinivasan > ; Haiyang > Zhang ; Stephen Hemminger ; > t...@linutronix.de; mi...@redhat.com; h...@zytor.com; x...@kernel.org; > pbonz...@

[PATCH] hv_netvsc: add per-cpu ethtool stats for netvsc

2018-06-05 Thread Yidong Ren
This patch implements following ethtool stats fields for netvsc: cpu_rx_packets cpu_tx_packets cpu_rx_bytes cpu_tx_bytes cpu_vf_rx_packets cpu_vf_tx_packets cpu_vf_rx_bytes cpu_vf_tx_bytes --- drivers/net/hyperv/hyperv_net.h | 11 + drivers/net/hyperv/netvsc_drv.c | 95

[PATCH 0/8] Drivers: hv: Miscellaneous fixes/improvements

2018-06-05 Thread kys
From: "K. Y. Srinivasan" Some miscellaneous fixes/improvements. Arjan van de Ven (1): use the new async probing feature for the hyperv drivers Dexuan Cui (1): Drivers: hv: vmbus: Fix the offer_in_progress in vmbus_process_offer() Michael Kelley (4): x86/hyperv: Add interrupt handler ann

[PATCH 4/8] Drivers: hv: vmbus: Fix the offer_in_progress in vmbus_process_offer()

2018-06-05 Thread kys
From: Dexuan Cui I didn't really hit a real bug, but just happened to spot the bug: we have decreased the counter at the beginning of vmbus_process_offer(), so we mustn't decrease it again. Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues") Signed-off-by: Dexuan Cui Cc: sta

[PATCH 3/8] Drivers: hv: vmbus: Add comments on ring buffer signaling

2018-06-05 Thread kys
From: Michael Kelley Add comments describing intricacies of Hyper-V ring buffer signaling code. This information is not in Hyper-V public documents, so include here to capture the knowledge for future coders. There are no code changes in this commit. Signed-off-by: Michael Kelley Signed-off-b

[PATCH 7/8] tools: hv: update lsvmbus to be compatible with python3

2018-06-05 Thread kys
From: Olaf Hering Python3 changed the way how 'print' works. Adjust the code to a syntax that is understood by python2 and python3. Signed-off-by: Olaf Hering Acked-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- tools/hv/lsvmbus | 12 ++-- 1 file changed, 6 insertions(+), 6 delet

[PATCH 5/8] Drivers: hv: vmbus: Remove x86 MSR refs in arch independent code

2018-06-05 Thread kys
From: Michael Kelley In architecture independent code for manipulating Hyper-V synthetic timers and synthetic interrupts, pass in an ordinal number identifying the timer or interrupt, rather than an actual MSR register address. Then in x86/x64 specific code, map the ordinal number to the appropr

[PATCH 1/8] use the new async probing feature for the hyperv drivers

2018-06-05 Thread kys
From: Arjan van de Ven Recent kernels support asynchronous probing; most hyperv drivers can be probed async easily so set the required flag for this. Signed-off-by: Arjan van de Ven Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan --- drivers/hid/hid-hyperv.c | 3

[PATCH 8/8] Tools: hv: vss: fix loop device detection

2018-06-05 Thread kys
From: Vitaly Kuznetsov Commit ea81fdf0981d ("Tools: hv: vss: Skip freezing filesystems backed by loop") added skip for filesystems backed by loop device. However, it seems the detection of such cases is incomplete. It was found that with 'devicemapper' storage driver docker creates the following

[PATCH 6/8] Drivers: hv: vmbus: Make TLFS #define names architecture neutral

2018-06-05 Thread kys
From: Michael Kelley The Hyper-V feature and hint flags in hyperv-tlfs.h are all defined with the string "X64" in the name. Some of these flags are indeed x86/x64 specific, but others are not. For the ones that are used in architecture independent Hyper-V driver code, or will be used in the upc

[PATCH 2/8] x86/hyperv: Add interrupt handler annotations

2018-06-05 Thread kys
From: Michael Kelley Add standard interrupt handler annotations to hyperv_vector_handler(). This does not fix any observed bug, but avoids potential removal of the code by link time optimization and makes it consistent with hv_stimer0_vector_handler in the same source file. Suggested-by: Thomas

[PATCH v3 03/21] Staging: gdm724x: use match_string() helper

2018-06-05 Thread Yisheng Xie
match_string() returns the index of an array for a matching string, which can be used instead of open coded variant. Cc: Greg Kroah-Hartman Cc: Quytelda Kahja Cc: de...@driverdev.osuosl.org Signed-off-by: Yisheng Xie --- v3: - no need to check input tty's index - per Greg v2: - const DRIVER_S

Re: [RFC Patch 1/3] X86/Hyper-V: Add flush HvFlushGuestPhysicalAddressSpace hypercall support

2018-06-05 Thread Tianyu Lan
Hi Michael: Thanks for your review. On 6/6/2018 12:59 AM, Michael Kelley (EOSG) wrote: >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org >> On Behalf >> Of Tianyu Lan >> Sent: Monday, June 4, 2018 2:08 AM >> Cc: Tianyu Lan ; KY Srinivasan >> ; Haiyang >> Zhang ;