When implementing custom irqchips it is important to also
implement .irq_request_resources() and .irq_release_resources()
and make sure these call gpiochip_[un]lock_as_irq().
Add those two for this driver. Also store struct device pointer
in global state structure to be able to use 'dev_err' with
This commit adds kerneldoc for the two data containers in
order to better understanding of its existence.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/gpio-mt7621.c | 18 ++
1 file changed, 18 insertions(+)
diff --git
Including file '' should be avoided in
new drivers code, so just remove it because it is
no necessary at all.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/gpio-mt7621.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c
This driver is actually platform-agnostic. Add COMPILE_TEST for
the compilation test coverage.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-gpio/Kconfig
This driver was being registered using 'module_platform_driver'
but it is not a module at all. Instead of this use
'builtin_platform_driver' which seems to be the correct one.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/gpio-mt7621.c | 2 +-
1 file changed, 1 insertion(+),
This chip support high level and low level interrupts. Those
have to be implemented also to get a complete and clean driver.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/gpio-mt7621.c | 51 +++
1 file changed, 38 insertions(+), 13 deletions(-)
Gpio complexity is just masking the fact that offset is always
0..n and writes to bits 0..n of some memory address. Because
of this whole thing can just me converted to use GPIO_GENERIC
and avoid duplications of a lot of driver custom functions.
So use bgpio_init instead of custom code adding
After submiting this driver to try to get mainlined and get
out of staging some new cleanups seems to be necessary.
According to this main of Linus Walleij:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-June/121742.html
this series tries to fix all of the issues in order
When nlmsg_put fails, the lack of error-handling code may
cause unexpected results.
This patch adds error-handling code after calling nlmsg_put.
Signed-off-by: Zhouyang Jia
---
drivers/staging/gdm724x/netlink_k.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Hi,
On Fri, 2018-06-08 at 13:59 +0200, Linus Walleij wrote:
> Hi Sergio!
>
> Thanks for your patch!
>
> Given that we have combined pin control and GPIO drivers for
> almost all Mediatek chips in drivers/pinctrl/mediatek/*
> I would ideally like to have some input from the Mediatek
>
Fixes the checkpatch warning:
WARNING: prefer 'help' over '---help---' for new help texts
+config COMMON_CLK_XLNX_CLKWZRD
Signed-off-by: Kyle Buzby
---
drivers/staging/clocking-wizard/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Use sign_extend32 kernel function instead of code duplication.
This function is also safe for 16 bits.
Signed-off-by: Karim Eshapa
---
drivers/staging/iio/accel/adis16201.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16201.c
> -Original Message-
> From: Sunil Muthuswamy
> Sent: Friday, June 8, 2018 11:39 AM
> To: Haiyang Zhang
> Cc: de...@linuxdriverproject.org; Sunil Muthuswamy
> ; KY Srinivasan ; Stephen
> Hemminger
> Subject: [PATCH v5] Drivers: HV: Send one page worth of kmsg dump over
> Hyper-V
On Sun, Jun 10, 2018 at 07:02:20PM +1000, NeilBrown wrote:
> On Sat, Jun 09 2018, Sergio Paracuellos wrote:
>
> > Instead of create a custom irq_domain for this chip, use
> > 'gpiochip_set_chained_irqchip' from GPIOLIB_IRQCHIP. It
> > is ok to call this function several times. You only have to
>
On Sun, Jun 10, 2018 at 06:56:21PM +1000, NeilBrown wrote:
> On Sat, Jun 09 2018, Sergio Paracuellos wrote:
>
> > When implementing custom irqchips it is important to also
> > implement .irq_request_resources() and .irq_release_resources()
> > and make sure these call gpiochip_[un]lock_as_irq().
On Sun, Jun 10, 2018 at 07:04:56PM +1000, NeilBrown wrote:
> On Sat, Jun 09 2018, Sergio Paracuellos wrote:
>
> > This chip support high level and low level interrupts. Those
> > have to be implemented also to get a complete and clean driver.
> >
> > Signed-off-by: Sergio Paracuellos
> > ---
> >
On Sun, Jun 10, 2018 at 06:53:04PM +1000, NeilBrown wrote:
> On Sat, Jun 09 2018, Sergio Paracuellos wrote:
>
> > Gpio complexity is just masking the fact that offset is always
> > 0..n and writes to bits 0..n of some memory address. Because
> > of this whole thing can just me converted to use
On Sat, Jun 09 2018, Sergio Paracuellos wrote:
> This chip support high level and low level interrupts. Those
> have to be implemented also to get a complete and clean driver.
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/mt7621-gpio/gpio-mt7621.c | 57
>
On Sat, Jun 09 2018, Sergio Paracuellos wrote:
> Instead of create a custom irq_domain for this chip, use
> 'gpiochip_set_chained_irqchip' from GPIOLIB_IRQCHIP. It
> is ok to call this function several times. You only have to
> mark the line with 'IRQF_SHARED' and then loop over the
> three banks
On Sat, Jun 09 2018, Sergio Paracuellos wrote:
> When implementing custom irqchips it is important to also
> implement .irq_request_resources() and .irq_release_resources()
> and make sure these call gpiochip_[un]lock_as_irq().
> Add those two for this driver. Also store struct device pointer
>
On Sat, Jun 09 2018, Sergio Paracuellos wrote:
> Gpio complexity is just masking the fact that offset is always
> 0..n and writes to bits 0..n of some memory address. Because
> of this whole thing can just me converted to use GPIO_GENERIC
> and avoid duplications of a lot of driver custom
Hi Greg,
I've added changelog text to the patch below. Appreciate your
feedback!
Regards,
Chris Opperman
>8--8<
Improved the readability of comedi_nsamples_left:
a) Reduced nesting by using more return calls.
b) Separated
Clean up W=1 warning: variable set but not used.
Signed-off-by: Kenneth Lu
---
v2: Rollback r8192U_core.c for the incorrect removed variables.
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 --
drivers/staging/rtl8192u/r8192U_core.c| 7 +--
Type used is unsigned char but expected is restricted __le16.
Warning reported by sparse. Part of eudyptula challenge.
Signed-off-by: Nishad Kamdar
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hello,
syzbot found the following crash on:
HEAD commit:a16afaf7928b Merge tag 'for-v4.18' of git://git.kernel.org..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1480e36f80
kernel config: https://syzkaller.appspot.com/x/.config?x=314f2150f36c16ca
25 matches
Mail list logo