On Sun, Jul 29, 2018 at 11:36:52AM +0530, Ajay Singh wrote:
> Cleanup patch to remove the unnecessary copyright information in
> the file, as it already has SPDX License Identifier.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_debugfs.c | 10 --
> drivers/staging/
On Sun, Jul 29, 2018 at 11:36:56AM +0530, Ajay Singh wrote:
> Cleanup patch to avoid the below checkpatch reported issue.
>
> "usleep_range is preferred over udelay; see
> Documentation/timers/timers-howto.txt".
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_wlan.c | 2 +-
>
On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote:
> Cleanup patch to fix below checkpatch reported issue:
>
> Macro argument 'id' may be better as '(id)' to avoid precedence issues
>
> Also updated the TODO file to remove the below item
> 'rework comments and function headers(also codi
In spinand_program_page(), it uses devm_kzalloc() to allocate memory to
wbuf dynamically if internal ECC is on, but it doesn't free memory
allocated to wbuf at the end of this function. Before the spinand device
is removed and frees memory automatically, programming pages may run many
times. This l
On Thu, Aug 02, 2018 at 03:51:30PM +0800, Jheng-Jhong Wu wrote:
> In spinand_program_page(), it uses devm_kzalloc() to allocate memory to
> wbuf dynamically if internal ECC is on, but it doesn't free memory
> allocated to wbuf at the end of this function. Before the spinand device
> is removed and
Hi Greg,
On Thu, 2 Aug 2018 09:33:17 +0200
Greg KH wrote:
> On Sun, Jul 29, 2018 at 11:36:52AM +0530, Ajay Singh wrote:
> > Cleanup patch to remove the unnecessary copyright information in
> > the file, as it already has SPDX License Identifier.
> >
> > diff --git a/drivers/staging/wilc1000/wil
Hi Greg,
On Thu, 2 Aug 2018 09:34:54 +0200
Greg KH wrote:
> On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote:
> > Cleanup patch to fix below checkpatch reported issue:
> > -#define ISWILC1000(id) ((id & 0xf000)
> > == 0x10 ? 1 : 0) +#define ISWILC1000(id)
Dear greg k-h,
Before device is removed and freed memory automatically, programming
pages may run many many times.
Assume we erase and rewrite a large part of the flash, then
spinand_program_page() might exhaust memory if memory is not large
enough.
We may not remove and re-add the device between
On Thu, Jul 26, 2018 at 05:17:18PM -0700, Sherry Yang wrote:
> Use rate-limited debug messages where userspace can trigger
> excessive log spams.
>
> Acked-by: Arve Hjønnevåg
> Signed-off-by: Sherry Yang
> ---
> drivers/android/binder.c | 5 +++--
> drivers/android/binder_alloc.c | 41 ++
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Aug 02, 2018 at 04:31
From: Todd Poynor
Set default value of allow_power_save parameter to enable power save
mode, which is expected to be the state usually desired.
Signed-off-by: Marty Faltesek
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
From: Todd Poynor
More cleanups for the gasket+apex drivers.
Todd Poynor (8):
staging: gasket: apex: enable power save mode by default
staging: gasket: core: print driver version code at registration time
staging: gasket: core: move driver loaded log after error cases
staging: gasket: co
From: Todd Poynor
Apex doesn't implement different types of resets based on the reset type
param passed through the gasket layer or from userspace via the
gasket_reset ioctl. The reset type is dropped from the gasket framework
in a previous patch due to a lack of present need and non-conforming
From: Todd Poynor
Print the driver version code in the kernel log at gasket driver
registration time for informational purposes. Add "gasket:" prefix to
make clear it is the gasket framework logging this information.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 5 +++-
From: Todd Poynor
Gasket could claim to have loaded a driver and then print an error
indicating it actually did not. Move the driver registration message
after the last error check. Replace the existing "loaded successfully"
message with this instead.
Signed-off-by: Todd Poynor
---
drivers/s
From: Todd Poynor
At device/driver registration time, convert a not-very-informative
info message to a more informative dbeug message, drop some not overly
helpful debug messages.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 7 ++-
1 file changed, 2 insertions(+),
From: Todd Poynor
There's no need to take an additional reference on the pci_dev structure
for the pointer copy saved in gasket data structures.
This reverts commit 8dd8a48b9a7dae5493494a8603adddfdf1914716.
Reported-by: Dmitry Torokhov
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/ga
From: Todd Poynor
The "type of reset" parameter to the gasket device reset APIs isn't
required by the only gasket device submitted upstream, apex.
The framework documents the param as private to the device driver and a
pass-through at the gasket layer, but the gasket core calls the device
driver
From: Todd Poynor
Identify gasket as the subsystem printing various error messages.
Add the driver name to appropriate messages to indicate which driver
has a problem.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 27 +++
1 file changed, 15 inser
On Thu, Aug 02, 2018 at 01:42:39AM -0700, Todd Poynor wrote:
> From: Todd Poynor
>
> Print the driver version code in the kernel log at gasket driver
> registration time for informational purposes. Add "gasket:" prefix to
> make clear it is the gasket framework logging this information.
>
> Sig
On Thu, Aug 02, 2018 at 01:42:41AM -0700, Todd Poynor wrote:
> From: Todd Poynor
>
> At device/driver registration time, convert a not-very-informative
> info message to a more informative dbeug message, drop some not overly
> helpful debug messages.
>
> Signed-off-by: Todd Poynor
> ---
> driv
On Thu, Aug 02, 2018 at 01:42:42AM -0700, Todd Poynor wrote:
> From: Todd Poynor
>
> Identify gasket as the subsystem printing various error messages.
> Add the driver name to appropriate messages to indicate which driver
> has a problem.
>
> Signed-off-by: Todd Poynor
> ---
> drivers/staging/
On Thu, Aug 02, 2018 at 01:42:40AM -0700, Todd Poynor wrote:
> From: Todd Poynor
>
> Gasket could claim to have loaded a driver and then print an error
> indicating it actually did not. Move the driver registration message
> after the last error check. Replace the existing "loaded successfully"
On Thu, Aug 02, 2018 at 01:42:45AM -0700, Todd Poynor wrote:
> From: Todd Poynor
>
> There's no need to take an additional reference on the pci_dev structure
> for the pointer copy saved in gasket data structures.
>
> This reverts commit 8dd8a48b9a7dae5493494a8603adddfdf1914716.
Hint, when deal
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 025556d55d6edf3b3be1267a481be0890b96cc65
commit: 02211edc9a1f71942a67d545614f8c7382230de7 [704/735] staging: wilc1000:
fix endianness warnings reported by sparse
config: powerpc-allyesconfig (attach
As Stephen Rothwell reported:
"After merging the staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/staging/erofs/super.c: In function 'erofs_read_super':
drivers/staging/erofs/super.c:343:17: error: 'MS_RDONLY' undeclared (first use
in this function); did you
Hi Chao,
On 2018/8/2 17:39, Chao Yu wrote:
> As Stephen Rothwell reported:
>
> "After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/staging/erofs/super.c: In function 'erofs_read_super':
> drivers/staging/erofs/super.c:343:17: error: 'MS_R
Fix below warning reported for PowerPC arch compilation
include/uapi/linux/byteorder/big_endian.h:95:37: warning: passing
argument 1 of '__swab32s' makes pointer from integer without a cast
[-Wint-conversion]
Fixes: 02211edc9a1f ("staging: wilc1000: fix endianness warnings
reported by sparse")
S
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 156c3df8d4db4e693c062978186f44079413d74d
commit: 02211edc9a1f71942a67d545614f8c7382230de7 [704/736] staging: wilc1000:
fix endianness warnings reported by sparse
config: xtensa-allyesconfig (attache
Hi Rui,
On 05/22/18 16:52, Rui Miguel Silva wrote:
> Hi,
> This series introduces the Media driver to work with the i.MX7 SoC. it uses
> the
> already existing imx media core drivers but since the i.MX7, contrary to
> i.MX5/6, do not have an IPU and because of that some changes in the imx media
>
Hi Rui,
On Tue, May 22, 2018 at 03:52:39PM +0100, Rui Miguel Silva wrote:
> Add bindings documentation for i.MX7 media drivers.
> The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface.
>
> Signed-off-by: Rui Miguel Silva
> ---
> .../devicetree/bindings/media/imx7-csi.txt| 44 ++
> .../b
Hi Xiang,
On 2018/8/2 18:11, Gao Xiang wrote:
> Hi Chao,
>
> On 2018/8/2 17:39, Chao Yu wrote:
>> As Stephen Rothwell reported:
>>
>> "After merging the staging tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/staging/erofs/super.c: In function 'erofs_read_s
From: Chao Yu
As Stephen Rothwell reported:
"After merging the staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/staging/erofs/super.c: In function 'erofs_read_super':
drivers/staging/erofs/super.c:343:17: error: 'MS_RDONLY' undeclared (first use
in this fu
> -Original Message-
> From: Dan Carpenter
> Sent: Wednesday, August 1, 2018 11:42 PM
> To: Michael Kelley (EOSG)
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@redhat.com; jasow...@redhat.c
On 07/16/18 15:30, Michael Straube wrote:
On 07/14/18 19:54, Ivan Safonov wrote:
Put data to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_security.c | 778 +++---
1 file changed, 72
Hi Hans,
On Thu 02 Aug 2018 at 13:37, Hans Verkuil wrote:
Hi Rui,
On 05/22/18 16:52, Rui Miguel Silva wrote:
Hi,
This series introduces the Media driver to work with the i.MX7
SoC. it uses the
already existing imx media core drivers but since the i.MX7,
contrary to
i.MX5/6, do not have an IPU
Hi Sakari,
Thanks for the review.
I will take this in account when preparing the v7, all your
comments
bellow look reasonable to me.
---
Cheers,
Rui
On Thu 02 Aug 2018 at 14:00, Sakari Ailus wrote:
Hi Rui,
On Tue, May 22, 2018 at 03:52:39PM +0100, Rui Miguel Silva
wrote:
Add bindi
Use is_multicast_ether_addr instead of custom IS_MCAST in
os_dep/recv_linux.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
b/drivers/stagi
Use is_multicast_ether_addr instead of custom IS_MCAST in
hal/rtl8188eu_xmit.c.
There is only one use, so remove the extra variable for the
result of IS_MCAST.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(
Replace tabs with spaces and/or remove spaces where appropriate.
Add a missing blank line after declarations.
Also clears checkpatch warnings.
WARNING: Statements should start on a tabstop
WARNING: suspect code indent for conditional statements (8, 17)
Signed-off-by: Michael Straube
---
drivers
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_sta_mgt.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl818
Cleanup a block comment to conform with kernel coding style.
Also cleans 'line over 80 characters' checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rt
Replace tabs with spaces and/or remove spaces where appropriate.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/hal/rtl8188eu_xmit.c| 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
b/drivers/st
Checkpatch complains about unnamed arguments in a function
prototype, so fix it.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
b/drivers
On Thu, Aug 02, 2018 at 10:34:55PM +0800, Chao Yu wrote:
> From: Chao Yu
>
> As Stephen Rothwell reported:
>
> "After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/staging/erofs/super.c: In function 'erofs_read_super':
> drivers/staging
From: Michael Kelley
If hv_synic_alloc() errors out, the state of the per-cpu context
for some CPUs is unknown since the zero'ing is done as each
CPU is iterated over. In such case, hv_synic_cleanup() may try to
free memory based on uninitialized values. Fix this by zero'ing
the per-cpu context
On Thu, Aug 02, 2018 at 04:57:02PM +0530, Ajay Singh wrote:
> Fix below warning reported for PowerPC arch compilation
>
> include/uapi/linux/byteorder/big_endian.h:95:37: warning: passing
> argument 1 of '__swab32s' makes pointer from integer without a cast
> [-Wint-conversion]
>
> Fixes: 02211ed
Two structures, (struct dig and struct dynamic_rx_path_sel) contain
a u8 member variable representing debug setting. In the file r8192U_dm.c
these member variables, for both structures, are initialised to an
enumerated constant 'DM_DBG_OFF'. The member variables are never
assigned another value, ot
Rename the two constants defined in the enumerated type enum
cck_rx_path_method so that they are both uppercase, as suggested by
the coding style.
This is purely a coding style change and should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/
The structure 'dig' defines a member variable, (rx_gain_range_max)
which is initialised to the value 'DM_DIG_MAX', (a defined constant).
The variable is then used to test and set another variable. Since
the member rx_gain_range_max is never assigned any other value then
the constant 'DM_DIG_MAX' th
This series of patches is a clean up of the file:
drivers/staging/rtl8192u/r8192U_dm.h
Whilst I consider all the changes to be coding style changes some have
removed structure member variables which were not implementing any
logic, which required them to be a member of a structure. The first
patch
The structure 'dig' defines a member variable
'initialgain_lowerbound_state', which although initialised to false,
is never used in the code. As a result this unused member variable
has been removed.
This is a coding style change which should not impact runtime code
execution.
Signed-off-by: John
The structure dynamic_rx_path_sel defines a member variable 'Enable'
which is initialised and later tested. The variable is however never
changed to the test is redundant and the member variable is then never
used.
The member variable, initialisation and test have all been removed.
This is a codi
The member variable SS_TH_low is assigned a constant and then used
in a comparison. This member variable is redundant as the constant
can be used directly for the comparison.
In addition the constant RxPathSelection_SS_TH_low has been renamed
to RX_PATH_SELECTION_SS_TH_LOW, to clear the checkpatch
Rename the member variable disabledRF to disabled_rf. This change
resolves the checkpatch issue with CamelCase naming.
The change is purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 10 +++
The structure DCMD_TXCMD_T is declared with a typedef, which causes a
checkpatch issue with defining new types. As a result the typedef has
been removed.
The structure's name DCMD_TXCMD_T, as a type, is meant to be lowercase
so has been renamed to tx_config_cmd.
The structures three members, (Op,
The constants 'VeryLowRSSI' and 'CTSToSelfTHVal' generate warnings from
checkpatch due to the use of CamelCase naming. The two constants have
been renamed to 'VERY_LOW_RSSI' and 'CTS_TO_SELF_TH_VAL' respectively.
These are coding style changes which should have no impact on runtime
code execution.
The constant RateAdaptiveTH_High causes a checkpatch issue with respect
to CamelCase naming. As a result the constant has been renamed to
RATE_ADAPTIVE_TH_HIGH.
This is purely a coding style change which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/s
The file r8192U_dm.h defines the structure DM_RxPathSelTable as being
external. The structure is however declared in r8192U_dm.c and only
used locally in that file.
As a result the external definition has been removed and the declaration
in r8192U_dm.c changed to being of type static.
This is a c
The two constants, RateAdaptiveTH_Low_20M and RateAdaptiveTH_Low_40M
generate a checkpatch warning about CamelCase naming. The two have been
renamed to clear this issue. RATE_ADAPTIVE_TH_LOW_20M and
RATE_ADAPTIVE_TH_LOW_40M
This is a coding style change which should have no impact on runtime
code
Rename the member variable cck_Rx_path to cck_rx_path. This clears
the checkpatch issue with CamelCase naming.
This is a coding style change which should have no impact one runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 8
drivers/stagin
The member variable diff_TH is assigned a constant value and then used
in a comparison. The variable is never changed so the comparison can
as easily be performed directly with the defined constant.
The member variable has been removed and the defined constant
RxPathSelection_diff_TH renamed to RX
The constant DM_DIG_MIN_Netcore causes a checkpatch issue with CamelCase
naming so has been renamed to DM_DIG_MIN_NETCORE.
This is a simple coding style change which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
dr
Multiple blank line, which cause an issue with checkpath, have been
removed and the spacing of definitions have been aligned to look
cleaner.
These are coding style changes which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm
The structure dynamic_rx_path_sel contains a u8 member variable called
reserved. This member variable is never actually used in the code.
The naming suggests that the sizeof the structure is significant but
the only use of the structure is a local static in r8192U_dm.c:
static struct dynamic_rx_p
The four register constants, 'Current_Tx_Rate_Reg',
'Initial_Tx_Rate_Reg', 'Tx_Retry_Count_Reg' and 'RegC38_TH' all cause
checkpatch issue with CamelCase naming. The three have been renamed to
'CURRENT_TX_RATE_REG', 'INITIAL_TX_RATE_REG', 'TX_RETRY_COUNT_REG' and
'REG_C38_TH' respectively.
These a
Hi Greg,
On 2018/8/3 1:33, Greg KH wrote:
> Sorry, I already took the first version in my tree. Don't worry about
> it for now you can fix this up after 4.19-rc1 is out when we enable the
> filesystem again.
>
OK, We will fix it and enable erofs after 4.19-rc1 is out. :)
Thanks,
Gao Xiang
> t
On 2018/8/3 1:33, Greg KH wrote:
> On Thu, Aug 02, 2018 at 10:34:55PM +0800, Chao Yu wrote:
>> From: Chao Yu
>>
>> As Stephen Rothwell reported:
>>
>> "After merging the staging tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/staging/erofs/super.c: In functi
From: Todd Poynor
More cleanups for the gasket+apex drivers.
Patched changed in v2 from v1:
staging: gasket: core: print driver version code at registration time
staging: gasket: core: move driver loaded log after error cases
Above 2 patches replaced by new patch:
staging: gaske
From: Todd Poynor
Remove logs for loading gasket drivers.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core.c
b/drivers/staging/gasket/gasket_core.c
index 2b75f100da4d3..fa477d0c3c74c 1
From: Todd Poynor
Identify gasket as the subsystem printing various messages.
Add the driver name to appropriate messages to indicate which driver
has a problem.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 13 +
1 file changed, 9 insertions(+), 4 deletions
From: Todd Poynor
There's no need to take an additional reference on the pci_dev structure
for the pointer copy saved in gasket data structures.
This reverts commit:
8dd8a48b9a7d ("staging: gasket: core: hold reference to pci_dev while used")
Reported-by: Dmitry Torokhov
Signed-off-by: Todd Po
From: Todd Poynor
At device/driver registration time, convert a not-very-informative
info message to a more informative debug message, drop some not overly
helpful debug messages.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 7 ++-
1 file changed, 2 insertions(+),
Hi Greg,
On Thu, 2 Aug 2018 21:31:16 +0200
Greg KH wrote:
> On Thu, Aug 02, 2018 at 04:57:02PM +0530, Ajay Singh wrote:
> > Fix below warning reported for PowerPC arch compilation
> >
> > include/uapi/linux/byteorder/big_endian.h:95:37: warning: passing
> > argument 1 of '__swab32s' makes point
On Thu, Aug 02 2018, Sergio Paracuellos wrote:
> This patch series include an attempt to avoid the use of custom
> read and writes in driver code and use PCI subsystem common ones.
>
> In order to do this 'map_bus' callback is implemented and also
> data structures for driver are included. The reg
Refactored rtl_get_tcb_desc slightly to stay within the 80 character
line limit.
Signed-off-by: Luke Triantafyllidis
---
Changes in v2:
- Fixed the formatting of the comments
- Unwrapped some of the lines that were originally wrapped over multiple
lines to stay within the 80 character limit
On Fri, Aug 03, 2018 at 02:33:22PM +1000, NeilBrown wrote:
> On Thu, Aug 02 2018, Sergio Paracuellos wrote:
>
> > This patch series include an attempt to avoid the use of custom
> > read and writes in driver code and use PCI subsystem common ones.
> >
> > In order to do this 'map_bus' callback is
77 matches
Mail list logo
