On Wed, 2018-08-08 at 22:00 +0100, John Whitmore wrote:
> The macro eqMacAddr implements the same functionality as the
> ether_addr_equal function defined in etherdevice.h, as a result the
> macro has been removed from the code, and its use replaced with the
> function call.
[]
> diff --git
The function Dot11d_Reset causes a checkpatch issue due to its use of
CamelCase naming, so has been renamed to dot11d_reset.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.c
The function dot11d_update_country_ie() uses parameter names which
cause a checkpatch issue due to the use of CamelCase naming.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 6
Multiple macros, defined in dot11d.h, use the variable __pIeeeDev as a
parameter. This name causes a checkpatch issue due to its use of
CamelCase naming. The parameter name has been changed to ieee_dev to
clear this issue.
This is a coding style change which should have no impact on runtime
code
The macro eqMacAddr implements the same functionality as the
ether_addr_equal function defined in etherdevice.h, as a result the
macro has been removed from the code, and its use replaced with the
function call.
Note that to use the ether_addr_equal function the data array
containing the MAC
The macro cpMacAddr implements the same functionality as the
ether_addr_copy function defined in etherdevice.h, as a result the
macro has been removed from the code, and its use replaced with the
function call.
Note that the header comment of the function ether_addr_copy states
that the two byte
The function DOT11D_GetMaxTxPwrInDbm causes a checkpatch issue due to
its use of CamelCase naming. The function has been renamed to
dot11d_get_max_tx_pwr_in_dbm.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
The function Dot11d_Init() causes a checkpatch issue due to its use
of CamelCase naming. The function has been renamed to dot11d_init.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
The array size 6 represents the length of an Ethernet address so the
magic number has been replaced with the defined constant representing
that length.
This is a coding style change which should not impact runtime code
execution.
Signed-off-by: John Whitmore
---
The function dot11d_get_max_tx_pwr_in_dbm() uses a parameter name,
Channel, which causes a checkpatch issue with CamelCase naming. The
parameter has been renamed to channel.
The change is a coding style change which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
The function DOT11D_ScanComplete causes a checkpatch issue due to its
use of CamelCase naming. The function has been renamed to
dot11d_scan_complete.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
Rename the function ToLegalChannel, which causes a checkpatch issue due
to its use of CamelCase naming. The function has been renamed to
to_legal_channel.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
The function Dot11d_UpdateCountryIe causes a checkpatch issue due to
its use of CamelCase naming, the function has been renamed to
dot11d_update_country_ie.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
The function IsLegalChannel causes a checkpatch issue due to its use
of CamelCase naming. The function has been renamed to is_legal_channel.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
The macro parameter __pTa causes a checkpatch issue because of its use
of CamelCase naming. The parameter has this been renamed to addr.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
A number of function prototypes cause a checkpatch issue - "Lines
should not end with a '(' ". This issue has been cleared by moving
function prototype parameters to the same line as the function name.
This is a coding style change which should have no impact on runtime
code execution.
In this second version of the series I've replaced the macros
eqMacAddr and cpMacAddr with functions suggested by Joe Perches
One issue with this change is that both of the functions now
used, defined in etherdevice.h, rely on the parameters being
u16 aligned. To achieve this I've re-ordered
On Wed, Aug 08, 2018 at 11:22:57AM +0200, Greg KH wrote:
> On Sun, Aug 05, 2018 at 09:41:06PM +0200, Frank Werner-Krippendorf wrote:
> > Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix
> > a coding style issue "Statements should start on a tabstop"
> > detected by checkpatch.pl
Oh, yeah. Greg's comments were very clear.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Aug 08, 2018 at 10:59:26AM -0500, Larry Finger wrote:
> On 08/08/2018 04:22 AM, Greg KH wrote:
> > On Sun, Aug 05, 2018 at 09:41:06PM +0200, Frank Werner-Krippendorf wrote:
> > > Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix
> > > a coding style issue "Statements should
Add support for overriding the default driver for a VMBus device
in the same way that it can be done for PCI devices. This patch
adds the /sys/bus/vmbus/devices/.../driver_override file
and the logic for matching.
This is used by driverctl tool to do driver override.
On Wed, Aug 08, 2018 at 04:51:26PM +0200, Christian Gromm wrote:
> On 08.08.2018 14:10, Greg KH wrote:
> > On Mon, Aug 06, 2018 at 12:03:10PM +0200, Christian Gromm wrote:
> > > The channel attribute dbr_size is only relevant for the DIM2 interface. So
> > > is the packets_per_xact for USB.
On 08/08/2018 04:22 AM, Greg KH wrote:
On Sun, Aug 05, 2018 at 09:41:06PM +0200, Frank Werner-Krippendorf wrote:
Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix
a coding style issue "Statements should start on a tabstop"
detected by checkpatch.pl script.
Signed-off-by: Frank
Add SPDX-License-Identifier to the source files.
Remove redundant, old license.
Signed-off-by: Arkadiusz Lis
---
Changes in v3:
- change old license to SPDX
- adding change summary, missing in v2
drivers/staging/olpc_dcon/olpc_dcon.c| 5 +
On 2018-08-07 09:34 PM, Greg Gallagher wrote:
Fix warnings generated by checkpatch.pl for alignment should match open
parenthesis. This is a coding style change only.
Signed-off-by: Greg Gallagher
---
.../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +-
1 file
On 08.08.2018 14:10, Greg KH wrote:
On Mon, Aug 06, 2018 at 12:03:10PM +0200, Christian Gromm wrote:
The channel attribute dbr_size is only relevant for the DIM2 interface. So
is the packets_per_xact for USB. Currently, all attrs are shown by default
in sysfs for any channel. To get a clean
On Wed, Aug 8, 2018 at 2:08 PM, Greg KH wrote:
> On Mon, Aug 06, 2018 at 10:21:46AM +1000, NeilBrown wrote:
>> On Fri, Aug 03 2018, Sergio Paracuellos wrote:
>>
>> > This patch series include an attempt to avoid the use of custom
>> > read and writes in driver code and use PCI subsystem common
On Wed, Aug 08, 2018 at 08:54:49AM -0400, Greg Gallagner wrote:
> On 08/08/2018 08:26 AM, Greg Kroah-Hartman wrote:
> > On Tue, Aug 07, 2018 at 09:40:47PM -0400, Greg Gallagher wrote:
> >> Fix warnings generated by checkpatch.pl for alignment should match open
> >> parenthesis. This is a coding
On Tue, 2018-08-07 at 22:12 +0100, John Whitmore wrote:
> The eqMacAddr(a, b) macro causes a checkpatch issue, due to CamelCase
> naming, so has been renamed to eq_mac_addr(a, b).
>
> This is a coding style change which should not impact on runtime code
> execution.
[]
> diff --git
On 08/08/2018 08:26 AM, Greg Kroah-Hartman wrote:
> On Tue, Aug 07, 2018 at 09:40:47PM -0400, Greg Gallagher wrote:
>> Fix warnings generated by checkpatch.pl for alignment should match open
>> parenthesis. This is a coding style change only.
>>
>> Signed-off-by: Greg Gallagher
>> ---
>> Changes
On Tue, Aug 07, 2018 at 09:40:47PM -0400, Greg Gallagher wrote:
> Fix warnings generated by checkpatch.pl for alignment should match open
> parenthesis. This is a coding style change only.
>
> Signed-off-by: Greg Gallagher
> ---
> Changes in v2:
> - Clean up all the alignment warnings in
On Tue, Aug 07, 2018 at 09:30:10PM -0300, Leonardo Brás wrote:
> Changes custom macro to dev_dbg to avoid parameter multiple usage and use of
> typeof().
linewrap please.
And while this is a good start, please replace the places this custom
macro is called with dev_dbg(), and then delete this
On Tue, Aug 07, 2018 at 09:28:42PM -0300, Leonardo Brás wrote:
> Trying to keep the code in the 80-char line limit.
>
> Signed-off-by: Leonardo Brás
>
> diff --git a/drivers/staging/fbtft/fb_ssd1306.c
> b/drivers/staging/fbtft/fb_ssd1306.c
> index 9276be499303..f5e0ec1c01dc 100644
> ---
On Tue, Aug 07, 2018 at 09:29:31PM -0300, Leonardo Brás wrote:
> Includes description to mutex and spinlocks, as recommended by checkpatch.pl.
>
> Signed-off-by: Leonardo Brás
> ---
> drivers/staging/fbtft/fbtft.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On Tue, Aug 07, 2018 at 09:29:25PM -0300, Leonardo Brás wrote:
> Fixing some styles as recommended by checkpatch.pl.
>
> Signed-off-by: Leonardo Brás
> ---
> drivers/staging/fbtft/fbtft-bus.c | 10 ++
> drivers/staging/fbtft/fbtft-core.c | 6 --
> drivers/staging/fbtft/fbtft.h
On Tue, Aug 07, 2018 at 09:28:00PM -0300, Leonardo Brás wrote:
> Changes some udelay(n) for n >= 10 to usleep_range(n, n+x) as recommended by
> checkpatch.pl.
Please properly wrap your changelog lines at 72 columns or close to
that.
>
> Signed-off-by: Leonardo Brás
> ---
>
On Mon, Aug 06, 2018 at 12:03:10PM +0200, Christian Gromm wrote:
> The channel attribute dbr_size is only relevant for the DIM2 interface. So
> is the packets_per_xact for USB. Currently, all attrs are shown by default
> in sysfs for any channel. To get a clean content of a channel directory,
>
On Mon, Aug 06, 2018 at 10:21:46AM +1000, NeilBrown wrote:
> On Fri, Aug 03 2018, Sergio Paracuellos wrote:
>
> > This patch series include an attempt to avoid the use of custom
> > read and writes in driver code and use PCI subsystem common ones.
> >
> > In order to do this 'map_bus' callback is
Hi,
On Sat, 2018-08-04 at 15:30 +0200, Hans Verkuil wrote:
> On 07/25/2018 12:02 PM, Paul Kocialkowski wrote:
[...]
> > diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst
> > b/Documentation/media/uapi/v4l/pixfmt-compressed.rst
> > index abec03937bb3..4e73f62b5163 100644
> > ---
Hi Hans,
On Sat, 2018-08-04 at 13:35 +0200, Hans Verkuil wrote:
> Hi Paul,
>
> Some comments below. It looks pretty good, it's mostly small things that I
> commented upon.
And thanks for the review!
> On 07/25/2018 12:02 PM, Paul Kocialkowski wrote:
> > Stateless video decoding engines require
The header mp_custom_oid.h is not used, so remove it.
'git grep mp_custom_oid.h drivers/staging/rtl8188eu/'
returns nothing.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/mp_custom_oid.h | 339 --
1 file changed, 339 deletions(-)
delete mode 100644
On Tue, 2018-08-07 at 22:12 +0100, John Whitmore wrote:
> Rename the Macro cpMacAddr(des, src), as it causes a checkpatch issue
> due its use of CamelCase naming, to cp_mac_addr(des, src).
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h
>
Splits definition of function programModeRegisters into two lines such
that each line is less than 80 characters.
Signed-off-by: Abishek V Ashok
---
drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hi,
On Mon, 2018-08-06 at 16:21 +0200, Paul Kocialkowski wrote:
> Hi,
>
> On Fri, 2018-08-03 at 17:49 -0300, Ezequiel Garcia wrote:
> > On Wed, 2018-07-25 at 12:02 +0200, Paul Kocialkowski wrote:
> > > This introduces the Cedrus VPU driver that supports the VPU found in
> > > Allwinner SoCs,
On Sun, Aug 05, 2018 at 09:41:06PM +0200, Frank Werner-Krippendorf wrote:
> Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix
> a coding style issue "Statements should start on a tabstop"
> detected by checkpatch.pl script.
>
> Signed-off-by: Frank Werner-Krippendorf
> ---
>
On Sun, Aug 05, 2018 at 01:07:34PM -0700, Todd Poynor wrote:
> From: Todd Poynor
>
> Stop wrapping PCI core calls like probe, enable, remove, etc. in the
> gasket framework, move these calls to the device driver instead. Have
> gasket drivers call into framework on init, enable, disable,
> etc.
On Sun, Aug 05, 2018 at 01:07:38PM -0700, Todd Poynor wrote:
> From: Todd Poynor
>
> Remaining info-level logs in gasket core converted to debug-level; the
> information is not needed during normal system operation.
>
> Signed-off-by: Todd Poynor
> ---
> drivers/staging/gasket/gasket_core.c |
On Wed, Aug 08, 2018 at 01:12:53AM -0700, Joe Perches wrote:
> On Tue, 2018-08-07 at 22:12 +0100, John Whitmore wrote:
> > The eqMacAddr(a, b) macro causes a checkpatch issue, due to CamelCase
> > naming, so has been renamed to eq_mac_addr(a, b).
> >
> > This is a coding style change which should
48 matches
Mail list logo
