Re: [PATCH] android: binder: no outgoing transaction when thread todo has transaction

Sherry, this was found by syzkaller, right? In that case, can you add the tag so the issue gets closed automatically when this gets merged? On Tue, Aug 14, 2018 at 2:28 AM, Sherry Yang wrote: > When a process dies, failed reply is sent to the sender of any transaction > queued on a dead thread'

[PATCH 16/24] staging: wilc1000: refactor tcp_process() to avoid extra leading tabs

Refactor tcp_process() to avoid unnecessary leading tabs in the function. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 52 +++- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/

[PATCH 12/24] staging: wilc1000: move static variable 'terminated_handle' to wilc_vif struct

Remove the use of static variable 'terminated_handle' and instead move in wilc_vif struct. After moving this variable to wilc_vif struct its not required to keep 'terminated_handle', so changed it to boolean type. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 11 +

[PATCH 20/24] staging: wilc1000: avoid line over 80 chars in tcp_process()

Cleanup patch to avoid line over 80 chars issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wla

[PATCH 14/24] staging: wilc1000: rename 'dummy_statistics' variable to 'periodic_stat'

Cleanup patch to use appropriate variable name to fetch the periodic statistics. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagin

[PATCH 15/24] staging: wilc1000: move 'rcv_assoc_resp' as part of hif_drv

Avoid use of static variable and move 'rcv_assoc_resp' as part of 'hif_drv' struct. Rename from 'rcv_assoc_resp' to 'assoc_resp'. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 +++- drivers/staging/wilc1000/host_interface.h | 1 + 2 files changed, 4 insertions(+

[PATCH 23/24] staging: wilc1000: move 'wilc_connecting' static variable to 'wilc_vif' struct

Move static variable 'wilc_connecting' as part of 'wilc_vif' private struct. Remove "wilc_" prefix from name as its already part of wilc_vif struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 -

[PATCH 18/24] staging: wilc1000: move tcp_ack_filter algo related variables to 'wilc_vif' struct

Avoid use of static variables and move them as part of wilc_vif struct. Move all the parameters related to tcp_ack_filter algo to wilc_vif struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +-

[PATCH 11/24] staging: wilc1000: move hif specific static variables to 'wilc' structure

Avoid use of static variable and move it in 'wilc' structure related to hif and added NULL before accessing hif_workqueue in wilc_enqueue_work(). Below variables are moved to 'wilc' struct: struct workqueue_struct *hif_workqueue; struct mutex hif_deinit_lock; struct completion hif_driver_comp;

[PATCH 17/24] staging: wilc1000: use lowercase for get_BSSID() and HIL variable

Cleanup patch to use lowercase name for get_BSSID() and HIL variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c| 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1

[PATCH 22/24] staging: wilc1000: move 'chip_ps_state' static variable as part of 'wilc' struct

Move the static variable as part of 'wilc' priv struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 ++ drivers/staging/wilc1000/wilc_wlan.c | 10 -- 3 files changed, 7 insertions(+), 6 de

[PATCH 24/24] staging: wilc1000: remove unnecessary static variable 'p2p_listen_state'

Remove the use of unnecessary static variable 'p2p_listen_state'. Already 'p2p_listen_state' is present in 'wilc_priv' struct. So making use of that variable as its getting set in channel ready and remain on channel expired callback. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_in

[PATCH 21/24] staging: wilc1000: remove unused code to set and get IP address

Cleanup code to remove the variables related to setting and getting IP address as this case was not handled from firmware side. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 105 -- drivers/staging/wilc1000/host_interface.h | 3 - drivers

[PATCH 09/24] staging: wilc1000: move static variable clients_count to 'wilc' structure

Avoid use of static variable 'clients_count' and move it part of 'wilc' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 9 - drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH 19/24] staging: wilc1000: avoid line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack()

Cleanup patch to avoid line over 80 chars checkpatch issue introduced in previous code refactor commit. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drive

[PATCH 02/24] staging: wilc1000: move 'aging_timer' static variable to wilc_priv struct

Moved 'aging_timer' to wilc_priv struct instead of having it as static variable. As 'aging_timer' is maintained for each interfaces so 'op_ifcs' check is not required before the timer_setup() and del_timer_sync() call. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations

[PATCH 00/24] staging: wilc1000: avoid use of static and global variable

This patch set mainly contains changes to avoid the use of static and global variables. Also contains few patch to avoid the checkpatch warning arise due to code refactor. Ajay Singh (24): staging: wilc1000: move 'wilc_enable_ps' global variable into 'wilc' struct staging: wilc1000: move '

[PATCH 08/24] staging: wilc1000: avoid use of extra 'if' condition in wilc_init()

Cleanup patch to avoid the avoid extra 'if' condition and clubbed the same condition in single 'if' block. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wil

[PATCH 07/24] staging: wilc1000: remove unused variable 'op_ifcs'

After code refactor in previous commit now 'op_ifcs' is not require any more, so remove it. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging

[PATCH 06/24] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

Move global variable 'wilc_during_ip_timer' and 'wilc_optaining_ip' to 'wilc_vif' structure. Rename these variables like below wilc_during_ip_timer -> during_ip_timer wilc_optaining_ip -> obtaining_ip. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15 +++

[PATCH 10/24] staging: wilc1000: move wilc_multicast_mac_addr_list to 'wilc_vif' struct

Instead of using 'wilc_multicast_mac_addr_list' as global variable move it part of wilc_vif struct. Rename 'wilc_multicast_mac_addr_list' variable to 'mc_mac_addr_list' as its now part of 'wilc_vif' struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 +--- dr

[PATCH 01/24] staging: wilc1000: move 'wilc_enable_ps' global variable into 'wilc' struct

Instead of having 'wilc_enable_ps' as global variable moved it to 'wilc' structure. Rename 'wilc_enable_ps' to 'enable_ps' as its already part of 'wilc' structure Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 5 ++--- drivers/staging/wilc1000/wilc_wfi_cfgoper

[PATCH 04/24] staging: wilc1000: remove unnecessary NULL check in clear_shadow_scan()

Cleanup patch to remove the unnecessary NULL check before freeing up ies information in clear_shadow_scan(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi

[PATCH 03/24] staging: wilc1000: fix to use correct index to free scanned info in clear_shadow_scan()

Fixes to use correct index to free the allocated memory for ies information. The check was done using 'last_scanned_cnt' index and its not correct, so use the correct index ('i') to check for before freeing the allocated memory. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfg

[PATCH 13/24] staging: wilc1000: move 'periodic_rssi' as part of 'wilc_vif' struct

Refactor code to move 'periodic_rssi' as part of wilc_vif struct.Move 'dummy_statistics' from 'wilc' struct to 'wilc_vif' to maintain for each interface separatly. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 19 --- drivers/staging/wilc1000/wilc_

[PATCH 05/24] staging: wilc1000: moved last_scanned_shadow & last_scanned_cnt to wilc_priv struct

Avoid use of static variables and moved the varibles as part of private data. last_scanned_shadow & last_scanned_cnt variable is moved to 'wilc_priv' to maintain for each interface. After moving static variable, clear_shadow_scan() doesn't require check 'op_ifcs' count as now for each interface the

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

Hi Arnd, On Mon, 13 Aug 2018 23:20:33 +0200 Arnd Bergmann wrote: > The TODO item named "make spi and sdio components coexist in one > build" was apparently addressed a long time ago, but never removed > from the TODO file. However, the new patch that tries to address it > actually makes it worse

[PATCH] android: binder: no outgoing transaction when thread todo has transaction

When a process dies, failed reply is sent to the sender of any transaction queued on a dead thread's todo list. The sender asserts that the received failed reply corresponds to the head of the transaction stack. This assert can fail if the dead thread is allowed to send outgoing transactions when t

[PATCH] media: imx: work around false-positive warning, again

A warning that I thought to be solved by a previous patch of mine has resurfaced with gcc-8: media/imx/imx-media-csi.c: In function 'csi_link_validate': media/imx/imx-media-csi.c:1025:20: error: 'upstream_ep' may be used uninitialized in this function [-Werror=maybe-uninitialized] media/imx/imx-m

[PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

The TODO item named "make spi and sdio components coexist in one build" was apparently addressed a long time ago, but never removed from the TODO file. However, the new patch that tries to address it actually makes it worse again by duplicating the common parts of the driver into two separate modul

[PATCH] Staging: rtlwifi: efuse: fixed a line length coding style issue

Fixed a code style issue. Line length over 80 characters. Signed-off-by: Tom Todd --- drivers/staging/rtlwifi/efuse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/efuse.c b/drivers/staging/rtlwifi/efuse.c index 1dc71455f270..49ec9728fb04 100644 --

Re: [PATCH 2/5] vmbus: add driver_override support

On Mon, 13 Aug 2018 19:30:50 + "Michael Kelley (EOSG)" wrote: > From: k...@linuxonhyperv.com Sent: Friday, August > 10, 2018 4:06 PM > > > From: Stephen Hemminger > > > > Add support for overriding the default driver for a VMBus device > > in the same way that it can be done for PCI dev

Re: [PATCH 2/5] vmbus: add driver_override support

On Mon, Aug 13, 2018 at 07:30:50PM +, Michael Kelley (EOSG) wrote: > From: k...@linuxonhyperv.com Sent: Friday, August > 10, 2018 4:06 PM > > > From: Stephen Hemminger > > > > Add support for overriding the default driver for a VMBus device > > in the same way that it can be done for PCI

RE: [PATCH 2/5] vmbus: add driver_override support

From: k...@linuxonhyperv.com Sent: Friday, August 10, 2018 4:06 PM > From: Stephen Hemminger > > Add support for overriding the default driver for a VMBus device > in the same way that it can be done for PCI devices. This patch > adds the /sys/bus/vmbus/devices/.../driver_override file > and

Re: [PATCH] vmbus: don't return values for uninitalized channels

Stephen Hemminger writes: > For unsupported device types, the vmbus channel ringbuffer is never > initialized, and therefore reading the sysfs files will return garbage > or cause a kernel OOPS. > > Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") > Signed-off-by: Stephen Hemminger > --

[PATCH] vmbus: don't return values for uninitalized channels

For unsupported device types, the vmbus channel ringbuffer is never initialized, and therefore reading the sysfs files will return garbage or cause a kernel OOPS. Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") Signed-off-by: Stephen Hemminger --- drivers/hv/vmbus_drv.c | 3 +++ 1 file

RE: [PATCH 1/5] Tools: hv: Fix a bug in the key delete code

From: k...@linuxonhyperv.com Sent: Friday, August 10, 2018 4:06 PM > > Fix a bug in the key delete code - the num_records range > from 0 to num_records-1. > > Signed-off-by: K. Y. Srinivasan > Reported-by: David Binderman > Cc: > --- Reviewed-by: Michael Kelley

[PATCH] Staging: octeon-usb: Replaces CVMX_WAIT_FOR_FIELD32 macro with a function

Replaces CVMX_WAIT_FOR_FIELD32 macro with equivalent function. Signed-off-by: Georgios Tsotsos --- drivers/staging/octeon-usb/octeon-hcd.c | 56 + 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/st

Re: [PATCH] staging: erofs: change 'unsigned' to 'unsigned int'

Hi Leon, On 2018/8/13 23:20, Leon Imhof wrote: > Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" > detected by checkpatch.pl > > Signed-off-by: Leon Imhof > --- Thanks for the patch, could be better if use `[PATCH v2]' to indicate that you send a new version of `[PATCH]

[PATCH] staging: erofs: change 'unsigned' to 'unsigned int'

Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" detected by checkpatch.pl Signed-off-by: Leon Imhof --- drivers/staging/erofs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c index ac26

Re: [PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote: > From: Thierry Reding > > The BSEV clock has a separate gate bit and can not be assumed to be > always enabled. Add explicit handling for the BSEV clock and reset. > > This fixes an issue on Tegra124 where the BSEV clock is not enable

[PATCH 09/14] staging: media: tegra-vde: Add IOMMU support

From: Thierry Reding Implement support for using an IOMMU to map physically discontiguous buffers into contiguous I/O virtual mappings that the VDE can use. This allows importing arbitrary DMA-BUFs for use by the VDE. While at it, make sure that the device is detached from any DMA/IOMMU mapping

[PATCH 02/14] staging: media: tegra-vde: Support reference picture marking

From: Thierry Reding Tegra114 and Tegra124 support reference picture marking, which will cause BSEV to write picture marking data to SDRAM. Make sure there is a valid destination address for that data to avoid error messages from the memory controller. Signed-off-by: Thierry Reding --- drivers

[PATCH 03/14] staging: media: tegra-vde: Prepare for interlacing support

From: Thierry Reding The number of frames doubles when decoding interlaced content and the structures describing the frames double in size. Take that into account to prepare for interlacing support. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 73

[PATCH 00/14] staging: media: tegra-vdea: Add Tegra124 support

From: Thierry Reding Hi, this set of patches perform a bit of cleanup and extend support to the VDE implementation found on Tegra114 and Tegra124. This requires adding handling for a clock and a reset for the BSEV block that is separate from the main VDE block. The new VDE revision also supports

[PATCH 11/14] ARM: tegra: Enable VDE on Tegra124

From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra124.dtsi | 40 + 1 file changed, 40 insertions(+) diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index b113e47b2b2a..8fdca4723205 100644 --- a/arch/arm/

[PATCH 14/14] ARM: tegra: Enable SMMU for VDE on Tegra124

From: Thierry Reding The video decode engine can use the SMMU to use buffers that are not physically contiguous in memory. This allows better memory usage for video decoding, since fragmentation may cause contiguous allocations to fail. Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra

[PATCH 06/14] staging: media: tegra-vde: Print out invalid FD

From: Thierry Reding Include the invalid file descriptor when reporting an error message to help diagnosing why importing the buffer failed. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 12/14] ARM: tegra: Add BSEV clock and reset for VDE on Tegra20

From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra20.dtsi | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index 15b73bd377f0..abb5738a0705 100644 --- a/arch/arm/boot/dts/te

[PATCH 07/14] staging: media: tegra-vde: Add some clarifying comments

From: Thierry Reding Add some comments specifying what tables are being set up in VRAM. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/

[PATCH 10/14] staging: media: tegra-vde: Keep VDE in reset when unused

From: Thierry Reding There is no point in keeping the VDE module out of reset when it is not in use. Reset it on runtime suspend. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/tegra-vde/te

[PATCH 04/14] staging: media: tegra-vde: Use DRM/KMS framebuffer modifiers

From: Thierry Reding VDE on Tegra20 through Tegra114 supports reading and writing frames in 16x16 tiled layout. Similarily, the various block-linear layouts that are supported by the GPU on Tegra124 can also be read from and written to by the Tegra124 VDE. Enable userspace to specify the desired

[PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

From: Thierry Reding The BSEV clock has a separate gate bit and can not be assumed to be always enabled. Add explicit handling for the BSEV clock and reset. This fixes an issue on Tegra124 where the BSEV clock is not enabled by default and therefore accessing the BSEV registers will hang the CPU

[PATCH 13/14] ARM: tegra: Add BSEV clock and reset for VDE on Tegra30

From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra30.dtsi | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi index a6781f653310..492917d61bab 100644 --- a/arch/arm/boot/dts/te

[PATCH 05/14] staging: media: tegra-vde: Properly mark invalid entries

From: Thierry Reding Entries in the reference picture list are marked as invalid by setting the frame ID to 0x3f. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/tegra-vde/te

[PATCH 08/14] staging: media: tegra-vde: Track struct device *

From: Thierry Reding The pointer to the struct device is frequently used, so store it in struct tegra_vde. Also, pass around a pointer to a struct tegra_vde instead of struct device in some cases to prepare for subsequent patches referencing additional data from that structure. Signed-off-by: Th

дюгд

взр тднй ттос ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

еюда

фцф йиаэ егея ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

> But it is better to fix them in an independent patch. :) Yah. Of course. This was completely unrelated. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-dev

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

Hi Dan, On 2018/8/13 20:25, Dan Carpenter wrote: > On Mon, Aug 13, 2018 at 08:17:27PM +0800, Gao Xiang wrote: >>> /* we assume that ofs is aligned with 4 bytes */ >>> it->ofs = EROFS_XATTR_ALIGN(it->ofs); >>> return err; >>> > This might be cleaner if we wrote: > > return (err <

Re: [PATCH 4/8] staging: erofs: cleanup z_erofs_vle_work_{lookup, register}

Hi Dan, On 2018/8/13 21:05, Dan Carpenter wrote: > Yeah. You'd have to remove the const. > > Anyway, on looking at it more, I guess this patch is fine for now. We > will probably end up changing z_erofs_vle_work_lookup() and > z_erofs_vle_work_register() some more in the future. > Thanks for

[PATCH 1/2] staging: most: register channel device after init of struct members

This patch moves the call to device_register to the end of the channel initialization section that the devcie belongs to. It is needed to avoid NULL pointer dereferences once the device is registered with sysfs. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 8 1 file

Re: [PATCH] staging: erofs: add int to usigned

Hi Leon, On 2018/8/13 20:09, Leon Imhof wrote: > Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" > detected by checkpatch.pl > > Signed-off-by: Leon Imhof Looks fine, Reviewed-by: Gao Xiang (BTW, could you fix the title of this commit? Thanks.) > --- > drivers/stag

Re: [PATCH 4/8] staging: erofs: cleanup z_erofs_vle_work_{lookup, register}

Yeah. You'd have to remove the const. Anyway, on looking at it more, I guess this patch is fine for now. We will probably end up changing z_erofs_vle_work_lookup() and z_erofs_vle_work_register() some more in the future. regards, dan carpenter ___ de

[PATCH 2/2] staging: most: do not make interface dependent attrs default for all channels

The channel attribute dbr_size is only relevant for the DIM2 interface. so is the packets_per_xact for USB. This patch cleans up the driver's ABI by not showing all attributes by default for each channel, but only on those they belong to. Signed-off-by: Christian Gromm --- drivers/staging/most/c

[PATCH 0/2] staging: most: clean up sysfs interface

This patch set cleans up the driver's ABI. It takes care of proper initialization sequences and prevents interface dependent channel attributes from being displayed by default on all interfaces. Christian Gromm (2): staging: most: register channel device after init of struct members staging:

Re: [PATCH 6/8] staging: erofs: fix vle_decompressed_index_clusterofs

Hi Dan, On 2018/8/13 20:03, Dan Carpenter wrote: >> -static inline unsigned >> -vle_compressed_index_clusterofs(unsigned clustersize, >> -struct z_erofs_vle_decompressed_index *di) >> +static inline int >> +vle_decompressed_index_clusterofs(unsigned int *clusterofs, > > Not related to your pa

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

Hi Dan, On 2018/8/13 20:40, Dan Carpenter wrote: > On Mon, Aug 13, 2018 at 08:17:27PM +0800, Gao Xiang wrote: @@ -294,8 +322,11 @@ static int inline_getxattr(struct inode *inode, struct getxattr_iter *it) ret = xattr_foreach(&it->it, &find_xattr_handlers, &remaining); >>

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

On 2018/8/13 20:17, Gao Xiang wrote: >> Generally the rule on likely/unlikely is that they hurt readability so >> we should only add them if it makes a difference in benchmarking. >> > > In my opinion, return values other than 0 and ENOATTR(ENODATA) rarely happens, > it should be in the slow path.

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

On Mon, Aug 13, 2018 at 08:17:27PM +0800, Gao Xiang wrote: > >> @@ -294,8 +322,11 @@ static int inline_getxattr(struct inode *inode, > >> struct getxattr_iter *it) > >>ret = xattr_foreach(&it->it, &find_xattr_handlers, &remaining); > >>if (ret >= 0) > >>

Re: [PATCH 4/8] staging: erofs: cleanup z_erofs_vle_work_{lookup, register}

Hi Dan, On 2018/8/13 20:00, Dan Carpenter wrote: > On Sun, Aug 12, 2018 at 10:01:46PM +0800, Chao Yu wrote: >> From: Gao Xiang >> >> This patch introduces 'struct z_erofs_vle_work_finder' to clean up >> arguments of z_erofs_vle_work_lookup and z_erofs_vle_work_register. >> >> Signed-off-by: Gao X

Re: [PATCH 2/8] staging: erofs: separate erofs_get_meta_page

On 2018/8/13 19:04, Dan Carpenter wrote: > On Sun, Aug 12, 2018 at 10:01:44PM +0800, Chao Yu wrote: >> --- a/drivers/staging/erofs/data.c >> +++ b/drivers/staging/erofs/data.c >> @@ -39,31 +39,44 @@ static inline void read_endio(struct bio *bio) >> } >> >> /* prio -- true is used for dir */ >>

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

On Mon, Aug 13, 2018 at 08:17:27PM +0800, Gao Xiang wrote: > > /* we assume that ofs is aligned with 4 bytes */ > > it->ofs = EROFS_XATTR_ALIGN(it->ofs); > > return err; > > This might be cleaner if we wrote: return (err < 0) ? error : 0; The callers all treate zero and one

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

Hi Dan, On 2018/8/13 19:47, Dan Carpenter wrote: >> -static void xattr_iter_fixup(struct xattr_iter *it) >> +static inline int xattr_iter_fixup(struct xattr_iter *it) >> { >> -if (unlikely(it->ofs >= EROFS_BLKSIZ)) { >> -xattr_iter_end(it, true); >> +if (likely(it->ofs < EROFS

[PATCH] staging: erofs: add int to usigned

Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" detected by checkpatch.pl Signed-off-by: Leon Imhof --- drivers/staging/erofs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c index ac26

Re: [PATCH 6/8] staging: erofs: fix vle_decompressed_index_clusterofs

> -static inline unsigned > -vle_compressed_index_clusterofs(unsigned clustersize, > - struct z_erofs_vle_decompressed_index *di) > +static inline int > +vle_decompressed_index_clusterofs(unsigned int *clusterofs, Not related to your patch, but don't make functions inline. Leave it to the com

Re: [PATCH 4/8] staging: erofs: cleanup z_erofs_vle_work_{lookup, register}

On Sun, Aug 12, 2018 at 10:01:46PM +0800, Chao Yu wrote: > From: Gao Xiang > > This patch introduces 'struct z_erofs_vle_work_finder' to clean up > arguments of z_erofs_vle_work_lookup and z_erofs_vle_work_register. > > Signed-off-by: Gao Xiang > Reviewed-by: Chao Yu > Signed-off-by: Chao Yu

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

> -static void xattr_iter_fixup(struct xattr_iter *it) > +static inline int xattr_iter_fixup(struct xattr_iter *it) > { > - if (unlikely(it->ofs >= EROFS_BLKSIZ)) { > - xattr_iter_end(it, true); > + if (likely(it->ofs < EROFS_BLKSIZ)) > + return 0; > > -

Re: [PATCH 2/8] staging: erofs: separate erofs_get_meta_page

Hi Dan, On 2018/8/13 19:04, Dan Carpenter wrote: > On Sun, Aug 12, 2018 at 10:01:44PM +0800, Chao Yu wrote: >> --- a/drivers/staging/erofs/data.c >> +++ b/drivers/staging/erofs/data.c >> @@ -39,31 +39,44 @@ static inline void read_endio(struct bio *bio) >> } >> >> /* prio -- true is used for d

Re: [PATCH 2/8] staging: erofs: separate erofs_get_meta_page

On Sun, Aug 12, 2018 at 10:01:44PM +0800, Chao Yu wrote: > --- a/drivers/staging/erofs/data.c > +++ b/drivers/staging/erofs/data.c > @@ -39,31 +39,44 @@ static inline void read_endio(struct bio *bio) > } > > /* prio -- true is used for dir */ > -struct page *erofs_get_meta_page(struct super_blo

mobile apps for you

Do you need mobile apps development? We can do it for you. We are an India base company. Here are the details about us: Years in business: 8 Staffs: 125 App developed: 350 We work on Android, iOS, Ionic, and PhoneGap platforms, we have clients across different kind of industries. Such like retai

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

Hi Xiang, On 2018/8/13 10:36, Gao Xiang wrote: > Hi Chao, > > On 2018/8/13 10:00, Chao Yu wrote: >> On 2018/8/12 22:01, Chao Yu wrote: >>> From: Gao Xiang >>> >>> This patch enhances the missing error handling code for >>> xattr submodule, which improves the stability for the rare cases. >>> >>>

the mobile apps

Do you need mobile apps development? We can do it for you. We are an India base company. Here are the details about us: Years in business: 8 Staffs: 125 App developed: 350 We work on Android, iOS, Ionic, and PhoneGap platforms, we have clients across different kind of industries. Such like retai

Re: [PATCH 00/16] staging: gasket: return of the son of cleanups

Btw, can someone explain what 'gasket' even is? A quick look through the directory didn't provide any answers. And please don't just send that anser to me, put it in the source tree (Kconfig, and if needed another documentation file). ___ devel mailing