On 2018/9/3 9:49, Chao Yu wrote:
> On 2018/8/30 23:14, Pavel Zemlyanoy wrote:
>> This patch does not change the logic, it only
>> corrects the formatting and checkpatch check by
>> alignment should match open parenthesis.
>>
>> The patch fixes 2 check of type:
>> "Check: Alignment should match
On 2018/9/3 9:49, Chao Yu wrote:
> On 2018/8/30 23:14, Pavel Zemlyanoy wrote:
>> This patch does not change the logic, it only
>> corrects the formatting and checkpatch checks by
>> braces {} should be used on all arms of this statement,
>> unbalanced braces around else statement and warning by
On 2018/9/3 9:47, Chao Yu wrote:
> On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
>>
>> This patch does not change the logic, it only
>> corrects the formatting and checkpatch warnings by
>> adding "int" to the unsigned type.
>>
>> The patch fixes 11 warnings of the type:
>> "WARNING: Prefer
On 2018/9/3 9:48, Chao Yu wrote:
> On 2018/8/30 23:14, Pavel Zemlyanoy wrote:
>> This patch does not change the logic, it only
>> corrects the formatting and checkpatch check by
>> adding spaces around '*'.
>>
>> The patch fixes 1 check of type:
>> "Check: spaces preferred around that '*'".
>>
On 2018/9/3 9:48, Chao Yu wrote:
> On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
>> This patch does not change the logic, it only
>> corrects the formatting and checkpatch checks by
>> adding spaces around '-'.
>>
>> The patch fixes 4 checks of type:
>> "Check: spaces preferred around that '-'".
> +++ b/drivers/auxdisplay/hd44780.c
> @@ -62,17 +62,12 @@ static void hd44780_strobe_gpio(struct hd44780 *hd)
> /* write to an LCD panel register in 8 bit GPIO mode */
> static void hd44780_write_gpio8(struct hd44780 *hd, u8 val, unsigned int rs)
> {
> - int values[10]; /* for DATA[0-7],
Hi,
On 2018/9/3 9:59, Chao Yu wrote:
> On 2018/8/31 17:41, Dan Carpenter wrote:
>> On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote:
>>>
>>> Hi Xiang,
>>>
>>> I'm not against this change which follows checkpatch's rule, since I think
>>> this
>>> can help to unify coding style in
On 2018/8/31 17:41, Dan Carpenter wrote:
> On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote:
>>
>> Hi Xiang,
>>
>> I'm not against this change which follows checkpatch's rule, since I think
>> this
>> can help to unify coding style in different modules of Linux. Maybe cleanup
>> in
>>
Hi,
It looks like there is another patch from Pavel Zemlyanoy changing the same
place, I think it needs to rebase this patch on that one.
[PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c
On 2018/8/31 4:56, Thomas Weißschuh wrote:
> Signed-off-by: Thomas Weißschuh
> ---
>
On 2018/8/30 23:14, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch checks by
> braces {} should be used on all arms of this statement,
> unbalanced braces around else statement and warning by
> braces {} are not necessary for any arm
On 2018/8/30 23:14, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch check by
> alignment should match open parenthesis.
>
> The patch fixes 2 check of type:
> "Check: Alignment should match open parenthesis".
>
> Signed-off-by:
On 2018/8/30 23:14, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch check by
> adding spaces around '*'.
>
> The patch fixes 1 check of type:
> "Check: spaces preferred around that '*'".
>
> Signed-off-by: Pavel Zemlyanoy
On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch checks by
> adding spaces around '-'.
>
> The patch fixes 4 checks of type:
> "Check: spaces preferred around that '-'".
>
> Signed-off-by: Pavel Zemlyanoy
On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch checks by
> to NULL comparison.
>
> The patch fixes 5 checks of type:
> "Comparison to NULL could be written".
>
> Signed-off-by: Pavel Zemlyanoy
Reviewed-by:
On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
>
> This patch does not change the logic, it only
> corrects the formatting and checkpatch warnings by
> adding "int" to the unsigned type.
>
> The patch fixes 11 warnings of the type:
> "WARNING: Prefer 'unsigned int' to bare use of 'unsigned'"
>
>
On Sun, Sep 02, 2018 at 03:45:01PM +0530, Nitin Gupta wrote:
> Hi Greg
>
> i am working on some project which is having huge changes and working
> on kernel-2.6.32-131.696
> it will be very difficult to back port them into 4.8 .
Why 4.8? That too is a totally unsupported kernel version.
On Sun, Sep 02, 2018 at 02:01:41PM +0200, Janusz Krzysztofik wrote:
> @@ -461,7 +461,7 @@ static long linehandle_ioctl(struct file *filep, unsigned
> int cmd,
>
> /* Clamp all values to [0,1] */
> for (i = 0; i < lh->numdescs; i++)
> - vals[i] =
Certain GPIO descriptor arrays returned by gpio_get_array() may contain
information on direct mapping of array members to pins of a single GPIO
chip in hardware order. In such cases, bitmaps of values can be passed
directly from/to the chip's .get/set_multiple() callbacks without
wasting time on
Certain GPIO array lookup results may map directly to GPIO pins of a
single GPIO chip in hardware order. If that condition is recognized
and handled efficiently, significant performance gain of get/set array
functions may be possible.
While processing a request for an array of GPIO descriptors,
In order to make use of array info obtained from gpiod_get_array() and
speed up processing of arrays matching single GPIO chip layout, that
information must be passed to get/set array functions. Extend the
functions' API with that additional parameter and update all users.
Pass NULL if a user
Most users of get/set array functions iterate consecutive bits of data,
usually a single integer, while processing array of results obtained
from, or building an array of values to be passed to those functions.
Save time wasted on those iterations by changing the functions' API to
accept bitmaps.
The goal is to boost performance of get/set array functions while
processing GPIO arrays which represent pins of a signle chip in
hardware order. If resulting performance is close to PIO, GPIO API
can be used for data I/O without much loss of speed.
Created and tested on a low end Amstrad
Hi Miguel,
On Thursday, August 30, 2018 1:10:59 PM CEST Miguel Ojeda wrote:
> Hi Janusz,
>
> On Wed, Aug 29, 2018 at 10:48 PM, Janusz Krzysztofik
> wrote:
> > ...
> > /* High nibble + RS, RW */
> > - for (i = 4; i < 8; i++)
> > - values[PIN_DATA0 + i] = !!(val &
23 matches
Mail list logo
