[PATCH] staging: rtlwifi: Use proper enumerated types for Wi-Fi only interface

2018-09-21 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:1264:34: warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversion]

RE: [PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-21 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Friday, September 21, 2018 4:22 PM > To: Haiyang Zhang > Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; vkuznets > > Subject: Re: [PATCH net-next,

Re: [PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-21 Thread Stephen Hemminger
On Fri, 21 Sep 2018 18:51:54 + Haiyang Zhang wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Friday, September 21, 2018 2:37 PM > > To: Haiyang Zhang > > Cc: Haiyang Zhang ; da...@davemloft.net; > > net...@vger.kernel.org; o...@aepfle.de;

[PATCH] staging: vc04_services: Remove unused vchiq_genversion script

2018-09-21 Thread Tuomas Tynkkynen
As far as I can tell, this has never been used. Signed-off-by: Tuomas Tynkkynen --- .../interface/vchiq_arm/vchiq_genversion | 88 -- 1 file changed, 88 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_genversion diff --git

[PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

2018-09-21 Thread Karthik Nishanth
The member regd of the struct rtl_priv is true in a boolean context. drivers/staging/rtlwifi/regd.c:413:27: warning: address of 'rtlpriv->regd' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!wiphy || !>regd) ~ ~^~~~ 1 warning

RE: [PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-21 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Friday, September 21, 2018 2:37 PM > To: Haiyang Zhang > Cc: Haiyang Zhang ; da...@davemloft.net; > net...@vger.kernel.org; o...@aepfle.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; vkuznets > Subject: Re:

Re: [PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-21 Thread Stephen Hemminger
On Fri, 21 Sep 2018 18:20:35 + Haiyang Zhang wrote: Overall, this looks good. Some minor suggestions. > +struct nvsc_rsc { > + const struct ndis_pkt_8021q_info *vlan; > + const struct ndis_tcp_ip_checksum_info *csum_info; > + u8 is_last; /* last RNDIS msg in a vmtransfer_page */

[PATCH net-next, v2, 3/3] hv_netvsc: Update document for LRO/RSC support

2018-09-21 Thread Haiyang Zhang
From: Haiyang Zhang Update document for LRO/RSC support, and the command line info to change the setting. Signed-off-by: Haiyang Zhang --- Documentation/networking/netvsc.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/networking/netvsc.txt

[PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-21 Thread Haiyang Zhang
From: Haiyang Zhang LRO/RSC in the vSwitch is a feature available in Windows Server 2019 hosts and later. It reduces the per packet processing overhead by coalescing multiple TCP segments when possible. This patch adds netvsc driver support for this feature. Signed-off-by: Haiyang Zhang ---

[PATCH net-next, v2, 2/3] hv_netvsc: Add handler for LRO setting change

2018-09-21 Thread Haiyang Zhang
From: Haiyang Zhang This patch adds the handler for LRO setting change, so that a user can use ethtool command to enable / disable LRO feature. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 4 drivers/net/hyperv/netvsc_drv.c | 30 ++

[PATCH net-next,v2,0/3] hv_netvsc: Support LRO/RSC in the vSwitch

2018-09-21 Thread Haiyang Zhang
From: Haiyang Zhang The patch adds support for LRO/RSC in the vSwitch feature. It reduces the per packet processing overhead by coalescing multiple TCP segments when possible. The feature is enabled by default on VMs running on Windows Server 2019 and later. The patch set also adds ethtool

[PATCH] staging: rtl8188eu: Remove unnecessary parentheses

2018-09-21 Thread Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single conditional statement. drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:295:21: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((pwrpriv->rpwm == pslv)) {

Re: [PATCH] memory_hotplug: Free pages as higher order

2018-09-21 Thread Dan Williams
On Fri, Sep 21, 2018 at 2:40 AM Arun KS wrote: > > When free pages are done with higher order, time spend on > coalescing pages by buddy allocator can be reduced. With > section size of 256MB, hot add latency of a single section > shows improvement from 50-60 ms to less than 1 ms, hence >

Re: [PATCH v3] staging: android: ion: Add per-heap counters

2018-09-21 Thread Laura Abbott
On 09/11/2018 04:29 AM, Alexey Skidanov wrote: Heap statistics have been removed and currently even basics statistics are missing. This patch creates per heap debugfs directory /sys/kernel/debug/ and adds the following counters: - the number of allocated buffers; - the number of allocated

Re: [PATCH v7 4/4] gpiolib: Implement fast processing path in get/set array

2018-09-21 Thread Marek Szyprowski
Hi Janusz, On 2018-09-21 12:51, Janusz Krzysztofik wrote: > 2018-09-21 10:18 GMT+02:00, Marek Szyprowski : >> On 2018-09-20 18:21, Janusz Krzysztofik wrote: >>> On Thursday, September 20, 2018 5:48:22 PM CEST Janusz Krzysztofik wrote: On Thursday, September 20, 2018 12:11:48 PM CEST Marek

Re: [PATCH 0/4] Add facility to directly query subdevice timing

2018-09-21 Thread Ian Abbott
On 19/09/18 17:51, Spencer E. Olson wrote: This patchset adds a facility to directly query hardware speed limits of subdevices, in particular for scan_begin and convert signals. This information is generally already stored for many devices, such as analog input devices for NI hardware. This

Re: [PATCH 00/13] device-global identifiers and routes introduced

2018-09-21 Thread Ian Abbott
On 19/09/18 17:38, Spencer E. Olson wrote: Because this patchset has come so far after my last version, I am submitting it without reference to the older patch set. -- This patchset introduces a new framework for providing and maintaining a consistent namespace to define terminal/signal names

Re: [PATCH] staging: comedi: ni_mio_common: protect register write overflow

2018-09-21 Thread Ian Abbott
On 19/09/18 17:17, Spencer E. Olson wrote: Fixes two problems introduced as early as commit 03aef4b6dc12 ("Staging: comedi: add ni_mio_common code"): (1) Ensures that the last four bits of NISTC_RTSI_TRIGB_OUT_REG register is not unduly overwritten on e-series devices. On e-series

Re: [PATCH 04/13] staging: comedi: ni_routing: Add NI signal routing info

2018-09-21 Thread Ian Abbott
On 19/09/18 17:38, Spencer E. Olson wrote: See README for a thorough discussion of this content. Adds tables of all register values for routing various signals to various terminals on National Instruments hardware. This information is directly compared to and taken from register-level

Re: [PATCH v7 4/4] gpiolib: Implement fast processing path in get/set array

2018-09-21 Thread Janusz Krzysztofik
Hi Marek, 2018-09-21 12:51 GMT+02:00, Janusz Krzysztofik : > Hi Marek, > > 2018-09-21 10:18 GMT+02:00, Marek Szyprowski : >> Hi Janusz, >> >> On 2018-09-20 18:21, Janusz Krzysztofik wrote: >>> On Thursday, September 20, 2018 5:48:22 PM CEST Janusz Krzysztofik >>> wrote: On Thursday,

Re: [PATCH v7 4/4] gpiolib: Implement fast processing path in get/set array

2018-09-21 Thread Janusz Krzysztofik
Hi Marek, 2018-09-21 10:18 GMT+02:00, Marek Szyprowski : > Hi Janusz, > > On 2018-09-20 18:21, Janusz Krzysztofik wrote: >> On Thursday, September 20, 2018 5:48:22 PM CEST Janusz Krzysztofik wrote: >>> On Thursday, September 20, 2018 12:11:48 PM CEST Marek Szyprowski wrote: On 2018-09-02

[PATCH] memory_hotplug: Free pages as higher order

2018-09-21 Thread Arun KS
When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less than 1 ms, hence improving the hot add latency by 60%. Modify external providers of

[PATCH] staging: most: fix label names

2018-09-21 Thread Christian Gromm
This patch makes use of label names that say what the goto actually does, as recommended in the kernel documentation. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 12 +-- drivers/staging/most/core.c | 24 ++--- drivers/staging/most/usb/usb.c

Re: [PATCH v7 4/4] gpiolib: Implement fast processing path in get/set array

2018-09-21 Thread Marek Szyprowski
Hi Janusz, On 2018-09-20 18:21, Janusz Krzysztofik wrote: > On Thursday, September 20, 2018 5:48:22 PM CEST Janusz Krzysztofik wrote: >> On Thursday, September 20, 2018 12:11:48 PM CEST Marek Szyprowski wrote: >>> On 2018-09-02 14:01, Janusz Krzysztofik wrote: Certain GPIO descriptor arrays

Re: [PATCH] staging: wilc1000: Remove unnecessary pointer check

2018-09-21 Thread Dan Carpenter
On Fri, Sep 21, 2018 at 01:25:32AM -0400, valdis.kletni...@vt.edu wrote: > On Thu, 20 Sep 2018 14:26:49 -0700, Nathan Chancellor said: > > Clang warns that the address of a pointer will always evaluated as true > > in a boolean context: > > > > drivers/staging/wilc1000/linux_wlan.c:267:20:

Re: [PATCH] staging: wilc1000: Remove unnecessary pointer check

2018-09-21 Thread Ajay Singh
Reviewed-by: Ajay Singh On Thu, 20 Sep 2018 22:39:11 -0700 Nathan Chancellor wrote: > On Fri, Sep 21, 2018 at 01:25:32AM -0400, valdis.kletni...@vt.edu > wrote: > > On Thu, 20 Sep 2018 14:26:49 -0700, Nathan Chancellor said: > > > Clang warns that the address of a pointer will always