[PATCH -next] staging: rtlwifi: Remove set but not used variable 'ppsc'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c: In function 'halbtc_leave_lps': drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:284:21: warning: variable 'ppsc' set but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/btcoexist/halbt

[PATCH] staging: bcm2835-camera: Avoid unneeded internal declaration warning

Clang warns: drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: variable 'mains_freq_qmenu' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const s64 mains_freq_qmenu[] = { ^ 1 warning generated. This is because mains_freq_qmenu

[PATCH] staging: rtl8723bs: Skip unnecessary field checks

Skip unnecessary request field checks when the information element pointer is null. Signed-off-by: Aymen Qader --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/s

Re: [PATCH v2] staging: rtl8188eu: Skip unnecessary field checks

On 9/27/18 4:19 PM, Aymen Qader wrote: Skip unnecessary request field checks when the information element pointer is null. Signed-off-by: Aymen Qader --- v2: combine pointer check and length check & change commit message to be more appropriate drivers/staging/rtl8188eu/core/rtw_mlme_ext.c |

[PATCH v2] staging: rtl8188eu: Skip unnecessary field checks

Skip unnecessary request field checks when the information element pointer is null. Signed-off-by: Aymen Qader --- v2: combine pointer check and length check & change commit message to be more appropriate drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 6 +++--- 1 file changed, 3 insertions(+),

Re: [PATCH] staging: rtl8188eu: Avoid null pointer arithmetic

On Thu, Sep 27, 2018 at 03:52:53PM -0500, Larry Finger wrote: > On 9/27/18 12:04 PM, Aymen Qader wrote: > > Avoid null pointer arithmetic in rtw_mlme_ext.c by skipping other field > > checks if the information element pointer is null. > > > > Signed-off-by: Aymen Qader > > --- > > drivers/stagi

Re: [PATCH] staging: rtl8188eu: Avoid null pointer arithmetic

On 9/27/18 12:04 PM, Aymen Qader wrote: Avoid null pointer arithmetic in rtw_mlme_ext.c by skipping other field checks if the information element pointer is null. Signed-off-by: Aymen Qader --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[tip:x86/hyperv] x86/hyperv: Suppress "PCI: Fatal: No config space access function found"

Commit-ID: 2f285f46240d67060061d153786740d4df53cd78 Gitweb: https://git.kernel.org/tip/2f285f46240d67060061d153786740d4df53cd78 Author: Dexuan Cui AuthorDate: Tue, 18 Sep 2018 22:29:50 + Committer: Thomas Gleixner CommitDate: Thu, 27 Sep 2018 21:19:14 +0200 x86/hyperv: Suppress "PC

[tip:x86/hyperv] x86/hyperv: Remove unused include

Commit-ID: 5140a6f471137205687428b0b8f12f7187bffd18 Gitweb: https://git.kernel.org/tip/5140a6f471137205687428b0b8f12f7187bffd18 Author: YueHaibing AuthorDate: Sun, 23 Sep 2018 08:20:22 + Committer: Thomas Gleixner CommitDate: Thu, 27 Sep 2018 21:21:00 +0200 x86/hyperv: Remove unuse

[PATCH v2 05/13] staging: comedi: add interface to ni routing table information

Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- Changes since last submission: - [PATCH v2 05/13]: Tweak Makefile to build routing info for newly added hardware in updates to [PATCH v2 04/

[PATCH v2 12/13] staging: comedi: ni_660x: clean up pfi routing

Cleans up the pfi routing code to make it easier to follow, read, and also to prepare to use this cleaned up code for enabling the device-global routing interface for ni_660x devices. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 72 ++-- 1 fi

[PATCH v2 02/13] staging: comedi: add abstracted NI signal/terminal named constants

This change adds abstracted constants for National Instruments terminal/signal names. Some background: There have been significant confusions over the past many years for users when trying to understand how to connect to/from signals and terminals on NI hardware using comedi. The major reas

[PATCH v2 09/13] staging: comedi: tio: implement global tio/ctr routing

Adds ability to use device-global names in command args, in particular cmd->start_arg (for NI_CtrArmStartTrigger), and cmd->scan_begin_arg or cmd->convert_arg (either is used to specify NI_CtrGate, with preference given to cmd->scan_begin_arg, if it is set). The actual arguments of cmd->start_arg

[PATCH v2 00/13] device-global identifiers and routes introduced

This patch set is the second revision of a recent patch set of the same name. Changes and notes: - [PATCH v2 02/13]: Update signal/terminal names found after adding additional devices to routing list in [PATCH v2 04/13]. - [PATCH v2 04/13]: Add routing information for PXIe-6535 and PXIe-673

[PATCH v2 01/13] staging: comedi: tests: add unittest framework for comedi

Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be written. Signed-off-by: Spencer E. Olson ---

[PATCH v2 13/13] staging: comedi: ni_660x: add device-global routing

Provides the device-global routing interface for ni_660x devices. Using the device-global names in comedi_cmd structures for commands was already supported through the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 265 +++ 1 fi

[PATCH v2 08/13] staging: comedi: ni_mio_common: implement output selection of GPFO_{0, 1}

Implement the ability to route various signals to NI_CtrOut(x) pin. This pin is also known as GPFO_{0,1} in the DAQ STC. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 ++ drivers/staging/comedi/drivers/ni_stc.h | 6 +- 2 files ch

[PATCH v2 10/13] staging: comedi: ni_mio_common: create device-global access to tio

Adds tio sub-devices of ni_mio_common supported hardware to the implementation of test_route, connect_route, disconnect_route. This change delegates the actual functionality to the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 11 +++

[PATCH v2 03/13] staging: comedi: add new device-global config interface

Adds interface for configuring options that are global to all sub-devices. For now, only options to configure device-globally identified signal routes have been defined. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 18 drivers/staging/comedi/comedi_fops.c |

[PATCH v2 07/13] staging: comedi: ni_mio_common: implement global pfi, rtsi routing

Implement device-global config interface for ni_mio devices. In particular, this patch implements: INSN_DEVICE_CONFIG_TEST_ROUTE, INSN_DEVICE_CONFIG_CONNECT_ROUTE, INSN_DEVICE_CONFIG_DISCONNECT_ROUTE, INSN_DEVICE_CONFIG_GET_ROUTES for the ni mio devices. This means that the new abstracted signal/

[PATCH v2 11/13] staging: comedi: ni_660x: Add NI PCI-6608 to list of supported devices

Previously, only the PXI version of the NI-6608 board was supported. This change adds support for the PCI version as well. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/come

[PATCH v2 06/13] staging: comedi: ni_mio_common: implement new routing for TRIG_EXT

Use new signal routing capability for all comedi command *_src == TRIG_EXT options. This new interface allows the user specify signals and terminals as TRIG_EXT sources using a very consistent naming convention. Furthermore, the interface allows backwards compatibility to prior behavior of specify

Re: [PATCH v3] staging: ks7010: Add null pointer check for skb

Retraction: in hindsight I see that with the current usage of this function, there is already a check for the socket buffer so this check is unnecessary. However, I'm not sure if it's considered good practice to keep this check anyway--in any case, ENOMEM isn't the right error to return. On Thu, S

[PATCH] staging: rtl8188eu: Avoid null pointer arithmetic

Avoid null pointer arithmetic in rtw_mlme_ext.c by skipping other field checks if the information element pointer is null. Signed-off-by: Aymen Qader --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu

Re: [PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

On Thu, Sep 27, 2018 at 7:24 AM, Dan Carpenter wrote: > On Wed, Sep 26, 2018 at 01:52:17PM -0400, valdis.kletni...@vt.edu wrote: >> John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call >> ieee80211_networks_free(). In addition, that function has an un-needed check >> before kfre

[PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix macros in sd.c

This patch removes #if 0 code blocks and usages of the functions defined in the #if 0 code block. It removes the macro msdc_irq_restore() and replaces its usage with call to the function called in the macro definition. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- Changes in v3: -

[PATCH v3] staging: ks7010: Add null pointer check for skb

Add a null pointer check for the socket buffer in ks_hostif.c to avoid a possible null pointer deference, and remove a later now-redundant null pointer check. Signed-off-by: Aymen Qader --- v2: Remove redundant pointer check v3: Style fix drivers/staging/ks7010/ks_hostif.c | 6 +- 1 file ch

[PATCH v2] staging: ks7010: Add null pointer check for skb

Add a null pointer check for the socket buffer in ks_hostif.c to avoid a possible null pointer deference, and remove a later now-redundant null pointer check. Signed-off-by: Aymen Qader --- v2: Remove redundant pointer check drivers/staging/ks7010/ks_hostif.c | 6 +- 1 file changed, 5 inser

For editing of your photos 17

Do you have needs for your photos cutting out and retouching? We do editing for e-commerce photos, portrait photos and wedding photos. You may choose to send us one or tow photos, we will provide testing to check quality. Thanks, Jessica ___ devel ma

[PATCH] staging: ks7010: Add null pointer check for skb

Add a null pointer check for the socket buffer in ks_hostif.c to avoid a possible null pointer deference. Signed-off-by: Aymen Qader --- drivers/staging/ks7010/ks_hostif.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hos

Re: [patch 09/11] x86/vdso: Simplify the invalid vclock case

On Tue, 18 Sep 2018, Thomas Gleixner wrote: > On Tue, 18 Sep 2018, Thomas Gleixner wrote: > > So if the TSC on CPU1 is slightly behind the TSC on CPU0 then now1 can be > > smaller than cycle_last. The TSC sync stuff does not catch the small delta > > for unknown raisins. I'll go and find that machi

Re: [patch 09/11] x86/vdso: Simplify the invalid vclock case

> On Sep 27, 2018, at 7:36 AM, Thomas Gleixner wrote: > >> On Wed, 19 Sep 2018, Thomas Gleixner wrote: >> On Tue, 18 Sep 2018, Andy Lutomirski wrote: On Sep 18, 2018, at 3:46 PM, Thomas Gleixner wrote: > On Tue, 18 Sep 2018, Andy Lutomirski wrote: > Do we do better if we use signe

Re: [patch 09/11] x86/vdso: Simplify the invalid vclock case

On Wed, 19 Sep 2018, Thomas Gleixner wrote: > On Tue, 18 Sep 2018, Andy Lutomirski wrote: > > > On Sep 18, 2018, at 3:46 PM, Thomas Gleixner wrote: > > > On Tue, 18 Sep 2018, Andy Lutomirski wrote: > > >> Do we do better if we use signed arithmetic for the whole calculation? > > >> Then a small ba

Re: [PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

On Wed, Sep 26, 2018 at 01:52:17PM -0400, valdis.kletni...@vt.edu wrote: > John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call > ieee80211_networks_free(). In addition, that function has an un-needed check > before kfree(). > > Reported-by: John Whitmore > Signed-off-by: Valdi

Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

On Thu, Sep 27, 2018 at 07:12:27PM +0800, Yangbo Lu wrote: > This patch is to move DPAA2 PTP driver out of staging/ > since the dpaa2-eth had been moved out. > > Signed-off-by: Yangbo Lu > --- > drivers/net/ethernet/freescale/Kconfig |9 + > drivers/net/ethernet/freescale

[PATCH][staging-next] staging: wilc1000: fix incorrect allocation size for structure

From: Colin Ian King Currently the allocation for str_vals is for the sizeof the pointer rather than the size of the structure. Fix this. Detected by smatch "wilc_wlan_cfg_init() error: not allocating enough data 392 vs 8" Fixes: acceb12a9f8b ("staging: wilc1000: refactor code to avoid static

[PATCH] staging: rtl8188eu: remove get_right_chnl_for_iqk()

The function get_right_chnl_for_iqk() only returns non zero values for channels > 14. According to the TODO, code valid only for 5 GHz should be removed. - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist.

[PATCH 2/2] MAINTAINERS: update files maintained under DPAA2 PTP/ETHERNET

The files maintained under DPAA2 PTP/ETHERNET needs to be updated since dpaa2 ptp driver had been moved into drivers/net/ethernet/freescale/dpaa2/. Signed-off-by: Yangbo Lu --- MAINTAINERS | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINER

[PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

This patch is to move DPAA2 PTP driver out of staging/ since the dpaa2-eth had been moved out. Signed-off-by: Yangbo Lu --- drivers/net/ethernet/freescale/Kconfig |9 + drivers/net/ethernet/freescale/dpaa2/Kconfig | 15 +++ drivers/net/ethernet/freesca

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

On Thu, 2018-09-27 at 12:23 +0200, Stephen Hemminger wrote: > On Thu, 27 Sep 2018 10:57:05 +0200 > Mohammed Gamal wrote: > > > On Wed, 2018-09-26 at 17:13 +, Haiyang Zhang wrote: > > > > -Original Message- > > > > From: Mohammed Gamal > > > > Sent: Wednesday, September 26, 2018 12:34

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

On Thu, 27 Sep 2018 10:57:05 +0200 Mohammed Gamal wrote: > On Wed, 2018-09-26 at 17:13 +, Haiyang Zhang wrote: > > > -Original Message- > > > From: Mohammed Gamal > > > Sent: Wednesday, September 26, 2018 12:34 PM > > > To: Stephen Hemminger ; netdev@vger.kernel. > > > org > > > Cc:

[PATCH v3 5/6] powerpc/powernv: hold device_hotplug_lock when calling memtrace_offline_pages()

Let's perform all checking + offlining + removing under device_hotplug_lock, so nobody can mess with these devices via sysfs concurrently. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Rashmica Gupta Cc: Balbir Singh Cc: Michael Neuling Reviewed-by: Pavel Tatashin R

[PATCH v3 4/6] powerpc/powernv: hold device_hotplug_lock when calling device_online()

device_online() should be called with device_hotplug_lock() held. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Rashmica Gupta Cc: Balbir Singh Cc: Michael Neuling Reviewed-by: Pavel Tatashin Reviewed-by: Rashmica Gupta Signed-off-by: David Hildenbrand --- arch/p

[PATCH v3 6/6] memory-hotplug.txt: Add some details about locking internals

Let's document the magic a bit, especially why device_hotplug_lock is required when adding/removing memory and how it all play together with requests to online/offline memory from user space. Cc: Jonathan Corbet Cc: Michal Hocko Cc: Andrew Morton Reviewed-by: Pavel Tatashin Reviewed-by: Rashmi

[PATCH v3 1/6] mm/memory_hotplug: make remove_memory() take the device_hotplug_lock

remove_memory() is exported right now but requires the device_hotplug_lock, which is not exported. So let's provide a variant that takes the lock and only export that one. The lock is already held in arch/powerpc/platforms/pseries/hotplug-memory.c drivers/acpi/acpi_memhotplug.c

[PATCH v3 3/6] mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock

There seem to be some problems as result of 30467e0b3be ("mm, hotplug: fix concurrent memory hot-add deadlock"), which tried to fix a possible lock inversion reported and discussed in [1] due to the two locks a) device_lock() b) mem_hotplug_lock While add_memory() first takes b), f

[PATCH v3 2/6] mm/memory_hotplug: make add_memory() take the device_hotplug_lock

add_memory() currently does not take the device_hotplug_lock, however is aleady called under the lock from arch/powerpc/platforms/pseries/hotplug-memory.c drivers/acpi/acpi_memhotplug.c to synchronize against CPU hot-remove and similar. In general, we should hold the device_hotplug

[PATCH v3 0/6] mm: online/offline_pages called w.o. mem_hotplug_lock

@Andrew, Only patch #5 changed (see change notes below). Thanks! Reading through the code and studying how mem_hotplug_lock is to be used, I noticed that there are two places where we can end up calling device_online()/device_offline() - online_pages()/offline_pages() without the mem_hotplug_lock

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

On Wed, 2018-09-26 at 17:13 +, Haiyang Zhang wrote: > > -Original Message- > > From: Mohammed Gamal > > Sent: Wednesday, September 26, 2018 12:34 PM > > To: Stephen Hemminger ; netdev@vger.kernel. > > org > > Cc: KY Srinivasan ; Haiyang Zhang > > ; vkuznets ; > > ot...@redhat.com; cave

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote: > On 26-09-18 16:44, Frieder Schrempf wrote: > > Hi, > > > > On Fri, Feb 09, 2018 at 03:01:00PM +0100, Ulf Hansson wrote: > > > [...] > > > > > > >> > I'd like to know if any progress has been made on that problem > > (I may > > > >>

Re: [PATCH v3] memory_hotplug: Free pages as higher order

On 2018-09-27 12:41, Juergen Gross wrote: On 27/09/18 08:58, Arun KS wrote: When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less than 1

Re: [PATCH v3] memory_hotplug: Free pages as higher order

On 2018-09-27 12:39, Oscar Salvador wrote: On Thu, Sep 27, 2018 at 12:28:50PM +0530, Arun KS wrote: + __free_pages_boot_core(page, order); Hi, I am not sure, but if we are going to use that function from the memory-hotplug code, we might want to rename that function to something more

Re: [PATCH v3] memory_hotplug: Free pages as higher order

On 27/09/18 08:58, Arun KS wrote: > When free pages are done with higher order, time spend on > coalescing pages by buddy allocator can be reduced. With > section size of 256MB, hot add latency of a single section > shows improvement from 50-60 ms to less than 1 ms, hence > improving the hot add la

Re: [PATCH v3] memory_hotplug: Free pages as higher order

On Thu, Sep 27, 2018 at 12:28:50PM +0530, Arun KS wrote: > + __free_pages_boot_core(page, order); I am not sure, but if we are going to use that function from the memory-hotplug code, we might want to rename that function to something more generic? The word "boot" suggests that this is only c

[PATCH v3] memory_hotplug: Free pages as higher order

When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less than 1 ms, hence improving the hot add latency by 60%. Modify external providers of