> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Tuesday, October 23, 2018 08:33
> To: Skidanov, Alexey
> Cc: Laura Abbott ; gre...@linuxfoundation.org;
> de...@driverdev.osuosl.org
> Subject: Re: [PATCH] staging: android: ion: Fixed uninitialized hea
On Mon, 22 Oct 2018, Shayenne da Luz Moura wrote:
> This patch fixes the checkpatch.pl check:
>
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> crtc->x'
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].y2 <
> crtc->y'
Please use the imperative, in th
On Mon, Oct 22, 2018 at 10:44:22PM +0530, Nishad Kamdar wrote:
> - chip->ldac_pin = adt7316_platform_data[1];
> + chip->ldac_pin = devm_gpiod_get(dev, "ldac", GPIOD_OUT_HIGH);
> + if (IS_ERR(chip->ldac_pin)) {
> + ret = PTR_ERR(chip->ldac_pin);
> + dev_err(dev, "
On Mon, Oct 22, 2018 at 05:47:08PM +0300, Alexey Skidanov wrote:
>
>
> On 10/22/18 17:32, Laura Abbott wrote:
> > On 10/22/2018 07:02 AM, Alexey Skidanov wrote:
> >> The heap name might be uninitialized and access might crash the
> >> kernel.
> >>
> >
> > The heap name should never be null so th
Hi,
I didn’t know if you had received my email from last week?
Can you direct me to the person that handles your company promo items?
Do you have any upcoming events, tradeshows or promotional needs?
We manufacture ALL custom LOGO and branded products.
The most asked about product that we make,
This patch fixes the checkpatch.pl check:
vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
crtc->x'
vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].y2 <
crtc->y'
Signed-off-by: Shayenne da Luz Moura
---
drivers/staging/vboxvideo/vbox_main.c | 8
1
Hello Mike,
AFAIU, this patch is wrong. Please correct me, maybe I misunderstand something.
> The problem that this patch seeks to resolve is that when userland asks for
> the delay
The userspace asks not for delay, but for the pointer.
You modify the function, which is called `snd_bcm2835_pcm_p
Heap name is mundatory.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion_carveout_heap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion_carveout_heap.c
b/drivers/staging/android/ion/ion_carveout_heap.c
index e129237..e89b464 100644
--- a/dr
This patch fixes the checkpatch.pl warning:
WARNING: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Victor Colombo
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c
b/driv
This patch fixes the checkpatch.pl warning:
WARNING: No space is necessary after a cast
Signed-off-by: Victor Colombo
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c
b/driver
This patch fixes the checkpatch.pl warnings:
WARNING: Blank lines aren't necessary before a close brace '}'
WARNING: No space is necessary after a cast
Victor Colombo (2):
staging: iio: ad5933: Remove unnecessary space on casting
staging: iio: ad5933: Remove unnecessary blank line
drivers/s
A new SPI NAND subsystem has been added in drivers/mtd/nand/spi/ and
Micron's MT29F devices are now supported in
drivers/mtd/nand/spi/micron.c.
Remove the old driver.
Signed-off-by: Boris Brezillon
---
Hello,
If anything is missing in drivers/mtd/nand/spi/micron.c to properly
support the device
When the BCM2835 audio output is used, userspace sees a jitter up to 10ms
in the audio position, aka "delay" -- the number of frames that must
be output before a new frame would be played.
Make this a bit nicer for userspace by interpolating the position
using the CPU clock.
The overhead is small -
Hi Kirill.
The problem that this patch seeks to resolve is that when userland asks for the
delay -- the time to hear -- the driver responds with a figure that is only
updated
when a GPU interrupt occurs, now approximately every 10 milliseconds.
As far as I am aware, there is no way to get a more
Hi,
On 22-10-18 17:42, Emil Velikov wrote:
On Mon, 22 Oct 2018 at 15:58, Hans de Goede wrote:
Add #ifdef CONFIG_PM_SLEEP around the suspend/hibernate functions.
Remove unnecessary #ifdef CONFIG_COMPAT, the .compat_ioctl member is
always available and if CONFIG_COMPAT is not set then drm_comp
On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface for ldac_pin.
>
> Signed-off-by: Nishad Kamdar
> ---
Hi Nishad,
I have been working on implementing device tree bindings for this
driver and removing platfo
Use the gpiod interface instead of the deprecated old non-descriptor
interface for ldac_pin.
Signed-off-by: Nishad Kamdar
---
drivers/staging/iio/addac/adt7316.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/
Use the gpiod interface instead of the deprecated old non-descriptor
interface.
Signed-off-by: Nishad Kamdar
---
Changes in v2:
- Use the spi_device struct embedded in st instead
of passing it as an argument to ad2s1210_setup_gpios().
- Use an array of structs to reduce redundant code in
On Sun, Oct 21, 2018 at 10:31:38AM +0200, Slawomir Stepien wrote:
> On paź 21, 2018 11:49, Nishad Kamdar wrote:
> > Use the gpiod interface instead of the deprecated old non-descriptor
> > interface.
>
> Hi!
>
> See my comments below.
>
> > Signed-off-by: Nishad Kamdar
> > ---
> > drivers/stag
On Mon, 22 Oct 2018 at 15:58, Hans de Goede wrote:
>
> Add #ifdef CONFIG_PM_SLEEP around the suspend/hibernate functions.
>
> Remove unnecessary #ifdef CONFIG_COMPAT, the .compat_ioctl member is
> always available and if CONFIG_COMPAT is not set then drm_compat_ioctl
> is defined to NULL.
>
> Sign
Add myself as MODULE_AUTHOR.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vboxvideo/vbox_drv.c
b/drivers/staging/vboxvideo/vbox_drv.c
index b6e6530aa4be..80d7395e48dc 100644
--- a/drivers/staging/vboxvi
Stop adding -Iinclude/drm to the CFLAGS and stop using the obsolete
"include-all" drm/drmP.h header.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/Makefile | 2 --
drivers/staging/vboxvideo/vbox_drv.c | 1 -
drivers/staging/vboxvideo/vbox_drv.h | 2 +-
drivers/staging/vboxvideo/vb
Hi All,
Note this series applies on top of my serious from a couple of days ago
which starts with
"[PATCH 1/6] staging: vboxvideo: Stop accessing crtc_state->active"
Regards,
Hans
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.li
This is a leftover from when the driver was out of tree and also build
against older kernels.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 4 +---
drivers/staging/vboxvideo/vbox_fb.c | 2 +-
drivers/staging/vboxvideo/vbox_main.c | 2 +-
3 files changed, 3 insertions
Use PCI_DEVICE() for our pci_id table and also simplify the terminating
entry tio just "{ }".
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_drv.c
b/drivers/staging/vbox
Use DRM_FB_HELPER_DEFAULT_OPS rather then open-coding it.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_fb.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_fb.c
b/drivers/staging/vboxvideo/vbox_fb.c
index d3a5255c93b6.
Add #ifdef CONFIG_PM_SLEEP around the suspend/hibernate functions.
Remove unnecessary #ifdef CONFIG_COMPAT, the .compat_ioctl member is
always available and if CONFIG_COMPAT is not set then drm_compat_ioctl
is defined to NULL.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.
On 10/22/18 17:32, Laura Abbott wrote:
> On 10/22/2018 07:02 AM, Alexey Skidanov wrote:
>> The heap name might be uninitialized and access might crash the
>> kernel.
>>
>
> The heap name should never be null so this seems like this is being
> fixed in the wrong place. Can you explain more how yo
On 10/22/2018 07:02 AM, Alexey Skidanov wrote:
The heap name might be uninitialized and access might crash the
kernel.
The heap name should never be null so this seems like this is being
fixed in the wrong place. Can you explain more how you are hitting
this issue?
Thanks,
Laura
Signed-off-
Hi,
Thank you for the review.
On 18-10-18 20:12, Sam Ravnborg wrote:
Hi Hans.
Just a bunch of random observations that I hope you find use of.
Sam
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index cb88528e7b10..6b4d6c957da8 100644
--- a/drivers/gpu/drm/Kconfig
+++
The heap name might be uninitialized and access might crash the
kernel.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 990
Hi,
On Wed, Oct 10, 2018 at 07:22:45PM +0200, Lubomir Rintel wrote:
> Hi.
>
> This patchset adds support for the Embedded Controller on an OLPC XO
> 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into
> the existing OLPC platform infrastructure, currently used by the x86
> based
Hi,
On Fri, Oct 19, 2018 at 04:00:32PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
> >
> > According to [1] and [2], the temperature values are in tenths of degree
> > Celsius. Exposing the Celsius value makes the battery appear on fire:
> >
> > $ upowe
On 2018-10-19 13:37, Michal Hocko wrote:
On Thu 18-10-18 19:18:25, Andrew Morton wrote:
[...]
So this patch needs more work, yes?
Yes, I've talked to Arun (he is offline until next week) offlist and he
will play with this some more.
Converted totalhigh_pages, totalram_pages and zone->managed
34 matches
Mail list logo
