[PATCH v2] staging: mt7621-dma: Add braces around else branches

2018-10-23 Thread Kimberly Brown
Add braces around else branches in conditional statements that include branches with multiple statements. This style complies with the Linux kernel coding style and improves consistency and readability. Issues found by checkpatch. Signed-off-by: Kimberly Brown Reviewed-by: Matthias Brugger ---

Re: [PATCH 2/3] staging: greybus: loopback.c: do insertion in O(n) instead of O(n lg n)

2018-10-23 Thread Bryan O'Donoghue
On 23/10/2018 17:20, Rasmus Villemoes wrote: On 2018-10-11 01:03, Bryan O'Donoghue wrote: On 05/10/2018 15:28, Rasmus Villemoes wrote: Signed-off-by: Rasmus Villemoes --- I have no idea if the performance matters (it probably doesn't). Feel free to ignore this and the followup cleanup.

[PATCH v3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-23 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- Changes in v3: - Use a pointer to pointer for gpio_desc in struct ad2s1210_gpio as it will be used to modify a pointer. - Use dot notation to initialize the structure. - Use

Re: [PATCH v2] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-23 Thread Nishad Kamdar
On Tue, Oct 23, 2018 at 01:13:56PM +0200, Slawomir Stepien wrote: > On paź 22, 2018 22:09, Nishad Kamdar wrote: > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface. > > Hi > > > Signed-off-by: Nishad Kamdar > > --- > > Changes in v2: > > - Use the spi_device

[PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-23 Thread Shayenne da Luz Moura
Remove unneeded parentheses around the arguments of ||. This reduces clutter and code behave in the same way. Change suggested by checkpatch.pl. vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 < crtc->x' Signed-off-by: Shayenne da Luz Moura --- Changes in v2: - Make the

Re: [PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller

2018-10-23 Thread Lubomir Rintel
On Fri, 2018-10-19 at 16:57 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote: > > Hi. > > > > This patchset adds support for the Embedded Controller on an OLPC XO > > 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into > > the existing OLPC

Re: [PATCH 2/3] staging: greybus: loopback.c: do insertion in O(n) instead of O(n lg n)

2018-10-23 Thread Rasmus Villemoes
On 2018-10-11 01:03, Bryan O'Donoghue wrote: > On 05/10/2018 15:28, Rasmus Villemoes wrote: >> Signed-off-by: Rasmus Villemoes >> --- >> I have no idea if the performance matters (it probably doesn't). Feel >> free to ignore this and the followup cleanup. > > What's the problem you're fixing here

Re: [PATCH v2] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-23 Thread Slawomir Stepien
On paź 22, 2018 22:09, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. Hi > Signed-off-by: Nishad Kamdar > --- > Changes in v2: > - Use the spi_device struct embedded in st instead >of passing it as an argument to

RE: [PATCH] staging: android: ion: Fixed uninitialized heap name access

2018-10-23 Thread Skidanov, Alexey
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday, October 23, 2018 08:33 > To: Skidanov, Alexey > Cc: Laura Abbott ; gre...@linuxfoundation.org; > de...@driverdev.osuosl.org > Subject: Re: [PATCH] staging: android: ion: Fixed uninitialized