On Tue, Nov 13, 2018 at 06:26:09PM +0100, Lubomir Rintel wrote:
> Hi,
>
> first of all -- thanks for such a careful review. It is very helpful.
>
> Wherever I don't respond to you, I'm just following what you wrote. It
> would perhaps be tiresome to respond to "Yes, will fix in next version"
> to
The parameter is sent to next line to stay in 80
characters
Signed-off-by: Cristian Sicilia
---
drivers/staging/rtlwifi/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c
index ca37f75..a990281 100644
--- a
Added before parameters some spaces to match open parenthesis
on previous line.
Signed-off-by: Cristian Sicilia
---
drivers/staging/rtlwifi/ps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtlwifi/ps.c b/drivers/staging/rtlwifi/ps.c
index 0ca0532..5118
In the first patch I added some space to align previous
parenthesis.
In the second patch split a line to stay in 80 characters.
Cristian Sicilia (2):
staging: rtlwifi: Add spaces to match open parenthesis
staging: rtlwifi: Add new line to stay in 80 characters
drivers/staging/rtlwifi/core.c
> andrealm...@riseup.net hat am 13. November 2018 um 19:58 geschrieben:
>
>
> From: André Almeida
>
> Using multiple license representation as shown here [1].
> [1]
> https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf
>
> Signed-off-by: André Alm
From: André Almeida
As one can see in a typedef at linux/types.h:103, s32 and int32_t are
both a 32 bits signed integer. s32 is preferred because it is defined
by the kernel maintainers and it prevents portability issues. Changed
to meet checkpatch criteria.
Signed-off-by: André Almeida
---
dr
From: André Almeida
Using multiple license representation as shown here [1].
[1]
https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf
Signed-off-by: André Almeida
---
Thanks for the feedback Stefan. I've tried to make the code similar
to your exam
From: André Almeida
Fix the following checkpatch issues:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
CHECK: Prefer kernel type 's32' over 'int32_t'
Changes in v3:
- Remove license text from header file
- Modify commit message
Changes in v2:
- Splits commits in a patch s
On Mon, Nov 12, 2018 at 04:15:09PM +0100, Johan Hovold wrote:
> On Fri, Nov 09, 2018 at 01:17:41PM +0530, Nishad Kamdar wrote:
> > Convert the GPIO driver to use the GPIO irqchip library
> > GPIOLIB_IRQCHIP instead of reimplementing the same.
>
> Thanks for picking this up. Linus W took a stab at
Hi,
first of all -- thanks for such a careful review. It is very helpful.
Wherever I don't respond to you, I'm just following what you wrote. It
would perhaps be tiresome to respond to "Yes, will fix in next version"
to every single point.
I'll be following up with a new version in a few days; I
The SPDX identifier is a legally binding shorthand,
which can be used instead of the full boiler plate text.
All source and header files have SPDX identifiers.
Remove the GPL boiler plate text to reduce file size.
Signed-off-by: Michael Straube
---
drivers/staging/pi433/pi433_if.c | 10 --
On 13.11.2018 19:52, Dmitry Osipenko wrote:
> On 09.11.2018 17:32, Hans Verkuil wrote:
>> On 11/08/18 12:02, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
>>> of the use of the BIT() macro when defining FLAG_B_FRAME and cau
Fixed lines over 80 characters by adding braces where control flow
statements are more than one line, aligned parenthesis of function
arguments.
Signed-off-by: Arnold Chand
---
.../vc04_services/bcm2835-audio/bcm2835-ctl.c | 27 +++
1 file changed, 16 insertions(+), 11 deletions(
On Mon, 2018-11-12 at 17:08 -0800, gre...@linuxfoundation.org wrote:
> On Mon, Nov 12, 2018 at 07:29:09PM -0500, Arnold Chand wrote:
> > Corrected warnings and checks issued by scripts/checkpatch.pl which
> > includes:
> > alignment of
> > parenthesis, lines over 80 characters and mutex definition
On 09.11.2018 17:32, Hans Verkuil wrote:
> On 11/08/18 12:02, Colin King wrote:
>> From: Colin Ian King
>>
>> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
>> of the use of the BIT() macro when defining FLAG_B_FRAME and causing a
>> build warning. Fix this by using the %lu
On Sun, 11 Nov 2018 19:21:29 +0100,
Mike Brady wrote:
>
> /* hardware definition */
> static const struct snd_pcm_hardware snd_bcm2835_playback_hw = {
> .info = (SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
>SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
On Tue, Nov 13, 2018 at 12:12 AM chouryzhou(周威) wrote:
>
> > I have not received an answer to my questions in the last version of this
> > patch
> > set. Also it would be good if I could be Cc'ed by default. I can't hunt
> > down all
> > patches.
> > I do not know of any kernel entity, specifica
follow the linux coding style, rename the variable
shortGIrate to short_gi_rate.
Signed-off-by: Kevin Dou
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu/c
Hi,
thank you for the response.
On Fri, 2018-10-19 at 16:05 +0300, Andy Shevchenko wrote:
> On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel
> wrote:
> > Also, the header is x86 specific, while there are non-x86 OLPC
> > machines.
>
> Same concern. as per patch 2.
Which concern? If it's that it
> I have not received an answer to my questions in the last version of this
> patch
> set. Also it would be good if I could be Cc'ed by default. I can't hunt down
> all
> patches.
> I do not know of any kernel entity, specifically devices, that change
> namespaces
> on open().
> This seems like
20 matches
Mail list logo
