Re: [PATCH v2 0/7] staging: mt7621-pci: some fixes after test previous series

On Sat, Nov 24, 2018 at 9:05 PM NeilBrown wrote: > > On Sat, Nov 24 2018, Sergio Paracuellos wrote: > > > Previous cleanup series was added to the staging tree without any > > testing. After get testing feedback some issues appear and this patch > > series should make the driver works properly

Re: [PATCH v2 0/7] staging: mt7621-pci: some fixes after test previous series

On Sat, Nov 24 2018, Sergio Paracuellos wrote: > Previous cleanup series was added to the staging tree without any > testing. After get testing feedback some issues appear and this patch > series should make the driver works properly again. > > Previous series are here: > * >

[PATCH v2 1/7] staging: mt7621-pci: avoid mapping sysctls registers

The sysctl register are already claimed by palmbus, so pci fails to claim it. The best way to access the sysc registers is to use rt_sysc_[rwm]32(). Fixes: 89e9f6e6adfc: staging: mt7621-pci: remap and use sysctl from device tree Reported-by: NeilBrown Signed-off-by: Sergio Paracuellos ---

[PATCH v2 5/7] staging: mt7621-pci: avoid using clk_* operations

There is no clock driver for ralink mips and clk_enable are no-ops for this architecture. This has been also tested without using clocks and seems to work so avoid to use them in this driver. Fixes: ad9c87e129d1: "staging: mt7621-pci: parse and init port data from device tree" Reported-by:

[PATCH v2 0/7] staging: mt7621-pci: some fixes after test previous series

Previous cleanup series was added to the staging tree without any testing. After get testing feedback some issues appear and this patch series should make the driver works properly again. Previous series are here: *

[PATCH v2 3/7] staging: mt7621-pci: dt-bindings: update bindings doc removing sysctls registers

The sysctl register are already claimed by palmbus, so pci fails to claim it. Device tree has been updated to not use it at all with pcie. Update bindings documentation. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 3 +-- 1 file changed, 1

[PATCH v2 4/7] staging: mt7621-pci: fix reset lines for each pcie port

Depending of chip revision reset lines are inverted. It is also necessary to read PCIE_FTS_NUM register before enabling the phy. Hence update the code to achieve this. Fixes: 745eeeac68d7: "staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function" Reported-by: NeilBrown Signed-off-by:

[PATCH v2 2/7] staging: mt7621-dts: remove sysctl registers from pcie bindings

The sysctl register are already claimed by palmbus, so pci fails to claim it. Remove registers accordly from DT bindings. Fixes: 624c5227ed0a: staging: mt7621-dts: add sysctl registers base address to pcie Reported-by: NeilBrown Signed-off-by: Sergio Paracuellos ---

[PATCH v2 6/7] staging: mt7621-dts: remove clocks for pcie bindings

There are no real need to use clocks for pcie ports for this driver. There is no clock driver for ralink and driver can work without them. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH v2 7/7] staging: mt7621-pci: dt-bindings: update bindings doc removing clocks

Clocks are not necessary for the driver to work. Remove them also for DT binding documentation. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt

[PATCH v2 5/7] staging: mt7621-pci: avoid using clk_* operations

There is no clock driver for ralink mips and clk_enable are no-ops for this architecture. This has been also tested without using clocks and seems to work so avoid to use them in this driver. Fixes: ad9c87e129d1: "staging: mt7621-pci: parse and init port data from device tree" Reported-by:

[PATCH v2 0/7]

Previous cleanup series was added to the staging tree without any testing. After get testing feedback some issues appear and this patch series should make the driver works properly again. Previous series are here: *

[PATCH v2 2/7] staging: mt7621-dts: remove sysctl registers from pcie bindings

The sysctl register are already claimed by palmbus, so pci fails to claim it. Remove registers accordly from DT bindings. Fixes: 624c5227ed0a: staging: mt7621-dts: add sysctl registers base address to pcie Reported-by: NeilBrown Signed-off-by: Sergio Paracuellos ---

[PATCH v2 1/7] staging: mt7621-pci: avoid mapping sysctls registers

The sysctl register are already claimed by palmbus, so pci fails to claim it. The best way to access the sysc registers is to use rt_sysc_[rwm]32(). Fixes: 89e9f6e6adfc: staging: mt7621-pci: remap and use sysctl from device tree Reported-by: NeilBrown Signed-off-by: Sergio Paracuellos ---

[PATCH v2 4/7] staging: mt7621-pci: fix reset lines for each pcie port

Depending of chip revision reset lines are inverted. It is also necessary to read PCIE_FTS_NUM register before enabling the phy. Hence update the code to achieve this. Fixes: 745eeeac68d7: "staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function" Reported-by: NeilBrown Signed-off-by:

[PATCH v2 6/7] staging: mt7621-dts: remove clocks for pcie bindings

There are no real need to use clocks for pcie ports for this driver. There is no clock driver for ralink and driver can work without them. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH v2 3/7] staging: mt7621-pci: dt-bindings: update bindings doc removing sysctls registers

The sysctl register are already claimed by palmbus, so pci fails to claim it. Device tree has been updated to not use it at all with pcie. Update bindings documentation. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 3 +-- 1 file changed, 1

[PATCH v2 7/7] staging: mt7621-pci: dt-bindings: update bindings doc removing clocks

Clocks are not necessary for the driver to work. Remove them also for DT binding documentation. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt

[PATCH 4/7] staging: mt7621-pci: fix reset lines for each pcie port

Depending of chip revision reset lines are inverted. It is also necessary to read PCIE_FTS_NUM register before enabling the phy. Hence update the code to achieve this. Fixes: 745eeeac68d7: "staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function" Reported-by: NeilBrown Signed-off-by:

[PATCH 3/7] staging: mt7621-pci: dt-bindings: update bindings doc removing sysctls registers

The sysctl register are already claimed by palmbus, so pci fails to claim it. Device tree has been updated to not use it at all with pcie. Update bindings documentation. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 3 +-- 1 file changed, 1

[PATCH 6/7] staging: mt7621-dts: remove clocks for pcie bindings

There are no real need to use clocks for pcie ports for this driver. There is no clock driver for ralink and driver can work without them. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 1/7] staging: mt7621-pci: avoid mapping sysctls registers

The sysctl register are already claimed by palmbus, so pci fails to claim it. The best way to access the sysc registers is to use rt_sysc_[rwm]32(). Fixes: 89e9f6e6adfc: staging: mt7621-pci: remap and use sysctl from device tree Reported-by: NeilBrown Signed-off-by: Sergio Paracuellos ---

[PATCH 0/7] staging: mt7621-pci: some fixes after test previous series

Previous cleanup series was added to the staging tree without any testing. After get testing feedback some issues appear and this patch series should make the driver works properly again. Previous series are here: *

[PATCH 5/7] staging: mt7621-pci: avoid using clk_* operations

There is no clock driver for ralink mips and clk_enable are no-ops for this architecture. This has been also tested without using clocks and seems to work so avoid to use them in this driver. Fixes: ad9c87e129d1: "staging: mt7621-pci: parse and init port data from device tree" Reported-by:

[PATCH 2/7] staging: mt7621-dts: remove sysctl registers from pcie bindings

The sysctl register are already claimed by palmbus, so pci fails to claim it. Remove registers accordly from DT bindings. Fixes: 624c5227ed0a: staging: mt7621-dts: add sysctl registers base address to pcie Reported-by: NeilBrown Signed-off-by: Sergio Paracuellos ---

[PATCH 7/7] staging: mt7621-pcie: dt-bindings: update bindings doc removing clocks

Clocks are not necessary for the driver to work. Remove them also for DT binding documentation. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt

[PATCH] staging: media: davinci_vpfe: fix a potential null pointer dereference on vpfe_ipipe_init

From: Wen Yang This patch fixes a possible null pointer dereference in do_load, detected by the semantic patch deref_null.cocci, with the following warning: drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1846:25-30: ERROR: res is NULL but dereferenced. The following code has potential null

[PATCH v2] staging: iio: ad5933: add device tree support

Add a of_device_id struct variable and subsequent call to MODULE_DEVICE_TABLE macro to complete device tree support. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH] staging: rtl8723bs: remove redundant null check on pregpriv

From: Wen Yang The null check on >registrypriv is redundant since registrypriv is a struct inside padapter and can never be null, so the check is always true. we may remove it. Signed-off-by: Wen Yang CC: de...@driverdev.osuosl.org CC: linux-ker...@vger.kernel.org ---

Re: [PATCH] staging: iio: ad5933: finalized device-tree support

On lis 23, 2018 21:51, Marcelo Schmitt wrote: > Added a of_device_id struct variable and subsequent call to > MODULE_DEVICE_TABLE macro to complete device-tree support for this > driver. > > Signed-off-by: Marcelo Schmitt > --- > drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + >