[PATCH AUTOSEL 4.14 02/41] Input: hyper-v - fix wakeup from suspend-to-idle

2018-12-12 Thread Sasha Levin
From: Vitaly Kuznetsov [ Upstream commit 10f91c73cc41ceead210a905dbd196398e99c7d2 ] It makes little sense but still possible to put Hyper-V guests into suspend-to-idle state. To wake them up two wakeup sources were registered in the past: hyperv-keyboard and hid-hyperv. However, since commit

[PATCH AUTOSEL 4.19 02/73] Input: hyper-v - fix wakeup from suspend-to-idle

2018-12-12 Thread Sasha Levin
From: Vitaly Kuznetsov [ Upstream commit 10f91c73cc41ceead210a905dbd196398e99c7d2 ] It makes little sense but still possible to put Hyper-V guests into suspend-to-idle state. To wake them up two wakeup sources were registered in the past: hyperv-keyboard and hid-hyperv. However, since commit

Re: [PATCH] staging: erofs: Add a blank line after declarations

2018-12-12 Thread Gao Xiang
On 2018/12/13 11:29, 김성경 wrote: > Thank you. I appreciate it for your prompt reply. > > > As a result of checking through 'checkpatch.pl ', there > was only one coding style problem in 'erofs / inode.c' file. > > > I will check for other files and send the patch file

Hello...

2018-12-12 Thread Susan Williams
Hi, How are you? I must confess that you're a nice looking gentle man on your profile.Are you married?, Can we be friends? Susan. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: erofs: Add a blank line after declarations

2018-12-12 Thread Gao Xiang
Hi Sungkyung, On 2018/12/12 23:50, Sungkyung Kim wrote: > Fix a warning from checkpathch.pl: 'Missing a blank line after > declarations' > > Signed-off-by: Sungkyung Kim > --- > drivers/staging/erofs/inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 0/3] staging: vchiq: fix completion routines & semaphores

2018-12-12 Thread Arnd Bergmann
On Wed, Dec 12, 2018 at 7:54 PM Nicolas Saenz Julienne wrote: > > As pointed out by Arnd Bergman[1] there where some issues on how I > converted semaphores to completion routines. I wasn't aware of a > macro override happening in vchiq_killable.h, which was changing > down_interruptible()'s

[PATCH 2/3] staging: vchiq_2835_arm: quit using custom down_interruptible()

2018-12-12 Thread Nicolas Saenz Julienne
vchi_killable.h overrides down_interruptible() by implementing a function similar to down_killable(). To make things simpler we turn calls to down_interruptible() into kernel's implementation of down_killable(). Signed-off-by: Nicolas Saenz Julienne ---

[PATCH 3/3] staging: vchiq: delete vchiq_killable.h

2018-12-12 Thread Nicolas Saenz Julienne
There are no users for that header file. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_2835_arm.c | 1 - .../interface/vchiq_arm/vchiq_arm.c | 1 - .../interface/vchiq_arm/vchiq_connected.c | 1 - .../interface/vchiq_arm/vchiq_core.c | 1

[PATCH 1/3] staging: vchiq: switch to wait_for_completion_killable

2018-12-12 Thread Nicolas Saenz Julienne
This fixes f27e47bc6b8b ("staging: vchiq: use completions instead of semaphores") as it neglected the subtle down_interruptible() macro override in vchiq_killable.h. Hence all completions should be killable instead of interruptible. Fixes: f27e47bc6b8b ("staging: vchiq: use completions instead of

[PATCH 0/3] staging: vchiq: fix completion routines & semaphores

2018-12-12 Thread Nicolas Saenz Julienne
As pointed out by Arnd Bergman[1] there where some issues on how I converted semaphores to completion routines. I wasn't aware of a macro override happening in vchiq_killable.h, which was changing down_interruptible()'s meaning. This patch changes all completions so they use the proper APIs and

[PATCH] staging: iio: ad7816: drop unnecessary initialization of variables

2018-12-12 Thread Hardik Singh Rathore
Initialization is unnecessary when the variable is written before it is read. There were some occasions in which the driver would initialize `ret' during declaration without need. Signed-off-by: Hardik Singh Rathore --- drivers/staging/iio/adc/ad7816.c | 7 +++ 1 file changed, 3

[PATCH] staging: iio: adt7316: drop unnecessary initialization of variables

2018-12-12 Thread Hardik Singh Rathore
Initialization is unnecessary when the variable is written before it is read. There were some occasions in which the driver would initialize `ret' during declaration without need. Purely a cosmetic change with no functional impact. Signed-off-by: Hardik Singh Rathore ---

Re: [PATCH] staging: vchiq: rework remove_event handling

2018-12-12 Thread Nicolas Saenz Julienne
On Tue, 2018-12-11 at 15:20 +0100, Arnd Bergmann wrote: > On Tue, Dec 11, 2018 at 1:36 PM Nicolas Saenz Julienne > wrote: > > On Mon, 2018-12-10 at 22:11 +0100, Arnd Bergmann wrote: > > > @@ -447,26 +444,26 @@ remote_event_wait(VCHIQ_STATE_T *state, > > > REMOTE_EVENT_T *event) > > > } > > > >

Re: [PATCH 3/6] staging: most: sound: rename variable

2018-12-12 Thread Christian.Gromm
On Mi, 2018-12-12 at 17:26 +0300, Dan Carpenter wrote: > On Wed, Dec 12, 2018 at 01:15:28PM +0100, Christian Gromm wrote: > > > > @@ -587,7 +587,7 @@ static int audio_probe_channel(struct > > most_interface *iface, int channel_id, > >   int capture_count = 0; > >   int ret; > >   int

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-12 Thread Christian.Gromm
On Mi, 2018-12-12 at 17:21 +0300, Dan Carpenter wrote: > On Wed, Dec 12, 2018 at 01:15:26PM +0100, Christian Gromm wrote: > > > > This patch avoids that a sound card is created and registered with > > ALSA > > every time a channel is being linked. Instead the channels are > > hooked on > > the

Re: [PATCH 6/6] staging: most: Documentation: add information to driver_usage file

2018-12-12 Thread Dan Carpenter
On Wed, Dec 12, 2018 at 01:15:31PM +0100, Christian Gromm wrote: > diff --git a/drivers/staging/most/Documentation/driver_usage.txt > b/drivers/staging/most/Documentation/driver_usage.txt > index bb9b4e8..da7a8f4 100644 > --- a/drivers/staging/most/Documentation/driver_usage.txt > +++

Re: [PATCH 3/6] staging: most: sound: rename variable

2018-12-12 Thread Dan Carpenter
On Wed, Dec 12, 2018 at 01:15:28PM +0100, Christian Gromm wrote: > @@ -587,7 +587,7 @@ static int audio_probe_channel(struct most_interface > *iface, int channel_id, > int capture_count = 0; > int ret; > int direction; > - char *card_name; > + char *device_name;

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-12 Thread Dan Carpenter
On Wed, Dec 12, 2018 at 01:15:26PM +0100, Christian Gromm wrote: > This patch avoids that a sound card is created and registered with ALSA > every time a channel is being linked. Instead the channels are hooked on > the same card, which is registered not until the final link has been added > to

[PATCH] Staging: rtl8723bs: Fix code style issue in rtl8723bs driver

2018-12-12 Thread Hardik Singh Rathore
Add space between 'else' and '{' to solve code style issue in all the files for rtl8723bs driver. Signed-off-by: Hardik Singh Rathore --- drivers/staging/rtl8723bs/core/rtw_ap.c | 24 ++--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 36 +++

Lets Work Together

2018-12-12 Thread Mr Peter OWEN
Good Day, Hope you are doing great Today.I have a proposed BUSINESS DEAL that will benefit both parties. This is legitimate,legal and your personality will not be compromised.Please Reply to me ONLY if you are interested and consider your self capable for details. Sincerely, Peter

Lets Work Together

2018-12-12 Thread Mr Peter OWEN
Good Day, Hope you are doing great Today.I have a proposed BUSINESS DEAL that will benefit both parties. This is legitimate,legal and your personality will not be compromised.Please Reply to me ONLY if you are interested and consider your self capable for details. Sincerely, Peter

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2018-12-12 Thread Paul Kocialkowski
Hi, On Wed, 2018-12-05 at 21:59 +0100, Jernej Škrabec wrote: > Hi! > > Dne petek, 23. november 2018 ob 14:02:08 CET je Paul Kocialkowski napisal(a): > > This introduces the required definitions for HEVC decoding support with > > stateless VPUs. The controls associated to the HEVC slice format

Re: [PATCH v1] binder: implement binderfs

2018-12-12 Thread Christian Brauner
> On Fri, Dec 7, 2018 at 3:26 PM Christian Brauner wrote: > > > > As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the > > implementation of binderfs. > > > > binderfs is a backwards-compatible filesystem for Android's binder ipc > > mechanism. Each ipc namespace will mount

Re: [PATCH v2] staging:erofs: Fix alignment issues

2018-12-12 Thread Gao Xiang
On 2018/12/12 20:11, Gao Xiang wrote: > Hi Aaron, > > On 2018/12/12 20:00, Aaron Strahlberger wrote: >> Fix of `CHECK: Alignment should match open parenthesis` issues, reported by >> checkpatch.pl >> >> Signed-off-by: Aaron Strahlberger >> Signed-off-by: Julius Wiedmann >> Signed-off-by:

Re: [PATCH v2] staging:erofs: Remove __EROFS_BIT macro

2018-12-12 Thread Gao Xiang
Hi Aaron, On 2018/12/12 20:02, Aaron Strahlberger wrote: > The `__EROFS_BIT` macro is used only once, do define the > `EROFS_I_DATA_MAPPING_BIT` constant. This Patch removes this > macro and expands it in the place it is used. > > Signed-off-by: Aaron Strahlberger > Signed-off-by: Julius

[PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-12 Thread Christian Gromm
This patch avoids that a sound card is created and registered with ALSA every time a channel is being linked. Instead the channels are hooked on the same card, which is registered not until the final link has been added to the component. Signed-off-by: Christian Gromm ---

[PATCH 5/6] staging: most: sound: remove channel number from ALSA card's long name

2018-12-12 Thread Christian Gromm
Adding the channel number to the name of the sound card is wrong, as the card does not represent a single streaming channel of the MOST device. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 0/6] staging: most: sound: change sound card layout

2018-12-12 Thread Christian Gromm
Currently, for every synchronous channel allocated on MOST an extra sound card is being created and registered with ALSA. From a logical point of view this fails to reflect the actual condition, as all channels originate in the same physical device. This patch series introduces a way to map this

[PATCH 3/6] staging: most: sound: rename variable

2018-12-12 Thread Christian Gromm
Since the channels of a MOST device are now being represented as individual PCM devices of one sound card, the variable card_name is not suitable anymore to describe them. Therefore, this patch renames the variable to device_name. Signed-off-by: Christian Gromm ---

[PATCH 6/6] staging: most: Documentation: add information to driver_usage file

2018-12-12 Thread Christian Gromm
This patch updates driver_usage.txt file to reflect the latest changes that this patch set introduces. Signed-off-by: Christian Gromm --- drivers/staging/most/Documentation/driver_usage.txt | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH 2/6] staging: most: sound: correct label name

2018-12-12 Thread Christian Gromm
This patch fixes the lable name that is used to jump to error handling section of function audio_probe_channel() in case something went wrong. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 4/6] staging: most: sound: use static name for ALSA card

2018-12-12 Thread Christian Gromm
This patch uses a static name for the sound card's short name and long name. Having the card names configurable doesn't make sense anymore, as the card represents the same physical hardware. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 4 ++-- 1 file changed, 2

Re: [PATCH v2] staging:erofs: Fix alignment issues

2018-12-12 Thread Gao Xiang
Hi Aaron, On 2018/12/12 20:00, Aaron Strahlberger wrote: > Fix of `CHECK: Alignment should match open parenthesis` issues, reported by > checkpatch.pl > > Signed-off-by: Aaron Strahlberger > Signed-off-by: Julius Wiedmann > Signed-off-by: Dominik Huber > --- > drivers/staging/erofs/dir.c |

[PATCH v2] staging:erofs: Remove __EROFS_BIT macro

2018-12-12 Thread Aaron Strahlberger
The `__EROFS_BIT` macro is used only once, do define the `EROFS_I_DATA_MAPPING_BIT` constant. This Patch removes this macro and expands it in the place it is used. Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber ---

[PATCH v2] staging:erofs: Fix alignment issues

2018-12-12 Thread Aaron Strahlberger
Fix of `CHECK: Alignment should match open parenthesis` issues, reported by checkpatch.pl Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber --- drivers/staging/erofs/dir.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH] staging: erofs: remove __EROFS_BIT

2018-12-12 Thread Gao Xiang
Hi Chao, On 2018/12/12 19:22, Chao Yu wrote: > On 2018-12-12 1:57, Gao Xiang wrote: >> It's better to use pre-calculated values to make >> on-disk definition more straight-forward and human-readable. >> >> Since there is the only one user, let's remove >> __EROFS_BIT entirely. >> >> Suggested-by:

Re: [PATCH] staging: erofs: remove __EROFS_BIT

2018-12-12 Thread Chao Yu
On 2018-12-12 1:57, Gao Xiang wrote: > It's better to use pre-calculated values to make > on-disk definition more straight-forward and human-readable. > > Since there is the only one user, let's remove > __EROFS_BIT entirely. > > Suggested-by: Joe Perches > Signed-off-by: Gao Xiang It looks

Re: [PATCH 10/11] staging: iio: adt7316: change interpretation of write to dac update mode

2018-12-12 Thread Jonathan Cameron
On 12 December 2018 08:31:32 GMT, Dan Carpenter wrote: >On Tue, Dec 11, 2018 at 05:55:02PM -0700, Jeremy Fertic wrote: >> Based on the output of adt7316_show_all_DAC_update_modes() and >> adt7316_show_DAC_update_mode(), adt7316_store_DAC_update_mode() >should >> expect the user to enter an

Re: [PATCH] staging: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-12 Thread Greg KH
On Sun, Dec 09, 2018 at 11:27:42AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > --- > drivers/staging/fwserial/fwserial.c | 32 +++ > drivers/staging/greybus/loopback.c| 16 ++ >

Re: [PATCH] staging: mt7621-pci: Fix checkpatch errors

2018-12-12 Thread Greg KH
On Mon, Dec 10, 2018 at 03:23:06PM +0800, yuhui zhang wrote: > This patch fixes the following checkpatch.pl errors in the > drivers/staging/mt7621-pci: > ERROR: space required after that ')'. > ERROR: space required after that '='. > > Signed-off-by: zhangyuhui > --- >

[bug report] staging: wilc1000: handle scan operation callback from cfg80211 context

2018-12-12 Thread Dan Carpenter
Hello Ajay Singh, The patch 8f1a0ac1eba7: "staging: wilc1000: handle scan operation callback from cfg80211 context" from Dec 2, 2018, leads to the following static checker warning: drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:562 scan() error: NULL dereference inside

Re: [PATCH 01/33] staging: vc04_services: Remove DUMP_CONTEXT_T typedef

2018-12-12 Thread Greg Kroah-Hartman
On Tue, Dec 11, 2018 at 07:30:58PM +0100, Dominic Braun wrote: > Typedefing structs is not encouraged in the kernel. > > The removal of typedefs was requested in interface/vchi/TODO in commit > 7626e002225a4c1b9455689b1f22909dfeff43ca. > > Signed-off-by: Dominic Braun > Signed-off-by: Tobias

Re: [PATCH 10/11] staging: iio: adt7316: change interpretation of write to dac update mode

2018-12-12 Thread Dan Carpenter
On Tue, Dec 11, 2018 at 05:55:02PM -0700, Jeremy Fertic wrote: > Based on the output of adt7316_show_all_DAC_update_modes() and > adt7316_show_DAC_update_mode(), adt7316_store_DAC_update_mode() should > expect the user to enter an integer input from 0 to 3. The user input is > currently expected

Re: [PATCH 04/11] staging: iio: adt7316: fix handling of dac high resolution option

2018-12-12 Thread Dan Carpenter
On Tue, Dec 11, 2018 at 05:54:56PM -0700, Jeremy Fertic wrote: > @@ -651,10 +649,12 @@ static ssize_t adt7316_store_da_high_resolution(struct > device *dev, > u8 config3; > int ret; > > + if (chip->id == ID_ADT7318 || chip->id == ID_ADT7519) > + return -EPERM;

Re: [PATCH 02/11] staging: iio: adt7316: invert the logic of the check for an ldac pin

2018-12-12 Thread Dan Carpenter
On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote: > ADT7316_DA_EN_VIA_DAC_LDCA is set when the dac and ldac registers are being > used to update the dacs instead of the ldac pin. ADT7516_SEL_AIN3 is an adc > input that shares the ldac pin. Only set these bits if an ldac pin is not >

Re: [PATCH 03/33] staging: vc04_services: Remove REMOTE_EVENT_T typedef

2018-12-12 Thread Dan Carpenter
On Tue, Dec 11, 2018 at 07:31:00PM +0100, Dominic Braun wrote: > Typedefing structs is not encouraged in the kernel. > > The removal of typedefs was requested in interface/vchi/TODO in commit > 7626e002225a4c1b9455689b1f22909dfeff43ca. When you mention a commit then use this format: "requested