Re: [PATCH RFC 01/11] staging: bcm2835-camera: Abort probe if there is no camera

2018-12-19 Thread Peter Robinson
On Thu, Oct 25, 2018 at 4:30 PM Stefan Wahren wrote: > > Abort the probing of the camera driver in case there isn't a camera > actually connected to the Raspberry Pi. This solution also avoids a > NULL ptr dereference of mmal instance on driver unload. > > Fixes: 7b3ad5abf027 ("staging: Import the

Re: [PATCH v3] binder: implement binderfs

2018-12-19 Thread Greg KH
On Fri, Dec 14, 2018 at 01:11:14PM +0100, Christian Brauner wrote: > As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the > implementation of binderfs. Looks good to me, thanks so much for doing this, now queued up! greg k-h ___

Re: [PATCH] mt7621-mmc/sd.c: Fix some coding style issues

2018-12-19 Thread Greg KH
On Thu, Dec 13, 2018 at 03:54:07PM +0100, Jona Crasselt wrote: > Fix some "bigger" issues reported by checkpatch.pl: > - Block comments use * on subsequent lines > - Blank lines aren't necessary before a close brace > - Block comments use a trailing */ on a separate line > - Alignment should match

[PATCH] staging: android: ion: add buffer flag update ioctl

2018-12-19 Thread Zeng Tao
In some usecases, the buffer cached attribute is not determined at allocation time, it's determined just before the real cpu mapping. And from the memory view of point, a buffer should not have the cached attribute util is really mapped by the cpu. So in this patch, we introduced the new ioctl comm

Re: [PATCH v3] binder: implement binderfs

2018-12-19 Thread Christian Brauner
On Wed, Dec 19, 2018 at 09:47:56AM +0100, Greg KH wrote: > On Fri, Dec 14, 2018 at 01:11:14PM +0100, Christian Brauner wrote: > > As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the > > implementation of binderfs. > > > > Looks good to me, thanks so much for doing this, n

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

2018-12-19 Thread kbuild test robot
Hi Zeng, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.20-rc7 next-20181219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

[PATCH v2 3/7] mt7621-mmc: Alignment should match open parenthesis

2018-12-19 Thread Jona Crasselt
Issue reported by checkpatch.pl. Signed-off-by: Jona Crasselt Signed-off-by: Felix Windsheimer --- drivers/staging/mt7621-mmc/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index 4483e04ae579..8af2d5

[PATCH v2 2/7] mt7621-mmc: Removed unnecessary blank lines

2018-12-19 Thread Jona Crasselt
Issue reported by checkpatch.pl. Signed-off-by: Jona Crasselt Signed-off-by: Felix Windsheimer --- drivers/staging/mt7621-mmc/sd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index e42cfe5fba7e..4483e04ae579 100644 --- a

[PATCH v2 1/7] mt7621-mmc: Fix some coding style issues

2018-12-19 Thread Jona Crasselt
Fix some comment-related issues reported by checkpatch.pl: - Block comments use * on subsequent lines - Block comments use a trailing */ on a separate line Signed-off-by: Jona Crasselt Signed-off-by: Felix Windsheimer --- drivers/staging/mt7621-mmc/sd.c | 31 +-- 1 f

[PATCH v2 4/7] mt7621-mmc: return statement in void function unnecessary

2018-12-19 Thread Jona Crasselt
Issue reported by checkpatch.pl. Signed-off-by: Jona Crasselt Signed-off-by: Felix Windsheimer --- drivers/staging/mt7621-mmc/sd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index 8af2d5733b11..ea19ae4f160f 100644 --- a

[PATCH v2 6/7] mt7621-mmc: printk() should include KERN_ facility level

2018-12-19 Thread Jona Crasselt
Issue reported by checkpatch.pl. Replace printk() with pr_debug() to include facility level. Signed-off-by: Jona Crasselt Signed-off-by: Felix Windsheimer --- drivers/staging/mt7621-mmc/sd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-mmc/s

[PATCH v2 7/7] mt7621-mmc: Correct spelling mistakes in comments

2018-12-19 Thread Jona Crasselt
Signed-off-by: Jona Crasselt Signed-off-by: Felix Windsheimer --- drivers/staging/mt7621-mmc/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index 149ea9ecfe32..ef3841604cfc 100644 --- a/drivers/stagin

[PATCH v2 5/7] mt7621-mmc: char * array declaration might be better as static const

2018-12-19 Thread Jona Crasselt
Issue reported by checkpatch.pl. Signed-off-by: Jona Crasselt Signed-off-by: Felix Windsheimer --- drivers/staging/mt7621-mmc/sd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index ea19ae4f160f..35

[PATCH] staging: wilc1000: fix missing read_write setting when reading data

2018-12-19 Thread Colin King
From: Colin Ian King Currently the cmd.read_write setting is not initialized so it contains garbage from the stack. Fix this by setting it to 0 to indicate a read is required. Detected by CoverityScan, CID#1357925 ("Uninitialized scalar variable") Fixes: c5c77ba18ea6 ("staging: wilc1000: Add S

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

2018-12-19 Thread Laura Abbott
On 12/19/18 9:19 AM, Zeng Tao wrote: In some usecases, the buffer cached attribute is not determined at allocation time, it's determined just before the real cpu mapping. And from the memory view of point, a buffer should not have the cached attribute util is really mapped by the cpu. So in this

Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-19 Thread Florian Fainelli
On 12/18/18 10:23 PM, Sergio Paracuellos wrote: > Hi Rob, > > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring wrote: >> >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode. >>> >>> Cc: devicet...@vger.ker

[PATCH 1/1] scsi: storvsc: Always use blk-mq

2018-12-19 Thread Michael Kelley
With high IOPS storage being increasingly prevalent for guests on Hyper-V and in Azure, make blk-mq the default so that the full performance of the storage can be realized without having to tweak other configuration settings. Signed-off-by: Michael Kelley --- drivers/scsi/storvsc_drv.c | 1 + 1

[PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-19 Thread Sergio Paracuellos
Add device-tree binding example of the ksz9477 switch managed in i2c mode. Cc: devicet...@vger.kernel.org Signed-off-by: Sergio Paracuellos --- Changes v4: - Use one tab formatting properly the binding sample. Changes v3: - No changes. Just resent patches together. Changes v2: - Use

Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-19 Thread Sergio Paracuellos
On Wed, Dec 19, 2018 at 7:26 PM Florian Fainelli wrote: > > On 12/18/18 10:23 PM, Sergio Paracuellos wrote: > > Hi Rob, > > > > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring wrote: > >> > >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: > >>> Add device-tree binding example of

RE: [PATCH] staging: android: ion: add buffer flag update ioctl

2018-12-19 Thread Zengtao (B)
Hi laura: >-Original Message- >From: Laura Abbott [mailto:labb...@redhat.com] >Sent: Thursday, December 20, 2018 2:10 AM >To: Zengtao (B) ; sumit.sem...@linaro.org >Cc: Greg Kroah-Hartman ; Arve Hjønnevåg >; Todd Kjos ; Martijn Coenen >; Joel Fernandes ; >de...@driverdev.osuosl.org; dri-de

Re: [PATCH 1/1] scsi: storvsc: Always use blk-mq

2018-12-19 Thread Martin K. Petersen
Michael, > With high IOPS storage being increasingly prevalent for guests > on Hyper-V and in Azure, make blk-mq the default so that the > full performance of the storage can be realized without having > to tweak other configuration settings. The legacy I/O path will be gone in 4.21 so this pat

Re: [PATCH] staging: wilc1000: fix missing read_write setting when reading data

2018-12-19 Thread Ajay.Kathat
On 12/19/2018 10:00 PM, Colin King wrote: > From: Colin Ian King > > Currently the cmd.read_write setting is not initialized so it contains > garbage from the stack. Fix this by setting it to 0 to indicate a > read is required. > > Detected by CoverityScan, CID#1357925 ("Uninitialized scalar

[PATCH] rts5208: add a missing check for the status of command sending

2018-12-19 Thread Kangjie Lu
ms_send_cmd() may fail. The fix checks the return value of it, and if it fails, returns the error "STATUS_FAIL" upstream. Signed-off-by: Kangjie Lu --- drivers/staging/rts5208/ms.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/ms.c b/drivers/stagi