Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-20 Thread David Miller
From: Sergio Paracuellos Date: Wed, 19 Dec 2018 20:46:26 +0100 > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sergio Paracuellos I am assuming the devicetree folks will take this into their tree or similar. If

Re: [PATCH] staging: android: ion: Add chunk heaps instantiation

2018-12-20 Thread Alexey Skidanov
On 12/20/18 10:36 PM, Laura Abbott wrote: > On 12/16/18 2:46 AM, Alexey Skidanov wrote: >> Chunk heap instantiation should be supported for device tree platforms >> and >> non device tree platforms. For device tree platforms, it's a platform >> specific code responsibility to retrieve the heap

Re: [RESEND] staging: rtlwifi: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-20 Thread kbuild test robot
Hi Yangtao, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.20-rc7 next-20181220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

2018-12-20 Thread Laura Abbott
On 12/19/18 5:39 PM, Zengtao (B) wrote: Hi laura: -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Thursday, December 20, 2018 2:10 AM To: Zengtao (B) ; sumit.sem...@linaro.org Cc: Greg Kroah-Hartman ; Arve Hjønnevåg ; Todd Kjos ; Martijn Coenen ; Joel Fernandes

Re: [PATCH] staging: android: ion: Add chunk heaps instantiation

2018-12-20 Thread Laura Abbott
On 12/16/18 2:46 AM, Alexey Skidanov wrote: Chunk heap instantiation should be supported for device tree platforms and non device tree platforms. For device tree platforms, it's a platform specific code responsibility to retrieve the heap configuration data and to call the appropriate API for

Re: [PATCH] rts5208: fix a missing check of ms read

2018-12-20 Thread Dan Carpenter
LGTM. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] rts5208: fix a missing check of ms read

2018-12-20 Thread Kangjie Lu
When ms_read_extra_data fails, the data read in "extra" buffer is just incorrect and thus should be used. However, "extra" is used in multiple places no matter ms_read_extra_data() fails or not. The fix checks the status of ms_read_extra_data() and returns with an error code upon its failure.

Re: [PATCH 10/11] staging: iio: adc: ad7606: Move out of staging

2018-12-20 Thread kbuild test robot
Hi Stefan, I love your patch! Yet something to improve: [auto build test ERROR on iio/togreg] [cannot apply to v4.20-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] rts5208: add a missing check for the status of command sending

2018-12-20 Thread kbuild test robot
Hi Kangjie, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.20-rc7 next-20181220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[PATCH] staging: fsl-dpaa2: fix SPDX identifiers in header files

2018-12-20 Thread Michael Straube
Use the correct comment style for SPDX identifiers in header files. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h | 2 +- drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 2 +- drivers/staging/fsl-dpaa2/ethsw/ethsw.h| 2 +- 3 files

Re: [PATCH v3] staging: mt7621-mmc: Correct spelling mistakes in comments

2018-12-20 Thread Greg KH
On Thu, Dec 20, 2018 at 05:57:37PM +0100, Jona Crasselt wrote: > Changed "avaiable" to "available" and "interupt" to "interrupt". > > Signed-off-by: Jona Crasselt > Signed-off-by: Felix Windsheimer > --- > drivers/staging/mt7621-mmc/sd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH v3] staging: mt7621-mmc: Correct spelling mistakes in comments

2018-12-20 Thread Jona Crasselt
Changed "avaiable" to "available" and "interupt" to "interrupt". Signed-off-by: Jona Crasselt Signed-off-by: Felix Windsheimer --- drivers/staging/mt7621-mmc/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c

Re: [PATCH v2 1/7] mt7621-mmc: Fix some coding style issues

2018-12-20 Thread Greg KH
On Wed, Dec 19, 2018 at 05:07:01PM +0100, Jona Crasselt wrote: > Fix some comment-related issues reported by checkpatch.pl: > - Block comments use * on subsequent lines > - Block comments use a trailing */ on a separate line > > Signed-off-by: Jona Crasselt > Signed-off-by: Felix Windsheimer >

Re: [PATCH v2 7/7] mt7621-mmc: Correct spelling mistakes in comments

2018-12-20 Thread Greg KH
On Wed, Dec 19, 2018 at 05:07:07PM +0100, Jona Crasselt wrote: > Signed-off-by: Jona Crasselt > Signed-off-by: Felix Windsheimer > --- > drivers/staging/mt7621-mmc/sd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I can't take patches without any changelog comments at all :(

Re: [PATCH v2 6/7] mt7621-mmc: printk() should include KERN_ facility level

2018-12-20 Thread Greg KH
On Wed, Dec 19, 2018 at 05:07:06PM +0100, Jona Crasselt wrote: > Issue reported by checkpatch.pl. > Replace printk() with pr_debug() to include facility level. > > Signed-off-by: Jona Crasselt > Signed-off-by: Felix Windsheimer > --- > drivers/staging/mt7621-mmc/sd.c | 8 > 1 file

Re: [PATCH RFCv2 0/4] mm/memory_hotplug: Introduce memory block types

2018-12-20 Thread David Hildenbrand
On 20.12.18 14:08, Michal Hocko wrote: > On Thu 20-12-18 13:58:16, David Hildenbrand wrote: >> On 30.11.18 18:59, David Hildenbrand wrote: >>> This is the second approach, introducing more meaningful memory block >>> types and not changing online behavior in the kernel. It is based on >>> latest

Re: [PATCH RFCv2 0/4] mm/memory_hotplug: Introduce memory block types

2018-12-20 Thread Michal Hocko
On Thu 20-12-18 13:58:16, David Hildenbrand wrote: > On 30.11.18 18:59, David Hildenbrand wrote: > > This is the second approach, introducing more meaningful memory block > > types and not changing online behavior in the kernel. It is based on > > latest linux-next. > > > > As we found out during

Re: [PATCH RFCv2 0/4] mm/memory_hotplug: Introduce memory block types

2018-12-20 Thread David Hildenbrand
On 30.11.18 18:59, David Hildenbrand wrote: > This is the second approach, introducing more meaningful memory block > types and not changing online behavior in the kernel. It is based on > latest linux-next. > > As we found out during dicussion, user space should always handle onlining > of

Re: [PATCH] rts5208: add a missing check for the status of command sending

2018-12-20 Thread Dan Carpenter
I think maybe this is the first kernel patch I have recieved from you. When you're adding error handling there are a couple ways to go wrong and this is what I look at when I review error handling patches: 1) The error handling is not required. 2) The error handling is not complete. I have

Re: [PATCH] rts5208: add a missing check for the status of command sending

2018-12-20 Thread Dan Carpenter
On Thu, Dec 20, 2018 at 01:57:01AM -0600, Kangjie Lu wrote: > ms_send_cmd() may fail. The fix checks the return value of it, and if it > fails, returns the error "STATUS_FAIL" upstream. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/rts5208/ms.c | 4 +++- > 1 file changed, 3