Re: [PATCH] staging: erofs: fix return type of erofs_workgroup_get

On 2018/12/26 11:34, Gao Xiang wrote: > There exists a return type misuse (`int'->`bool') since all > users assume it fails if only return value != 0, let's fix > the return type to `int' instead of confusing `bool'. > > No logic changes. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu

[PATCH] staging: erofs: fix return type of erofs_workgroup_get

There exists a return type misuse (`int'->`bool') since all users assume it fails if only return value != 0, let's fix the return type to `int' instead of confusing `bool'. No logic changes. Signed-off-by: Gao Xiang --- drivers/staging/erofs/internal.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2] rtl8712: add a check for the status of register_netdev

register_netdev() may fail, so let's check its return value, and if it fails, issue an error message. Signed-off-by: Kangjie Lu --- drivers/staging/rtl8712/hal_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c

Re: [PATCH] rtl8712: add a check for the status of register_netdev

Hi Kangjie, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.20 next-20181224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] rtl8712: add a check for the status of register_netdev

Hi Kangjie, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.20 next-20181224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] rtl8712: add a check for the status of register_netdev

register_netdev() may fail, so let's check its return value, and if it fails, issue an error message. Signed-off-by: Kangjie Lu --- drivers/staging/rtl8712/hal_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/hal_init.c

[PATCH] staging: wilc1000: make function wilc_get_stats_async static

Makes local function wilc_get_stats_async() static Cleans up sparse warning: symbol 'wilc_get_stats_async' was not declared. Should it be static? Signed-off-by: Marko Stankovic --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: wilc100: make function wilc_get_stats_async static

Makes local function wilc_get_stats_async() static Cleans up sparse warning: symbol 'wilc_get_stats_async' was not declared. Should it be static? Signed-off-by: Marko Stankovic --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] dt-bindings: net: dsa: ksz9477: fix indentation for switch spi bindings

On Tue, Dec 25, 2018 at 1:39 PM Andrew Lunn wrote: > > On Tue, Dec 25, 2018 at 12:45:11PM +0100, Sergio Paracuellos wrote: > > Hi David, > > > > On Mon, Dec 24, 2018 at 11:15 PM David Miller wrote: > > > > > > From: Sergio Paracuellos > > > Date: Sat, 22 Dec 2018 08:39:09 +0100 > > > > > > >

Re: [PATCH] dt-bindings: net: dsa: ksz9477: fix indentation for switch spi bindings

On Tue, Dec 25, 2018 at 12:45:11PM +0100, Sergio Paracuellos wrote: > Hi David, > > On Mon, Dec 24, 2018 at 11:15 PM David Miller wrote: > > > > From: Sergio Paracuellos > > Date: Sat, 22 Dec 2018 08:39:09 +0100 > > > > > Switch bindings for spi managed mode are using spaces instead of tabs. >

Re: [PATCH] dt-bindings: net: dsa: ksz9477: fix indentation for switch spi bindings

Hi David, On Mon, Dec 24, 2018 at 11:15 PM David Miller wrote: > > From: Sergio Paracuellos > Date: Sat, 22 Dec 2018 08:39:09 +0100 > > > Switch bindings for spi managed mode are using spaces instead of tabs. > > Fix them to get a file with a proper kernel indentation style. > > > >

[PATCH] rts5208: fix a missing check of the status of sd_init_power

sd_init_power() could fail. The fix inserts a check of its status. If it fails, returns STATUS_FAIL. Signed-off-by: Kangjie Lu --- drivers/staging/rts5208/sd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c