Re: [PATCH v2 3/3] staging: mt7621-dts: add pci-phy related bindings to board's device tree

2019-01-02 Thread Sergio Paracuellos
On Thu, Jan 3, 2019 at 6:15 AM NeilBrown wrote: > > On Mon, Dec 24 2018, Sergio Paracuellos wrote: > > > New driver for pci phy has been added, as well as. pci driver has been > > changed to use kernel's generic PHY API. Add related PCI PHY bindings > > accordly. > > > > Signed-off-by: Sergio

Re: [PATCH] staging: android: ion: Add chunk heaps instantiation

2019-01-02 Thread Alexey Skidanov
On 1/3/19 12:37 AM, Laura Abbott wrote: > On 12/20/18 1:29 PM, Alexey Skidanov wrote: >> >> >> On 12/20/18 10:36 PM, Laura Abbott wrote: >>> On 12/16/18 2:46 AM, Alexey Skidanov wrote: Chunk heap instantiation should be supported for device tree platforms and non device tree

Re: [PATCH v2 1/3] staging: mt7621-pci-phy: add new driver for phy part of mt7621-pci

2019-01-02 Thread Sergio Paracuellos
Hi Neil. Thanks for the feedback. On Thu, Jan 3, 2019 at 6:19 AM NeilBrown wrote: > > On Mon, Dec 24 2018, Sergio Paracuellos wrote: > > > Phy part of the pci for this SoC can be handled using a generic phy > > driver. This commit extracts phy part of the mt7621-pci into a new > >

Re: [PATCH v2 1/3] staging: mt7621-pci-phy: add new driver for phy part of mt7621-pci

2019-01-02 Thread NeilBrown
On Mon, Dec 24 2018, Sergio Paracuellos wrote: > Phy part of the pci for this SoC can be handled using a generic phy > driver. This commit extracts phy part of the mt7621-pci into a new > 'mt7621-pci-phy' driver. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/Kconfig

Re: [PATCH v2 3/3] staging: mt7621-dts: add pci-phy related bindings to board's device tree

2019-01-02 Thread NeilBrown
On Mon, Dec 24 2018, Sergio Paracuellos wrote: > New driver for pci phy has been added, as well as. pci driver has been > changed to use kernel's generic PHY API. Add related PCI PHY bindings > accordly. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/mt7621-dts/mt7621.dtsi | 40

[PATCH 1/2] staging: rtl8188eu: Fix module loading from tasklet for CCMP encryption

2019-01-02 Thread Larry Finger
Commit 6bd082af7e36 ("staging:r8188eu: use lib80211 CCMP decrypt") causes scheduling while atomic bugs followed by a hard freeze whenever the driver tries to connect to a CCMP-encrypted network. Experimentation showed that the freezes were eliminated when module lib80211 was preloaded, which can

[PATCH 0/2] Fixes for system freezes for r8188eu

2019-01-02 Thread Larry Finger
The driver issues "scheduling while atomic" messages and will freeze the system. These problems are due to attempting to dynamically load library encryption routines from a tasklet. The fixes are relatively simple. All that is needed is to replace indirect calls of the try_then_request_module()

[PATCH 2/2] staging: rtl8188eu: Fix module loading from tasklet for WEP encryption

2019-01-02 Thread Larry Finger
Commit 2b2ea09e74a5 ("staging:r8188eu: Use lib80211 to decrypt WEP-frames") causes scheduling while atomic bugs followed by a hard freeze whenever the driver tries to connect to a WEP-encrypted network. Experimentation showed that the freezes were eliminated when module lib80211 was preloaded,

Re: [PATCH 0/2] staging: mt7621-pinctrl: use pinconf-generic in some driver ops

2019-01-02 Thread NeilBrown
On Mon, Dec 31 2018, Sergio Paracuellos wrote: > dt_node_to_map and dt_free_map operations can use pinconf-generic API's > instead of redefine operations in the driver. Make use of them cleaning > a bit driver's code. > > Update DT accordly to make sure used bindings property in code match > with

Re: [PATCH] staging: android: ion: Add chunk heaps instantiation

2019-01-02 Thread Laura Abbott
On 12/20/18 1:29 PM, Alexey Skidanov wrote: On 12/20/18 10:36 PM, Laura Abbott wrote: On 12/16/18 2:46 AM, Alexey Skidanov wrote: Chunk heap instantiation should be supported for device tree platforms and non device tree platforms. For device tree platforms, it's a platform specific code

Re: [PATCH] staging: android: ion: move map_kernel to ion_dma_buf_kmap

2019-01-02 Thread Laura Abbott
On 12/24/18 12:19 AM, Qing Xia wrote: Now, as Google's user guide, if userspace need clean ION buffer's cache, they should call ioctl(fd, DMA_BUF_IOCTL_SYNC, sync). Then we found that ion_dma_buf_begin_cpu_access/ion_dma_buf_end_cpu_access will do ION buffer's map_kernel, it's not necessary. And

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

2019-01-02 Thread Laura Abbott
On 12/23/18 6:47 PM, Zengtao (B) wrote: Hi laura: -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Friday, December 21, 2018 4:50 AM To: Zengtao (B) ; sumit.sem...@linaro.org Cc: Greg Kroah-Hartman ; Arve Hjønnevåg ; Todd Kjos ; Martijn Coenen ; Joel Fernandes ;

Re: [PATCH] Staging: iio: ad7192: replaced bool in struct

2019-01-02 Thread Matt Ranostay
> On Dec 24, 2018, at 01:58, Himanshu Jha wrote: > >> On Fri, Dec 21, 2018 at 03:26:26PM -0800, Amir Mahdi Ghorbanian wrote: >> Replaced bool in struct with unsigned int bitfield to conserve space and >> more clearly define size of varibales Important thing to note is depending on padding,

[PATCH] MAINTAINERS: Add entry for staging driver r8188eu

2019-01-02 Thread Larry Finger
This entry was missed when the driver was added. Signed-off-by: Larry Finger --- Greg, Because this driver is in staging, I am sending it to you. I hope that is OK. Larry --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"

2019-01-02 Thread Ivan Safonov
On 1/2/19 4:06 AM, Larry Finger wrote: On 1/1/19 1:31 PM, Michael Straube wrote: I've tested your patch and it solved the issue. No freezes and dmesg looks good. I noticed that try_then_request_module() is also used in rtw_wep_encrypt() and rtw_wep_decrypt(). I guess that also could cause

Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"

2019-01-02 Thread Ivan Safonov
On 1/2/19 12:38 AM, Larry Finger wrote: On 1/1/19 3:02 AM, Ivan Safonov wrote: I suggested a patch for loading modules from interruptible mode, but this patch remained unclaimed ( http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-August/124851.html ). For some reason I

[driver-core:debugfs_cleanup 40/40] drivers/infiniband/hw/cxgb4/device.c:740:9: warning: 'return' with a value, in function returning void

2019-01-02 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: 3991c968605e239dcbd501054f0b45cb2639816c commit: 3991c968605e239dcbd501054f0b45cb2639816c [40/40] ib: cxgb4: no need to check return value of debugfs_create functions config:

Re: [PATCH] Staging: iio: ad7192: replaced bool in struct

2019-01-02 Thread Dan Carpenter
On Fri, Dec 21, 2018 at 03:26:26PM -0800, Amir Mahdi Ghorbanian wrote: > Replaced bool in struct with unsigned int bitfield to conserve space and > more clearly define size of varibales > > Signed-off-by: Amir Mahdi Ghorbanian > --- > drivers/staging/iio/adc/ad7192.h | 14 +++--- > 1

[PATCH v2 2/2] binderfs: reserve devices for initial mount

2019-01-02 Thread Christian Brauner
The binderfs instance in the initial ipc namespace will always have a reserve of 4 binder devices unless explicitly capped by specifying a lower value via the "max" mount option. This ensures when binder devices are removed (on accident or on purpose) they can always be recreated without risking

[PATCH v2 1/2] binderfs: implement "max" mount option

2019-01-02 Thread Christian Brauner
Since binderfs can be mounted by userns root in non-initial user namespaces some precautions are in order. First, a way to set a maximum on the number of binder devices that can be allocated per binderfs instance and second, a way to reserve a reasonable chunk of binderfs devices for the initial

Re: [PATCH] rts5208: fix a missing check of ms read

2019-01-02 Thread Dan Carpenter
On Thu, Dec 20, 2018 at 02:00:01PM -0600, Kangjie Lu wrote: > When ms_read_extra_data fails, the data read in "extra" buffer is > just incorrect and thus should be used. However, "extra" is used > in multiple places no matter ms_read_extra_data() fails or not. > The fix checks the status of

Re: [PATCH] staging: rtlwifi: Fix one line with over 80 chars.

2019-01-02 Thread Dan Carpenter
On Tue, Dec 18, 2018 at 10:30:05AM -0500, Lei Zhou wrote: > Add local temporary variable used as buffer to pass caller pointer into > function ieee80211_connection_loss() to avoid over 80 characters on one > line. > Adding a temporary variable which is only used once does not improve

Re: [PATCH v1 1/2] binderfs: implement "max" mount option

2019-01-02 Thread Christian Brauner
On Wed, Jan 02, 2019 at 12:17:31PM +0300, Dan Carpenter wrote: > On Sun, Dec 23, 2018 at 03:35:49PM +0100, Christian Brauner wrote: > > static inline struct binderfs_info *BINDERFS_I(const struct inode *inode) > > @@ -110,10 +132,16 @@ static int binderfs_binder_device_create(struct inode > >

Re: [PATCH] Staging: vt6655: Fix camel case of variable

2019-01-02 Thread Dan Carpenter
On Sat, Dec 29, 2018 at 11:59:52PM +0100, Petr Sedlák wrote: > Replace variable uDelayUnit with u_delay_unit. Issue found by > checkpatch. > > Signed-off-by: Petr Sedlák > --- > drivers/staging/vt6655/upc.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] staging: rts5208: Add a check for ms_read_extra_data

2019-01-02 Thread Dan Carpenter
On Thu, Dec 27, 2018 at 01:35:53PM -0600, Aditya Pakki wrote: > In ms_copy_page, the function ms_read_extra_data may fail for many > reasons. The fix adds a check similar to other invocation to return > error upstream. > > Signed-off-by: Aditya Pakki Yup. It doesn't make sense to use stale

Re: [PATCH v2] rtl8712: add a check for the status of register_netdev

2019-01-02 Thread Dan Carpenter
On Tue, Dec 25, 2018 at 08:39:53PM -0600, Kangjie Lu wrote: > register_netdev() may fail, so let's check its return value, and if it > fails, issue an error message. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/rtl8712/hal_init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2

Re: [PATCH v2 0/3] staging: mt7621-pci: extract PCI PHY part into a new 'pci-mt7621-phy' driver

2019-01-02 Thread Sergio Paracuellos
Hi Dan, On Wed, Jan 2, 2019 at 10:41 AM Dan Carpenter wrote: > > Send a reply to the v1 thread so we don't apply that by mistake. Thanks for letting me know. I have just sent the mail reply to v1. > > regards, > dan carpenter > Best regards, Sergio Paracuellos

Re: [PATCH 0/3] staging: mt7621-pci: extract PCI PHY part into a new 'pci-mt7621-phy' driver

2019-01-02 Thread Sergio Paracuellos
On Mon, Dec 24, 2018 at 11:45 AM Sergio Paracuellos wrote: > > There is a lot of code related with PHY part of the mt7621 PCI driver > that can be extracted to a new PHY generic driver to do the same function. > > This patch series add a new 'mt7621-pci-phy' driver to handle those > and updates

Re: [PATCH] rts5208: fix a missing check of the status of sd_init_power

2019-01-02 Thread Dan Carpenter
On Tue, Dec 25, 2018 at 02:33:32AM -0600, Kangjie Lu wrote: > sd_init_power() could fail. The fix inserts a check of its status. If it > fails, returns STATUS_FAIL. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/rts5208/sd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

Re: [PATCH v2 0/3] staging: mt7621-pci: extract PCI PHY part into a new 'pci-mt7621-phy' driver

2019-01-02 Thread Dan Carpenter
Send a reply to the v1 thread so we don't apply that by mistake. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning"

2019-01-02 Thread Dan Carpenter
The subject is too long. On Mon, Dec 24, 2018 at 08:11:28AM -0800, Prathamesh Deshpande wrote: > This patch removes unnecessary out of memory warning > message from wlan-ng prism2fw.c file. > > Signed-off-by: Prathamesh Deshpande > --- > drivers/staging/wlan-ng/prism2fw.c | 1 - > 1 file

Re: [PATCH v1 1/2] binderfs: implement "max" mount option

2019-01-02 Thread Dan Carpenter
On Sun, Dec 23, 2018 at 03:35:49PM +0100, Christian Brauner wrote: > static inline struct binderfs_info *BINDERFS_I(const struct inode *inode) > @@ -110,10 +132,16 @@ static int binderfs_binder_device_create(struct inode > *ref_inode, > > /* Reserve new minor number for the new device.

Re: [PATCH] rtl8723bs/ioctl_linux: Add a security check to copy_from_user()

2019-01-02 Thread Dan Carpenter
On Sun, Dec 23, 2018 at 06:13:02PM -0600, Aditya Pakki wrote: > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > index b8631baf128d..9992caa8c839 100644 > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > +++