Re: [PATCH] Mediatek staging: Use individual config flags in Makefile

2019-01-09 Thread George Hilliard
On Thu, Jan 10, 2019 at 12:39 AM Greg KH wrote: > > On Thu, Jan 10, 2019 at 12:26:28AM -0700, thirtythreefo...@gmail.com wrote: > > From: George Hilliard > > > > These drivers are useful on other MT76xx SoCs, which have compatible > > peripherals. The drivers are selectable in Kconfig, but they

Re: [PATCH] Mediatek staging: Use individual config flags in Makefile

2019-01-09 Thread Greg KH
On Thu, Jan 10, 2019 at 12:26:28AM -0700, thirtythreefo...@gmail.com wrote: > From: George Hilliard > > These drivers are useful on other MT76xx SoCs, which have compatible > peripherals. The drivers are selectable in Kconfig, but they were > quietly excluded from the build because the SOC_MT762

[PATCH] Mediatek staging: Use individual config flags in Makefile

2019-01-09 Thread thirtythreeforty
From: George Hilliard These drivers are useful on other MT76xx SoCs, which have compatible peripherals. The drivers are selectable in Kconfig, but they were quietly excluded from the build because the SOC_MT7621 chip was not selected. So, make the main staging Makefile use the same flags as eve

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Peter Robinson
> > I get difference results with 5.0-rc1 but neither of the above apps > > work either, will follow up based on the rest of the thread there. > > > > My first step with Raspbian is to enable the Camera interface which results > into an appending of the following lines to config.txt: > > start_x=1

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2019-01-09 Thread Greg KH
On Wed, Jan 09, 2019 at 04:19:30PM -0800, Nick Desaulniers wrote: > Digging up an old thread to point out I was wrong: > > On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers > wrote: > > > This is not a million-little-commits problem; more like 2 drivers in > > > the whole tree have this problem. >

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Peter Robinson
> > Hi Stefan, > > > ... > > > > I get difference results with 5.0-rc1 but neither of the above apps > > work either, will follow up based on the rest of the thread there. > > > > My first step with Raspbian is to enable the Camera interface which results > into an appending of the following lines

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Stefan Wahren
> Peter Robinson hat am 10. Januar 2019 um 06:09 > geschrieben: > > > Hi Stefan, > ... > > I get difference results with 5.0-rc1 but neither of the above apps > work either, will follow up based on the rest of the thread there. > My first step with Raspbian is to enable the Camera interfa

[PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local variable

2019-01-09 Thread Sidong Yang
Removed unnecessary local variable in have_hgsmi_mode_hints. The result of hgsmi_query_conf should be directly compared without assigning to local variable. Signed-off-by: Sidong Yang --- drivers/staging/vboxvideo/vbox_main.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-)

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Peter Robinson
Hi Dave, > > > This patch series improves the load/unload of bcm2835 camera and audio > > > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1. > > > > > > This series based on current linux-next and Phil Elwell's series > > > ("Improve VCHIQ > > > cache line size handling"

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Peter Robinson
Hi Stefan, > > > But why didn't you applied the series which was actually applied to > > > mainline? > > > Did you apply the rest of Phil's DT series as mentioned in the cover > > > letter? > > > > I'm fairly certain I have Phil's "Improve VCHIQ cache line size > > handling" patch series applied

RE: [PATCH v2] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-09 Thread Dexuan Cui
> From: Michael Kelley > Sent: Saturday, January 5, 2019 1:01 PM > > From: Kimberly Brown Sent: Friday, January 4, > > 2019 8:35 PM > > > > static inline void set_channel_pending_send_size(struct vmbus_channel *c, > > u32 size) > > { > > + if (si

RE: [PATCH v2] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-09 Thread Dexuan Cui
> From: Kimberly Brown > Sent: Friday, January 4, 2019 8:35 PM ... > +What: > /sys/bus/vmbus/devices//channels//intr_in_full > +Date: January 2019 > +KernelVersion: 4.21 There is no 4.21 version: see https://lkml.org/lkml/2019/1/6/178 :-) Thanks! -- Dexuan __

Re: [PATCH][re-post] vmbus: fix subchannel removal

2019-01-09 Thread Sasha Levin
On Wed, Jan 09, 2019 at 08:56:06PM +, Dexuan Cui wrote: The changes to split ring allocation from open/close, broke the cleanup of subchannels. This resulted in problems using uio on network devices because the subchannel was left behind when the network device was unbound. The cause was in

[PATCH][re-post] vmbus: fix subchannel removal

2019-01-09 Thread Dexuan Cui
The changes to split ring allocation from open/close, broke the cleanup of subchannels. This resulted in problems using uio on network devices because the subchannel was left behind when the network device was unbound. The cause was in the disconnect logic which used list splice to move the subc

[PATCH] media: imx-csi: Input connections to CSI should be optional

2019-01-09 Thread Steve Longerbeam
Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode endpoint parsing will not treat a

[PATCH v8 07/11] media: imx-csi: Allow skipping odd chroma rows for YVU420

2019-01-09 Thread Steve Longerbeam
Skip writing U/V components to odd rows for YVU420 in addition to YUV420 and NV12. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel --- drivers/staging/media/imx/imx-media-csi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/st

[PATCH v8 02/11] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-09 Thread Steve Longerbeam
The function ipu_csi_init_interface() was inverting the F-bit for NTSC case, in the CCIR_CODE_1/2 registers. The result being that for NTSC bottom-top field order, the CSI would swap fields and capture in top-bottom order. Instead, base field swap on the field order of the input to the CSI, and th

[PATCH v8 10/11] media: imx: Allow interweave with top/bottom lines swapped

2019-01-09 Thread Steve Longerbeam
Allow sequential->interlaced interweaving but with top/bottom lines swapped to the output buffer. This can be accomplished by adding one line length to IDMAC output channel address, with a negative line length for the interlace offset. This is to allow the seq-bt -> interlaced-bt transformation,

[PATCH v8 09/11] media: imx-csi: Move crop/compose reset after filling default mbus fields

2019-01-09 Thread Steve Longerbeam
If caller passes un-initialized field type V4L2_FIELD_ANY to CSI sink pad, the reset CSI crop window would not be correct, because the crop window depends on a valid input field type. To fix move the reset of crop and compose windows to after the call to imx_media_fill_default_mbus_fields(). Signe

[PATCH v8 06/11] media: imx: interweave and odd-chroma-row skip are incompatible

2019-01-09 Thread Steve Longerbeam
If IDMAC interweaving is enabled in a write channel, the channel must write the odd chroma rows for 4:2:0 formats. Skipping writing the odd chroma rows produces corrupted captured 4:2:0 images when interweave is enabled. Reported-by: Krzysztof Hałasa Signed-off-by: Steve Longerbeam Reviewed-by:

[PATCH v8 05/11] media: imx-csi: Double crop height for alternate fields at sink

2019-01-09 Thread Steve Longerbeam
If the incoming sink field type is alternate, the reset crop height and crop height bounds must be set to twice the incoming height, because in alternate field mode, upstream will report only the lines for a single field, and the CSI captures the whole frame. Signed-off-by: Steve Longerbeam Revie

[PATCH v8 08/11] media: imx: vdic: rely on VDIC for correct field order

2019-01-09 Thread Steve Longerbeam
prepare_vdi_in_buffers() was setting up the dma pointers as if the VDIC is always programmed to receive the fields in bottom-top order, i.e. as if ipu_vdi_set_field_order() only programs BT order in the VDIC. But that's not true, ipu_vdi_set_field_order() is working correctly. So fix prepare_vdi_i

[PATCH v8 04/11] media: imx: Fix field negotiation

2019-01-09 Thread Steve Longerbeam
IDMAC interlaced scan, a.k.a. interweave, should be enabled in the IDMAC output channels only if the IDMAC output pad field type is 'seq-bt' or 'seq-tb', and field type at the capture interface is 'interlaced*'. V4L2_FIELD_HAS_BOTH() macro should not be used on the input to determine enabling inte

[PATCH v8 03/11] gpu: ipu-v3: Add planar support to interlaced scan

2019-01-09 Thread Steve Longerbeam
To support interlaced scan with planar formats, cpmem SLUV must be programmed with the correct chroma line stride. For full and partial planar 4:2:2 (YUV422P, NV16), chroma line stride must be doubled. For full and partial planar 4:2:0 (YUV420, YVU420, NV12), chroma line stride must _not_ be double

[PATCH v7 09/11] media: imx-csi: Move crop/compose reset after filling default mbus fields

2019-01-09 Thread Steve Longerbeam
If caller passes un-initialized field type V4L2_FIELD_ANY to CSI sink pad, the reset CSI crop window would not be correct, because the crop window depends on a valid input field type. To fix move the reset of crop and compose windows to after the call to imx_media_fill_default_mbus_fields(). Signe

[PATCH v7 06/11] media: imx: interweave and odd-chroma-row skip are incompatible

2019-01-09 Thread Steve Longerbeam
If IDMAC interweaving is enabled in a write channel, the channel must write the odd chroma rows for 4:2:0 formats. Skipping writing the odd chroma rows produces corrupted captured 4:2:0 images when interweave is enabled. Reported-by: Krzysztof Hałasa Signed-off-by: Steve Longerbeam Reviewed-by:

[PATCH v7 04/11] media: imx: Fix field negotiation

2019-01-09 Thread Steve Longerbeam
IDMAC interlaced scan, a.k.a. interweave, should be enabled in the IDMAC output channels only if the IDMAC output pad field type is 'seq-bt' or 'seq-tb', and field type at the capture interface is 'interlaced*'. V4L2_FIELD_HAS_BOTH() macro should not be used on the input to determine enabling inte

[PATCH v7 10/11] media: imx: Allow interweave with top/bottom lines swapped

2019-01-09 Thread Steve Longerbeam
Allow sequential->interlaced interweaving but with top/bottom lines swapped to the output buffer. This can be accomplished by adding one line length to IDMAC output channel address, with a negative line length for the interlace offset. This is to allow the seq-bt -> interlaced-bt transformation,

[PATCH v7 08/11] media: imx: vdic: rely on VDIC for correct field order

2019-01-09 Thread Steve Longerbeam
prepare_vdi_in_buffers() was setting up the dma pointers as if the VDIC is always programmed to receive the fields in bottom-top order, i.e. as if ipu_vdi_set_field_order() only programs BT order in the VDIC. But that's not true, ipu_vdi_set_field_order() is working correctly. So fix prepare_vdi_i

[PATCH v7 05/11] media: imx-csi: Double crop height for alternate fields at sink

2019-01-09 Thread Steve Longerbeam
If the incoming sink field type is alternate, the reset crop height and crop height bounds must be set to twice the incoming height, because in alternate field mode, upstream will report only the lines for a single field, and the CSI captures the whole frame. Signed-off-by: Steve Longerbeam Revie

[PATCH v7 02/11] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-09 Thread Steve Longerbeam
The function ipu_csi_init_interface() was inverting the F-bit for NTSC case, in the CCIR_CODE_1/2 registers. The result being that for NTSC bottom-top field order, the CSI would swap fields and capture in top-bottom order. Instead, base field swap on the field order of the input to the CSI, and th

[PATCH v7 07/11] media: imx-csi: Allow skipping odd chroma rows for YVU420

2019-01-09 Thread Steve Longerbeam
Skip writing U/V components to odd rows for YVU420 in addition to YUV420 and NV12. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel --- drivers/staging/media/imx/imx-media-csi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/st

[PATCH v7 03/11] gpu: ipu-v3: Add planar support to interlaced scan

2019-01-09 Thread Steve Longerbeam
To support interlaced scan with planar formats, cpmem SLUV must be programmed with the correct chroma line stride. For full and partial planar 4:2:2 (YUV422P, NV16), chroma line stride must be doubled. For full and partial planar 4:2:0 (YUV420, YVU420, NV12), chroma line stride must _not_ be double

Re: [PATCH v6 05/12] media: imx-csi: Input connections to CSI should be optional

2019-01-09 Thread Steve Longerbeam
On 1/9/19 3:13 AM, Philipp Zabel wrote: On Tue, 2019-01-08 at 16:15 -0800, Steve Longerbeam wrote: Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2

Re: [PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Hans Verkuil
On 01/09/19 15:42, Paul Kocialkowski wrote: > Hi, > > On Wed, 2019-01-09 at 15:29 +0100, Hans Verkuil wrote: >> On 01/09/19 15:19, Paul Kocialkowski wrote: >>> It was reported that some cases of interleaved video decoding require >>> using the current destination buffer as a reference. However, th

[PATCH] staging/android/vsoc: Remove duplicate header

2019-01-09 Thread Brajeswar Ghosh
Remove linux/mutex.h.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/staging/android/vsoc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/vsoc.c b/drivers/staging/android/vsoc.c index 22571abcaa4e..8a75bd27c413 100644 --- a/drivers/stagi

Re: [PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Paul Kocialkowski
Hi, On Wed, 2019-01-09 at 15:29 +0100, Hans Verkuil wrote: > On 01/09/19 15:19, Paul Kocialkowski wrote: > > It was reported that some cases of interleaved video decoding require > > using the current destination buffer as a reference. However, this is > > no longer possible after the move to vb2_

Re: [PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Hans Verkuil
On 01/09/19 15:19, Paul Kocialkowski wrote: > It was reported that some cases of interleaved video decoding require > using the current destination buffer as a reference. However, this is > no longer possible after the move to vb2_find_timestamp because only > dequeued and done buffers are consider

[PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Paul Kocialkowski
It was reported that some cases of interleaved video decoding require using the current destination buffer as a reference. However, this is no longer possible after the move to vb2_find_timestamp because only dequeued and done buffers are considered. Add a helper in our driver that also considers

[PATCH 1/2] media: cedrus: Cleanup duplicate declarations from cedrus_dec header

2019-01-09 Thread Paul Kocialkowski
Some leftover declarations are still in the cedrus_dec header although they were moved to cedrus_video already. Clean them up. Signed-off-by: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/cedrus_dec.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/media/sunxi

[PATCH -next] staging: wilc1000: remove set but not used variable 'msa'

2019-01-09 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/wilc1000/host_interface.c: In function 'wilc_parse_network_info': drivers/staging/wilc1000/host_interface.c:748:16: warning: variable 'msa' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- drivers/staging

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Nicolas Saenz Julienne
Hi Stefan, On Wed, 2019-01-09 at 09:33 +0100, Stefan Wahren wrote: > > But i noticed a regression introduced in 5.0-rc1, which might be > related. I > tried to run "vchiq_test -f 1" and it never completes. After > reverting commit > 852b2876a8a8 ("staging: vchiq: rework remove_event handling") >

Re: [PATCH v4 4/4] staging: greybus: arche-platform: Switch to the gpio descriptor interface

2019-01-09 Thread Johan Hovold
On Sat, Dec 22, 2018 at 08:23:02PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated > old non-descriptor interface. > > Signed-off-by: Nishad Kamdar > --- > Changes in v4: > - Move 'gpio_desc *svc_sysboot' below the reset flag >as it is more logical to have res

Re: [PATCH v4 3/4] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

2019-01-09 Thread Johan Hovold
On Sat, Dec 22, 2018 at 08:22:09PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar > --- > Changes in v4: > - Use gpiod_set_raw_value() for deassert_reset() and >assert_reset() as gpiod_set_value

Re: [PATCH v6 05/12] media: imx-csi: Input connections to CSI should be optional

2019-01-09 Thread Philipp Zabel
On Tue, 2019-01-08 at 16:15 -0800, Steve Longerbeam wrote: > Some imx platforms do not have fwnode connections to all CSI input > ports, and should not be treated as an error. This includes the > imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. > Return -ENOTCONN in imx_csi_par

Re: [PATCH v6 02/12] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-09 Thread Philipp Zabel
On Tue, 2019-01-08 at 16:15 -0800, Steve Longerbeam wrote: > The function ipu_csi_init_interface() was inverting the F-bit for > NTSC case, in the CCIR_CODE_1/2 registers. The result being that > for NTSC bottom-top field order, the CSI would swap fields and > capture in top-bottom order. > > Inst

Re: [PATCH v4 2/4] staging: greybus: gpio: Use gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller()

2019-01-09 Thread Johan Hovold
On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote: > This patch drops gpio_chip_to_gb_gpio_controller(), > and uses gpiochip_get_data() to retrieve the container > of struct gpio_chip. So this will break the driver, since gpiochip_add() sets the data pointer to NULL. These kind of cha

Re: [PATCH v4 1/4] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

2019-01-09 Thread Johan Hovold
On Sat, Dec 22, 2018 at 08:17:02PM +0530, Nishad Kamdar wrote: > Convert the GPIO driver to use the GPIO irqchip library > GPIOLIB_IRQCHIP instead of reimplementing the same. > > Signed-off-by: Nishad Kamdar > --- > Changes in v4: > - Remove changes related to conversion to gpiochip_get_data() t

Re: [PATCH AUTOSEL 4.20 056/117] media: cedrus: don't initialize pointers with zero

2019-01-09 Thread Dan Carpenter
This is a pure cleanup patch, it doesn't affect runtime. On Tue, Jan 08, 2019 at 02:25:24PM -0500, Sasha Levin wrote: > From: Mauro Carvalho Chehab > > [ Upstream commit e4d7b113fdccde1acf8638c5879f2a450d492303 ] > > A common mistake is to assume that initializing a var with: > struct foo

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Stefan Wahren
Hi, [add Arnd] > Dave Stevenson hat am 8. Januar 2019 um 18:10 > geschrieben: > > > Hi Peter > > On Tue, 8 Jan 2019 at 07:21, Peter Robinson wrote: > > > > Hi Stefan, > > > > > This patch series improves the load/unload of bcm2835 camera and audio > > > drivers. It has been tested with Raspb