Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-11 Thread Peter Robinson
> > > > > > I get difference results with 5.0-rc1 but neither of the above apps > > > > > > work either, will follow up based on the rest of the thread there. > > > > > > > > > > > > > > > > My first step with Raspbian is to enable the Camera interface which > > > > > results into an appending of

Re: [PATCH] staging: vchiq: Fix local event signalling

2019-01-11 Thread Stefan Wahren
> Phil Elwell hat am 11. Januar 2019 um 12:34 > geschrieben: > > > Prior to the recent event reworking (see Fixes), thread synchronisation > was implemented using completions, the worker thread being woken with > a call to complete(). The replacement uses waitqueues, which are more > like

[PATCH] binderfs: handle !CONFIG_IPC_NS builds

2019-01-11 Thread Christian Brauner
kbuild reported a build faile in [1]. This is triggered when CONFIG_IPC_NS is not set. So let's make the use of init_ipc_ns conditional on CONFIG_IPC_NS being set. [1]: https://lists.01.org/pipermail/kbuild-all/2019-January/056903.html Signed-off-by: Christian Brauner ---

[PATCH 06/14] staging: android: ion: Fixup some white-space issues

2019-01-11 Thread Andrew F. Davis
Add white-space for easier reading and remove some where it does not belong. No functional changes, they just bug me.. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion_carveout_heap.c | 1 + drivers/staging/android/ion/ion_chunk_heap.c| 2 +-

[PATCH 00/14] Misc ION cleanups and adding unmapped heap

2019-01-11 Thread Andrew F. Davis
Hello all, This is a set of (hopefully) non-controversial cleanups for the ION framework and current set of heaps. These were found as I start to familiarize myself with the framework to help in whatever way I can in getting all this up to the standards needed for de-staging. I would like to get

[PATCH 14/14] staging: android: ion: Add UNMAPPED heap type and helper

2019-01-11 Thread Andrew F. Davis
The "unmapped" heap is very similar to the carveout heap except the backing memory is presumed to be unmappable by the host, in my specific case due to firewalls. This memory can still be allocated from and used by devices that do have access to the backing memory. Based originally on the

[PATCH 01/14] staging: android: ion: Add proper header information

2019-01-11 Thread Andrew F. Davis
The filenames in headers add nothing are often wrong after moves, lets drop them here and add a little description of the files contents. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion.c | 2 +- drivers/staging/android/ion/ion.h | 2 +-

[PATCH 02/14] staging: android: ion: Remove empty ion_ioctl_dir() function

2019-01-11 Thread Andrew F. Davis
This function is empty of real function and can be replaced with _IOC_DIR(). Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion-ioctl.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c

[PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-11 Thread Andrew F. Davis
Buffers may not be mapped from the CPU so skip cache maintenance here. Accesses from the CPU to a cached heap should be bracketed with {begin,end}_cpu_access calls so maintenance should not be needed anyway. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion.c | 7 --- 1

[PATCH 07/14] staging: android: ion: Sync comment docs with struct ion_buffer

2019-01-11 Thread Andrew F. Davis
This struct is no longer documented correctly, fix this. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index

[PATCH 08/14] staging: android: ion: Remove base from ion_carveout_heap

2019-01-11 Thread Andrew F. Davis
The base address is not used anywhere and tracked by the pool allocator. No need to store this anymore. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion_carveout_heap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 04/14] staging: android: ion: Remove leftover comment

2019-01-11 Thread Andrew F. Davis
Since we use CMA APIs directly there is no device nor private heaps data, drop this comment. Fixes: 204f672255c2 ("staging: android: ion: Use CMA APIs directly") Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion_cma_heap.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 05/14] staging: android: ion: Remove struct ion_platform_heap

2019-01-11 Thread Andrew F. Davis
Now that ION heap registration has been re-worked to not depend on board files or have a central heap register helper there is no need to have this data structure. Most of the fields are unused. Some heap creation helpers are still available that use this to define the a heap but only use 2 or 3

[PATCH 03/14] staging: android: ion: Merge ion-ioctl.c into ion.c

2019-01-11 Thread Andrew F. Davis
The file ion-ioctl.c is now much to small and tightly integrated with the main ion.c file to justify keeping it separate. Merge this file. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/Makefile| 2 +- drivers/staging/android/ion/ion-ioctl.c | 86 -

[PATCH 10/14] staging: android: ion: Remove unused headers

2019-01-11 Thread Andrew F. Davis
Various cleanups have removed the use of some headers in ION, remove these here. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion.c | 3 --- drivers/staging/android/ion/ion_carveout_heap.c | 4 ++-- drivers/staging/android/ion/ion_chunk_heap.c| 3 +-- 3 files

[PATCH 09/14] staging: android: ion: Remove base from ion_chunk_heap

2019-01-11 Thread Andrew F. Davis
The base address is not used anywhere and tracked by the pool allocator. No need to store this anymore. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion_chunk_heap.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 12/14] staging: android: ion: Declare helpers for carveout and chunk heaps

2019-01-11 Thread Andrew F. Davis
When enabled the helpers functions for creating carveout and chunk heaps should have declarations in the ION header. Signed-off-by: Andrew F. Davis --- drivers/staging/android/ion/ion.h | 33 +++ 1 file changed, 33 insertions(+) diff --git

[PATCH 11/14] staging: android: ion: Allow heap name to be null

2019-01-11 Thread Andrew F. Davis
The heap name can be used for debugging but otherwise does not seem to be required and no other part of the code will fail if left NULL except here. We can make it required and check for it at some point, for now lets just prevent this from causing a NULL pointer exception. Signed-off-by: Andrew

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-11 Thread Dave Stevenson
Hi Peter On Fri, 11 Jan 2019 at 06:10, Peter Robinson wrote: > > Hi Stefan, > > > > > > I get difference results with 5.0-rc1 but neither of the above apps > > > > > work either, will follow up based on the rest of the thread there. > > > > > > > > > > > > > My first step with Raspbian is to

[PATCH v2] binder: create node flag to request sender's security context

2019-01-11 Thread Todd Kjos
To allow servers to verify client identity, allow a node flag to be set that causes the sender's security context to be delivered with the transaction. The BR_TRANSACTION command is extended in BR_TRANSACTION_SEC_CTX to contain a pointer to the security context string. Signed-off-by: Todd Kjos

[PATCH v6 2/2] staging: greybus: arche-platform: Switch to the gpio descriptor interface

2019-01-11 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface while continuing to ignore gpio flags from device tree in "svc_reset_onoff()" for now. Reviewed-by: Johan Hovold Signed-off-by: Nishad Kamdar --- Changes in v6: - Make error messages consistent. Changes in v5: -

[PATCH v6 1/2] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

2019-01-11 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface while continuing to ignore gpio flags from device tree in functions "deassert_reset()" and "assert_reset()" for now. Reviewed-by: Johan Hovold Signed-off-by: Nishad Kamdar --- Changes in v6: - Remove some

[PATCH v6 0/2] greybus: gpio: Switch to the gpio descriptor interface

2019-01-11 Thread Nishad Kamdar
This patch series converts uses of the old GPIO API to the GPIO descriptor API. It also converts the GPIO driver to use the GPIO irqchip library GPIOLIB_IRQCHIP instead of repimplementing the same. Changes in v6: - Patchset now contains two patches as the patch 1 has been accepted. - Changes

Re: [RESEND PATCH] binderfs: reserve devices for initial mount

2019-01-11 Thread Greg KH
On Fri, Jan 11, 2019 at 11:20:56AM +0100, Christian Brauner wrote: > On Fri, Jan 11, 2019 at 11:19:40AM +0100, Christian Brauner wrote: > > The binderfs instance in the initial ipc namespace will always have a > > reserve of 4 binder devices unless explicitly capped by specifying a lower > > value

[PATCH] staging: vchiq: Fix local event signalling

2019-01-11 Thread Phil Elwell
Prior to the recent event reworking (see Fixes), thread synchronisation was implemented using completions, the worker thread being woken with a call to complete(). The replacement uses waitqueues, which are more like condition variables in that the waiting thread is only woken if the condition is

Re: [RESEND PATCH] binderfs: reserve devices for initial mount

2019-01-11 Thread Christian Brauner
On Fri, Jan 11, 2019 at 11:19:40AM +0100, Christian Brauner wrote: > The binderfs instance in the initial ipc namespace will always have a > reserve of 4 binder devices unless explicitly capped by specifying a lower > value via the "max" mount option. > This ensures when binder devices are removed

[RESEND PATCH] binderfs: reserve devices for initial mount

2019-01-11 Thread Christian Brauner
The binderfs instance in the initial ipc namespace will always have a reserve of 4 binder devices unless explicitly capped by specifying a lower value via the "max" mount option. This ensures when binder devices are removed (on accident or on purpose) they can always be recreated without risking

Re: [PATCH v2 2/2] binderfs: reserve devices for initial mount

2019-01-11 Thread Christian Brauner
On Fri, Jan 11, 2019 at 10:18:18AM +0100, Greg KH wrote: > On Wed, Jan 02, 2019 at 12:32:19PM +0100, Christian Brauner wrote: > > The binderfs instance in the initial ipc namespace will always have a > > reserve of 4 binder devices unless explicitly capped by specifying a lower > > value via the

Re: [PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local variable

2019-01-11 Thread Greg Kroah-Hartman
On Thu, Jan 10, 2019 at 06:13:47AM +, Sidong Yang wrote: > Removed unnecessary local variable in have_hgsmi_mode_hints. > The result of hgsmi_query_conf should be directly compared without > assigning to local variable. > > Signed-off-by: Sidong Yang > --- >

Re: [PATCH v2 2/2] binderfs: reserve devices for initial mount

2019-01-11 Thread Greg KH
On Wed, Jan 02, 2019 at 12:32:19PM +0100, Christian Brauner wrote: > The binderfs instance in the initial ipc namespace will always have a > reserve of 4 binder devices unless explicitly capped by specifying a lower > value via the "max" mount option. > This ensures when binder devices are removed

Re: [PATCH] binder: create node flag to request sender's security context

2019-01-11 Thread Greg KH
On Thu, Jan 10, 2019 at 10:21:00AM -0800, Todd Kjos wrote: > To allow servers to verify client identity, allow a node > flag to be set that causes the sender's security context > to be delivered with the transaction. The BR_TRANSACTION > command is extended in BR_TRANSACTION_SEC_CTX to > contain a

Re: [PATCH v5 3/3] staging: greybus: arche-platform: Switch to the gpio descriptor interface

2019-01-11 Thread Johan Hovold
On Thu, Jan 10, 2019 at 11:23:07PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface while continuing to ignore gpio flags from device tree in > "svc_reset_onoff()" for now. > > Signed-off-by: Nishad Kamdar > --- > Changes in v5: > -

Re: [PATCH v5 2/3] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

2019-01-11 Thread Johan Hovold
On Thu, Jan 10, 2019 at 11:21:04PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface while continuing to ignore gpio flags from device tree in > functions "deassert_reset()" and "assert_reset()" for now. > > Signed-off-by: Nishad Kamdar

Re: [PATCH v5 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

2019-01-11 Thread Johan Hovold
On Thu, Jan 10, 2019 at 11:24:28PM +0530, Nishad Kamdar wrote: > Convert the GPIO driver to use the GPIO irqchip library > GPIOLIB_IRQCHIP instead of reimplementing the same. > > Signed-off-by: Nishad Kamdar > --- > Changes in v5: > - Restore "struct irq_chip irqc" in "struct