Re: [PATCH] staging: comedi: Removed not necessary braces for single block

2019-01-15 Thread Jitendra
"interesting" email name you used here :) Please fix up, it has to match the signed-off-by line. I fixed and resent the patch again. --- Jitendra ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: rtl8723bs: Fix build error with Clang when inlining is disabled

2019-01-15 Thread Nathan Chancellor
On Wed, Jan 16, 2019 at 07:42:02AM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 15, 2019 at 11:03:02PM -0700, Nathan Chancellor wrote: > > When CONFIG_NO_AUTO_INLINE was present in linux-next (which added > > '-fno-inline-functions' to KBUILD_CFLAGS), an allyesconfig build with > > Clang failed

Re: [PATCH -next] binderfs: fix error return code in binderfs_fill_super()

2019-01-15 Thread Greg KH
On Wed, Jan 16, 2019 at 07:28:26AM +0100, Christian Brauner wrote: > On Wed, Jan 16, 2019 at 07:25:46AM +0100, Christian Brauner wrote: > > On Wed, Jan 16, 2019 at 03:01:04AM +, Wei Yongjun wrote: > > > Fix to return a negative error code -ENOMEM from the new_inode() and > > > d_make_root()

[PATCH v5] staging: Mediatek: Use individual config flags in Makefile

2019-01-15 Thread George Hilliard
These drivers can be useful on other MT76xx SoCs, which have compatible peripherals. The drivers were selectable in Kconfig, but they were quietly excluded from the build because the SOC_MT7621 chip was not selected. So, make the Makefiles use the same flags as Kconfig for these drivers.

Re: [PATCH] staging: rtl8723bs: Fix build error with Clang when inlining is disabled

2019-01-15 Thread Greg Kroah-Hartman
On Tue, Jan 15, 2019 at 11:03:02PM -0700, Nathan Chancellor wrote: > When CONFIG_NO_AUTO_INLINE was present in linux-next (which added > '-fno-inline-functions' to KBUILD_CFLAGS), an allyesconfig build with > Clang failed at the modpost stage: > > ERROR: "is_broadcast_mac_addr"

Re: [PATCH -next] binderfs: fix error return code in binderfs_fill_super()

2019-01-15 Thread Christian Brauner
On Wed, Jan 16, 2019 at 07:25:46AM +0100, Christian Brauner wrote: > On Wed, Jan 16, 2019 at 03:01:04AM +, Wei Yongjun wrote: > > Fix to return a negative error code -ENOMEM from the new_inode() and > > d_make_root() error handling cases instead of 0, as done elsewhere in > > this function. >

Re: [PATCH -next] binderfs: fix error return code in binderfs_fill_super()

2019-01-15 Thread Christian Brauner
On Wed, Jan 16, 2019 at 03:01:04AM +, Wei Yongjun wrote: > Fix to return a negative error code -ENOMEM from the new_inode() and > d_make_root() error handling cases instead of 0, as done elsewhere in > this function. > > Fixes: 3ad20fe393b3 ("binder: implement binderfs") > Signed-off-by: Wei

[PATCH] staging: rtl8723bs: Fix build error with Clang when inlining is disabled

2019-01-15 Thread Nathan Chancellor
When CONFIG_NO_AUTO_INLINE was present in linux-next (which added '-fno-inline-functions' to KBUILD_CFLAGS), an allyesconfig build with Clang failed at the modpost stage: ERROR: "is_broadcast_mac_addr" [drivers/staging/rtl8723bs/r8723bs.ko] undefined! ERROR: "is_zero_mac_addr"

Re: [PATCH v4] staging: Mediatek: Use individual config flags in Makefile

2019-01-15 Thread kbuild test robot
Hi George, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [cannot apply to v5.0-rc2 next-20190115] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH -next] binderfs: fix error return code in binderfs_fill_super()

2019-01-15 Thread Wei Yongjun
Fix to return a negative error code -ENOMEM from the new_inode() and d_make_root() error handling cases instead of 0, as done elsewhere in this function. Fixes: 3ad20fe393b3 ("binder: implement binderfs") Signed-off-by: Wei Yongjun --- drivers/android/binderfs.c | 8 ++-- 1 file changed, 6

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-15 Thread Andrew F. Davis
On 1/14/19 11:13 AM, Liam Mark wrote: > On Fri, 11 Jan 2019, Andrew F. Davis wrote: > >> Buffers may not be mapped from the CPU so skip cache maintenance here. >> Accesses from the CPU to a cached heap should be bracketed with >> {begin,end}_cpu_access calls so maintenance should not be needed

[PATCH] media: imx: capture: Allow event subscribe/unsubscribe

2019-01-15 Thread Steve Longerbeam
Implement the vidioc_(un)subscribe_event operations. Imx will allow subscribing to the imx-specific frame interval error events, events from subdevices (V4L2_EVENT_SOURCE_CHANGE), and control events. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-capture.c | 18

[PATCH v2] media: imx: queue subdev events to reachable video devices

2019-01-15 Thread Steve Longerbeam
In order to receive events generated by subdevices on the video capture nodes, those events need to be forwarded to the subdevice's list of reachable video capture devices. Note this will queue the event to a video device even if there is no actual _enabled_ media path from the sub-device to the

Re: [PATCH 14/14] staging: android: ion: Add UNMAPPED heap type and helper

2019-01-15 Thread Laura Abbott
On 1/15/19 10:43 AM, Laura Abbott wrote: On 1/15/19 7:58 AM, Andrew F. Davis wrote: On 1/14/19 8:32 PM, Laura Abbott wrote: On 1/11/19 10:05 AM, Andrew F. Davis wrote: The "unmapped" heap is very similar to the carveout heap except the backing memory is presumed to be unmappable by the host,

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-15 Thread Laura Abbott
On 1/15/19 10:38 AM, Andrew F. Davis wrote: On 1/15/19 11:45 AM, Liam Mark wrote: On Tue, 15 Jan 2019, Andrew F. Davis wrote: On 1/14/19 11:13 AM, Liam Mark wrote: On Fri, 11 Jan 2019, Andrew F. Davis wrote: Buffers may not be mapped from the CPU so skip cache maintenance here. Accesses

Re: [PATCH 00/14] Misc ION cleanups and adding unmapped heap

2019-01-15 Thread Laura Abbott
On 1/15/19 9:47 AM, Andrew F. Davis wrote: On 1/14/19 8:39 PM, Laura Abbott wrote: On 1/11/19 10:05 AM, Andrew F. Davis wrote: Hello all, This is a set of (hopefully) non-controversial cleanups for the ION framework and current set of heaps. These were found as I start to familiarize myself

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-15 Thread Andrew F. Davis
On 1/15/19 12:38 PM, Andrew F. Davis wrote: > On 1/15/19 11:45 AM, Liam Mark wrote: >> On Tue, 15 Jan 2019, Andrew F. Davis wrote: >> >>> On 1/14/19 11:13 AM, Liam Mark wrote: On Fri, 11 Jan 2019, Andrew F. Davis wrote: > Buffers may not be mapped from the CPU so skip cache

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-15 Thread Andrew F. Davis
On 1/15/19 11:45 AM, Liam Mark wrote: > On Tue, 15 Jan 2019, Andrew F. Davis wrote: > >> On 1/14/19 11:13 AM, Liam Mark wrote: >>> On Fri, 11 Jan 2019, Andrew F. Davis wrote: >>> Buffers may not be mapped from the CPU so skip cache maintenance here. Accesses from the CPU to a cached

Re: [PATCH 14/14] staging: android: ion: Add UNMAPPED heap type and helper

2019-01-15 Thread Laura Abbott
On 1/15/19 7:58 AM, Andrew F. Davis wrote: On 1/14/19 8:32 PM, Laura Abbott wrote: On 1/11/19 10:05 AM, Andrew F. Davis wrote: The "unmapped" heap is very similar to the carveout heap except the backing memory is presumed to be unmappable by the host, in my specific case due to firewalls. This

Re: [PATCH 00/14] Misc ION cleanups and adding unmapped heap

2019-01-15 Thread Andrew F. Davis
On 1/14/19 8:39 PM, Laura Abbott wrote: > On 1/11/19 10:05 AM, Andrew F. Davis wrote: >> Hello all, >> >> This is a set of (hopefully) non-controversial cleanups for the ION >> framework and current set of heaps. These were found as I start to >> familiarize myself with the framework to help in

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-15 Thread Liam Mark
On Tue, 15 Jan 2019, Andrew F. Davis wrote: > On 1/14/19 11:13 AM, Liam Mark wrote: > > On Fri, 11 Jan 2019, Andrew F. Davis wrote: > > > >> Buffers may not be mapped from the CPU so skip cache maintenance here. > >> Accesses from the CPU to a cached heap should be bracketed with > >>

Re: [PATCH v4] staging: Mediatek: Use individual config flags in Makefile

2019-01-15 Thread Greg Kroah-Hartman
On Tue, Jan 15, 2019 at 10:29:18AM -0700, George Hilliard wrote: > These drivers can be useful on other MT76xx SoCs, which have compatible > peripherals. The drivers were selectable in Kconfig, but they were > quietly excluded from the build because the SOC_MT7621 chip was not > selected. So,

Re: [PATCH v3] staging: Mediatek: Use individual config flags in Makefile

2019-01-15 Thread George Hilliard
On Tue, Jan 15, 2019 at 10:20 AM Greg Kroah-Hartman wrote: > What changed from v2 and v1? That always goes below the --- line. > > Please fix that up and resend v4. > Sent. Didn't know to do that - first time contributor here. Sorry about the churn and thanks for your patience! Cheers, George

[PATCH v4] staging: Mediatek: Use individual config flags in Makefile

2019-01-15 Thread George Hilliard
These drivers can be useful on other MT76xx SoCs, which have compatible peripherals. The drivers were selectable in Kconfig, but they were quietly excluded from the build because the SOC_MT7621 chip was not selected. So, make the Makefiles use the same flags as Kconfig for these drivers.

Re: [PATCH v3] staging: Mediatek: Use individual config flags in Makefile

2019-01-15 Thread Greg Kroah-Hartman
On Tue, Jan 15, 2019 at 10:02:21AM -0700, George Hilliard wrote: > These drivers can be useful on other MT76xx SoCs, which have compatible > peripherals. The drivers were selectable in Kconfig, but they were > quietly excluded from the build because the SOC_MT7621 chip was not > selected. So,

[PATCH v3] staging: Mediatek: Use individual config flags in Makefile

2019-01-15 Thread George Hilliard
These drivers can be useful on other MT76xx SoCs, which have compatible peripherals. The drivers were selectable in Kconfig, but they were quietly excluded from the build because the SOC_MT7621 chip was not selected. So, make the Makefiles use the same flags as Kconfig for these drivers.

Re: [PATCH] media: imx-csi: Input connections to CSI should be optional

2019-01-15 Thread Tim Harvey
On Wed, Jan 9, 2019 at 10:34 AM Steve Longerbeam wrote: > > Some imx platforms do not have fwnode connections to all CSI input > ports, and should not be treated as an error. This includes the > imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. > Return -ENOTCONN in

[PATCH v2 1/2] staging: rtl8188eu: cleanup declarations in os_intfs.c

2019-01-15 Thread Michael Straube
Replace tabs with spaces and/or remove extra spaces in declarations. Signed-off-by: Michael Straube --- v1 -> v2 added missing Signed-off-by drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH v2 2/2] staging: rtl8188eu: add spaces around operators in os_intfs.c

2019-01-15 Thread Michael Straube
Add spaces around '+', '<<' and '*' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c

[PATCH] rtl8188eu: Refactoring struct ndis_802_11_ssid from CamelCase to correct code style.

2019-01-15 Thread Florian Büstgens
rtl8188eu uses CamelCase for many struct members. Refactors the ndis_802_11_ssid members Ssid and SsidLength to keep correct code style. Issue found by checkpatch. Signed-off-by: Florian Büstgens --- drivers/staging/rtl8188eu/core/rtw_ap.c | 8 ++--

Re: [PATCH 14/14] staging: android: ion: Add UNMAPPED heap type and helper

2019-01-15 Thread Andrew F. Davis
On 1/14/19 8:32 PM, Laura Abbott wrote: > On 1/11/19 10:05 AM, Andrew F. Davis wrote: >> The "unmapped" heap is very similar to the carveout heap except >> the backing memory is presumed to be unmappable by the host, in >> my specific case due to firewalls. This memory can still be >> allocated

[PATCH] staging: comedi: Removed not necessary braces for single block

2019-01-15 Thread Jitendra Khasdev
This patch is used to remove not necessary braces for single if block. Signed-off-by: Jitendra Khasdev --- drivers/staging/comedi/comedi_fops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c

Re: [PATCH v2 2/2] staging: Mediatek: Use individual config flags in Makefile

2019-01-15 Thread Greg Kroah-Hartman
On Thu, Jan 10, 2019 at 05:43:37PM -0700, thirtythreefo...@gmail.com wrote: > From: George Hilliard > > These drivers are useful on other MT76xx SoCs, which have compatible > peripherals. The drivers are selectable in Kconfig, but they were > quietly excluded from the build because the

Re: [PATCH 3/3] staging: rtl8188eu: add spaces around operators in os_intfs.c

2019-01-15 Thread Greg KH
On Tue, Jan 15, 2019 at 09:24:02AM +0100, Michael Straube wrote: > Add spaces around '+', '<<' and '*' to follow kernel coding style. > Reported by checkpatch. > --- > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) No signed-off-by :(

Re: [PATCH 2/3] staging: rtl8188eu: cleanup declarations in os_intfs.c

2019-01-15 Thread Greg KH
On Tue, Jan 15, 2019 at 09:24:01AM +0100, Michael Straube wrote: > Replace tabs with spaces and/or remove extra spaces in declarations. > --- > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) No signed off by :(

Re: [PATCH] staging: comedi: Removed not necessary braces for single block

2019-01-15 Thread Greg KH
On Tue, Jan 15, 2019 at 08:21:08PM +0530, root wrote: > This patch is used to remove not necessary braces for single if block. > > Signed-off-by: Jitendra Kumar Khasdev > --- > drivers/staging/comedi/comedi_fops.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) "interesting" email

Re: [PATCH v7 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

2019-01-15 Thread Greg Kroah-Hartman
On Tue, Jan 15, 2019 at 04:13:17PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 14, 2019 at 08:26:16PM +0530, Nishad Kamdar wrote: > > Convert the GPIO driver to use the GPIO irqchip library > > GPIOLIB_IRQCHIP instead of reimplementing the same. > > > > Reviewed-by: Johan Hovold > >

Re: [PATCH v7 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

2019-01-15 Thread Greg Kroah-Hartman
On Mon, Jan 14, 2019 at 08:26:16PM +0530, Nishad Kamdar wrote: > Convert the GPIO driver to use the GPIO irqchip library > GPIOLIB_IRQCHIP instead of reimplementing the same. > > Reviewed-by: Johan Hovold > Signed-off-by: Nishad Kamdar Did you test build this patch? It fails horribly for me:

Re: [PATCH] staging/android/vsoc: Remove duplicate header

2019-01-15 Thread Greg KH
On Tue, Jan 15, 2019 at 03:59:42PM +0100, Greg KH wrote: > On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote: > > Remove linux/mutex.h which is included more than once > > > > Signed-off-by: Brajeswar Ghosh > > Acked-by: Souptick Joarder > > --- > > drivers/staging/android/vsoc.c

Re: [PATCH v2] Staging: fbtft: Switch to the gpio descriptor interface

2019-01-15 Thread Greg Kroah-Hartman
On Tue, Jan 15, 2019 at 10:17:09AM +0530, Nishad Kamdar wrote: > This switches the fbtft driver to use GPIO descriptors > rather than numerical gpios: > > Utilize the GPIO library's intrinsic handling of OF GPIOs > and polarity. If the line is flagged active low, gpiolib > will deal with this. >

Re: [PATCH] staging/android/vsoc: Remove duplicate header

2019-01-15 Thread Greg KH
On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote: > Remove linux/mutex.h which is included more than once > > Signed-off-by: Brajeswar Ghosh > Acked-by: Souptick Joarder > --- > drivers/staging/android/vsoc.c | 1 - > 1 file changed, 1 deletion(-) This does not apply as it is

Re: [PATCH] staging/android/vsoc: Remove duplicate header

2019-01-15 Thread Greg KH
On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote: > Remove linux/mutex.h.h which is included more than once I think you have one too many ".h" in that line :) I'll go fix it up... ___ devel mailing list de...@linuxdriverproject.org

[PATCH] staging: comedi: Removed not necessary braces for single block

2019-01-15 Thread root
This patch is used to remove not necessary braces for single if block. Signed-off-by: Jitendra Kumar Khasdev --- drivers/staging/comedi/comedi_fops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c

Re: [PATCH RFC 2/4] media: v4l2-mem2mem: Add an optional job_done operation

2019-01-15 Thread Ezequiel Garcia
On Mon, 2019-01-14 at 14:38 +0100, Paul Kocialkowski wrote: > Introduce a new optional job_done operation, which allows calling back > to the driver when a job is done. Since the job might be completed > from interrupt context where some operations are not available, having > a callback from

[PATCH 3/3] staging: rtl8188eu: add spaces around operators in os_intfs.c

2019-01-15 Thread Michael Straube
Add spaces around '+', '<<' and '*' to follow kernel coding style. Reported by checkpatch. --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c

[PATCH 1/3] staging: rtl8188eu: remove unnecessary parentheses in os_intfs.c

2019-01-15 Thread Michael Straube
Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c

[PATCH 2/3] staging: rtl8188eu: cleanup declarations in os_intfs.c

2019-01-15 Thread Michael Straube
Replace tabs with spaces and/or remove extra spaces in declarations. --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c index