Re: [PATCH net-next 10/16] rocker: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-09 Thread Florian Fainelli
Le 2/9/19 à 10:21 AM, Jiri Pirko a écrit : > Sat, Feb 09, 2019 at 01:32:42AM CET, f.faine...@gmail.com wrote: >> Following patches will change the way we communicate getting or setting > > Just "setting", no "getting". > > >> a port's attribute and use a blocking notifier to perform those tasks.

Re: [PATCH net-next 15/16] net: switchdev: Replace port attr set SDO with a notification

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:36:18AM CET, f.faine...@gmail.com wrote: >On 2/8/19 4:32 PM, Florian Fainelli wrote: >> Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field >> from all clients, which were migrated to use switchdev notification in >> the previous patches. >> >> Add a new

Re: [PATCH net-next 10/16] rocker: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 07:21:47PM CET, j...@resnulli.us wrote: [...] >>+static int >>+rocker_switchdev_port_attr_event(unsigned long event, struct net_device >>*netdev, >>+ struct switchdev_notifier_port_attr_info >>+ *port_attr_info) >>+{

Re: [PATCH net-next 10/16] rocker: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:42AM CET, f.faine...@gmail.com wrote: >Following patches will change the way we communicate getting or setting Just "setting", no "getting". >a port's attribute and use a blocking notifier to perform those tasks. > >Prepare rocker to support receiving notifier events t

Re: [PATCH net-next 09/16] switchdev: Add SWITCHDEV_PORT_ATTR_SET

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:41AM CET, f.faine...@gmail.com wrote: >In preparation for allowing switchdev enabled drivers to veto specific >attribute settings from within the context of the caller, introduce a >new switchdev notifier type for port attributes. > >Suggested-by: Ido Schimmel >Signed-of

Re: [PATCH net-next 08/16] net: Get rid of switchdev_port_attr_get()

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:40AM CET, f.faine...@gmail.com wrote: >With the bridge no longer calling switchdev_port_attr_get() to obtain >the supported bridge port flags from a driver but instead trying to set >the bridge port flags directly and relying on driver to reject >unsupported configuration

Re: [PATCH net-next 06/16] net: bridge: Stop calling switchdev_port_attr_get()

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:38AM CET, f.faine...@gmail.com wrote: >Now that all switchdev drivers have been converted to checking the >bridge port flags during the prepare phase of the >switchdev_port_attr_set(), we can move straight to trying to set the >desired flag through SWITCHDEV_ATTR_ID_PORT_

Re: [PATCH net-next 05/16] rocker: Check bridge flags during prepare phase

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:37AM CET, f.faine...@gmail.com wrote: >In preparation for getting rid of switchdev_port_attr_get(), have rocker >check for the bridge flags being set through switchdev_port_attr_set() >with the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS attribute identifier. > >Signed-off-by: Fl

Re: [PATCH net-next 07/16] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:39AM CET, f.faine...@gmail.com wrote: >Now that we have converted the bridge code and the drivers to check for >bridge port(s) flags at the time we try to set them, there is no need >for a get() -> set() sequence anymore and >SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT th

Re: [PATCH net-next 04/16] net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:36AM CET, f.faine...@gmail.com wrote: >In preparation for removing SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT, >add support for a function that processes the >SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS attribute and returns not supported >for any flag set, since DSA does not cu

Re: [PATCH net-next 03/16] staging: fsl-dpaa2: ethsw: Check bridge port flags during set

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:35AM CET, f.faine...@gmail.com wrote: >In preparation for removing SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT, >have ethsw check that the bridge port flags that are being set are >supported. > >Signed-off-by: Florian Fainelli Acked-by: Jiri Pirko _

Re: [PATCH net-next 02/16] mlxsw: spectrum: Check bridge flags during prepare phase

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:34AM CET, f.faine...@gmail.com wrote: >In preparation for getting rid of switchdev_port_attr_get(), have mlxsw >check for the bridge flags being set through switchdev_port_attr_set() >with the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS attribute identifier. > >Signed-off-by: Flo

Re: [PATCH 2/2] staging: iio: frequency: ad9834: Move phase and scale to standard iio attribute

2019-02-09 Thread Jonathan Cameron
On Wed, 6 Feb 2019 14:05:42 +0200 Beniamin Bia wrote: > The custom phase and scale attributes were moved to standard iio types. > > Signed-off-by: Beniamin Bia Similar comments apply as to patch 1. Jonathan > --- > drivers/staging/iio/frequency/ad9834.c | 54 +++--- > 1 fi

Re: [PATCH 1/2] staging: iio: frequency: ad9834: Move frequency to standard iio types

2019-02-09 Thread Jonathan Cameron
On Wed, 6 Feb 2019 14:05:41 +0200 Beniamin Bia wrote: > Frequency attribute is added with a standard type from iio framework > instead of custom attribute. This is a small step towards removing any > unnecessary custom attribute. > > Signed-off-by: Beniamin Bia > --- > drivers/staging/iio/freq

Re: [PATCH net-next 01/16] Documentation: networking: switchdev: Update port parent ID section

2019-02-09 Thread Jiri Pirko
Sat, Feb 09, 2019 at 01:32:33AM CET, f.faine...@gmail.com wrote: >Update the section about switchdev drivers having to implement a >switchdev_port_attr_get() function to return >SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after >commit bccb30254a4a ("net: Get rid of >SWITCHDEV_AT

Re: [PATCH 1/2] staging: iio: frequency: ad9834: Move frequency to standard iio types

2019-02-09 Thread Jonathan Cameron
On Wed, 6 Feb 2019 14:25:41 +0200 Beniamin Bia wrote: > From: Beniamin Bia > > Frequency attribute is added with a standard type from iio framework > instead of custom attribute. This is a small step towards removing any > unnecessary custom attribute. > > Signed-off-by: Beniamin Bia Hi, Ho

[PATCH] Staging: mt7621-pci: Fix space required coding style

2019-02-09 Thread Guilherme Tadashi Maeoka
Fix some space required coding style. Signed-off-by: Guilherme Tadashi Maeoka --- drivers/staging/mt7621-pci/pci-mt7621.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index 31310b6fb7db.

Re: [PATCH v3 4/4] staging: iio: ad7780: moving ad7780 out of staging

2019-02-09 Thread Jonathan Cameron
On Tue, 5 Feb 2019 15:14:03 -0200 Renato Lui Geh wrote: > Move ad7780 ADC driver out of staging and into the mainline. > > The ad7780 is a sigma-delta analog to digital converter. This driver provides > reading voltage values and status bits from both the ad778x and ad717x series. > Its interfac

Re: [PATCH v3 2/4] staging: iio: ad7780: move regulator to after GPIO init

2019-02-09 Thread Jonathan Cameron
On Tue, 5 Feb 2019 15:13:21 -0200 Renato Lui Geh wrote: > To maintain consistency between ad7780_probe and ad7780_remove orders, > regulator initialization has been moved to after GPIO initializations. > > Signed-off-by: Renato Lui Geh This looks fine, will pick up with the earlier patches when

Re: [PATCH v3 1/4] staging: iio: ad7780: add gain & filter gpio support

2019-02-09 Thread Jonathan Cameron
On Tue, 5 Feb 2019 15:13:00 -0200 Renato Lui Geh wrote: > Previously, the AD7780 driver only supported gpio for the 'powerdown' > pin. This commit adds suppport for the 'gain' and 'filter' pin. > > Signed-off-by: Renato Lui Geh > Signed-off-by: Giuliano Belinassi > Co-developed-by: Giuliano Be