Re: [PATCH] staging: wilc1000: Fix incorrent type in assignment

2019-02-25 Thread YU Bo
On Tue, Feb 26, 2019 at 06:39:28AM +, ajay.kat...@microchip.com wrote: On 2/26/2019 8:58 AM, Bo YU wrote: The patch fixes following sparse warning: drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000/host

[PATCH V2] staging: wilc1000: fix incorrent type assignment

2019-02-25 Thread Bo YU
Fix sparse warning: drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000/host_interface.c:450:30:expected restricted __le16 [usertype] beacon_period drivers/staging/wilc1000/host_interface.c:450:30:got uns

Re: [PATCH] staging: wilc1000: Fix incorrent type in assignment

2019-02-25 Thread Ajay.Kathat
On 2/26/2019 8:58 AM, Bo YU wrote: > The patch fixes following sparse warning: > > drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in > assignment (different base types) > drivers/staging/wilc1000/host_interface.c:450:30:expected restricted > __le16 [usertype] be

[PATCH] staging: wilc1000: fix incorrect type in initializer

2019-02-25 Thread Bo YU
Fix sparse warning following: drivers/staging/wilc1000/host_interface.c:444:49: warning: incorrect type in initializer (different address spaces) drivers/staging/wilc1000/host_interface.c:444:49:expected struct cfg80211_bss_ies const *ies drivers/staging/wilc1000/host_interface.c:444:49:

[PATCH] staging: wilc1000: Fix incorrent type in assignment

2019-02-25 Thread Bo YU
The patch fixes following sparse warning: drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000/host_interface.c:450:30:expected restricted __le16 [usertype] beacon_period drivers/staging/wilc1000/host_interfac

Re: [PATCH] staging: android: ashmem: Avoid range_alloc() allocation with ashmem_mutex held.

2019-02-25 Thread Joel Fernandes
On Fri, Feb 22, 2019 at 3:04 AM Tetsuo Handa wrote: > > ashmem_pin() is calling range_shrink() without checking whether > range_alloc() succeeded. Also, doing memory allocation with ashmem_mutex > held should be avoided because ashmem_shrink_scan() tries to hold it. > > Therefore, move memory allo

Re: [PATCH] staging: android: ashmem: Avoid range_alloc() allocation with ashmem_mutex held.

2019-02-25 Thread Joel Fernandes
On Mon, Feb 25, 2019 at 2:11 PM Tetsuo Handa wrote: > > On 2019/02/26 6:55, Joel Fernandes wrote: > >> @@ -763,6 +767,8 @@ static int ashmem_pin_unpin(struct ashmem_area *asma, > >> unsigned long cmd, > >> > >> out_unlock: > >> mutex_unlock(&ashmem_mutex); > >> +if (range) > >> +

Re: [PATCH] staging: android: ashmem: Avoid range_alloc() allocation with ashmem_mutex held.

2019-02-25 Thread Tetsuo Handa
On 2019/02/26 6:55, Joel Fernandes wrote: >> @@ -763,6 +767,8 @@ static int ashmem_pin_unpin(struct ashmem_area *asma, >> unsigned long cmd, >> >> out_unlock: >> mutex_unlock(&ashmem_mutex); >> +if (range) >> +kmem_cache_free(ashmem_range_cachep, range); > > This seems a b

Re: [PATCH] staging: android: ashmem: Avoid range_alloc() allocation with ashmem_mutex held.

2019-02-25 Thread Joel Fernandes
On Fri, Feb 22, 2019 at 08:03:55PM +0900, Tetsuo Handa wrote: > ashmem_pin() is calling range_shrink() without checking whether > range_alloc() succeeded. Also, doing memory allocation with ashmem_mutex > held should be avoided because ashmem_shrink_scan() tries to hold it. > > Therefore, move mem

RE: [PATCH V5 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode

2019-02-25 Thread Michael Kelley
From: Tianyu Lan Sent: Friday, February 22, 2019 4:12 AM > > On the bare metal, enabling X2APIC mode requires interrupt remapping > function which helps to deliver irq to cpu with 32-bit APIC ID. > Hyper-V doesn't provide interrupt remapping function so far and Hyper-V > MSI protocol already sup

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-25 Thread Florian Fainelli
On 2/25/19 1:49 AM, Ido Schimmel wrote: > On Sun, Feb 24, 2019 at 08:47:27AM -0800, Florian Fainelli wrote: >> Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : >>> On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: - if (attr->flags & SWITCHDEV_F_NO_RECURSE) + if (attr & SWIT

[PATCH v3 2/3] staging: iio: frequency: ad9834: Move phase and scale to standard iio attribute

2019-02-25 Thread Beniamin Bia
The custom phase and scale attributes were moved to standard iio types. Signed-off-by: Beniamin Bia --- Changes in v3: -abi documentation added .../testing/sysfs-bus-iio-frequency-ad9834| 10 ++-- drivers/staging/iio/frequency/ad9834.c| 53 +++ 2 files change

[PATCH v3 1/3] staging: iio: frequency: ad9834: Move frequency to standard iio types

2019-02-25 Thread Beniamin Bia
Frequency attribute is added with a standard type from iio framework instead of custom attribute. This is a small step towards removing any unnecessary custom attribute. Ad9834 will diverge from ad9833 in the future, that is why we have two identical arrays for ad9834 and 9833. Signed-off-by: Beni

[PATCH] staging: comedi: ni_tio: Allocate shadow regs for each counter chip

2019-02-25 Thread Ian Abbott
The "ni_tio" module contains code to allocate, destroy and operate on a `struct ni_gpct_device`, which represents a number of counters spread over one or more blocks (or "chips"). `struct ni_gpct_device` includes an array member `regs` holding shadow copies of register values. Unfortunately, this

Re: [Update PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

2019-02-25 Thread Tianyu Lan
On Mon, Feb 25, 2019 at 10:19 PM Greg KH wrote: > > On Mon, Feb 25, 2019 at 10:12:14PM +0800, lantianyu1...@gmail.com wrote: > > From: Lan Tianyu > > > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > > is equal with how many entries of union hv_gpa_page_range can be popul

[PATCH V2] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

2019-02-25 Thread lantianyu1986
From: Lan Tianyu The max flush rep count of HvFlushGuestPhysicalAddressList hypercall is equal with how many entries of union hv_gpa_page_range can be populated into the input parameter page. The origin code lacks parenthesis around PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it. Cc: Fixe

Re: [Update PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

2019-02-25 Thread Greg KH
On Mon, Feb 25, 2019 at 10:12:14PM +0800, lantianyu1...@gmail.com wrote: > From: Lan Tianyu > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > is equal with how many entries of union hv_gpa_page_range can be populated > into the input parameter page. The origin code lacks

[Update PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

2019-02-25 Thread lantianyu1986
From: Lan Tianyu The max flush rep count of HvFlushGuestPhysicalAddressList hypercall is equal with how many entries of union hv_gpa_page_range can be populated into the input parameter page. The origin code lacks parenthesis around PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it. Cc: Fixs

RE: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

2019-02-25 Thread Ioana Ciornei
> Subject: Re: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice > check > > Le 2/23/19 à 12:45 AM, Ioana Ciornei a écrit : > > > >> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice > >> check > >> > >> port_switchdev_event() does not check that the target network

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-25 Thread Ido Schimmel
On Sun, Feb 24, 2019 at 08:47:27AM -0800, Florian Fainelli wrote: > Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : > > On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: > >> - if (attr->flags & SWITCHDEV_F_NO_RECURSE) > >> + if (attr & SWITCHDEV_F_DEFER) > >> + rc = call_sw