Re: [PATCH v3] staging: ralink-gdma: Use u32 over uint32_t

2019-03-22 Thread Joe Perches
On Fri, 2019-03-22 at 22:43 +0530, Bharath Vedartham wrote: > This fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" Please run your proposed patches through checkpatch before submitting them. > Signed-off-by: Bharath Vedartham > --- > Changes since v2 > - Improved changelog >

Re: Help on testing ad5933 driver

2019-03-22 Thread Alexandru Ardelean
On Thu, Mar 21, 2019 at 9:39 PM Marcelo Schmitt wrote: > > Hello, would anyone mind helping me test ad5933 driver on actual > hardware? I went through this > (https://oslongjourney.github.io/linux-kernel/experiment-one-iio-dummy/) > tutorial so I was able to load iio_simple_dummy driver, create a

[PATCH v3] staging: ralink-gdma: Use u32 over uint32_t

2019-03-22 Thread Bharath Vedartham
This fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" Signed-off-by: Bharath Vedartham --- Changes since v2 - Improved changelog - Thanks for the good feedback. I am a beginner. I will learn and grow. :) --- drivers/staging/ralink-gdma/ralink-gdma.c | 12

Re: [PATCH v2] staging: ralink-gdma: Change uint32_t to u32

2019-03-22 Thread Greg KH
On Fri, Mar 22, 2019 at 06:35:07PM +0530, Bharath Vedartham wrote: > Change occurences of uint32_t to u32 to fix checkpatch.pl warnings. > > Signed-off-by: Bharath Vedartham > --- > Changes since v1: > - Improved changelog. I have 3 "v2" patches from you :( I have no idea which one is the

Re: [PATCH] spi: mt7621: Move SPI driver out of staging

2019-03-22 Thread Stefan Roese
On 21.03.19 15:25, Mark Brown wrote: On Thu, Mar 14, 2019 at 12:52:12PM +0100, Stefan Roese wrote: This looks pretty good, a few trivial issues below but nothing major I think. +config SPI_MT7621 + tristate "MediaTek MT7621 SPI Controller" + depends on RALINK + help +

[PATCH] staging: rtl8188eu: remove unnecessary parentheses

2019-03-22 Thread Michael Straube
Remove unnecessary parentheses in rtl8188eu_xmit.c. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/s

[PATCH v2] staging: ralink-gdma: Change uint32_t to u32

2019-03-22 Thread Bharath Vedartham
Change occurences of uint32_t to u32 to fix checkpatch.pl warnings. Signed-off-by: Bharath Vedartham --- Changes since v1: - Improved changelog. --- --- drivers/staging/ralink-gdma/ralink-gdma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/stagin

[PATCH v2] staging: ralink-gdma: Change uint32_t to u32

2019-03-22 Thread Bharath Vedartham
Change occurences of uint32_t to u32 to fix checkpatch.pl warning Signed-off-by: Bharath Vedartham --- Changes since v1: -Improved the changelog. --- drivers/staging/ralink-gdma/ralink-gdma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r

Re: [PATCH] staging: ralink-gdma: Change uint32_t to u32

2019-03-22 Thread Bharath Vedartham
On Fri, Mar 22, 2019 at 01:01:40PM +0300, Dan Carpenter wrote: > On Fri, Mar 22, 2019 at 12:55:02AM +0530, Bharath Vedartham wrote: > > This is a follow up on my previous patch. Change occurences of the > ^ I did not send a patch set. I should have worded m

[RFC PATCH] staging: most: set_cfg_buffer_size() can be static

2019-03-22 Thread kbuild test robot
Fixes: 7c85575b16e9 ("staging: most: enable configfs support") Signed-off-by: kbuild test robot --- configfs.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/configfs.c b/drivers/staging/most/configfs.c index cefce69..36d40d7 100644 ---

Re: [PATCH 05/14] staging: most: enable configfs support

2019-03-22 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Christian-Gromm/staging-most-switch-to-configfs/20190322-075523 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' sparse warnings: (new ones prefixed by >>) &g

Re: [PATCH 01/14] staging: most: add new file configfs.c

2019-03-22 Thread Dan Carpenter
On Thu, Mar 21, 2019 at 02:26:02PM +0100, Christian Gromm wrote: > +static ssize_t mdev_link_direction_store(struct config_item *item, > + const char *page, size_t count) > +{ > + struct mdev_link *mdev_link = to_mdev_link(item); > + char *buf = (char *)

Re: [PATCH 01/14] staging: most: add new file configfs.c

2019-03-22 Thread Dan Carpenter
On Thu, Mar 21, 2019 at 02:26:02PM +0100, Christian Gromm wrote: > This patch adds the file configfs.c to the driver directory. The file > registers the necessary subsystems with configfs in order to move the > driver configuration from sysfs to configfs. > > Signed-off-by: Christian Gromm > ---

Re: [PATCH] Staging: comedi: ni_mio_common.c: Added blank line after declarations

2019-03-22 Thread Ian Abbott
On 21/03/2019 19:18, Arash Fotouhi wrote: Added blank line after declarations. Signed-off-by: Arash Fotouhi --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/driver

Re: Help on testing ad5933 driver

2019-03-22 Thread Dan Carpenter
On Thu, Mar 21, 2019 at 04:39:13PM -0300, Marcelo Schmitt wrote: > Hello, would anyone mind helping me test ad5933 driver on actual > hardware? I went through this > (https://oslongjourney.github.io/linux-kernel/experiment-one-iio-dummy/) > tutorial so I was able to load iio_simple_dummy driver, c

Re: [PATCH] staging: ralink-gdma: Change uint32_t to u32

2019-03-22 Thread Dan Carpenter
On Fri, Mar 22, 2019 at 12:55:02AM +0530, Bharath Vedartham wrote: > This is a follow up on my previous patch. Change occurences of the ^ Put this sort of information under the --- cut off below the Sign off. > stdint type uint32_t to its shortened type u3