Re: [PATCH] staging: rtl8723bs: core: fix line over 80 characters warning

2019-03-26 Thread Dan Carpenter
On Tue, Mar 26, 2019 at 11:55:07PM +0530, Anirudh Rayabharam wrote: > Shorten the expression by re-using the part that was already computed to This confused me. Better to phrase it like: Shorten the expression by using the "psecuritypriv" pointer. > fix the line over 80 characters warning repor

RE: [PATCH 3/3] PCI: hv: Add pci_destroy_slot() in pci_devices_present_work(), if necessary

2019-03-26 Thread Dexuan Cui
> From: Lorenzo Pieralisi > Sent: Tuesday, March 26, 2019 12:55 PM > On Mon, Mar 04, 2019 at 09:34:49PM +, Dexuan Cui wrote: > > When we hot-remove a device, usually the host sends us a PCI_EJECT > message, > > and a PCI_BUS_RELATIONS message with bus_rel->device_count == 0. But > when > > we

RE: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-26 Thread Michael Kelley
From: Lorenzo Pieralisi Sent: Tuesday, March 26, 2019 10:09 AM > On Thu, Mar 21, 2019 at 12:12:03AM +, Dexuan Cui wrote: > > > From: Michael Kelley > > > Sent: Wednesday, March 20, 2019 2:38 PM > > > > > > From: Dexuan Cui > > > > > > > > After a device is just created in new_pcichild_devi

RE: [PATCH 3/3] PCI: hv: Add pci_destroy_slot() in pci_devices_present_work(), if necessary

2019-03-26 Thread Michael Kelley
From: Dexuan Cui Sent: Wednesday, March 20, 2019 5:36 PM > > > From: Michael Kelley > > > ... > > > diff --git a/drivers/pci/controller/pci-hyperv.c > > > @@ -1776,6 +1776,10 @@ static void pci_devices_present_work(struct > > work_struct *work) > > > hpdev = list_first_entry(&removed,

Re: [PATCH 3/3] PCI: hv: Add pci_destroy_slot() in pci_devices_present_work(), if necessary

2019-03-26 Thread Lorenzo Pieralisi
On Mon, Mar 04, 2019 at 09:34:49PM +, Dexuan Cui wrote: > When we hot-remove a device, usually the host sends us a PCI_EJECT message, > and a PCI_BUS_RELATIONS message with bus_rel->device_count == 0. But when > we do the quick hot-add/hot-remove test, the host may not send us the > PCI_EJECT m

[PATCH] staging: rtl8723bs: core: fix line over 80 characters warning

2019-03-26 Thread Anirudh Rayabharam
Shorten the expression by re-using the part that was already computed to fix the line over 80 characters warning reported by checkpatch.pl. Signed-off-by: Anirudh Rayabharam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

Re: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-26 Thread Lorenzo Pieralisi
On Tue, Mar 26, 2019 at 06:01:32PM +, Dexuan Cui wrote: [...] > > > Have we reached a conclusion on this ? I would like to merge this series > > > given that it is fixing bugs and it has hung in the balance for quite > > > a while but it looks like Michael is not too happy about these patches

RE: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-26 Thread Dexuan Cui
> From: Michael Kelley > Sent: Tuesday, March 26, 2019 10:47 AM > To: Lorenzo Pieralisi ; Dexuan Cui > > Cc: bhelg...@google.com; linux-...@vger.kernel.org; KY Srinivasan > ; Stephen Hemminger ; > Sasha Levin ; linux-hyp...@vger.kernel.org; > linux-ker...@vger.kernel.org; driverdev-devel@linuxdri

Re: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-26 Thread Lorenzo Pieralisi
On Thu, Mar 21, 2019 at 12:12:03AM +, Dexuan Cui wrote: > > From: Michael Kelley > > Sent: Wednesday, March 20, 2019 2:38 PM > > > > From: Dexuan Cui > > > > > > After a device is just created in new_pcichild_device(), hpdev->refs is > > > set > > > to 2 (i.e. the initial value of 1 plus th

[PATCH] Staging: emxx_udc: emxx_udc: Fixed a coding style error

2019-03-26 Thread Will Cunningham
Removed unnecessary parentheses. Signed-off-by: Will Cunningham --- drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index a913d40f0801..80a906742cdc 100644 --- a/dri

Re: [PATCH] staging: octeon-ethernet: fix incorrect PHY mode

2019-03-26 Thread Aaro Koskinen
Hi, On Tue, Mar 26, 2019 at 10:01:50AM +0100, Andrew Lunn wrote: > Humm, that is unique, as far as i know. Every other MAC driver uses > of_get_phy_mode() to get the value out of device tree. The proprietary > delay values can then be used to fine tune the basic delay setting > read from DT. Prob

Re: [PATCH] staging: octeon-ethernet: fix incorrect PHY mode

2019-03-26 Thread Andrew Lunn
> -static void cvm_set_rgmii_delay(struct device_node *np, int iface, int port) > +static void cvm_set_rgmii_delay(struct octeon_ethernet *priv, int iface, > + int port) > { > + struct device_node *np = priv->of_node; > u32 delay_value; > + bool rx_delay;

Re: your mail

2019-03-26 Thread Dan Carpenter
On Sat, Mar 23, 2019 at 01:17:38PM -0400, William J. Cunningham wrote: > >From bb04b0ca982b7042902fffe1377e0e38e83b402b Mon Sep 17 00:00:00 2001 > From: Will Cunningham > Date: Sat, 23 Mar 2019 12:54:34 -0400 > Subject: [PATCH] Staging: emxx_udc: emxx_udc: Fixed a coding style error > > Removed u