[PATCH V2] staging: wilc1000: give usleep_range a range

2019-04-10 Thread Nicholas Mc Guire
microseconds should be tolerable. Patch was compile tested with: x86_64_defconfig + Staging=y, WILC1000_SDIO=m, WILC1000_SPI=m, WILC1000=m Patch is against 5.1-rc4 (localversion-next is -next-20190410) drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH RFC] staging: wilc1000: give usleep_range a range

2019-04-10 Thread Nicholas Mc Guire
On Wed, Apr 10, 2019 at 06:31:21PM +, adham.aboza...@microchip.com wrote: > Hi Nicolas > > On 4/8/19 6:36 PM, Nicholas Mc Guire wrote: > > On Mon, Apr 08, 2019 at 09:10:00PM +, adham.aboza...@microchip.com > > wrote: > >> Hi Nicholas > >> > >> On 4/6/19 5:01 AM, Nicholas Mc Guire wrote: >

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-10 Thread Madhumthia Prabakaran
On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h > > b/drivers/staging/rtl8723bs/include/drv_types.h > > index bafb2c30e7fb..b0623c936940 100644 > >

Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper

2019-04-10 Thread Gustavo A. R. Silva
Johan, On 4/4/19 2:24 AM, Johan Hovold wrote: > On Thu, Apr 04, 2019 at 08:09:51AM +0100, Rui Miguel Silva wrote: >> Hi Gustavo, >> Thanks a lot for the patch. >> >> On Wed 03 Apr 2019 at 21:58, Gustavo A. R. Silva wrote: >>> Make use of the struct_size() helper instead of an open-coded >>> versi

Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper

2019-04-10 Thread Gustavo A. R. Silva
Hi Johan, On 4/4/19 1:57 AM, Johan Hovold wrote: > > This patch looks good, but I noticed a bug here in the current code, > which should be fixed before applying this clean up. > > sizeof(req) should have been sizeof(*req) above. > Good catch. >> - sizeof(struct gb

Re: [PATCH RFC] staging: wilc1000: give usleep_range a range

2019-04-10 Thread Adham.Abozaeid
Hi Nicolas On 4/8/19 6:36 PM, Nicholas Mc Guire wrote: > On Mon, Apr 08, 2019 at 09:10:00PM +, adham.aboza...@microchip.com wrote: >> Hi Nicholas >> >> On 4/6/19 5:01 AM, Nicholas Mc Guire wrote: >>> External E-Mail >>> >>> >>> Someone that knows the motivation for setting the time to 2 millis

Re: [PATCH] staging: vc04_services: add missing __user annotations

2019-04-10 Thread Stefan Wahren
Hi Jas, Am 10.04.19 um 15:45 schrieb Jas: > On 5/04/19 3:12 PM, Stefan Wahren wrote: >> Hi Jasminko, >> >> maybe this sounds overcautious to you, but did you test your patch on a >> Raspberry Pi? >> > > Hello, > > I've tested it on a Raspberry Pi 3 b, with a 32 bit linux-next kernel, > and with an

Re: [PATCH] staging: vc04_services: add missing __user annotations

2019-04-10 Thread Jas
On 5/04/19 3:12 PM, Stefan Wahren wrote: Hi Jasminko, Am 24.03.19 um 18:17 schrieb Jasminko Dedic: This patch fixes the following sparse warnings by adding missing __user annotations. It also cleans up two related unnecessary casts by reuseing casts already made a few lines up. Remaining sparse

Re: [PATCH] staging: fbtft: fix alignment should match open parenthesis

2019-04-10 Thread Himadri Pandya
On 10/04/19 4:12 PM, Dan Carpenter wrote: On Wed, Apr 10, 2019 at 03:30:22PM +0530, Himadri Pandya wrote: Fix checkpatch warning "Alignment should match open parenthesis". Signed-off-by: Himadri Pandya --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH] staging: media: zoran: fix trailing whitespaces

2019-04-10 Thread Hans Verkuil
On 4/8/19 8:51 AM, Dan Carpenter wrote: > On Mon, Apr 08, 2019 at 01:35:30AM -0300, Arthur Moraes do Lago wrote: >> There were several form feeds(^L) in the file, this patch removes them >> to conform with the coding style. >> >> Signed-off-by: Arthur Moraes do Lago >> --- >> drivers/staging/medi

Re: [PATCH] staging: fbtft: fix alignment should match open parenthesis

2019-04-10 Thread Dan Carpenter
On Wed, Apr 10, 2019 at 03:30:22PM +0530, Himadri Pandya wrote: > Fix checkpatch warning "Alignment should match open parenthesis". > > Signed-off-by: Himadri Pandya > --- > drivers/staging/fbtft/fb_tinylcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/stagi

[PATCH] staging: gasket: replace symbolic permissions with octal permissions

2019-04-10 Thread Himadri Pandya
Resolve checkpatch warning for using symbolic permissions by replacing them with octal permissions. Signed-off-by: Himadri Pandya --- drivers/staging/gasket/gasket_sysfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging

Re: [RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

2019-04-10 Thread David Howells
Dan Carpenter wrote: > > + struct ipc_namespace *ipc_ns = fc->s_fs_info; > > + put_ipc_ns(ipc_ns); > > I feel like put_ipc_ns(info->ipc_ns) would be more readable. Not so much more readable as more correct. David ___ devel mailing

[PATCH] staging: fbtft: fix alignment should match open parenthesis

2019-04-10 Thread Himadri Pandya
Fix checkpatch warning "Alignment should match open parenthesis". Signed-off-by: Himadri Pandya --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c index 9469248f2c50..

RE: [PATCH 4/4] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

2019-04-10 Thread Alastair D'Silva
> -Original Message- > From: David Laight > Sent: Wednesday, 10 April 2019 6:45 PM > To: 'Alastair D'Silva' ; alast...@d-silva.org > Cc: Jani Nikula ; Joonas Lahtinen > ; Rodrigo Vivi ; > David Airlie ; Daniel Vetter ; Karsten Keil > ; Jassi Brar ; Tom Lendacky > ; David S. Miller ; > Jose

Re: [PATCH 4/4] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

2019-04-10 Thread Sergey Senozhatsky
On (04/10/19 13:17), Alastair D'Silva wrote: > With the wider display format, it can become hard to identify how many > bytes into the line you are looking at. > > The patch adds new flags to hex_dump_to_buffer() and print_hex_dump() to > print vertical lines to separate every N groups of bytes. >

RE: [PATCH 4/4] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

2019-04-10 Thread David Laight
From: Alastair D'Silva > Sent: 10 April 2019 04:17 > With the wider display format, it can become hard to identify how many > bytes into the line you are looking at. > > The patch adds new flags to hex_dump_to_buffer() and print_hex_dump() to > print vertical lines to separate every N groups of by