Re: [PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-24 Thread Nick Desaulniers
On Wed, Apr 24, 2019 at 11:58 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/staging/kpc2000/kpc2000/cell_probe.c:96:38: warning: suggest > braces around initialization of subobject [-Wmissing-braces] > struct resource resources[2] = {0}; > ^ >

[PATCH] binder: check for overflow when alloc for security context

2019-04-24 Thread Todd Kjos
When allocating space in the target buffer for the security context, make sure the extra_buffers_size doesn't overflow. This can only happen if the given size is invalid, but an overflow can turn it into a valid size. Fail the transaction if an overflow is detected. Signed-off-by: Todd Kjos ---

[PATCH] staging: most: cdev: fix chrdev_region leak in mod_exit

2019-04-24 Thread Eugeniu Rosca
From: Suresh Udipi It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0 commit [1] missed to fix the memory leak in mod_exit function. Do it now. [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak") [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381

[PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-24 Thread Nathan Chancellor
Clang warns: drivers/staging/kpc2000/kpc2000/cell_probe.c:96:38: warning: suggest braces around initialization of subobject [-Wmissing-braces] struct resource resources[2] = {0}; ^ {}

Re: [PATCH 16/28] staging: most: sound: call snd_card_new with struct device

2019-04-24 Thread Eugeniu Rosca
Hi Christian, On Tue, 08 May 2018 02:46:44 -0700, Christian Gromm wrote: > This patch is needed as function snd_card_new needs a valid > parent device. Passing a NULL pointer leads to kernel Ooops. > > Signed-off-by: Christian Gromm > --- > drivers/staging/most/core.h|

Re: [PATCH] staging: most: protect potential string overflow

2019-04-24 Thread Dan Carpenter
On Mon, Apr 22, 2019 at 10:20:18PM -0400, Bo YU wrote: > There maybe cause potential string overflow issue due to use > strcpy without checking the length > > Detected By CoversityScan CID# 1444760 > > Fixes: 131ac62253dba:(staging: most: core: use device description as name) It doesn't really

Re: [PATCH] staging: ion: solve warning symbol was not declared

2019-04-24 Thread Dan Carpenter
On Mon, Apr 22, 2019 at 08:49:27PM +0200, Oscar Gomez Fuente wrote: > These changes solve warning symbol was not declared in the functions: > ion_carveout_heap_create and ion_chunk_heap_create > > Signed-off-by: Oscar Gomez Fuente > --- > drivers/staging/android/ion/ion_carveout_heap.c | 2 +- >

Re: [PATCH] staging: unisys: use help instead of ---help--- in Kconfig

2019-04-24 Thread Dan Carpenter
On Sat, Apr 20, 2019 at 11:46:46AM +, MosesChristopher wrote: > From: Moses Christopher > Could you Fix your email From header so this isn't required? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH -next] staging: kpc2000: remove duplicated include from kp2000_module.c

2019-04-24 Thread Mukesh Ojha
On 4/24/2019 8:20 AM, YueHaibing wrote: Remove duplicated include. Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/kpc2000/kpc2000/kp2000_module.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/kp2000_module.c