Re: [PATCH RFC] staging: fieldbus: anybus-s: use proper type for wait_for_completion_timeout

Hello Nicholas, thank you for your contribution, I really appreciate it ! See inline comments below. On Sat, Apr 27, 2019 at 12:32 AM Nicholas Mc Guire wrote: > > wait_for_completion_timeout() returns unsigned long (0 on timeout or > remaining jiffies) not int. Nice catch ! > thus there is no n

[PATCH RFC] staging: fieldbus: anybus-s: use proper type for wait_for_completion_timeout

unreachable in the current code. Patch was compile-tested with. x86_64_defconfig + FIELDBUS_DEV=m, HMS_ANYBUSS_BUS=m (some unrelated sparse warnings (cast to restricted __be16)) Patch is against 5.1-rc6 (localversion-next is next-20190426) drivers/staging/fieldbus/anybuss/host.c | 7 +++ 1 file

[PATCH] staging: greybus: use proper return type for wait_for_completion_timeout

(localversion-next is next-20190426) drivers/staging/greybus/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index b3bffe9..ff18112 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus

[PATCH RFC] staging: kpc2000: use int for wait_for_completion_interruptible

coccicheck warning about usless casting) Patch is against 5.1-rc6 (localversion-next is next-20190426) drivers/staging/kpc2000/kpc_dma/fileops.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000

Re: [PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake

Hi Vatsala, On 4/26/19 3:43 AM, Vatsala Narang wrote: > Replace explicitely with explicitly to get rid of checkpatch warning. > > Signed-off-by: Vatsala Narang > --- > Changes in v2: > -added this patch to patchset to fix spelling mistake. > When you create a series, it is a good thing to incl

[PATCH v2] staging: comedi: comedi_isadma: Use a non-NULL device for DMA API

The "comedi_isadma" module calls `dma_alloc_coherent()` and `dma_free_coherent()` with a NULL device pointer which is no longer allowed. If the `hw_dev` member of the `struct comedi_device` has been set to a valid device, that can be used instead. Unfortunately, all the current users of the "come

Re: [PATCH] staging: xgifb: delete the driver

On Fri, Apr 26, 2019 at 2:42 AM Aaro Koskinen wrote: > On Fri, Jan 18, 2019 at 12:20:28PM +0100, Daniel Vetter wrote: > > On Fri, Jan 18, 2019 at 11:08:28AM +0100, Greg Kroah-Hartman wrote: > > > There has not been any real work done on cleaning this driver up and > > > getting it out of the stagi

Re: [PATCH] staging: comedi: comedi_isadma: Use a non-NULL device for DMA API

On 25/04/2019 18:13, Greg Kroah-Hartman wrote: On Thu, Apr 25, 2019 at 05:26:44PM +0100, Ian Abbott wrote: The "comedi_isadma" module calls `dma_alloc_coherent()` and `dma_free_coherent()` with a NULL device pointer which is no longer allowed. If the `hw_dev` member of the `struct comedi_device

[PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake

Replace explicitely with explicitly to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- Changes in v2: -added this patch to patchset to fix spelling mistake. drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v2 1/2] staging: rtl8192u: ieee80211: Replace bit shifting with BIT macro

Change suggested by coccinelle. Replace bit shifting on 1 with the BIT(x) macro. Coccinelle script: @@ expression c; @@ -(1 << c) +BIT(c) Signed-off-by: Vatsala Narang --- Changes in v2: -changed log message -added space around '&' opreator and after 'if' -added another patch to fix spelling m

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

On Thu, Apr 25, 2019 at 11:25 PM Johannes Berg wrote: > On Thu, 2019-04-25 at 17:55 +0200, Arnd Bergmann wrote: > > On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > > > > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > > > > > If I understand your patch descriptio