RE: RFC: kpc2000 driver naming

>-Original Message- >From: 'gre...@linuxfoundation.org' >On Fri, May 03, 2019 at 10:24:00PM +, Matt Sickler wrote: >> Hello, >> >> Recently Greg KH posted the first set of drivers for our PCIe device >(kpc2000) and shortly after that I posted the kpc2000_dma driver. I was

[PATCH] Staging: kpc2000: Cleanup in kpc_dma_transfer()

Remove unnecessary typecast in kzalloc function. In addition to that replace kzalloc(sizeof(*acd)) over kzalloc(sizeof(struct aio_cb_data)) to maintain Linux kernel style. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +-

[PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.

Move logical operator to previous line to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

[PATCH v2 5/6] staging: rtl8723bs: core: Fix variable constant comparisons.

Swap the terms of comparisons whenever the constant comes first to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

[PATCH v2 3/6] staging: rtl8723bs: core: Remove unnecessary parentheses.

Remove unnecessary parentheses after 'address-of' operator to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 4/6] staging: rtl8723bs: core: Remove braces from single if statement.

Remove braces from single if statement to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

[PATCH v2 2/6] staging: rtl8723bs: core: Replace NULL comparisons.

Replace NULL comparisons in the file to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

[PATCH v2 1/6] staging: rtl8723bs: core: Remove blank line.

To avoid style issues, remove multiple blank lines. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index

[PATCH v2 0/6] staging: rtl8723bs: core: Fix checkpatch warnings.

This series fix the following warnings: -Remove multiple blank lines. -Replace NULL comparison. -Remove unncessary parentheses. -Remove braces from single if statement. -Fix variable constant comparison. -Move logical operator to previous line. Changes in v2: -Dropped one patch from the series as

Re: [PATCH 0/4] staging: iio: ad7150: improve driver readability

On Sat, 4 May 2019 14:12:22 +0300 Alexandru Ardelean wrote: > On Sat, May 4, 2019 at 1:24 AM Melissa Wen wrote: > > > > This patchset solves readability issues in AD7150 code, such as clarify > > register and mask definition, fashion improvement of mask uses, reduce > > tedious operation and

Re: [PATCH 3/4] staging: iio: ad7150: simplify i2c SMBus return treatment

On Sat, 4 May 2019 13:36:43 +0300 Alexandru Ardelean wrote: > On Sat, May 4, 2019 at 1:26 AM Melissa Wen wrote: > > > > Since i2c_smbus_write_byte_data returns no-positive value, this commit > > making the treatment of its return value less verbose. > > > > Signed-off-by: Melissa Wen > > --- >

Re: [PATCH 1/4] staging: iio: ad7150: organize registers definition

On Sat, 4 May 2019 13:13:55 +0300 Alexandru Ardelean wrote: > On Sat, May 4, 2019 at 1:25 AM Melissa Wen wrote: > > > > Use the suffix REG to make the register addresses clear > > and indentation to highlight field names. > > > > I'm inclined to say that this change is a bit too much noise

Re: [PATCH] staging: iio: adc: Add paragraph to describe Kconfig symbol

On Wed, 1 May 2019 12:45:41 +0530 Vatsala Narang wrote: > This patch updates Kconfig with paragraph that describe config symbol > fully.Issue addressed by checkpatch. > > Signed-off-by: Vatsala Narang I'm not a great fan of that particular checkpatch warning as sometimes it leads to silly

Re: [PATCH] staging: iio: adt7316: match parenthesis alignment

On Mon, 29 Apr 2019 14:59:40 -0300 João Seckler wrote: > This patch solves the following checkpatch.pl message: > CHECK: Alignment should match open parenthesis. > This makes the file more compliant with the preferred coding style for > the Linux kernel. > > Signed-off-by: João Seckler Applied

[PATCH] staging: rtl8712: get rid of IS_MCAST

Use is_multicast_ether_addr instead of custom IS_MCAST and remove the now unused IS_MCAST. All buffers are properly aligned. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- drivers/staging/rtl8712/rtl871x_recv.c | 14 +++---

Re: [PATCH] Staging: speakup: Replace return type

Hello, Madhumitha Prabakaran, le dim. 05 mai 2019 02:26:45 -0500, a ecrit: > Replace return type and remove the respective assignment. I prefer to keep it the way it was, it looks more straightforward for the reader. Samuel > Issue found by Coccinelle. > > Signed-off-by: Madhumitha Prabakaran

[PATCH] Staging: speakup: Replace return type

Replace return type and remove the respective assignment. Issue found by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/speakup/i18n.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c