On Sat, 2019-05-18 at 02:29 +, Geordan Neukum wrote:
> Throughout i2c_driver.c, there are instances where the log strings
> contain the function's name hardcoded into the string. Instead, use the
> printk conversion specifier '%s' with the __func__ preprocessor
> identifier to more
On Fri, May 17, 2019 at 07:58:19PM -0700, Joe Perches wrote:
> On Sat, 2019-05-18 at 02:29 +, Geordan Neukum wrote:
> > Throughout i2c_driver.c, there are instances where the log strings
> > contain the function's name hardcoded into the string. Instead, use the
> > printk conversion specifier
Throughout i2c_driver.c, there are instances where the log strings
contain the function's name hardcoded into the string. Instead, use the
printk conversion specifier '%s' with the __func__ preprocessor
identifier to more maintainably print the function's name.
Signed-off-by: Geordan Neukum
---
i2c_driver.c uses a mixture of space and tab indentations which
conflicts with the kernel coding style guide. Reindent i2c_driver.c.
Signed-off-by: Geordan Neukum
---
drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 1014 +-
1 file changed, 507 insertions(+), 507 deletions(-)
Throughout i2c_driver.c, there are numerous deviations from the two
standards of:
- placing a '*' at the beginning of every line containing a
block comment.
- placing the closing comment marker '*/' on a new line.
Instead, use a block comment style that is more
Attached are an assortment of updates to the kpc_i2c driver in the
staging subtree.
As a quick summary:
Patches 1, 4, and 5 address style concerns raised by the checkpatch
script. Patch 1 (a reindentation fix) likely added additional 'line
length' warnings, but given the fact that they were only
The copyright header in i2c_driver.c is difficult to read and not
chronologically ordered. Reformat and reorganize the copyright header
to be similar to other drivers in the i2c subsystem.
Signed-off-by: Geordan Neukum
---
drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 30
The probe() function performs a kzalloc to dynamically allocate memory
at runtime. If the allocation succeeds, yet invoking the function
i2c_add_adapter fails, the dynamically allocated memory is never freed.
Change the allocation to use the managed allocation API instead and
remove the manual
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[cannot apply to v5.1 next-20190517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
river out of its
subdirectory")
CC: Greg Kroah-Hartman
Signed-off-by: kbuild test robot
---
url:
https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/staging-kpc2000-fix-a-bunch-of-orginization-and-header-file-issues/20190517-213909
kpc2000_i2c.c |2 +-
1 file changed, 1 inser
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[cannot apply to v5.1 next-20190517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On Fri, May 17, 2019 at 8:55 AM Dmitry Vyukov wrote:
>
> On Fri, May 17, 2019 at 5:51 PM Dmitry Vyukov wrote:
> > > > >
> > > > > From: Dmitry Vyukov
> > > > > Date: Fri, May 17, 2019 at 3:26 AM
> > > > > To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
> > > > > Joel
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[cannot apply to v5.1 next-20190517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
These changes solve a warning realated to an incorrect type inilizer in the
function
fieldbus_poll.
Signed-off-by: Oscar Gomez Fuente
---
drivers/staging/fieldbus/dev_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fieldbus/dev_core.c
Fix the following checkpatch.pl warning :
CHECK: Comparison to NULL could be written "!x"
by changing (x == NULL) to !x and (x != NULL) to x.
Signed-off-by: Puranjay Mohan
---
.../rtl8192u/ieee80211/ieee80211_module.c | 2 +-
.../staging/rtl8192u/ieee80211/ieee80211_rx.c | 14 ++---
On Fri, May 17, 2019 at 8:33 AM Dmitry Vyukov wrote:
>
> On Fri, May 17, 2019 at 5:26 PM Todd Kjos wrote:
> >
> > Yes (and syzbot seemed to confirm the fix). I didn't realize I needed
> > to manually close the issue. I guess you closed it yesterday.
>
> This is required to auto-close the bug
On Fri, May 17, 2019 at 06:53:11PM +0200, Oscar Gomez Fuente wrote:
> Signed-off-by: Oscar Gomez Fuente
> ---
> drivers/staging/fieldbus/dev_core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I don't take patches without any changelog text, sorry.
Please fix and resend.
Signed-off-by: Oscar Gomez Fuente
---
drivers/staging/fieldbus/dev_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fieldbus/dev_core.c
b/drivers/staging/fieldbus/dev_core.c
index 60b851406..f6f5b92 100644
--- a/drivers/staging/fieldbus/dev_core.c
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[cannot apply to v5.1 next-20190517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On Fri, May 17, 2019 at 5:51 PM Dmitry Vyukov wrote:
> > > >
> > > > From: Dmitry Vyukov
> > > > Date: Fri, May 17, 2019 at 3:26 AM
> > > > To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
> > > > Joel Fernandes, Christian Brauner, open list:ANDROID DRIVERS, LKML
> > > > Cc:
On Fri, May 17, 2019 at 5:45 PM Dmitry Vyukov wrote:
>
> On Fri, May 17, 2019 at 5:44 PM Dmitry Vyukov wrote:
> >
> > On Fri, May 17, 2019 at 5:36 PM Todd Kjos wrote:
> > >
> > > From: Dmitry Vyukov
> > > Date: Fri, May 17, 2019 at 3:26 AM
> > > To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd
On Fri, May 17, 2019 at 5:44 PM Dmitry Vyukov wrote:
>
> On Fri, May 17, 2019 at 5:36 PM Todd Kjos wrote:
> >
> > From: Dmitry Vyukov
> > Date: Fri, May 17, 2019 at 3:26 AM
> > To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
> > Joel Fernandes, Christian Brauner, open
On Fri, May 17, 2019 at 5:36 PM Todd Kjos wrote:
>
> From: Dmitry Vyukov
> Date: Fri, May 17, 2019 at 3:26 AM
> To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
> Joel Fernandes, Christian Brauner, open list:ANDROID DRIVERS, LKML
> Cc: syzkaller
>
> > Hi,
> >
> > I have 2
From: Dmitry Vyukov
Date: Fri, May 17, 2019 at 3:26 AM
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, open list:ANDROID DRIVERS, LKML
Cc: syzkaller
> Hi,
>
> I have 2 questions re drivers/android/binder.c stress testing.
>
> 1. Are there any
On Fri, May 17, 2019 at 5:26 PM Todd Kjos wrote:
>
> Yes (and syzbot seemed to confirm the fix). I didn't realize I needed
> to manually close the issue. I guess you closed it yesterday.
This is required to auto-close the bug when the commit is merged:
> IMPORTANT: if you fix the bug, please
Yes (and syzbot seemed to confirm the fix). I didn't realize I needed
to manually close the issue. I guess you closed it yesterday.
From: Dmitry Vyukov
Date: Fri, May 17, 2019 at 3:08 AM
To: syzbot
Cc: Arve Hjønnevåg, Christian Brauner, open list:ANDROID DRIVERS, Greg
Kroah-Hartman, Joel
Hi Greg,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[cannot apply to v5.1 next-20190517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits
On Fri, May 17, 2019 at 11:17:23AM +0200, Greg Kroah-Hartman wrote:
> On Fri, May 17, 2019 at 07:53:49AM +, Quentin Deslandes wrote:
> > Returns error code from 'vnt_int_start_interrupt()' so the device's private
> > buffers will be correctly freed and 'struct ieee80211_hw' start function
> >
On Fri, May 17, 2019 at 01:15:43PM +, Quentin Deslandes wrote:
> On Fri, May 17, 2019 at 11:17:23AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 17, 2019 at 07:53:49AM +, Quentin Deslandes wrote:
> > > Returns error code from 'vnt_int_start_interrupt()' so the device's
> > > private
>
On 2019-05-17, at 13:50:13 +0200, Greg KH wrote:
> On Fri, May 17, 2019 at 12:03:15PM +0100, Jeremy Sowden wrote:
> > Previously the next card number was assigned from a static int local
> > variable, which was read and later incremented. This was not
> > thread- safe, so now we use an IDA
On 2019-05-17, at 13:54:51 +0200, Greg KH wrote:
> On Fri, May 17, 2019 at 12:03:12PM +0100, Jeremy Sowden wrote:
> > The call-backs used the same recipe to get the pcard from dev:
> >
> > struct pci_dev *pdev = to_pci_dev(dev);
> > struct kp2000_device *pcard;
> >
> > if (!pdev) return
On Fri, May 17, 2019 at 12:03:12PM +0100, Jeremy Sowden wrote:
> The call-backs used the same recipe to get the pcard from dev:
>
> struct pci_dev *pdev = to_pci_dev(dev);
> struct kp2000_device *pcard;
>
> if (!pdev) return -ENXIO;
> pcard = pci_get_drvdata(pdev);
> if (!pcard) return
On Fri, May 17, 2019 at 12:03:15PM +0100, Jeremy Sowden wrote:
> Previously the next card number was assigned from a static int local
> variable, which was read and later incremented. This was not thread-
> safe, so now we use an IDA instead.
An ida is not thread safe either.
But, you are onlyu
Previously the next card number was assigned from a static int local
variable, which was read and later incremented. This was not thread-
safe, so now we use an IDA instead.
Updated TODO.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/TODO | 1 -
The show functions of two attributes output nothing and they are unused.
Removed them.
Signed-off-by: Jeremy Sowden
Reported-by: Matt Sickler
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 16
1 file changed, 16 deletions(-)
diff --git
Define separate simple show functions for each attribute instead of
having a one big one containing a chain of conditionals.
Replaced scnprintf calls with sprintf since all the outputs are short
bounded strings or single integers.
All of the device attributes are read-only, so use DEVICE_ATTR_RO
Define separate simple show functions for each attribute instead of
having a one big one containing a chain of conditionals.
Replaced calls to scnprintf with sprintf since all the outputs are
single integers.
All the readable device attributes are read-only, so use DEVICE_ATTR_RO
to define them.
The call-backs used the same recipe to get the pcard from dev:
struct pci_dev *pdev = to_pci_dev(dev);
struct kp2000_device *pcard;
if (!pdev) return -ENXIO;
pcard = pci_get_drvdata(pdev);
if (!pcard) return -ENXIO;
where to_pci_dev is a wrapper for container_of.
However,
Fixed indentation of cpld_reconfigure store call-back and definition of
attribute list.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/core.c | 55 ++
1 file changed, 29 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
These apply on top of the ones I sent earlier this week, which are
currently in the staging-test branch.
There are a number relating to device attributes and one that fixes a
race affecting the assignment of card numbers.
Jeremy Sowden (6):
staging: kpc2000: add separate show functions for
On Fri, May 17, 2019 at 10:49:36AM +0200, Greg Kroah-Hartman wrote:
> The kp200_module.c does not need to be stand-alone, so move it into the
> core.c file. This lets us make some functions static, reducing the
> global namespace of the driver.
>
> Cc: Matt Sickler
> Signed-off-by: Greg
On Fri, May 17, 2019 at 07:53:49AM +, Quentin Deslandes wrote:
> Returns error code from 'vnt_int_start_interrupt()' so the device's private
> buffers will be correctly freed and 'struct ieee80211_hw' start function
> will return an error code.
>
> Signed-off-by: Quentin Deslandes
> ---
>
The functions GetBackEndStatus() and BackEndControlSetClear() are never
used by any code, so just remove them.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc2000/dma_common_defs.h | 14 --
1 file changed, 14 deletions(-)
diff --git
The kp200_module.c does not need to be stand-alone, so move it into the
core.c file. This lets us make some functions static, reducing the
global namespace of the driver.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc2000/Makefile | 2 +-
The kp200_module.c does not need to be stand-alone, so move it into the
core.c file. This lets us make some functions static, reducing the
global namespace of the driver.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc2000/Makefile | 2 +-
As this is only called twice, just call writel() like a normal driver
should :)
At the same time, clean up the formatting for the irq handler, as there
is no need to have that be incorrect, it just hurts the eyes...
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
There is no need for a subdirectory for just a single .c file. So move
it out of kpc_i2c/ and rename it to the module name that we want the
file to build to, saving one more linking stage.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/Makefile
There is no need for a subdirectory for just a single .c file. So move
it out of kpc_spi/ and rename it to the module name that we want the
file to build to, saving one more linking stage.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/Makefile
The fileops.c file does not need to be stand-alone, so move it into the
core.c file. This lets us make some functions static, reducing the
global namespace of the driver.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc2000/Makefile | 2 +-
Use tabs in pcie.h, like is mandated.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc2000/pcie.h | 106 -
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/pcie.h
We do not need an inline function to "hide" the lock, so just replace
the few calls to these functions with the "real" mutex_lock/unlock()
calls.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 ++--
The structures defined in spi_parts.h belong in the .c file that uses
it. So move it directly into spi_driver.c to make things simpler to
manage.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc_spi/spi_driver.c | 43 +-
Here's a short series of patches to fix up some header file issues in
the kpc2000 drivers, as well as move them from subdirectories for
individual files, to live in the "main" directory, saving some linking
and directory traversal steps in the build.
Greg Kroah-Hartman (10):
staging: kpc2000:
Use tabs in uapi.h, like is mandated.
Cc: Matt Sickler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc2000/uapi.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/uapi.h
Returns error code from 'vnt_int_start_interrupt()' so the device's private
buffers will be correctly freed and 'struct ieee80211_hw' start function
will return an error code.
Signed-off-by: Quentin Deslandes
---
v2: returns 'status' value to caller instead of removing it.
v3: add patch version
Am 16.05.2019 um 23:33 schrieb Madhumitha Prabakaran:
Fix the warning issued by checkpatch
Prefer kernel type 'u32' over 'uint32_t'.
Along with that include a blank line after a declaration
to maintain Linux kernel coding style.
Signed-off-by: Madhumitha Prabakaran
Acked-by: Stefan Wahren
On Thu, May 16, 2019 at 11:57:15AM +, Quentin Deslandes wrote:
> Returns error code from 'vnt_int_start_interrupt()' so the device's private
> buffers will be correctly freed and 'struct ieee80211_hw' start function
> will return an error code.
>
> Signed-off-by: Quentin Deslandes
> ---
>
On Thu, May 16, 2019 at 10:38:06PM +0100, Jeremy Sowden wrote:
> Removed trailing white-space from four files.
>
> Signed-off-by: Jeremy Sowden
I've applied, just this one patch from the series, please fix the rest
up and resend.
thanks,
greg k-h
On Thu, May 16, 2019 at 10:38:08PM +0100, Jeremy Sowden wrote:
> The definitions are only used to populate the kpc_uio_class_attrs
> attribute array, so declare them as static.
>
> Fixes the following sparse warnings:
>
> drivers/staging/kpc2000/kpc2000/cell_probe.c:220:1: warning: symbol
>
On Thu, May 16, 2019 at 10:38:07PM +0100, Jeremy Sowden wrote:
> Define separate simple show functions for each attribute instead of
> having a one big one containing a chain of conditionals.
>
> Replaced scnprintf calls with sprintf since all the outputs are short
> bounded strings or single
On Thu, May 16, 2019 at 10:38:09PM +0100, Jeremy Sowden wrote:
> The show functions of two attributes output nothing and they are unused.
> Removed them.
>
> Signed-off-by: Jeremy Sowden
You forgot a "reported-by:" tag here :(
Please add that for the next round of this patch series.
thanks,
On Thu, May 16, 2019 at 10:14:56PM +, Matt Sickler wrote:
> >-Original Message-
> >From: devel On Behalf Of
> >Previously the next card number was assigned from a static int local
> >variable,
> >which was read and later incremented. This was not thread- safe, so now we
> >use an
62 matches
Mail list logo
