Re: [PATCH] staging: rtl8723bs: Add missing blank lines

2019-05-28 Thread Fabio Lima
Em qua, 22 de mai de 2019 06:41, Dan Carpenter escreveu: > > On Tue, May 21, 2019 at 09:46:55PM -0300, Fabio Lima wrote: > > This patch resolves the following warning from checkpatch.pl > > WARNING: Missing a blank line after declarations > > > > Signed-off-by: Fabio Lima > > --- > >

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread Sven Van Asbroeck
On Tue, May 28, 2019 at 12:00 PM Greg KH wrote: > > You all need a better email client, mutt handles this just fine, it's > not a problem on my system with my workflow at all :) Argh, my bad. I use Google Mail -> Download Message, which does appear to mess up the endings. Luckily, dos2unix fixes

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread Greg KH
On Tue, May 28, 2019 at 11:41:57PM +0800, YueHaibing wrote: > On 2019/5/28 22:35, Sven Van Asbroeck wrote: > > On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote: > >> > >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set > >> > > > > checkpatch.pl errors remain: > > > > $

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
On 2019/5/28 22:35, Sven Van Asbroeck wrote: > On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote: >> >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set >> > > checkpatch.pl errors remain: > > $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml > ERROR: DOS line endings > #92: FILE:

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
Sorry, this is broken, Pls igore this. On 2019/5/28 22:29, YueHaibing wrote: > Fix gcc build error while CONFIG_REGMAP_MMIO is not set > > drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function > `controller_probe': > arcx-anybus.c: undefined reference to `__devm_regmap_init_mmio_clk' > >

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread Sven Van Asbroeck
On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote: > > Fix gcc build error while CONFIG_REGMAP_MMIO is not set > checkpatch.pl errors remain: $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml ERROR: DOS line endings #92: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17: +^Iselect

[PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
Fix gcc build error while CONFIG_REGMAP_MMIO is not set drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function `controller_probe': arcx-anybus.c: undefined reference to `__devm_regmap_init_mmio_clk' Select REGMAP_MMIO to fix it. Reported-by: Hulk Robot Fixes: 2411a336c8ce ("staging:

Re: [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
On 2019/5/28 21:41, Sven Van Asbroeck wrote: > Hello YueHaibing, > > On Tue, May 28, 2019 at 9:33 AM YueHaibing wrote: >> >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set >> >> drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function >> `controller_probe': >>

Re: [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread Sven Van Asbroeck
Hello YueHaibing, On Tue, May 28, 2019 at 9:33 AM YueHaibing wrote: > > Fix gcc build error while CONFIG_REGMAP_MMIO is not set > > drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function > `controller_probe': > arcx-anybus.c:(.text+0x9d6): undefined reference to >

[PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
Fix gcc build error while CONFIG_REGMAP_MMIO is not set drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function `controller_probe': arcx-anybus.c:(.text+0x9d6): undefined reference to `__devm_regmap_init_mmio_clk' Select REGMAP_MMIO to fix it. Reported-by: Hulk Robot Fixes: 2411a336c8ce

[driver-core:debugfs_cleanup 4/55] arch/x86/kvm/debugfs.c:60:3: error: 'ret' undeclared; did you mean 'net'?

2019-05-28 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: ed5c9a4774ec958bdcd25c4786629537e8ee2317 commit: 14edfc42c918fb71d35786bb35622a175d9fab5c [4/55] x86: kvm: no need to check return value of debugfs_create functions config: x86_64-kexec

Re: [PATCH v2 2/2] staging: erofs: fix i_blocks calculation

2019-05-28 Thread Chao Yu
On 2019/5/28 14:57, Dan Carpenter wrote: > On Tue, May 28, 2019 at 11:02:12AM +0800, Chao Yu wrote: >> On 2019/5/28 10:36, Gao Xiang wrote: >>> For compressed files, i_blocks should not be calculated >>> by using i_size. i_u.compressed_blocks is used instead. >>> >>> In addition, i_blocks was

[PATCH 1/3][V2] lib: fix match_string() helper on -1 array size

2019-05-28 Thread Alexandru Ardelean
The documentation the `_match_string()` helper mentions that `n` should be: * @n: number of strings in the array or -1 for NULL terminated arrays The behavior of the function is different, in the sense that it exits on the first NULL element in the array, regardless of whether `n` is -1 or a

[PATCH -next v3 2/2] staging: kpc2000: replace white spaces with tabs for kpc2000_spi.c

2019-05-28 Thread Mao Wenan
There are multiple wrong formats in kpc2000_spi.c, is time to do clean work for it. Signed-off-by: Mao Wenan --- drivers/staging/kpc2000/kpc2000_spi.c | 722 +- 1 file changed, 361 insertions(+), 361 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c

[PATCH -next v3 1/2] staging: kpc2000: report error status to spi core

2019-05-28 Thread Mao Wenan
There is an error condition that's not reported to the spi core in kp_spi_transfer_one_message(). It should restore status value to m->status, and return it in error path. Signed-off-by: Mao Wenan --- drivers/staging/kpc2000/kpc2000_spi.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH -next v3 0/2] cleanup for kpc2000_spi.c

2019-05-28 Thread Mao Wenan
The error status should resotre to m->status in kp_spi_transfer_one_message(), and many white spaces in kpc2000_spi.c. patch 1 is to fix the error path, and patch 2 is to cleanup kpc2000_spi.c. v1: remove set but not used variable 'status'. v2: fix the subject tile. v3: add another patch to fix

[PATCH 3/3][V2] lib: re-introduce new match_string() helper/macro

2019-05-28 Thread Alexandru Ardelean
This change re-introduces `match_string()` as a macro that uses ARRAY_SIZE() to compute the size of the array. After this change, work can start on migrating subsystems to use this new helper. Since the original helper is pretty used, migrating to this new one will take a while, and will be

[PATCH 2/3][V2] treewide: rename match_string() -> __match_string()

2019-05-28 Thread Alexandru Ardelean
This change does a rename of match_string() -> __match_string(). There are a few parts to the intention here (with this change): 1. Align with sysfs_match_string()/__sysfs_match_string() 2. This helps to group users of `match_string()`: a. those that use ARRAY_SIZE(_a) to specify the number of

Re: [PATCH v2 2/2] staging: erofs: fix i_blocks calculation

2019-05-28 Thread Gao Xiang
Hi Dan, On 2019/5/28 14:57, Dan Carpenter wrote: > On Tue, May 28, 2019 at 11:02:12AM +0800, Chao Yu wrote: >> On 2019/5/28 10:36, Gao Xiang wrote: >>> For compressed files, i_blocks should not be calculated >>> by using i_size. i_u.compressed_blocks is used instead. >>> >>> In addition, i_blocks

Re: [PATCH v2 2/2] staging: erofs: fix i_blocks calculation

2019-05-28 Thread Dan Carpenter
On Tue, May 28, 2019 at 11:02:12AM +0800, Chao Yu wrote: > On 2019/5/28 10:36, Gao Xiang wrote: > > For compressed files, i_blocks should not be calculated > > by using i_size. i_u.compressed_blocks is used instead. > > > > In addition, i_blocks was miscalculated for non-compressed > > files